1 files changed, 231 insertions, 110 deletions

diff --git a/qmake/generators/win32/msvc_objectmodel.cpp b/qmake/generators/win32/msvc_objectmodel.cpp
index 7ffe4f7..a672c2d 100644
--- a/qmake/generators/win32/msvc_objectmodel.cpp
+++ b/qmake/generators/win32/msvc_objectmodel.cpp
@@ -1,9 +1,9 @@
 /****************************************************************************
-** $Id$
+** 
 **
-** Definition of ________ class.
+** Implementation of VCProject class.
 **
-** Copyright (C) 2002 Trolltech AS.  All rights reserved.
+** Copyright (C) 2002-2003 Trolltech AS.  All rights reserved.
 **
-** This file is part of the network module of the Qt GUI Toolkit.
+** This file is part of qmake.
 **
@@ -39,17 +39,3 @@
 #include <qstringlist.h>
-#include <quuid.h>
-
-#if defined(Q_OS_WIN32)
-#include <objbase.h>
-#ifndef GUID_DEFINED
-#define GUID_DEFINED
-typedef struct _GUID
-{
-    ulong   Data1;
-    ushort  Data2;
-    ushort  Data3;
-    uchar   Data4[8];
-} GUID;
-#endif
-#endif
+#include <qfileinfo.h>
 
@@ -283,3 +269,2 @@ struct XPair {
 
-
 // Streaming operators for property Pairs ---------------------------
@@ -320,3 +305,3 @@ QTextStream &operator<<( QTextStream &strm, const SPair &prop )
     if ( !prop.value.isEmpty() )
-        strm << prop.name << prop.value.latin1() << "\"";
+        strm << prop.name << QString(prop.value).remove("\"") << "\"";
     return strm;
@@ -336,3 +321,3 @@ VCCLCompilerTool::VCCLCompilerTool()
         BrowseInformation( brInfoNone ),
-        BufferSecurityCheck( unset ),
+        BufferSecurityCheck( _False ),
         CallingConvention( callConventionDefault ),
@@ -348,3 +333,3 @@ VCCLCompilerTool::VCCLCompilerTool()
         EnableIntrinsicFunctions( unset ),
-        ExceptionHandling( unset ),
+        ExceptionHandling( _False ),
         ExpandAttributedSource( unset ),
@@ -356,3 +341,3 @@ VCCLCompilerTool::VCCLCompilerTool()
         ImproveFloatingPointConsistency( unset ),
-        InlineFunctionExpansion( expandOnlyInline ),
+        InlineFunctionExpansion( expandDefault ),
         KeepComments( unset ),
@@ -360,5 +345,6 @@ VCCLCompilerTool::VCCLCompilerTool()
         OmitFramePointers( unset ),
-        Optimization( optimizeDisabled ),
+        Optimization( optimizeCustom ),
         OptimizeForProcessor( procOptimizeBlended ),
         OptimizeForWindowsApplication( unset ),
+        ProgramDataBaseFileName( "" ),
         RuntimeLibrary( rtMultiThreaded ),
@@ -373,3 +359,3 @@ VCCLCompilerTool::VCCLCompilerTool()
         UndefineAllPreprocessorDefinitions( unset ),
-        UsePrecompiledHeader( pchGenerateAuto ),
+        UsePrecompiledHeader( pchNone ),
         WarnAsError( unset ),
@@ -397,3 +383,3 @@ QTextStream &operator<<( QTextStream &strm, const VCCLCompilerTool &tool )
     strm << TPair( _CompileOnly, tool.CompileOnly );
-    strm << EPair( _DebugInformationFormat, tool.DebugInformationFormat );
+            if ( tool.DebugInformationFormat != debugUnknown )    strm << EPair( _DebugInformationFormat, tool.DebugInformationFormat );
     strm << TPair( _DefaultCharIsUnsigned, tool.DefaultCharIsUnsigned );
@@ -411,3 +397,3 @@ QTextStream &operator<<( QTextStream &strm, const VCCLCompilerTool &tool )
     strm << XPair( _ForcedUsingFiles, tool.ForcedUsingFiles );
-    strm << EPair( _GeneratePreprocessedFile, tool.GeneratePreprocessedFile );
+    if ( tool.GeneratePreprocessedFile != preprocessUnknown)strm << EPair( _GeneratePreprocessedFile, tool.GeneratePreprocessedFile );
     strm << TPair( _GlobalOptimizations, tool.GlobalOptimizations );
@@ -415,3 +401,3 @@ QTextStream &operator<<( QTextStream &strm, const VCCLCompilerTool &tool )
     strm << TPair( _ImproveFloatingPointConsistency, tool.ImproveFloatingPointConsistency );
-    strm << EPair( _InlineFunctionExpansion, tool.InlineFunctionExpansion );
+    if ( tool.InlineFunctionExpansion != expandDefault ) strm << EPair( _InlineFunctionExpansion, tool.InlineFunctionExpansion );
     strm << TPair( _KeepComments, tool.KeepComments );
@@ -420,3 +406,3 @@ QTextStream &operator<<( QTextStream &strm, const VCCLCompilerTool &tool )
     strm << TPair( _OmitFramePointers, tool.OmitFramePointers );
-    strm << EPair( _Optimization, tool.Optimization );
+    if ( tool.Optimization != optimizeDefault ) strm << EPair( _Optimization, tool.Optimization );
     if ( tool.OptimizeForProcessor != procOptimizeBlended ) strm << EPair( _OptimizeForProcessor, tool.OptimizeForProcessor );
@@ -427,4 +413,4 @@ QTextStream &operator<<( QTextStream &strm, const VCCLCompilerTool &tool )
     strm << XPair( _PreprocessorDefinitions, tool.PreprocessorDefinitions );
-    strm << SPair( _ProgramDataBaseFileName, tool.ProgramDataBaseFileName );
-    strm << EPair( _RuntimeLibrary, tool.RuntimeLibrary );
+    if ( !tool.ProgramDataBaseFileName.isNull() ) strm << _ProgramDataBaseFileName << tool.ProgramDataBaseFileName.latin1() << "\"";
+    if ( tool.RuntimeLibrary != rtUnknown ) strm << EPair( _RuntimeLibrary, tool.RuntimeLibrary );
     strm << TPair( _RuntimeTypeInfo, tool.RuntimeTypeInfo );
@@ -443,3 +429,3 @@ QTextStream &operator<<( QTextStream &strm, const VCCLCompilerTool &tool )
     strm << TPair( _WarnAsError, tool.WarnAsError );
-    strm << EPair( _WarningLevel, tool.WarningLevel );
+    if ( tool.WarningLevel != warningLevelUnknown ) strm << EPair( _WarningLevel, tool.WarningLevel );
     strm << TPair( _WholeProgramOptimization, tool.WholeProgramOptimization );
@@ -476,3 +462,3 @@ bool VCCLCompilerTool::parseOption( const char* option )
         }
-        AdditionalUsingDirectories += option+2;
+        AdditionalUsingDirectories += option+3;
         break;
@@ -482,3 +468,3 @@ bool VCCLCompilerTool::parseOption( const char* option )
     case 'D':
-        PreprocessorDefinitions += option+1;
+        PreprocessorDefinitions += option+2;
         break;
@@ -486,3 +472,5 @@ bool VCCLCompilerTool::parseOption( const char* option )
         if ( second == 'H' ) {
-            if ( third == 'a' || third == 'c' || third == 's' ) {
+            if ( third == 'a'
+                    || (third == 'c' && fourth != 's')
+                    || (third == 's' && fourth != 'c') ) {
                 // ExceptionHandling must be false, or it will override
@@ -492,2 +480,7 @@ bool VCCLCompilerTool::parseOption( const char* option )
                 break;
+            } else if ( (third == 'c' && fourth == 's')
+                     || (third == 's' && fourth == 'c') ) {
+                ExceptionHandling = _True;
+                AdditionalOptions += option;
+                break;
             }
@@ -593,2 +586,5 @@ bool VCCLCompilerTool::parseOption( const char* option )
         case 'X':
+            // ExceptionHandling == true will override with
+            // an /EHsc option, which is correct with /GX
+            ExceptionHandling = _True; // Fall-through
         case 'Z':
@@ -956,6 +952,6 @@ VCLinkerTool::VCLinkerTool()
         IgnoreEmbeddedIDL( unset ),
-        IgnoreImportLibrary( unset ),
+        IgnoreImportLibrary( _True ),
         LargeAddressAware( addrAwareDefault ),
         LinkDLL( unset ),
-        LinkIncremental( linkIncrementalYes ),
+        LinkIncremental( linkIncrementalDefault ),
         LinkTimeCodeGeneration( unset ),
@@ -1021,3 +1017,3 @@ QTextStream &operator<<( QTextStream &strm, const VCLinkerTool &tool )
     strm << SPair( _OutputFile, tool.OutputFile );
-    strm << SPair( _ProgramDatabaseFile, tool.ProgramDatabaseFile );
+    strm << _ProgramDatabaseFile << tool.ProgramDatabaseFile << "\"";
     strm << TPair( _RegisterOutput, tool.RegisterOutput );
@@ -1709,5 +1705,5 @@ QTextStream &operator<<( QTextStream &strm, const VCCustomBuildTool &tool )
     strm << XPair( _AdditionalDependencies4, tool.AdditionalDependencies, ";" );
-    strm << SPair( _CommandLine4, tool.CommandLine );
+    strm << XPair( _CommandLine4, tool.CommandLine, "\n" );
     strm << SPair( _Description4, tool.Description );
-    strm << SPair( _Outputs4, tool.Outputs );
+    strm << XPair( _Outputs4, tool.Outputs, ";" );
     strm << SPair( _ToolPath, tool.ToolPath );
@@ -1828,39 +1824,35 @@ VCFilter::VCFilter()
 {
+    useCustomBuildTool = FALSE;
+    useCompilerTool = FALSE;
 }
 
-void VCFilter::generateMOC( QTextStream &strm, QString str ) const
+void VCFilter::addMOCstage( QTextStream &strm, QString filename )
 {
-    QString mocOutput = Project->findMocDestination( str );
+    QString mocOutput = Project->findMocDestination( filename );
     QString mocApp = Project->var( "QMAKE_MOC" );
 
-    if( mocOutput.isEmpty() ) {
+    if( mocOutput.isEmpty() && filename.endsWith(".moc") ) {
         // In specialcases we DO moc .cpp files
         // when the result is an .moc file
-        if ( !str.endsWith(".moc") )
-            return;
-        mocOutput = str;
-        str = Project->findMocSource( mocOutput );
+        mocOutput = filename;
+        filename = Project->findMocSource( mocOutput );
     }
 
-    strm << _begFileConfiguration;
-    strm << _Name5;
-    strm << Config->Name;
-    strm << "\">";
-    strm << _begTool5;
-    strm << _VCCustomBuildTool;
-    strm << _Description6;
-    strm << "Moc'ing " << str << "...\"";
-    strm << _CommandLine6;
-    strm << mocApp;
-    strm << " " << str << " -o " << mocOutput << "\"";
-    strm << _AdditionalDependencies6;
-    strm << mocApp << "\"";
-    strm << _Outputs6;
-    strm << mocOutput << "\"";
-    strm << "/>";
-    strm << _endFileConfiguration;
+    if (mocOutput.isEmpty())
+        return;
+
+    CustomBuildTool = VCCustomBuildTool();
+    useCustomBuildTool = TRUE;
+    CustomBuildTool.Description = "Moc&apos;ing " + filename + "...";
+    CustomBuildTool.CommandLine += (mocApp + " "
+                                + filename + " -o " + mocOutput);
+    CustomBuildTool.AdditionalDependencies = mocApp;
+    CustomBuildTool.Outputs += mocOutput;
 }
 
-void VCFilter::generateUIC( QTextStream &strm, const QString& str ) const
+void VCFilter::addUICstage( QTextStream &strm, QString str )
 {
+    CustomBuildTool = VCCustomBuildTool();
+    useCustomBuildTool = TRUE;
+
     QString uicApp = Project->var("QMAKE_UIC");
@@ -1897,23 +1889,99 @@ void VCFilter::generateUIC( QTextStream &strm, const QString& str ) const
 
-    strm << _begFileConfiguration;
-    strm << _Name5;
-    strm << Config->Name;
-    strm << "\">";
-    strm << _begTool5;
-    strm << _VCCustomBuildTool;
-    strm << _Description6;
-    strm << "Uic'ing " << str << "...\"";
-    strm << _CommandLine6;
-            strm << uicApp << " " << str << " -o " << uiHeaders << fname << ".h &amp;&amp; ";                   // Create .h from .ui file
-            strm << uicApp << " " << str << " -i " << fname << ".h -o " << uiSources << fname << ".cpp &amp;&amp; ";// Create .cpp from .ui file
-    strm << mocApp << " " << uiHeaders << fname << ".h -o " << mocDir << "moc_" << fname << ".cpp\"";
-    strm << _AdditionalDependencies6;
-    strm << mocApp << ";" << uicApp << "\"";
-    strm << _Outputs6;
-    strm << uiHeaders << fname << ".h;" << uiSources << fname << ".cpp;" << mocDir << "moc_" << fname << ".cpp\"";
-    strm << "/>";
-    strm << _endFileConfiguration;
+    if ( mocDir.isEmpty() )
+        mocDir = pname;
+
+    CustomBuildTool.Description = ("Uic'ing " + str + "...\"");
+    CustomBuildTool.CommandLine += // Create .h from .ui file
+        uicApp + " " + str + " -o " + uiHeaders + fname + ".h";
+    CustomBuildTool.CommandLine += // Create .cpp from .ui file
+        uicApp + " " + str + " -i " + fname + ".h -o " + uiSources + fname + ".cpp";
+    CustomBuildTool.CommandLine += // Moc the headerfile
+        mocApp + " " + uiHeaders + fname + ".h -o " + mocDir + Option::h_moc_mod + fname + Option::h_moc_ext;
+
+    CustomBuildTool.AdditionalDependencies += mocApp;
+    CustomBuildTool.AdditionalDependencies += uicApp;
+    CustomBuildTool.Outputs +=
+        uiHeaders + fname + ".h;" + uiSources + fname + ".cpp;" + mocDir + Option::h_moc_mod + fname + Option::h_moc_ext;
 }
 
-QTextStream &operator<<( QTextStream &strm, const VCFilter &tool )
+void VCFilter::modifyPCHstage( QTextStream &strm, QString str )
+{
+    bool isCFile = str.endsWith(".c");
+    bool isHFile = (str.endsWith(".h") && str == Project->precompH);
+
+    if (!isCFile && !isHFile)
+        return;
+
+    CompilerTool = VCCLCompilerTool();
+    useCompilerTool = TRUE;
+
+    // Unset some default options
+    CompilerTool.BufferSecurityCheck = unset;
+    CompilerTool.DebugInformationFormat = debugUnknown;
+    CompilerTool.ExceptionHandling = unset;
+    CompilerTool.GeneratePreprocessedFile = preprocessUnknown;
+    CompilerTool.Optimization = optimizeDefault;
+    CompilerTool.ProgramDataBaseFileName = QString::null;
+    CompilerTool.RuntimeLibrary = rtUnknown;
+    CompilerTool.WarningLevel = warningLevelUnknown;
+
+    // Setup PCH options
+    CompilerTool.UsePrecompiledHeader     = (isCFile ? pchNone : pchCreateUsingSpecific);
+    CompilerTool.PrecompiledHeaderThrough = "$(NOINHERIT)";
+    CompilerTool.ForcedIncludeFiles       = "$(NOINHERIT)";
+}
+
+bool VCFilter::addIMGstage( QTextStream &strm, QString str )
+{
+    bool isCorH = FALSE;
+    if (str.endsWith(".c") || str.endsWith(".rc"))
+        isCorH = TRUE;
+    QStringList::Iterator it;
+    for(it = Option::cpp_ext.begin(); it != Option::cpp_ext.end(); ++it)
+        if(str.endsWith(*it))
+            isCorH = TRUE;
+    for(it = Option::h_ext.begin(); it != Option::h_ext.end(); ++it)
+        if(str.endsWith(*it))
+            isCorH = TRUE;
+
+    QString collectionName = Project->project->first("QMAKE_IMAGE_COLLECTION");
+    if (str.isEmpty() || isCorH || collectionName.isEmpty())
+        return FALSE;
+
+    CustomBuildTool = VCCustomBuildTool();
+    useCustomBuildTool = TRUE;
+
+    // Some projects (like designer core) may have too many images to
+    // call uic directly. Therefor we have to create a temporary
+    // file, with the image list, and call uic with the -f option.
+    QString tmpFileCmd = "echo ";
+    QString tmpImageFilename = ".imgcol";
+    QStringList& list = Project->project->variables()["IMAGES"];
+    bool firstOutput = TRUE;
+    it = list.begin();
+    while( it!=list.end() ) {
+        tmpFileCmd += (*it) + " ";
+        ++it;
+        if (tmpFileCmd.length()>250 || it==list.end()) {
+            CustomBuildTool.CommandLine += tmpFileCmd
+                                          + (firstOutput?"> ":">> ")
+                                          + tmpImageFilename;
+            tmpFileCmd = "echo ";
+            firstOutput = FALSE;
+        }
+    }
+
+    QString uicApp = Project->var("QMAKE_UIC");
+    CustomBuildTool.Description = ("Generate imagecollection");
+    CustomBuildTool.CommandLine +=
+        uicApp + " -embed " + Project->project->first("QMAKE_ORIG_TARGET")
+        + " -f .imgcol -o " + collectionName;
+    CustomBuildTool.AdditionalDependencies += uicApp;
+    CustomBuildTool.AdditionalDependencies += list;
+    CustomBuildTool.Outputs = collectionName;
+    CustomBuildTool.Outputs += tmpImageFilename;
+    return TRUE;
+}
+
+QTextStream &operator<<( QTextStream &strm, VCFilter &tool )
 {
@@ -1927,3 +1995,49 @@ QTextStream &operator<<( QTextStream &strm, const VCFilter &tool )
     strm << ">";
+
+    bool resourceBuild = FALSE;
+    int currentLevels = 0;
+    QStringList currentDirs;
     for ( QStringList::ConstIterator it = tool.Files.begin(); it != tool.Files.end(); ++it ) {
+        if ( !tool.flat_files ) {
+            QStringList newDirs = QStringList::split('\\',(*it));
+            newDirs.pop_back(); // Skip the filename
+
+            int newLevels = int(newDirs.count());
+            int equalLevels = 0;
+            for (int i = 0; i<currentLevels; i++, equalLevels++ )
+                if (currentDirs[i] != newDirs[i])
+                    break;
+            int closeFilters = currentLevels - equalLevels;
+            int openFilters  = newLevels - equalLevels;
+
+            // close previous non-equal filter
+            while ( closeFilters-- )
+                strm << _endFilter;
+
+            // open new non-equal filters
+            newLevels = 0;
+            while ( openFilters-- ) {
+                strm << _begFilter;
+                strm << SPair( _Name3, newDirs[equalLevels + newLevels] );
+                strm << _Filter << "\">"; // Blank filter
+                ++newLevels;
+            }
+            currentDirs = newDirs;
+            currentLevels = int(newDirs.count());
+        }
+
+        tool.useCustomBuildTool = FALSE;
+        tool.useCompilerTool = FALSE;
+        // Add UIC, MOC and PCH stages to file
+        if ( tool.CustomBuild == moc )
+            tool.addMOCstage( strm, *it );
+        else if ( tool.CustomBuild == uic )
+            tool.addUICstage( strm, *it );
+        else if ( tool.CustomBuild == resource ) {
+            if (!resourceBuild)
+                resourceBuild = tool.addIMGstage(strm, *it);
+        }
+        if (tool.Project->usePCH)
+            tool.modifyPCHstage( strm, *it );
+
         strm << _begFile;
@@ -1931,9 +2045,23 @@ QTextStream &operator<<( QTextStream &strm, const VCFilter &tool )
         strm << ">";
-        if ( tool.CustomBuild == moc )
-            tool.generateMOC( strm, *it );
-        else if ( tool.CustomBuild == uic )
-            tool.generateUIC( strm, *it );
+        // Output custom build and compiler options
+        // for all configurations
+        if (tool.useCustomBuildTool || tool.useCompilerTool) {
+            for ( uint i = 0; i < tool.Config->count(); i++ ) {
+                strm << _begFileConfiguration;
+                strm << _Name5;
+                strm << (*tool.Config)[i].Name;
+                strm << "\">";
+                if (tool.useCustomBuildTool)
+                    strm <<  tool.CustomBuildTool;
+                if (tool.useCompilerTool)
+                    strm <<  tool.CompilerTool;
+                strm << _endFileConfiguration;
+            }
+        }
         strm << _endFile;
     }
-
+    // close remaining open filters, in non-flat mode
+    while ( !tool.flat_files && currentLevels-- ) {
+        strm << _endFilter;
+    }
     strm << _endFilter;
@@ -1945,13 +2073,5 @@ VCProject::VCProject()
 {
-#if defined(Q_WS_WIN32)
-    GUID guid;
-    QUuid uniqueId;
-    HRESULT h = CoCreateGuid( &guid );
-    if ( h == S_OK )
-        uniqueId = QUuid( guid );
-    ProjectGUID = uniqueId.toString();
-#else
-    // Qt doesn't support GUID on other platforms yet
-    ProjectGUID = "";
-#endif
+    VCConfiguration conf;
+    Configuration += conf ; // Release
+    //Configuration += conf ; // Debug added later, after Release init
 }
@@ -1975,13 +2095,14 @@ QTextStream &operator<<( QTextStream &strm, const VCProject &tool )
     strm << _begConfigurations;
-    strm << tool.Configuration;
+    for ( uint i = 0; i < tool.Configuration.count(); i++ )
+        strm << tool.Configuration[i];
     strm << _endConfigurations;
     strm << _begFiles;
-    strm << tool.SourceFiles;
-    strm << tool.HeaderFiles;
-    strm << tool.MOCFiles;
-    strm << tool.UICFiles;
-    strm << tool.FormFiles;
-    strm << tool.TranslationFiles;
-    strm << tool.LexYaccFiles;
-    strm << tool.ResourceFiles;
+    strm << (VCFilter&)tool.SourceFiles;
+    strm << (VCFilter&)tool.HeaderFiles;
+    strm << (VCFilter&)tool.MOCFiles;
+    strm << (VCFilter&)tool.UICFiles;
+    strm << (VCFilter&)tool.FormFiles;
+    strm << (VCFilter&)tool.TranslationFiles;
+    strm << (VCFilter&)tool.LexYaccFiles;
+    strm << (VCFilter&)tool.ResourceFiles;
     strm << _endFiles;