From 226ddd19ef0adeb279c3a864e24cbfcf556b2f17 Mon Sep 17 00:00:00 2001 From: sandman Date: Mon, 28 Oct 2002 04:41:42 +0000 Subject: - read ( fd, buffer, 4 ); return 5 (!!) for /proc/hal/light_sensor so we better try to read 5 bytes ... - small "off by one" fix for the lcd brightness resolution --- diff --git a/libopie/odevice.cpp b/libopie/odevice.cpp index 6ea4d45..2b7e927 100644 --- a/libopie/odevice.cpp +++ b/libopie/odevice.cpp @@ -674,7 +674,7 @@ bool iPAQ::setDisplayBrightness ( int bright ) int iPAQ::displayBrightnessResolution ( ) const { - return 255; // really 128, but logarithmic control is smoother this way + return 256; // really 128, but logarithmic control is smoother this way } @@ -682,16 +682,17 @@ bool iPAQ::hasLightSensor ( ) const { return true; } - +#include +#include int iPAQ::readLightSensor ( ) { int fd; int val = -1; if (( fd = ::open ( "/proc/hal/light_sensor", O_RDONLY )) >= 0 ) { - char buffer [5]; + char buffer [8]; - if ( ::read ( fd, buffer, 4 ) == 4 ) { + if ( ::read ( fd, buffer, 5 ) == 5 ) char *endptr; buffer [4] = 0; @@ -699,8 +700,7 @@ int iPAQ::readLightSensor ( ) if ( *endptr != 0 ) val = -1; - } - + } ::close ( fd ); } @@ -946,7 +946,7 @@ bool Zaurus::setDisplayBrightness ( int bright ) int Zaurus::displayBrightnessResolution ( ) const { - return 4; + return 5; } //QValueList Zaurus::keyList ( ) const -- cgit v0.9.0.2