From 74363a9e1d5688d65286e7fea156227b68a28002 Mon Sep 17 00:00:00 2001 From: zecke Date: Sat, 14 Aug 2004 17:15:44 +0000 Subject: -Remove the KeyFilter on destruction Alwin could we either add a 'QObject' as a owner so that we could use QGuardedPtr or look for the deleteEvent ourselves. Or let us create a KeyFilter ourselves that auto registers (maybe) but cleans up itself in any case? --- diff --git a/development/keyview/keyboardimpl.cpp b/development/keyview/keyboardimpl.cpp index 673eaa5..0216110 100644 --- a/development/keyview/keyboardimpl.cpp +++ b/development/keyview/keyboardimpl.cpp @@ -164,6 +164,8 @@ QString KeyboardImpl::name() void KeyboardImpl::onKeyPress( QObject *receiver, const char *slot ) { + Q_UNUSED( receiver ); + Q_CONST_UNUSED( slot ); //if ( input ) //QObject::connect( input, SIGNAL(key(ushort,ushort,ushort,bool,bool)), receiver, slot ); } @@ -176,6 +178,8 @@ QRESULT KeyboardImpl::queryInterface( const QUuid &uuid, QUnknownInterface **ifa *iface = this; else if ( uuid == IID_InputMethod ) *iface = this; + else + return QS_FALSE; if ( *iface ) (*iface)->addRef(); diff --git a/development/keyview/keyview.cpp b/development/keyview/keyview.cpp index 8187744..cf082a8 100644 --- a/development/keyview/keyview.cpp +++ b/development/keyview/keyview.cpp @@ -65,11 +65,16 @@ KeyFilter::KeyFilter(QObject * parent, const char *name) : QObject( parent, name { } +KeyFilter::~KeyFilter() { + /* we need to remove the KeyFilter */ + Opie::Core::OKeyFilter::inst()->remHandler( this ); +} + bool KeyFilter::filter(int unicode, int keycode, int modifiers, bool isPress, bool autoRepeat) { qDebug( "unicode: %d, keycode: %d, modifiers: %0x, isPress: %d, autoRepeat: %d", - unicode, keycode, modifiers, isPress ); + unicode, keycode, modifiers, isPress, autoRepeat ); emit keyPressed(unicode, keycode, modifiers, isPress, autoRepeat); return 0; // return 1 to stop key emiting diff --git a/development/keyview/keyview.h b/development/keyview/keyview.h index 5f1e943..87c0d15 100644 --- a/development/keyview/keyview.h +++ b/development/keyview/keyview.h @@ -23,7 +23,6 @@ private: QLineEdit *modifiers; QLineEdit *isPress; QLineEdit *autoRepeat; - }; class KeyFilter : public QObject, public QWSServer::KeyboardFilter @@ -32,6 +31,7 @@ class KeyFilter : public QObject, public QWSServer::KeyboardFilter public: KeyFilter( QObject* parent, const char* name = 0); + virtual ~KeyFilter(); virtual bool filter(int unicode, int keycode, int modifiers, bool isPress, bool autoRepeat); -- cgit v0.9.0.2