From 480284c491e26427c630131a25e56f9ed1d129b2 Mon Sep 17 00:00:00 2001 From: simon Date: Fri, 22 Nov 2002 10:56:30 +0000 Subject: - properly namespace the input methods. fixes symbols clashes at run-time with names like 'Keyboard' or 'KeyboardConfig' . the qcom interface objects are in an anonymous namespace now and the actual keyboard implementations are in Dvorak, JumpX, etc. namespaces. What's left is to solve the symbol clashes of the multiply compiled pickboard classes. I'll leave that one (as part of the patch posted yesterday) for another day for review. This part (namespacing) sounds like a safe bet to me though, so comitting now. (got no comments anyway) --- (limited to 'inputmethods/jumpx') diff --git a/inputmethods/jumpx/keyboard.cpp b/inputmethods/jumpx/keyboard.cpp index 0b8fc14..0cfb4be 100644 --- a/inputmethods/jumpx/keyboard.cpp +++ b/inputmethods/jumpx/keyboard.cpp @@ -124,6 +124,7 @@ static const int cursorMap[][2] = { { Qt::Key_Down, Qt::Key_Down }, }; +using namespace JumpX; Keyboard::Keyboard(QWidget* parent, const char* name, WFlags f) : QFrame(parent, name, f), diff --git a/inputmethods/jumpx/keyboard.h b/inputmethods/jumpx/keyboard.h index 1be095d..689d95a 100644 --- a/inputmethods/jumpx/keyboard.h +++ b/inputmethods/jumpx/keyboard.h @@ -13,6 +13,9 @@ #include #include +namespace JumpX +{ + class Keyboard : public QFrame { Q_OBJECT @@ -69,3 +72,5 @@ private: QTimer *delayTimer; QTimer *rateTimer; }; + +} // namespace JumpX diff --git a/inputmethods/jumpx/keyboardimpl.cpp b/inputmethods/jumpx/keyboardimpl.cpp index 92abb09..34c227f 100644 --- a/inputmethods/jumpx/keyboardimpl.cpp +++ b/inputmethods/jumpx/keyboardimpl.cpp @@ -15,7 +15,7 @@ #include "keyboardimpl.h" /* XPM */ -static const char * icon_xpm[] = { +static const char * const icon_xpm[] = { "26 13 2 1", " c None", ". c #000000", @@ -48,7 +48,7 @@ KeyboardImpl::~KeyboardImpl() QWidget *KeyboardImpl::inputMethod( QWidget *parent, Qt::WFlags f ) { if ( !input ) - input = new Keyboard( parent, "Keyboard", f ); + input = new JumpX::Keyboard( parent, "Keyboard", f ); return input; } diff --git a/inputmethods/jumpx/keyboardimpl.h b/inputmethods/jumpx/keyboardimpl.h index a82ec4a..087781f 100644 --- a/inputmethods/jumpx/keyboardimpl.h +++ b/inputmethods/jumpx/keyboardimpl.h @@ -14,9 +14,15 @@ #include -class Keyboard; +namespace JumpX +{ + class Keyboard; +}; class QPixmap; +namespace +{ + class KeyboardImpl : public InputMethodInterface { public: @@ -35,9 +41,11 @@ public: virtual void onKeyPress( QObject *receiver, const char *slot ); private: - Keyboard *input; + JumpX::Keyboard *input; QPixmap *icn; ulong ref; }; +} // anonymous namespace + #endif -- cgit v0.9.0.2