moved UI authorization code from flickr object

git-svn-id: http://svn.klever.net/kin/fireflix/trunk@176 fe716a7a-6dde-0310-88d9-d003556173a8

2 files changed, 6 insertions, 10 deletions

diff --git a/content/fireflix.js b/content/fireflix.js
index 0f01d26..f180379 100644
--- a/content/fireflix.js
+++ b/content/fireflix.js
@@ -9,97 +9,99 @@ function splitascii(s) {
 }
 
 
 var fireflix = {
  flickr: new Flickr(),
  init: function() {
   pull_elements(this,document,[
    'cmd_auth_auth','cmd_auth_done','cmd_auth_unauth',
    'menu_auth_done','b_auth','b_auth_done','auth_info',
    'loc_strings','cmd_set_props'
   ]);
   this.build_menus();
   this.foundphotos.init(this);
   this.photosets.init(this);
   this.photoset.init(this);
   this.uploads.init(this);
   this.uploadObserver.init(this);
   this.flickr.api_key = '9c43cd66947a57e6f29db1a9da3f72e3';
   this.flickr.api_shs = '9c33c9e2f0f0cfd5';
   this.flickr.prefs_root = 'net.klever.kin.fireflix';
   this.flickr.load_token();
   document.getElementById('setslist').view = this.photosets;
   document.getElementById('setphotos').view = this.photoset;
   document.getElementById('uploadlist').view = this.uploads;
   this.no_auth_info_label = this.auth_info.value;
   this.set_auth_state(this.flickr.token,false);
   if(this.flickr.token) {
    this.refresh_stuff();
   }else{
    this.on_cmd_auth();
   }
  },
  set_auth_state: function(au,inp) { /* authorized, in progress */
   this.cmd_auth_unauth.disabled = !au;
   this.b_auth.hidden = au || inp;
   this.b_auth_done.hidden = !inp;
   this.menu_auth_done.hidden = !inp;
   this.cmd_auth_done.setAttribute('disabled',!inp);
   this.auth_info.disabled = !au;
   if(au) {
    this.auth_info.value = this.flickr.user.fullname+' ['+this.flickr.user.username+']'; /* TODO: move to locale */
   }else{
    this.auth_info.value = this.no_auth_info_label;
   }
  },
  on_cmd_auth: function() {
   var _this = this;
   this.flickr.authorize_0(
-   function() {
+   'delete',
+   function(x,f,u) {
+    _this.openTab(u);
     _this.set_auth_state(_this.flickr.token,true);
    }, function(x,s,c,m) {
     _this.flickr_failure(x,s,c,m);
    }
   );
  },
  on_cmd_auth_done: function() {
   this.set_auth_state(this.flickr.token,false);
   var _this = this;
   this.flickr.authorize_1(
    function() {
     _this.flickr.save_token();
     _this.refresh_stuff();
     _this.set_auth_state(_this.flickr.token,false);
     _this.auth_info.value = 
      _this.flickr.user.fullname+' ['+_this.flickr.user.username+']';
    }, function(x,s,c,m) {
     _this.set_auth_state(_this.flickr.token,false); /* XXX: no reset token? */
     _this.flickr_failure(x,s,c,m);
    }
   );
  },
  on_cmd_auth_unauth: function() {
   this.flickr.reset_token();
   this.set_auth_state(false,false);
  },
 
  refresh_sets: function() { this.photosets.refresh_sets(); },
  refresh_stuff: function() {
   this.refresh_sets();
   this.refresh_user_tags();
  },
 
  /* photoset treeview */
  photoset: {
   photos: new Array(),
   fireflix: null,
   init: function(f) {
    this.fireflix = f;
    pull_elements(this,document,[ 'set_photo' ]);
   },
   rowCount: 0,
   getCellText: function(r,c) {
    var p = this.photos[r];
    if(c.id=='sp_title') return p.title;
    if(c.id=='sp_taken') return p.datetaken;
    if(c.id=='sp_upload') return p.dateupload; /* TODO: unixtime conversion */
    return c.id;
diff --git a/content/flickr.js b/content/flickr.js
index add628a..b5bfa43 100644
--- a/content/flickr.js
+++ b/content/flickr.js
@@ -100,111 +100,105 @@ Flickr.prototype = {
 
  api_sig: function(paramstr) {
   return MD5(toutf8(this.api_shs+paramstr));
  },
  api_call_url: function(params,url) {
   params.api_key = this.api_key;
   var pp = new Array();
   for(var p in params) {
    pp.push(p);
   }
   var pstr = '';
   var rv = (url?url:this.rest_url)+'?';
   for(var p in pp.sort()) {
    var pn = pp[p];
    pstr += pn+params[pn];
    rv += pn+'='+params[pn]+'&';
   }
   rv += 'api_sig='+this.api_sig(pstr);
   return rv;
  },
  api_call: function(params, on_success, on_failure) {
   if(params.auth_token == 'default')
    params.auth_token = this.token;
   var x = new XMLHttpRequest();
   x.open("GET",this.api_call_url(params));
   x.onreadystatechange=function() {
    if(x.readyState!=4) return false;
    if(x.status==200) {
     var stat = x.responseXML.firstChild.getAttribute('stat');
     if(stat=='ok') {
      if(on_success) on_success(x);
     }else{
      var e = x.responseXML.getElementsByTagName('err').item(0);
      var ecode = e.getAttribute('code');
      var emsg = e.getAttribute('msg');
      dump(params.method+' failed: '+ecode+' '+emsg+'\n');
      if(on_failure) on_failure(x,stat,ecode,emsg);
     }
    }else{
     if(on_failure) on_failure(x);
    }
    return true;
   }
   x.send(null);
   return true;
  },
 
  frob: null,
- authorize_0: function(on_s, on_f) {
+ authorize_0: function(perms, on_s, on_f) {
   var _this = this;
   this.api_call(
    { method: 'flickr.auth.getFrob' },
    function(x) {
     _this.frob = xp_str('/rsp/frob',x.responseXML);
     var u = _this.api_call_url(
-     { frob: _this.frob, perms: 'delete' }, _this.auth_url );
-    var wm = Components.classes['@mozilla.org/appshell/window-mediator;1'].getService(
-     Components.interfaces.nsIWindowMediator );
-    var bw = wm.getMostRecentWindow('navigator:browser');
-    var b = bw.getBrowser();
-    var t = b.addTab(u);
-    b.selectedTab = t;
-    if(on_s) on_s();
+     { frob: _this.frob, perms: perms?perms:'delete' }, _this.auth_url );
+    if(on_s) on_s(x,_this.frob,u);
    }, function(x,s,c,m) {
     if(on_f) on_f(x,s,c,m);
    }
   );
  },
  token: null,
  perms: null,
  user: null,
  authorize_1: function(on_s, on_f) {
   var _this = this;
   this.api_call(
    { method: 'flickr.auth.getToken', frob: this.frob },
    function(x) {
     _this.token = xp_str('/rsp/auth/token',x.responseXML);
     _this.perms = xp_str('/rsp/auth/perms',x.responseXML);
     var u = xp_node('/rsp/auth/user',x.responseXML);
     _this.user = {
      nsid: u.getAttribute('nsid'),
      username: u.getAttribute('username'),
      fullname: u.getAttribute('fullname')
     };
     if(on_s) on_s(x);
    }, function(x,s,c,m) {
     if(on_f) on_f(x,s,c,m);
    }
   );
  },
 
  prefs: Components.classes['@mozilla.org/preferences-service;1'].getService(
   Components.interfaces.nsIPrefBranch
  ),
  prefs_root: 'net.klever.kin.flickr',
  save_token: function() {
   // TODO: don't clear when there's nothing to clear or catch exceptions
   if(this.token)
    this.prefs.setCharPref(this.prefs_root+'.auth_token',this.token);
   else
    this.prefs.clearUserPref(this.prefs_root+'.auth_token');
   if(this.perms)
    this.prefs.setCharPref(this.prefs_root+'.auth_perms',this.perms);
   else
    this.prefs.clearUserPref(this.prefs_root+'.auth_perms');
   if(this.user && this.user.nsid!=null && this.user.nsid!=undefined)
    this.prefs.setCharPref(this.prefs_root+'.auth_user.nsid',this.user.nsid);
   else
    this.prefs.clearUserPref(this.prefs_root+'.auth_user.nsid');
   if(this.user && this.user.username!=null && this.user.username!=undefined)
    this.prefs.setCharPref(this.prefs_root+'.auth_user.username',this.user.username);