linting debian stuff

Signed-off-by: Michael Krelin <hacker@klever.net>

8 files changed, 8 insertions, 7 deletions

diff --git a/configure.ac b/configure.ac
index d580f58..f79983e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,75 +1,75 @@
 AC_INIT([iii], [0.2], [iii-bugs@klever.net])
 AC_CONFIG_SRCDIR([src/iiid.cc])
 AC_CONFIG_HEADERS([config.h])
 AM_INIT_AUTOMAKE([dist-bzip2])
 
 AC_PROG_INSTALL
 AC_PROG_CXX
 AC_PROG_CC
 PKG_PROG_PKG_CONFIG
 
 AC_HEADER_STDC
 
 AC_PATH_PROG([XSLTPROC],[xsltproc],[true])
 
-PKG_CHECK_MODULES([MODULES],[gsoap++ openssl libconfuse])
+PKG_CHECK_MODULES([MODULES],[gsoap++ libcrypto libconfuse])
 PKG_CHECK_MODULES([UUID],[uuid],[have_uuid=true],[have_uuid=false])
 AM_CONDITIONAL([HAVE_UUID],[$have_uuid])
 if $have_uuid ; then
  AC_DEFINE([HAVE_LIBUUID],,[defined in presence of libuuid])
  AC_SUBST([UUID_UUID],[uuid])
 fi
 
 AC_PATH_PROG([SOAPCPP2],[soapcpp2],[false])
 test "$SOAPCPP2" = "false" && AC_MSG_ERROR([no soapcpp2 tool, part of gsoap package, found.])
 
 notfound=false
 AC_CHECK_HEADERS([archive.h],[
  AC_CHECK_LIB([archive],[archive_read_new],,[notfound=true])
 ],[notfound=true])
 $notfound && AC_MSG_ERROR([no required libarchive library found. get one from http://people.freebsd.org/~kientzle/libarchive/])
 
 notfound=false
 AC_LANG_PUSH([C++])
 AC_CHECK_HEADERS([autosprintf.h],[
  AC_CHECK_LIB([asprintf],[main],,[notfound=true])
 ],[notfound=true])
 $notfound && AC_MSG_ERROR([no autosprintf, part of gettext, found])
 AC_LANG_POP([C++])
 
 nitpick=false
 AC_ARG_ENABLE([nitpicking],
  AC_HELP_STRING([--enable-nitpicking],[make compiler somewhat overly fastidious about the code it deals with]),
  [ test "$enableval" = "no" || nitpick=true ]
 )
 if $nitpick ; then
  CPP_NITPICK="-pedantic -Wall -Wextra -Wundef -Wshadow \
   -Wunsafe-loop-optimizations -Wconversion -Wmissing-format-attribute \
   -Wredundant-decls -ansi -Wlogical-op -Wmissing-noreturn"
  C_NITPICK="$CPP_NITPICK"
  CXX_NITPICK="$C_NITPICK"
 
  CPPFLAGS="$CPPFLAGS $CPP_NITPICK"
  CFLAGS="$CFLAGS $C_NITPICK"
  CXXFLAGS="$CXXFLAGS $CXX_NITPICK"
 fi
 
 ndebug=true
 AC_ARG_ENABLE([debug],
  AC_HELP_STRING([--enable-debug],[enable debugging code]),
  [ test "$enableval" = "no" || ndebug=false ]
 )
 if $ndebug ; then
  CPPFLAGS_DEBUG="-DNDEBUG"
 else
  CPPFLAGS_DEBUG="-DDEBUG"
 fi
 AC_SUBST([CPPFLAGS_DEBUG])
 
 AC_CONFIG_FILES([
  Makefile
  src/Makefile
  doc/Makefile
   doc/iiid.8
 ])
 AC_OUTPUT
diff --git a/debian/compat b/debian/compat
index b8626c4..7ed6ff8 100644
--- a/debian/compat
+++ b/debian/compat
@@ -1 +1 @@
-4
+5
diff --git a/debian/control b/debian/control
index 02a6138..aaa8c78 100644
--- a/debian/control
+++ b/debian/control
@@ -1,13 +1,13 @@
 Source: iii
 Section: graphics
 Priority: optional
 Maintainer: Michael Krelin <hacker@klever.net>
 Build-Depends: debhelper (>=7), gsoap, libssl-dev, libconfuse-dev, libarchive-dev, gettext
-Standards-Version: 3.8.0
+Standards-Version: 3.8.4
 
 Package: iii
 Architecture: any
-Depends: adduser, ${shlibs:Depends}
+Depends: adduser, ${shlibs:Depends}, ${misc:Depends}
 Description: Eye-Fi Manager implementation
  Implementation of Eye-Fi manager service for Linux
 
diff --git a/debian/iii.postinst b/debian/iii.postinst
index 20463a1..f52bf84 100755
--- a/debian/iii.postinst
+++ b/debian/iii.postinst
@@ -1,18 +1,18 @@
 #!/bin/sh
 set -e
 UG=eyefi
-P=eyekindo
+P=iii
 H=/var/lib/$P
 
 if [ "$1" = configure ] ; then
  getent group $UG >/dev/null 2>&1 || addgroup --system $UG
  getent passwd $UG >/dev/null 2>&1 || adduser --system --home $H \
      --no-create-home --disabled-password --ingroup $UG $UG
  if ! test -d $H ; then
   mkdir -p $H
   chown $UG:$UG $H
   chmod 2770 $H
  fi
 fi
 
 #DEBHELPER#
diff --git a/debian/iii.postrm b/debian/iii.postrm
index a2c66fa..6060c4f 100755
--- a/debian/iii.postrm
+++ b/debian/iii.postrm
@@ -1,3 +1,4 @@
 #!/bin/sh
+set -e
 
 #DEBHELPER#
diff --git a/debian/source/format b/debian/source/format
new file mode 100644
index 0000000..89ae9db
--- a/dev/null
+++ b/debian/source/format
@@ -0,0 +1 @@
+3.0 (native)
diff --git a/doc/000000000000.conf b/doc/000000000000.conf
index d7b365f..01f8fae 100644
--- a/doc/000000000000.conf
+++ b/doc/000000000000.conf
@@ -1,17 +1,17 @@
 # target directory for uploaded files, if the name contains %s, it is replaced
 # with eyefi card mac address.
-targetdir = "/var/lib/eyekindo/%s/"
+targetdir = "/var/lib/iii/%s/"
 # the upload key as seen in Mac and (perhaps) windows Settings.xml file
 uploadkey = "e3e2c4a305cee6bce0ebb38a3259ac08"
 
 # commands to be executed at certain events, the commands also receive certain
 # values of interested passed via environment.
 # for on-start-session: EYEFI_MACADDRESS, EYEFI_TRANSFER_MODE, EYEFI_TRANSFERMODETIMESTAMP
 on-start-session = "bash /usr/local/lib/iii/on-start-session.bash"
 # for on-upload-photo: EYEFI_MACADDRESS, EYEFI_UPLOADED (uploaded file name)
 on-upload-photo = "bash /usr/local/lib/iii/on-upload-photo.bash"
 # for on-mark-last-photo-in-roll: EYEFI_MACADDRESS, EYEFI_MERGEDELTA
 on-mark-last-photo-in-roll = "bash /usr/local/lib/iii/on-mark-last-photo-in-roll.bash"
 
 # file mode creation mask
 umask = 002
diff --git a/src/eyefiservice.cc b/src/eyefiservice.cc
index 49521e0..9650ec1 100644
--- a/src/eyefiservice.cc
+++ b/src/eyefiservice.cc
@@ -1,201 +1,200 @@
 #include <cassert>
 #include <iostream>
 #include <fstream>
 #include <stdexcept>
 #include <iterator>
 #include <syslog.h>
 #include <sys/wait.h>
 #include <autosprintf.h>
-#include <openssl/rand.h>
 #include "eyekinfig.h"
 #include "eyetil.h"
 #include "soapeyefiService.h"
 
 static binary_t session_nonce;
 
 static bool detached_child() {
     pid_t p = fork();
     if(p<0) throw std::runtime_error("failed to fork()");
     if(!p) {
         p = fork();
         if(p<0) {
             syslog(LOG_ERR,"Failed to re-fork child process");
             _exit(-1);
         }
         if(!p) {
             setsid();
             for(int i=getdtablesize();i>=0;--i) close(i);
             int i=open("/dev/null",O_RDWR); assert(i==0);
             i = dup(i); assert(i==1);
             i = dup(i); assert(i==2);
             return true;
         }
         _exit(0);
     }
     int rc;
     if(waitpid(p,&rc,0)<0) throw std::runtime_error("failed to waitpid()");
     if(!WIFEXITED(rc)) throw std::runtime_error("error in forked process");
     if(WEXITSTATUS(rc)) throw std::runtime_error("forked process signalled error");
     return false;
 }
 
 int eyefiService::StartSession(
         std::string macaddress,std::string cnonce,
         int transfermode,long transfermodetimestamp,
         struct rns__StartSessionResponse &r ) try {
 #ifndef NDEBUG
     syslog(LOG_DEBUG,
             "StartSession request from %s with cnonce=%s, transfermode=%d, transfermodetimestamp=%ld",
             macaddress.c_str(), cnonce.c_str(), transfermode, transfermodetimestamp );
 #endif
     eyekinfig_t eyekinfig(macaddress);
     r.credential = binary_t(macaddress+cnonce+eyekinfig.get_upload_key()).md5().hex();
 
     r.snonce = session_nonce.make_nonce().hex();
     r.transfermode=transfermode;
     r.transfermodetimestamp=transfermodetimestamp;
     r.upsyncallowed=false;
 
     std::string cmd = eyekinfig.get_on_start_session();
     if(!cmd.empty()) {
         if(detached_child()) {
             putenv( gnu::autosprintf("EYEFI_MACADDRESS=%s",macaddress.c_str()) );
             putenv( gnu::autosprintf("EYEFI_TRANSFERMODE=%d",transfermode) );
             putenv( gnu::autosprintf("EYEFI_TRANSFERMODETIMESTAMP=%ld",transfermodetimestamp) );
             char *argv[] = { (char*)"/bin/sh", (char*)"-c", (char*)cmd.c_str(), 0 };
             execv("/bin/sh",argv);
             syslog(LOG_ERR,"Failed to execute '%s'",cmd.c_str());
             _exit(-1);
         }
     }
     return SOAP_OK;
 }catch(std::runtime_error& e) {
     syslog(LOG_ERR,"error while processing StartSession: %s",e.what());
 }
 
 int eyefiService::GetPhotoStatus(
         std::string credential, std::string macaddress,
         std::string filename, long filesize, std::string filesignature,
         int flags,
         struct rns__GetPhotoStatusResponse &r ) {
 #ifndef NDEBUG
     syslog(LOG_DEBUG,
             "GetPhotoStatus request from %s with credential=%s, filename=%s, filesize=%ld, filesignature=%s, flags=%d; session nonce=%s",
             macaddress.c_str(), credential.c_str(), filename.c_str(), filesize, filesignature.c_str(), flags,
             session_nonce.hex().c_str() );
 #endif
 
     std::string computed_credential = binary_t(macaddress+eyekinfig_t(macaddress).get_upload_key()+session_nonce.hex()).md5().hex();
 
 #ifndef NDEBUG
     syslog(LOG_DEBUG, " computed credential=%s", computed_credential.c_str());
 #endif
 
     if (credential != computed_credential) throw std::runtime_error("card authentication failed");
 
     r.fileid = 1; r.offset = 0;
     return SOAP_OK;
 }
 
 int eyefiService::MarkLastPhotoInRoll(
         std::string macaddress, int mergedelta,
         struct rns__MarkLastPhotoInRollResponse &r ) {
 #ifndef NDEBUG
     syslog(LOG_DEBUG,
             "MarkLastPhotoInRoll request from %s with mergedelta=%d",
             macaddress.c_str(), mergedelta );
 #endif
     std::string cmd = eyekinfig_t(macaddress).get_on_mark_last_photo_in_roll();
     if(!cmd.empty()) {
         if(detached_child()) {
             putenv( gnu::autosprintf("EYEFI_MACADDRESS=%s",macaddress.c_str()) );
             putenv( gnu::autosprintf("EYEFI_MERGEDELTA=%d",mergedelta) );
             char *argv[] = { (char*)"/bin/sh", (char*)"-c", (char*)cmd.c_str(), 0 };
             execv("/bin/sh",argv);
             syslog(LOG_ERR,"Failed to execute '%s'",cmd.c_str());
             _exit(-1);
         }
     }
     return SOAP_OK;
 }
 
 int eyefiService::UploadPhoto(
         int fileid, std::string macaddress,
         std::string filename, long filesize, std::string filesignature,
         std::string encryption, int flags,
         struct rns__UploadPhotoResponse& r ) {
 #ifndef NDEBUG
     syslog(LOG_DEBUG,
             "UploadPhoto request from %s with fileid=%d, filename=%s, filesize=%ld,"
             " filesignature=%s, encryption=%s, flags=%04X",
             macaddress.c_str(), fileid, filename.c_str(), filesize,
             filesignature.c_str(), encryption.c_str(), flags );
 #endif
     eyekinfig_t eyekinfig(macaddress);
 
     umask(eyekinfig.get_umask());
 
     std::string td = eyekinfig.get_targetdir();
     tmpdir_t indir(td+"/.incoming.XXXXXX");
 
     std::string jf,lf;
     binary_t digest, idigest;
 
     for(soap_multipart::iterator i=mime.begin(),ie=mime.end();i!=ie;++i) {
 #ifndef NDEBUG
         syslog(LOG_DEBUG,
                 " MIME attachment with id=%s, type=%s, size=%ld",
                 (*i).id, (*i).type, (long)(*i).size );
 #endif
 
         if((*i).id && !strcmp((*i).id,"INTEGRITYDIGEST")) {
             std::string idigestr((*i).ptr,(*i).size);
 #ifndef NDEBUG
             syslog(LOG_DEBUG, " INTEGRITYDIGEST=%s", idigestr.c_str());
 #endif
             idigest.from_hex(idigestr);
         }
         if( (*i).id && !strcmp((*i).id,"FILENAME") ) {
             assert( (*i).type && !strcmp((*i).type,"application/x-tar") );
 #ifdef III_SAVE_TARS
             std::string tarfile = indir.get_file(filename);
             {
                 std::ofstream(tarfile.c_str(),std::ios::out|std::ios::binary).write((*i).ptr,(*i).size);
             }
 #endif
 
             if(!jf.empty()) throw std::runtime_error("already seen tarball");
             if(!digest.empty()) throw std::runtime_error("already have integrity digest");
             digest = integrity_digest((*i).ptr,(*i).size,eyekinfig.get_upload_key());
 #ifndef NDEBUG
             syslog(LOG_DEBUG," computed integrity digest=%s", digest.hex().c_str());
 #endif
 
             tarchive_t a((*i).ptr,(*i).size);
             while(a.read_next_header()) {
                 std::string f = indir.get_file(a.entry_pathname());
                 std::string::size_type fl = f.length();
                 if(fl<4) continue;
                 const char *s = f.c_str()+fl-4;
                 if(!strcasecmp(s,".JPG"))
                     jf = f;
                 else if(!strcasecmp(s,".log"))
                     lf = f;
                 else continue;
                 int fd=open(f.c_str(),O_CREAT|O_WRONLY,0666);
                 if(fd<0)
                     throw std::runtime_error(gnu::autosprintf("failed to create output file '%s'",f.c_str()));
                 if(!a.read_data_into_fd(fd))
                     throw std::runtime_error(gnu::autosprintf("failed to untar file into '%s'",f.c_str()));
                 close(fd);
             }
         }
     }
 
     if(jf.empty()) throw std::runtime_error("haven't seen jpeg file");
     if(digest!=idigest) throw std::runtime_error("integrity digest verification failed");
 
     std::string::size_type ls = jf.rfind('/');
     // XXX: actually, lack of '/' signifies error here
     std::string jbn = (ls==std::string::npos)?jf:jf.substr(ls+1);
     ls = lf.rfind('/');