author | Michael Krelin <hacker@klever.net> | 2013-02-12 20:37:10 (UTC) |
---|---|---|
committer | Michael Krelin <hacker@klever.net> | 2013-02-12 20:37:10 (UTC) |
commit | 13fb4abba3fd3cac0d5cb25d3eccddc298220d41 (patch) (unidiff) | |
tree | 8a086ffef06f153e739674a5c8beab1db9388238 | |
parent | b80844f51353339cfbb8b35a5585911cdb4301e2 (diff) | |
download | iii-13fb4abba3fd3cac0d5cb25d3eccddc298220d41.zip iii-13fb4abba3fd3cac0d5cb25d3eccddc298220d41.tar.gz iii-13fb4abba3fd3cac0d5cb25d3eccddc298220d41.tar.bz2 |
introduce throwable_exit for nicer stack unwinding
yes, I enjoy abusing features
Signed-off-by: Michael Krelin <hacker@klever.net>
-rw-r--r-- | src/eyefiworker.cc | 4 | ||||
-rw-r--r-- | src/eyefiworker.h | 1 | ||||
-rw-r--r-- | src/eyetil.h | 5 | ||||
-rw-r--r-- | src/iiid.cc | 4 |
4 files changed, 12 insertions, 2 deletions
diff --git a/src/eyefiworker.cc b/src/eyefiworker.cc index ac75fc1..1979b46 100644 --- a/src/eyefiworker.cc +++ b/src/eyefiworker.cc | |||
@@ -28,12 +28,14 @@ eyefiworker::eyefiworker() | |||
28 | SO_NOSIGPIPE | 28 | SO_NOSIGPIPE |
29 | #else | 29 | #else |
30 | #error Something is wrong with sigpipe prevention on the platform | 30 | #error Something is wrong with sigpipe prevention on the platform |
31 | #endif | 31 | #endif |
32 | ; | 32 | ; |
33 | } | 33 | } |
34 | eyefiworker::~eyefiworker() { | ||
35 | } | ||
34 | 36 | ||
35 | int eyefiworker::run(int bindport) { | 37 | int eyefiworker::run(int bindport) { |
36 | #ifdef HAVE_SQLITE | 38 | #ifdef HAVE_SQLITE |
37 | sqlite3_initialize(); | 39 | sqlite3_initialize(); |
38 | #endif | 40 | #endif |
39 | if(!soap_valid_socket(bind(0,bindport,64))) | 41 | if(!soap_valid_socket(bind(0,bindport,64))) |
@@ -53,13 +55,13 @@ int eyefiworker::run(int bindport) { | |||
53 | if(getrusage(RUSAGE_SELF,&ru)) { | 55 | if(getrusage(RUSAGE_SELF,&ru)) { |
54 | syslog(LOG_NOTICE,"Failed to getrusage(): %d",errno); | 56 | syslog(LOG_NOTICE,"Failed to getrusage(): %d",errno); |
55 | }else{ | 57 | }else{ |
56 | syslog(LOG_INFO,"maxrss: %ld\n",ru.ru_maxrss); | 58 | syslog(LOG_INFO,"maxrss: %ld\n",ru.ru_maxrss); |
57 | } | 59 | } |
58 | #endif /* NDEBUG */ | 60 | #endif /* NDEBUG */ |
59 | _exit(0); | 61 | throw throwable_exit(0); |
60 | } | 62 | } |
61 | close(socket); socket = SOAP_INVALID_SOCKET; | 63 | close(socket); socket = SOAP_INVALID_SOCKET; |
62 | } | 64 | } |
63 | } | 65 | } |
64 | 66 | ||
65 | static binary_t session_nonce; | 67 | static binary_t session_nonce; |
diff --git a/src/eyefiworker.h b/src/eyefiworker.h index 6d4082c..6cdecff 100644 --- a/src/eyefiworker.h +++ b/src/eyefiworker.h | |||
@@ -4,12 +4,13 @@ | |||
4 | #include "soapeyefiService.h" | 4 | #include "soapeyefiService.h" |
5 | 5 | ||
6 | class eyefiworker : public eyefiService { | 6 | class eyefiworker : public eyefiService { |
7 | public: | 7 | public: |
8 | 8 | ||
9 | eyefiworker(); | 9 | eyefiworker(); |
10 | ~eyefiworker(); | ||
10 | 11 | ||
11 | int run(int port) __attribute__ ((noreturn)); | 12 | int run(int port) __attribute__ ((noreturn)); |
12 | 13 | ||
13 | int StartSession(std::string macaddress, std::string cnonce, | 14 | int StartSession(std::string macaddress, std::string cnonce, |
14 | int transfermode, long transfermodetimestamp, | 15 | int transfermode, long transfermodetimestamp, |
15 | struct rns__StartSessionResponse &r); | 16 | struct rns__StartSessionResponse &r); |
diff --git a/src/eyetil.h b/src/eyetil.h index eff2c43..03b9ba8 100644 --- a/src/eyetil.h +++ b/src/eyetil.h | |||
@@ -4,12 +4,17 @@ | |||
4 | #include <vector> | 4 | #include <vector> |
5 | #include <string> | 5 | #include <string> |
6 | #include <archive.h> | 6 | #include <archive.h> |
7 | #include <archive_entry.h> | 7 | #include <archive_entry.h> |
8 | #include "openssl/md5.h" | 8 | #include "openssl/md5.h" |
9 | 9 | ||
10 | struct throwable_exit { | ||
11 | int rc; | ||
12 | throwable_exit(int rc_) : rc(rc_) { } | ||
13 | }; | ||
14 | |||
10 | class binary_t : public std::vector<unsigned char> { | 15 | class binary_t : public std::vector<unsigned char> { |
11 | public: | 16 | public: |
12 | binary_t() { } | 17 | binary_t() { } |
13 | binary_t(size_type n) : std::vector<unsigned char>(n) { } | 18 | binary_t(size_type n) : std::vector<unsigned char>(n) { } |
14 | binary_t(const std::string& h) { from_hex(h); } | 19 | binary_t(const std::string& h) { from_hex(h); } |
15 | binary_t(const void *d,size_t s) { from_data(d,s); } | 20 | binary_t(const void *d,size_t s) { from_data(d,s); } |
diff --git a/src/iiid.cc b/src/iiid.cc index d655fe3..b3dd3bf 100644 --- a/src/iiid.cc +++ b/src/iiid.cc | |||
@@ -86,12 +86,14 @@ int main(int argc,char **argv) try { | |||
86 | globfree(&g); | 86 | globfree(&g); |
87 | 87 | ||
88 | eyefiworker().run(port); | 88 | eyefiworker().run(port); |
89 | 89 | ||
90 | closelog(); | 90 | closelog(); |
91 | return 0; | 91 | return 0; |
92 | } catch(std::exception& e) { | 92 | } catch(const throwable_exit& e) { |
93 | return e.rc; | ||
94 | } catch(const std::exception& e) { | ||
93 | syslog(LOG_CRIT,"Exiting iii daemon, because of error condition"); | 95 | syslog(LOG_CRIT,"Exiting iii daemon, because of error condition"); |
94 | syslog(LOG_CRIT,"Exception: %s",e.what()); | 96 | syslog(LOG_CRIT,"Exception: %s",e.what()); |
95 | return 1; | 97 | return 1; |
96 | } | 98 | } |
97 | 99 | ||