| author | Michael Krelin <hacker@klever.net> | 2011-03-20 02:19:04 (UTC) |
|---|---|---|
| committer | Michael Krelin <hacker@klever.net> | 2011-03-20 02:19:04 (UTC) |
| commit | 16c80883ba6c8657bc6129fb9e2695eaf3d3c09b (patch) (side-by-side diff) | |
| tree | 14861e99fe9522a2e33b076325815a46f415858f | |
| parent | c457b6da4401d13c3d914f34b8a41a1711027dd2 (diff) | |
| download | iii-16c80883ba6c8657bc6129fb9e2695eaf3d3c09b.zip iii-16c80883ba6c8657bc6129fb9e2695eaf3d3c09b.tar.gz iii-16c80883ba6c8657bc6129fb9e2695eaf3d3c09b.tar.bz2 | |
don't double-fork
Signed-off-by: Michael Krelin <hacker@klever.net>
| -rw-r--r-- | src/eyefiservice.cc | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/src/eyefiservice.cc b/src/eyefiservice.cc index 0bf26c4..4ca2777 100644 --- a/src/eyefiservice.cc +++ b/src/eyefiservice.cc @@ -14,11 +14,8 @@ static binary_t session_nonce; static bool detached_child() { pid_t p = fork(); - if(p<0) throw std::runtime_error("failed to fork()"); - if(!p) { - p = fork(); if(p<0) { - syslog(LOG_ERR,"Failed to re-fork child process"); + syslog(LOG_ERR,"Failed to fork away for hook execution"); _exit(-1); } if(!p) { @@ -29,12 +26,6 @@ static bool detached_child() { i = dup(i); assert(i==2); return true; } - _exit(0); - } - int rc; - if(waitpid(p,&rc,0)<0) throw std::runtime_error("failed to waitpid()"); - if(!WIFEXITED(rc)) throw std::runtime_error("error in forked process"); - if(WEXITSTATUS(rc)) throw std::runtime_error("forked process signalled error"); return false; } |