| author | Michael Krelin <hacker@klever.net> | 2007-12-16 22:52:51 (UTC) |
|---|---|---|
| committer | Michael Krelin <hacker@klever.net> | 2007-12-17 12:09:16 (UTC) |
| commit | 24a6f9e3525b76ed1aa787f66b003b01b767af39 (patch) (side-by-side diff) | |
| tree | 87741582a2a673205b11ac0386725c0b9d8377f9 | |
| parent | d4e05a6fe00ebd64546637e5873759d4e8d1b010 (diff) | |
| download | libopkele-24a6f9e3525b76ed1aa787f66b003b01b767af39.zip libopkele-24a6f9e3525b76ed1aa787f66b003b01b767af39.tar.gz libopkele-24a6f9e3525b76ed1aa787f66b003b01b767af39.tar.bz2 | |
made secret_t non-constant size and added params_t::query_string function
1. removed checking that secret_t is exactly 20 bytes, because its size is not
so constant anymore.
2. added a query_string function that produces a query string suitable for use
in GET and POST requests. I'm making use of it when performing direct
request when establishing associations.
Signed-off-by: Michael Krelin <hacker@klever.net>
| -rw-r--r-- | include/opkele/types.h | 18 | ||||
| -rw-r--r-- | lib/params.cc | 13 | ||||
| -rw-r--r-- | lib/secret.cc | 12 |
3 files changed, 30 insertions, 13 deletions
diff --git a/include/opkele/types.h b/include/opkele/types.h index 520618d..ca07df5 100644 --- a/include/opkele/types.h +++ b/include/opkele/types.h @@ -42,12 +42,12 @@ namespace opkele { * xor the secret and hmac together and encode, using base64 - * @param key_sha1 pointer to the sha1 digest + * @param key_d pointer to the message digest * @param rv reference to the return value */ - void enxor_to_base64(const unsigned char *key_sha1,string& rv) const; + void enxor_to_base64(const unsigned char *key_d,string& rv) const; /** - * decode base64-encoded secret and xor it with the sha1 digest - * @param key_sha1 pointer to the message digest + * decode base64-encoded secret and xor it with the message digest + * @param key_d pointer to the message digest * @param b64 base64-encoded secret value */ - void enxor_from_base64(const unsigned char *key_sha1,const string& b64); + void enxor_from_base64(const unsigned char *key_d,const string& b64); /** @@ -163,2 +163,10 @@ namespace opkele { string append_query(const string& url,const char *prefix = "openid.") const; + + /** + * make up a query string suitable for use in GET and POST + * requests. + * @param prefix string to prened to parameter names + * @return query string + */ + string query_string(const char *prefix = "openid.") const; }; diff --git a/lib/params.cc b/lib/params.cc index ea86d3a..7a572c1 100644 --- a/lib/params.cc +++ b/lib/params.cc @@ -101,2 +101,15 @@ namespace opkele { + string params_t::query_string(const char *prefix) const { + string rv; + for(const_iterator i=begin();i!=end();++i) { + if(!rv.empty()) + rv += '&'; + rv += prefix; + rv += i->first; + rv += '='; + rv += util::url_encode(i->second); + } + return rv; + } + ostream& operator << (ostream& o,const params_t& p) { diff --git a/lib/secret.cc b/lib/secret.cc index 632a2ca..d538890 100644 --- a/lib/secret.cc +++ b/lib/secret.cc @@ -16,5 +16,3 @@ namespace opkele { - void secret_t::enxor_to_base64(const unsigned char *key_sha1,string& rv) const { - if(size()!=20) - throw bad_input(OPKELE_CP_ "wrong secret size"); + void secret_t::enxor_to_base64(const unsigned char *key_d,string& rv) const { vector<unsigned char> tmp; @@ -22,3 +20,3 @@ namespace opkele { begin(), end(), - key_sha1, + key_d, back_insert_iterator<vector<unsigned char> >(tmp), @@ -28,3 +26,3 @@ namespace opkele { - void secret_t::enxor_from_base64(const unsigned char *key_sha1,const string& b64) { + void secret_t::enxor_from_base64(const unsigned char *key_d,const string& b64) { clear(); @@ -33,3 +31,3 @@ namespace opkele { begin(), end(), - key_sha1, + key_d, begin(), @@ -39,4 +37,2 @@ namespace opkele { void secret_t::to_base64(string& rv) const { - if(size()!=20) - throw bad_input(OPKELE_CP_ "wrong secret size"); rv = util::encode_base64(&(front()),size()); |