| author | Michael Krelin <hacker@klever.net> | 2007-06-18 21:38:12 (UTC) |
|---|---|---|
| committer | Michael Krelin <hacker@klever.net> | 2007-06-18 21:38:12 (UTC) |
| commit | 3b404dd029a2aba05efc2edadcc7f67c59746cf7 (patch) (side-by-side diff) | |
| tree | a972e6f7ab320927409cf773977b4ee58ce5cf68 | |
| parent | e4873a10430d012943d2712b5b9c3363e8c74cb5 (diff) | |
| download | libopkele-3b404dd029a2aba05efc2edadcc7f67c59746cf7.zip libopkele-3b404dd029a2aba05efc2edadcc7f67c59746cf7.tar.gz libopkele-3b404dd029a2aba05efc2edadcc7f67c59746cf7.tar.bz2 | |
Adhere to Postel's Law.
That is, be liberal when parsing key/value parameters from remote.
Along with configure switch to disable it.
| -rw-r--r-- | configure.ac | 7 | ||||
| -rw-r--r-- | lib/params.cc | 16 |
2 files changed, 23 insertions, 0 deletions
diff --git a/configure.ac b/configure.ac index 8397914..19e7832 100644 --- a/configure.ac +++ b/configure.ac @@ -74,8 +74,15 @@ AC_ARG_ENABLE([ssl-verify-peer], [ test "${enableval}" = "no" && curl_ssl_verify_peer="false" ] ) ${curl_ssl_verify_peer} || AC_DEFINE([DISABLE_CURL_SSL_VERIFYPEER],,[defined if cURL is not to verify cert validity]) +postels_law=true +AC_ARG_ENABLE([postels-law], + AC_HELP_STRING([--disable-postels-law],[Be strict, do not adhere to Postel's Law ("be conservative in what you do, be liberal in what you accept from others", RFC 793)]), + [ test "${enableval}" = "no" && postels_law=false ] +) +$postels_law && AC_DEFINE([POSTELS_LAW],,[defined if we want to adhere to Postel's Law]) + AC_CONFIG_FILES([ Makefile libopkele.pc Doxyfile diff --git a/lib/params.cc b/lib/params.cc index b181811..ea86d3a 100644 --- a/lib/params.cc +++ b/lib/params.cc @@ -3,8 +3,10 @@ #include <opkele/util.h> #include <openssl/sha.h> #include <openssl/hmac.h> +#include "config.h" + namespace opkele { using namespace std; bool params_t::has_param(const string& n) const { @@ -29,14 +31,28 @@ namespace opkele { while(true) { string::size_type co = kv.find(':',p); if(co==string::npos) break; +#ifndef POSTELS_LAW string::size_type nl = kv.find('\n',co+1); if(nl==string::npos) throw bad_input(OPKELE_CP_ "malformed input"); if(nl>co) insert(value_type(kv.substr(p,co-p),kv.substr(co+1,nl-co-1))); p = nl+1; +#else /* POSTELS_LAW */ + string::size_type lb = kv.find_first_of("\r\n",co+1); + if(lb==string::npos) { + insert(value_type(kv.substr(p,co-p),kv.substr(co+1))); + break; + } + if(lb>co) + insert(value_type(kv.substr(p,co-p),kv.substr(co+1,lb-co-1))); + string::size_type nolb = kv.find_first_not_of("\r\n",lb); + if(nolb==string::npos) + break; + p = nolb; +#endif /* POSTELS_LAW */ } } void params_t::sign(secret_t secret,string& sig,const string& slist,const char *prefix) const { |