author | Michael Krelin <hacker@klever.net> | 2007-12-04 19:02:15 (UTC) |
---|---|---|
committer | Michael Krelin <hacker@klever.net> | 2007-12-04 19:02:15 (UTC) |
commit | 7a6a6fbcf7e20f0d7da5f625a73c865b361f16aa (patch) (unidiff) | |
tree | 42a2983bd4fdbba0b49d9a5329e5f819ad73d5ec | |
parent | 206de587733c5dbde280fb6e9f1eab2f02de7f54 (diff) | |
download | libopkele-7a6a6fbcf7e20f0d7da5f625a73c865b361f16aa.zip libopkele-7a6a6fbcf7e20f0d7da5f625a73c865b361f16aa.tar.gz libopkele-7a6a6fbcf7e20f0d7da5f625a73c865b361f16aa.tar.bz2 |
Minor improvements
- almost irrelevant documentation updates
- introduced id_res_expired_on_delivery exception to be thrown if the
association has expired right before it could've been used for signature
verification.
Signed-off-by: Michael Krelin <hacker@klever.net>
-rw-r--r-- | include/opkele/consumer.h | 6 | ||||
-rw-r--r-- | include/opkele/exception.h | 9 | ||||
-rw-r--r-- | lib/consumer.cc | 6 |
3 files changed, 18 insertions, 3 deletions
diff --git a/include/opkele/consumer.h b/include/opkele/consumer.h index 50ff692..c463787 100644 --- a/include/opkele/consumer.h +++ b/include/opkele/consumer.h | |||
@@ -66,8 +66,13 @@ namespace opkele { | |||
66 | * The user is responsible for handling associations and this | 66 | * The user is responsible for handling associations and this |
67 | * function should never return an expired or invalidated | 67 | * function should never return an expired or invalidated |
68 | * association. | 68 | * association. |
69 | * | 69 | * |
70 | * @note | ||
71 | * It may be a good idea to pre-expire associations shortly before | ||
72 | * their time is really up to avoid association expiry in the | ||
73 | * middle of negotiations. | ||
74 | * | ||
70 | * @param server the OpenID server | 75 | * @param server the OpenID server |
71 | * @return the auto_ptr<> for the newly allocated association_t object | 76 | * @return the auto_ptr<> for the newly allocated association_t object |
72 | * @throw failed_lookup in case of absence of the handle | 77 | * @throw failed_lookup in case of absence of the handle |
73 | */ | 78 | */ |
@@ -136,8 +141,9 @@ namespace opkele { | |||
136 | * @throw id_res_mismatch in case of signature mismatch | 141 | * @throw id_res_mismatch in case of signature mismatch |
137 | * @throw id_res_setup in case of openid.user_setup_url failure | 142 | * @throw id_res_setup in case of openid.user_setup_url failure |
138 | * (supposedly checkid_immediate only) | 143 | * (supposedly checkid_immediate only) |
139 | * @throw id_res_failed in case of failure | 144 | * @throw id_res_failed in case of failure |
145 | * @throw id_res_expired_on_delivery if the association expired before it could've been verified | ||
140 | * @throw exception in case of other failures | 146 | * @throw exception in case of other failures |
141 | */ | 147 | */ |
142 | virtual void id_res(const params_t& pin,const string& identity="",extension_t *ext=0); | 148 | virtual void id_res(const params_t& pin,const string& identity="",extension_t *ext=0); |
143 | /** | 149 | /** |
diff --git a/include/opkele/exception.h b/include/opkele/exception.h index 753a818..2ff44b7 100644 --- a/include/opkele/exception.h +++ b/include/opkele/exception.h | |||
@@ -169,8 +169,17 @@ namespace opkele { | |||
169 | : id_res_failed(OPKELE_E_CONS) { } | 169 | : id_res_failed(OPKELE_E_CONS) { } |
170 | }; | 170 | }; |
171 | 171 | ||
172 | /** | 172 | /** |
173 | * thrown if the association has expired before it could've been verified. | ||
174 | */ | ||
175 | class id_res_expired_on_delivery : public id_res_failed { | ||
176 | public: | ||
177 | id_res_expired_on_delivery(OPKELE_E_PARS) | ||
178 | : id_res_failed(OPKELE_E_CONS) { } | ||
179 | }; | ||
180 | |||
181 | /** | ||
173 | * openssl malfunction occured | 182 | * openssl malfunction occured |
174 | */ | 183 | */ |
175 | class exception_openssl : public exception { | 184 | class exception_openssl : public exception { |
176 | public: | 185 | public: |
diff --git a/lib/consumer.cc b/lib/consumer.cc index 66db7dd..9f7530f 100644 --- a/lib/consumer.cc +++ b/lib/consumer.cc | |||
@@ -183,10 +183,10 @@ namespace opkele { | |||
183 | retrieve_links(identity.empty()?pin.get_param("openid.identity"):canonicalize(identity),server,delegate); | 183 | retrieve_links(identity.empty()?pin.get_param("openid.identity"):canonicalize(identity),server,delegate); |
184 | params_t ps; | 184 | params_t ps; |
185 | try { | 185 | try { |
186 | assoc_t assoc = retrieve_assoc(server,pin.get_param("openid.assoc_handle")); | 186 | assoc_t assoc = retrieve_assoc(server,pin.get_param("openid.assoc_handle")); |
187 | if(assoc->is_expired()) /* TODO: or should I throw some other exception to force programmer fix his implementation? */ | 187 | if(assoc->is_expired()) |
188 | throw failed_lookup(OPKELE_CP_ "retrieve_assoc() has returned expired handle"); | 188 | throw id_res_expired_on_delivery(OPKELE_CP_ "retrieve_assoc() has returned expired handle"); |
189 | const string& sigenc = pin.get_param("openid.sig"); | 189 | const string& sigenc = pin.get_param("openid.sig"); |
190 | vector<unsigned char> sig; | 190 | vector<unsigned char> sig; |
191 | util::decode_base64(sigenc,sig); | 191 | util::decode_base64(sigenc,sig); |
192 | const string& slist = pin.get_param("openid.signed"); | 192 | const string& slist = pin.get_param("openid.signed"); |
@@ -213,9 +213,9 @@ namespace opkele { | |||
213 | (const unsigned char *)kv.data(),kv.length(), | 213 | (const unsigned char *)kv.data(),kv.length(), |
214 | 0,&md_len); | 214 | 0,&md_len); |
215 | if(sig.size()!=md_len || memcmp(&(sig.front()),md,md_len)) | 215 | if(sig.size()!=md_len || memcmp(&(sig.front()),md,md_len)) |
216 | throw id_res_mismatch(OPKELE_CP_ "signature mismatch"); | 216 | throw id_res_mismatch(OPKELE_CP_ "signature mismatch"); |
217 | }catch(failed_lookup& e) { /* XXX: more specific? */ | 217 | }catch(failed_lookup& e) { |
218 | const string& slist = pin.get_param("openid.signed"); | 218 | const string& slist = pin.get_param("openid.signed"); |
219 | string::size_type pp = 0; | 219 | string::size_type pp = 0; |
220 | params_t p; | 220 | params_t p; |
221 | while(true) { | 221 | while(true) { |