| author | Rys Sommefeldt <rys@pixeltards.com> | 2009-11-07 14:24:45 (UTC) |
|---|---|---|
| committer | Lars Hjemli <hjemli@gmail.com> | 2009-11-07 14:34:18 (UTC) |
| commit | 8cfe4897f01066ae901bdd6ef106faf8e8f2ddf2 (patch) (side-by-side diff) | |
| tree | 2b66d688de6ce2b7598cc78ea6ed812f2d5f882a | |
| parent | e34a3b5adc00255f8acb7d674e5fdadef2ac80f7 (diff) | |
| download | cgit-8cfe4897f01066ae901bdd6ef106faf8e8f2ddf2.zip cgit-8cfe4897f01066ae901bdd6ef106faf8e8f2ddf2.tar.gz cgit-8cfe4897f01066ae901bdd6ef106faf8e8f2ddf2.tar.bz2 | |
Close fd on error in readfile()
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
| -rw-r--r-- | shared.c | 9 |
1 files changed, 7 insertions, 2 deletions
@@ -408,6 +408,10 @@ int readfile(const char *path, char **buf, size_t *size) return errno; - if (fstat(fd, &st)) + if (fstat(fd, &st)) { + close(fd); return errno; - if (!S_ISREG(st.st_mode)) + } + if (!S_ISREG(st.st_mode)) { + close(fd); return EISDIR; + } *buf = xmalloc(st.st_size + 1); @@ -415,2 +419,3 @@ int readfile(const char *path, char **buf, size_t *size) (*buf)[*size] = '\0'; + close(fd); return (*size == st.st_size ? 0 : errno); |