ui-shared: Improve const-ness in API

This is needed to prevent const-related warnings in later patches.

Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>

2 files changed, 80 insertions, 65 deletions

diff --git a/ui-shared.c b/ui-shared.c
index 8827fff..7d7fff0 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -29,3 +29,3 @@ static char *http_date(time_t t)
 
-void cgit_print_error(char *msg)
+void cgit_print_error(const char *msg)
 {
@@ -135,3 +135,3 @@ char *cgit_currurl()
 
-static void site_url(char *page, char *search, int ofs)
+static void site_url(const char *page, const char *search, int ofs)
 {
@@ -162,4 +162,4 @@ static void site_url(char *page, char *search, int ofs)
 
-static void site_link(char *page, char *name, char *title, char *class,
-                      char *search, int ofs)
+static void site_link(const char *page, const char *name, const char *title,
+                      const char *class, const char *search, int ofs)
 {
@@ -183,4 +183,4 @@ static void site_link(char *page, char *name, char *title, char *class,
 
-void cgit_index_link(char *name, char *title, char *class, char *pattern,
-                     int ofs)
+void cgit_index_link(const char *name, const char *title, const char *class,
+                     const char *pattern, int ofs)
 {
@@ -189,4 +189,4 @@ void cgit_index_link(char *name, char *title, char *class, char *pattern,
 
-static char *repolink(char *title, char *class, char *page, char *head,
-                      char *path)
+static char *repolink(const char *title, const char *class, const char *page,
+                      const char *head, const char *path)
 {
@@ -242,4 +242,5 @@ static char *repolink(char *title, char *class, char *page, char *head,
 
-static void reporevlink(char *page, char *name, char *title, char *class,
-                        char *head, char *rev, char *path)
+static void reporevlink(const char *page, const char *name, const char *title,
+                        const char *class, const char *head, const char *rev,
+                        const char *path)
 {
@@ -258,3 +259,4 @@ static void reporevlink(char *page, char *name, char *title, char *class,
 
-void cgit_summary_link(char *name, char *title, char *class, char *head)
+void cgit_summary_link(const char *name, const char *title, const char *class,
+                       const char *head)
 {
@@ -263,4 +265,4 @@ void cgit_summary_link(char *name, char *title, char *class, char *head)
 
-void cgit_tag_link(char *name, char *title, char *class, char *head,
-                   char *rev)
+void cgit_tag_link(const char *name, const char *title, const char *class,
+                   const char *head, const char *rev)
 {
@@ -269,4 +271,4 @@ void cgit_tag_link(char *name, char *title, char *class, char *head,
 
-void cgit_tree_link(char *name, char *title, char *class, char *head,
-                    char *rev, char *path)
+void cgit_tree_link(const char *name, const char *title, const char *class,
+                    const char *head, const char *rev, const char *path)
 {
@@ -275,4 +277,4 @@ void cgit_tree_link(char *name, char *title, char *class, char *head,
 
-void cgit_plain_link(char *name, char *title, char *class, char *head,
-                     char *rev, char *path)
+void cgit_plain_link(const char *name, const char *title, const char *class,
+                     const char *head, const char *rev, const char *path)
 {
@@ -281,5 +283,5 @@ void cgit_plain_link(char *name, char *title, char *class, char *head,
 
-void cgit_log_link(char *name, char *title, char *class, char *head,
-                   char *rev, char *path, int ofs, char *grep, char *pattern,
-                   int showmsg)
+void cgit_log_link(const char *name, const char *title, const char *class,
+                   const char *head, const char *rev, const char *path,
+                   int ofs, const char *grep, const char *pattern, int showmsg)
 {
@@ -318,4 +320,4 @@ void cgit_log_link(char *name, char *title, char *class, char *head,
 
-void cgit_commit_link(char *name, char *title, char *class, char *head,
-                      char *rev, int toggle_ssdiff)
+void cgit_commit_link(char *name, const char *title, const char *class,
+                      const char *head, const char *rev, int toggle_ssdiff)
 {
@@ -346,4 +348,4 @@ void cgit_commit_link(char *name, char *title, char *class, char *head,
 
-void cgit_refs_link(char *name, char *title, char *class, char *head,
-                    char *rev, char *path)
+void cgit_refs_link(const char *name, const char *title, const char *class,
+                    const char *head, const char *rev, const char *path)
 {
@@ -352,4 +354,5 @@ void cgit_refs_link(char *name, char *title, char *class, char *head,
 
-void cgit_snapshot_link(char *name, char *title, char *class, char *head,
-                        char *rev, char *archivename)
+void cgit_snapshot_link(const char *name, const char *title, const char *class,
+                        const char *head, const char *rev,
+                        const char *archivename)
 {
@@ -358,5 +361,5 @@ void cgit_snapshot_link(char *name, char *title, char *class, char *head,
 
-void cgit_diff_link(char *name, char *title, char *class, char *head,
-                    char *new_rev, char *old_rev, char *path,
-                    int toggle_ssdiff)
+void cgit_diff_link(const char *name, const char *title, const char *class,
+                    const char *head, const char *new_rev, const char *old_rev,
+                    const char *path, int toggle_ssdiff)
 {
@@ -386,4 +389,4 @@ void cgit_diff_link(char *name, char *title, char *class, char *head,
 
-void cgit_patch_link(char *name, char *title, char *class, char *head,
-                     char *rev)
+void cgit_patch_link(const char *name, const char *title, const char *class,
+                     const char *head, const char *rev)
 {
@@ -392,4 +395,4 @@ void cgit_patch_link(char *name, char *title, char *class, char *head,
 
-void cgit_stats_link(char *name, char *title, char *class, char *head,
-                     char *path)
+void cgit_stats_link(const char *name, const char *title, const char *class,
+                     const char *head, const char *path)
 {
@@ -419,3 +422,3 @@ void cgit_object_link(struct object *obj)
 
-void cgit_print_date(time_t secs, char *format, int local_time)
+void cgit_print_date(time_t secs, const char *format, int local_time)
 {
@@ -434,3 +437,3 @@ void cgit_print_date(time_t secs, char *format, int local_time)
 
-void cgit_print_age(time_t t, time_t max_relative, char *format)
+void cgit_print_age(time_t t, time_t max_relative, const char *format)
 {
@@ -613,3 +616,4 @@ int print_archive_ref(const char *refname, const unsigned char *sha1,
 
-void cgit_add_hidden_formfields(int incl_head, int incl_search, char *page)
+void cgit_add_hidden_formfields(int incl_head, int incl_search,
+                                const char *page)
 {
diff --git a/ui-shared.h b/ui-shared.h
index 9ebc1f9..308c982 100644
--- a/ui-shared.h
+++ b/ui-shared.h
@@ -12,32 +12,43 @@ extern char *cgit_pageurl(const char *reponame, const char *pagename,
 
-extern void cgit_index_link(char *name, char *title, char *class,
-                            char *pattern, int ofs);
-extern void cgit_summary_link(char *name, char *title, char *class, char *head);
-extern void cgit_tag_link(char *name, char *title, char *class, char *head,
-                          char *rev);
-extern void cgit_tree_link(char *name, char *title, char *class, char *head,
-                           char *rev, char *path);
-extern void cgit_plain_link(char *name, char *title, char *class, char *head,
-                            char *rev, char *path);
-extern void cgit_log_link(char *name, char *title, char *class, char *head,
-                          char *rev, char *path, int ofs, char *grep,
-                          char *pattern, int showmsg);
-extern void cgit_commit_link(char *name, char *title, char *class, char *head,
-                             char *rev, int toggle_ssdiff);
-extern void cgit_patch_link(char *name, char *title, char *class, char *head,
-                            char *rev);
-extern void cgit_refs_link(char *name, char *title, char *class, char *head,
-                           char *rev, char *path);
-extern void cgit_snapshot_link(char *name, char *title, char *class,
-                               char *head, char *rev, char *archivename);
-extern void cgit_diff_link(char *name, char *title, char *class, char *head,
-                           char *new_rev, char *old_rev, char *path,
-                           int toggle_ssdiff);
-extern void cgit_stats_link(char *name, char *title, char *class, char *head,
-                            char *path);
+extern void cgit_index_link(const char *name, const char *title,
+                            const char *class, const char *pattern, int ofs);
+extern void cgit_summary_link(const char *name, const char *title,
+                              const char *class, const char *head);
+extern void cgit_tag_link(const char *name, const char *title,
+                          const char *class, const char *head,
+                          const char *rev);
+extern void cgit_tree_link(const char *name, const char *title,
+                           const char *class, const char *head,
+                           const char *rev, const char *path);
+extern void cgit_plain_link(const char *name, const char *title,
+                            const char *class, const char *head,
+                            const char *rev, const char *path);
+extern void cgit_log_link(const char *name, const char *title,
+                          const char *class, const char *head, const char *rev,
+                          const char *path, int ofs, const char *grep,
+                          const char *pattern, int showmsg);
+extern void cgit_commit_link(char *name, const char *title,
+                             const char *class, const char *head,
+                             const char *rev, int toggle_ssdiff);
+extern void cgit_patch_link(const char *name, const char *title,
+                            const char *class, const char *head,
+                            const char *rev);
+extern void cgit_refs_link(const char *name, const char *title,
+                           const char *class, const char *head,
+                           const char *rev, const char *path);
+extern void cgit_snapshot_link(const char *name, const char *title,
+                               const char *class, const char *head,
+                               const char *rev, const char *archivename);
+extern void cgit_diff_link(const char *name, const char *title,
+                           const char *class, const char *head,
+                           const char *new_rev, const char *old_rev,
+                           const char *path, int toggle_ssdiff);
+extern void cgit_stats_link(const char *name, const char *title,
+                            const char *class, const char *head,
+                            const char *path);
 extern void cgit_object_link(struct object *obj);
 
-extern void cgit_print_error(char *msg);
-extern void cgit_print_date(time_t secs, char *format, int local_time);
-extern void cgit_print_age(time_t t, time_t max_relative, char *format);
+extern void cgit_print_error(const char *msg);
+extern void cgit_print_date(time_t secs, const char *format, int local_time);
+extern void cgit_print_age(time_t t, time_t max_relative, const char *format);
 extern void cgit_print_http_headers(struct cgit_context *ctx);
@@ -50,3 +61,3 @@ extern void cgit_print_snapshot_links(const char *repo, const char *head,
 extern void cgit_add_hidden_formfields(int incl_head, int incl_search,
-                                       char *page);
+                                       const char *page);
 #endif /* UI_SHARED_H */