author | Lars Hjemli <hjemli@gmail.com> | 2007-05-14 23:05:39 (UTC) |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2007-05-14 23:05:39 (UTC) |
commit | cfd2aa079770ddb4c93d5995b2cd7b5f25da3681 (patch) (unidiff) | |
tree | 44dd0fba85d035e445168b365618000ff82239f3 | |
parent | ea2831f1c826d92c0158474c2d07837ec2f9fd6c (diff) | |
download | cgit-cfd2aa079770ddb4c93d5995b2cd7b5f25da3681.zip cgit-cfd2aa079770ddb4c93d5995b2cd7b5f25da3681.tar.gz cgit-cfd2aa079770ddb4c93d5995b2cd7b5f25da3681.tar.bz2 |
Do not alter incoming sha1 when handling the download refs.
The code used to overwrite the const sha1 parameter just to avoid declaring
an extra variable. Fix it.
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r-- | ui-summary.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/ui-summary.c b/ui-summary.c index 3410e1a..b99ea98 100644 --- a/ui-summary.c +++ b/ui-summary.c | |||
@@ -132,2 +132,3 @@ static int cgit_print_archive_cb(const char *refname, const unsigned char *sha1, | |||
132 | char buf[256], *url; | 132 | char buf[256], *url; |
133 | unsigned char fileid[20]; | ||
133 | 134 | ||
@@ -143,5 +144,7 @@ static int cgit_print_archive_cb(const char *refname, const unsigned char *sha1, | |||
143 | return 0; | 144 | return 0; |
144 | hashcpy(sha1, tag->tagged->sha1); | 145 | hashcpy(fileid, tag->tagged->sha1); |
145 | } else if (obj->type != OBJ_BLOB) { | 146 | } else if (obj->type != OBJ_BLOB) { |
146 | return 0; | 147 | return 0; |
148 | } else { | ||
149 | hashcpy(fileid, sha1); | ||
147 | } | 150 | } |
@@ -154,3 +157,3 @@ static int cgit_print_archive_cb(const char *refname, const unsigned char *sha1, | |||
154 | url = cgit_pageurl(cgit_query_repo, "blob", | 157 | url = cgit_pageurl(cgit_query_repo, "blob", |
155 | fmt("id=%s&path=%s", sha1_to_hex(sha1), | 158 | fmt("id=%s&path=%s", sha1_to_hex(fileid), |
156 | buf)); | 159 | buf)); |