author | Lars Hjemli <hjemli@gmail.com> | 2007-05-16 08:45:45 (UTC) |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2007-05-16 08:46:59 (UTC) |
commit | c1ad6cb77889880ad0189a689840fbfa6e5cbc80 (patch) (unidiff) | |
tree | 352c32898316a388b582385a5fb3c6c534eaa30a | |
parent | f4f1339fe62fb1a28c147567195a86dd99485e25 (diff) | |
download | cgit-c1ad6cb77889880ad0189a689840fbfa6e5cbc80.zip cgit-c1ad6cb77889880ad0189a689840fbfa6e5cbc80.tar.gz cgit-c1ad6cb77889880ad0189a689840fbfa6e5cbc80.tar.bz2 |
Restrict length of repo description on repolist page
If any repo has a very long description, all repos suffer since the
repo-links in the right-most column gets pushed out of sight.
Fix it by introducing max-repodesc-length parameter in cgitrc, and default
to 60 chars.
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r-- | cgit.h | 1 | ||||
-rw-r--r-- | cgitrc | 4 | ||||
-rw-r--r-- | shared.c | 3 | ||||
-rw-r--r-- | ui-repolist.c | 2 |
4 files changed, 9 insertions, 1 deletions
@@ -80,24 +80,25 @@ extern char *cgit_script_name; | |||
80 | extern char *cgit_cache_root; | 80 | extern char *cgit_cache_root; |
81 | 81 | ||
82 | extern int cgit_nocache; | 82 | extern int cgit_nocache; |
83 | extern int cgit_snapshots; | 83 | extern int cgit_snapshots; |
84 | extern int cgit_max_lock_attempts; | 84 | extern int cgit_max_lock_attempts; |
85 | extern int cgit_cache_root_ttl; | 85 | extern int cgit_cache_root_ttl; |
86 | extern int cgit_cache_repo_ttl; | 86 | extern int cgit_cache_repo_ttl; |
87 | extern int cgit_cache_dynamic_ttl; | 87 | extern int cgit_cache_dynamic_ttl; |
88 | extern int cgit_cache_static_ttl; | 88 | extern int cgit_cache_static_ttl; |
89 | extern int cgit_cache_max_create_time; | 89 | extern int cgit_cache_max_create_time; |
90 | 90 | ||
91 | extern int cgit_max_msg_len; | 91 | extern int cgit_max_msg_len; |
92 | extern int cgit_max_repodesc_len; | ||
92 | extern int cgit_max_commit_count; | 93 | extern int cgit_max_commit_count; |
93 | 94 | ||
94 | extern char *cgit_repo_name; | 95 | extern char *cgit_repo_name; |
95 | extern char *cgit_repo_desc; | 96 | extern char *cgit_repo_desc; |
96 | extern char *cgit_repo_owner; | 97 | extern char *cgit_repo_owner; |
97 | 98 | ||
98 | extern int cgit_query_has_symref; | 99 | extern int cgit_query_has_symref; |
99 | extern int cgit_query_has_sha1; | 100 | extern int cgit_query_has_sha1; |
100 | 101 | ||
101 | extern char *cgit_querystring; | 102 | extern char *cgit_querystring; |
102 | extern char *cgit_query_repo; | 103 | extern char *cgit_query_repo; |
103 | extern char *cgit_query_page; | 104 | extern char *cgit_query_page; |
@@ -42,24 +42,28 @@ | |||
42 | ## Link to logo file | 42 | ## Link to logo file |
43 | #logo=/cgit/git-logo.png | 43 | #logo=/cgit/git-logo.png |
44 | 44 | ||
45 | 45 | ||
46 | ## Url loaded when clicking the logo | 46 | ## Url loaded when clicking the logo |
47 | #logo-link=http://www.kernel.org/pub/software/scm/git/docs/ | 47 | #logo-link=http://www.kernel.org/pub/software/scm/git/docs/ |
48 | 48 | ||
49 | 49 | ||
50 | ## Url loaded when clicking a submodule link | 50 | ## Url loaded when clicking a submodule link |
51 | #module-link=./?repo=%s&page=commit&id=%s | 51 | #module-link=./?repo=%s&page=commit&id=%s |
52 | 52 | ||
53 | 53 | ||
54 | ## Number of chars shown of repo description (in repolist view) | ||
55 | #max-repodesc-length=60 | ||
56 | |||
57 | |||
54 | ## Number of chars shown of commit subject message (in log view) | 58 | ## Number of chars shown of commit subject message (in log view) |
55 | #max-message-length=60 | 59 | #max-message-length=60 |
56 | 60 | ||
57 | 61 | ||
58 | ## Number of commits per page in log view | 62 | ## Number of commits per page in log view |
59 | #max-commit-count=50 | 63 | #max-commit-count=50 |
60 | 64 | ||
61 | 65 | ||
62 | ## Root of cached output | 66 | ## Root of cached output |
63 | #cache-root=/var/cache/cgit | 67 | #cache-root=/var/cache/cgit |
64 | 68 | ||
65 | 69 | ||
@@ -21,24 +21,25 @@ char *cgit_script_name = CGIT_SCRIPT_NAME; | |||
21 | char *cgit_cache_root = "/var/cache/cgit"; | 21 | char *cgit_cache_root = "/var/cache/cgit"; |
22 | 22 | ||
23 | int cgit_nocache = 0; | 23 | int cgit_nocache = 0; |
24 | int cgit_snapshots = 0; | 24 | int cgit_snapshots = 0; |
25 | int cgit_max_lock_attempts = 5; | 25 | int cgit_max_lock_attempts = 5; |
26 | int cgit_cache_root_ttl = 5; | 26 | int cgit_cache_root_ttl = 5; |
27 | int cgit_cache_repo_ttl = 5; | 27 | int cgit_cache_repo_ttl = 5; |
28 | int cgit_cache_dynamic_ttl = 5; | 28 | int cgit_cache_dynamic_ttl = 5; |
29 | int cgit_cache_static_ttl = -1; | 29 | int cgit_cache_static_ttl = -1; |
30 | int cgit_cache_max_create_time = 5; | 30 | int cgit_cache_max_create_time = 5; |
31 | 31 | ||
32 | int cgit_max_msg_len = 60; | 32 | int cgit_max_msg_len = 60; |
33 | int cgit_max_repodesc_len = 60; | ||
33 | int cgit_max_commit_count = 50; | 34 | int cgit_max_commit_count = 50; |
34 | 35 | ||
35 | int cgit_query_has_symref = 0; | 36 | int cgit_query_has_symref = 0; |
36 | int cgit_query_has_sha1 = 0; | 37 | int cgit_query_has_sha1 = 0; |
37 | 38 | ||
38 | char *cgit_querystring = NULL; | 39 | char *cgit_querystring = NULL; |
39 | char *cgit_query_repo = NULL; | 40 | char *cgit_query_repo = NULL; |
40 | char *cgit_query_page = NULL; | 41 | char *cgit_query_page = NULL; |
41 | char *cgit_query_head = NULL; | 42 | char *cgit_query_head = NULL; |
42 | char *cgit_query_search = NULL; | 43 | char *cgit_query_search = NULL; |
43 | char *cgit_query_sha1 = NULL; | 44 | char *cgit_query_sha1 = NULL; |
44 | char *cgit_query_sha2 = NULL; | 45 | char *cgit_query_sha2 = NULL; |
@@ -109,24 +110,26 @@ void cgit_global_config_cb(const char *name, const char *value) | |||
109 | else if (!strcmp(name, "cache-root")) | 110 | else if (!strcmp(name, "cache-root")) |
110 | cgit_cache_root = xstrdup(value); | 111 | cgit_cache_root = xstrdup(value); |
111 | else if (!strcmp(name, "cache-root-ttl")) | 112 | else if (!strcmp(name, "cache-root-ttl")) |
112 | cgit_cache_root_ttl = atoi(value); | 113 | cgit_cache_root_ttl = atoi(value); |
113 | else if (!strcmp(name, "cache-repo-ttl")) | 114 | else if (!strcmp(name, "cache-repo-ttl")) |
114 | cgit_cache_repo_ttl = atoi(value); | 115 | cgit_cache_repo_ttl = atoi(value); |
115 | else if (!strcmp(name, "cache-static-ttl")) | 116 | else if (!strcmp(name, "cache-static-ttl")) |
116 | cgit_cache_static_ttl = atoi(value); | 117 | cgit_cache_static_ttl = atoi(value); |
117 | else if (!strcmp(name, "cache-dynamic-ttl")) | 118 | else if (!strcmp(name, "cache-dynamic-ttl")) |
118 | cgit_cache_dynamic_ttl = atoi(value); | 119 | cgit_cache_dynamic_ttl = atoi(value); |
119 | else if (!strcmp(name, "max-message-length")) | 120 | else if (!strcmp(name, "max-message-length")) |
120 | cgit_max_msg_len = atoi(value); | 121 | cgit_max_msg_len = atoi(value); |
122 | else if (!strcmp(name, "max-repodesc-length")) | ||
123 | cgit_max_repodesc_len = atoi(value); | ||
121 | else if (!strcmp(name, "max-commit-count")) | 124 | else if (!strcmp(name, "max-commit-count")) |
122 | cgit_max_commit_count = atoi(value); | 125 | cgit_max_commit_count = atoi(value); |
123 | else if (!strcmp(name, "repo.url")) | 126 | else if (!strcmp(name, "repo.url")) |
124 | cgit_repo = add_repo(value); | 127 | cgit_repo = add_repo(value); |
125 | else if (!strcmp(name, "repo.name")) | 128 | else if (!strcmp(name, "repo.name")) |
126 | cgit_repo->name = xstrdup(value); | 129 | cgit_repo->name = xstrdup(value); |
127 | else if (cgit_repo && !strcmp(name, "repo.path")) | 130 | else if (cgit_repo && !strcmp(name, "repo.path")) |
128 | cgit_repo->path = xstrdup(value); | 131 | cgit_repo->path = xstrdup(value); |
129 | else if (cgit_repo && !strcmp(name, "repo.desc")) | 132 | else if (cgit_repo && !strcmp(name, "repo.desc")) |
130 | cgit_repo->desc = xstrdup(value); | 133 | cgit_repo->desc = xstrdup(value); |
131 | else if (cgit_repo && !strcmp(name, "repo.owner")) | 134 | else if (cgit_repo && !strcmp(name, "repo.owner")) |
132 | cgit_repo->owner = xstrdup(value); | 135 | cgit_repo->owner = xstrdup(value); |
diff --git a/ui-repolist.c b/ui-repolist.c index d341193..d7311e4 100644 --- a/ui-repolist.c +++ b/ui-repolist.c | |||
@@ -21,25 +21,25 @@ void cgit_print_repolist(struct cacheitem *item) | |||
21 | "<th class='left'>Name</th>" | 21 | "<th class='left'>Name</th>" |
22 | "<th class='left'>Description</th>" | 22 | "<th class='left'>Description</th>" |
23 | "<th class='left'>Owner</th>" | 23 | "<th class='left'>Owner</th>" |
24 | "<th class='left'>Links</th></tr>\n"); | 24 | "<th class='left'>Links</th></tr>\n"); |
25 | 25 | ||
26 | for (i=0; i<cgit_repolist.count; i++) { | 26 | for (i=0; i<cgit_repolist.count; i++) { |
27 | repo = &cgit_repolist.repos[i]; | 27 | repo = &cgit_repolist.repos[i]; |
28 | html("<tr><td>"); | 28 | html("<tr><td>"); |
29 | html_link_open(cgit_repourl(repo->url), NULL, NULL); | 29 | html_link_open(cgit_repourl(repo->url), NULL, NULL); |
30 | html_txt(repo->name); | 30 | html_txt(repo->name); |
31 | html_link_close(); | 31 | html_link_close(); |
32 | html("</td><td>"); | 32 | html("</td><td>"); |
33 | html_txt(repo->desc); | 33 | html_ntxt(cgit_max_repodesc_len, repo->desc); |
34 | html("</td><td>"); | 34 | html("</td><td>"); |
35 | html_txt(repo->owner); | 35 | html_txt(repo->owner); |
36 | html("</td><td>"); | 36 | html("</td><td>"); |
37 | html_link_open(cgit_pageurl(repo->name, "commit", NULL), | 37 | html_link_open(cgit_pageurl(repo->name, "commit", NULL), |
38 | "Commit: display last commit", NULL); | 38 | "Commit: display last commit", NULL); |
39 | html("C</a> "); | 39 | html("C</a> "); |
40 | html_link_open(cgit_pageurl(repo->name, "diff", NULL), | 40 | html_link_open(cgit_pageurl(repo->name, "diff", NULL), |
41 | "Diff: see changes introduced by last commit", NULL); | 41 | "Diff: see changes introduced by last commit", NULL); |
42 | html("D</a> "); | 42 | html("D</a> "); |
43 | html_link_open(cgit_pageurl(repo->name, "log", NULL), | 43 | html_link_open(cgit_pageurl(repo->name, "log", NULL), |
44 | "Log: show history of the main branch", NULL); | 44 | "Log: show history of the main branch", NULL); |
45 | html("L</a> "); | 45 | html("L</a> "); |