author | Lars Hjemli <hjemli@gmail.com> | 2007-10-27 11:50:18 (UTC) |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2007-10-27 11:55:12 (UTC) |
commit | c61360fea0357672d2ab84a2c5a41ae1569f5d8a (patch) (unidiff) | |
tree | c0d55917537b1cbc8237ee63e3a1252abbdded40 | |
parent | 13d2b0b25cf19de03c7cdcf8bb708be1168aeda7 (diff) | |
download | cgit-c61360fea0357672d2ab84a2c5a41ae1569f5d8a.zip cgit-c61360fea0357672d2ab84a2c5a41ae1569f5d8a.tar.gz cgit-c61360fea0357672d2ab84a2c5a41ae1569f5d8a.tar.bz2 |
cgit_parse_commit(): Add missing call to xstrdup()
It's rather silly to point into random memory-locations. Also, remove a
call to strdup() used on a literal char *.
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r-- | parsing.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -233,32 +233,32 @@ struct commitinfo *cgit_parse_commit(struct commit *commit) | |||
233 | p = strchr(t, '\n') + 1; | 233 | p = strchr(t, '\n') + 1; |
234 | } | 234 | } |
235 | 235 | ||
236 | while (*p && (*p != '\n')) | 236 | while (*p && (*p != '\n')) |
237 | p = strchr(p, '\n') + 1; // skip unknown header fields | 237 | p = strchr(p, '\n') + 1; // skip unknown header fields |
238 | 238 | ||
239 | while (*p == '\n') | 239 | while (*p == '\n') |
240 | p = strchr(p, '\n') + 1; | 240 | p = strchr(p, '\n') + 1; |
241 | 241 | ||
242 | t = strchr(p, '\n'); | 242 | t = strchr(p, '\n'); |
243 | if (t) { | 243 | if (t) { |
244 | if (*t == '\0') | 244 | if (*t == '\0') |
245 | ret->subject = strdup("** empty **"); | 245 | ret->subject = "** empty **"; |
246 | else | 246 | else |
247 | ret->subject = substr(p, t); | 247 | ret->subject = substr(p, t); |
248 | p = t + 1; | 248 | p = t + 1; |
249 | 249 | ||
250 | while (*p == '\n') | 250 | while (*p == '\n') |
251 | p = strchr(p, '\n') + 1; | 251 | p = strchr(p, '\n') + 1; |
252 | ret->msg = p; | 252 | ret->msg = xstrdup(p); |
253 | } else | 253 | } else |
254 | ret->subject = substr(p, p+strlen(p)); | 254 | ret->subject = substr(p, p+strlen(p)); |
255 | 255 | ||
256 | return ret; | 256 | return ret; |
257 | } | 257 | } |
258 | 258 | ||
259 | 259 | ||
260 | struct taginfo *cgit_parse_tag(struct tag *tag) | 260 | struct taginfo *cgit_parse_tag(struct tag *tag) |
261 | { | 261 | { |
262 | void *data; | 262 | void *data; |
263 | enum object_type type; | 263 | enum object_type type; |
264 | unsigned long size; | 264 | unsigned long size; |