author | Lars Hjemli <hjemli@gmail.com> | 2008-08-09 19:11:41 (UTC) |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2008-09-15 21:00:30 (UTC) |
commit | e154edd8078020d6eba41b448afade0a68617f35 (patch) (unidiff) | |
tree | 9fdde0c3944e327ed2694464a4c6808373ee09b7 | |
parent | a30453a5d3f6db4d6e055da2112343e054e7e7d5 (diff) | |
download | cgit-e154edd8078020d6eba41b448afade0a68617f35.zip cgit-e154edd8078020d6eba41b448afade0a68617f35.tar.gz cgit-e154edd8078020d6eba41b448afade0a68617f35.tar.bz2 |
Teach cgit how to use PATH_INFO
This commit makes cgit use the cgi variables SCRIPT_NAME and PATH_INFO
when virtual-root is unspecified in cgitrc and no url-parameter is
specified on the querystring. This has two nice effects:
* Virtual urls works out of the box, no more need for rewrite-rules in httpd.
* Virtual urls with special querystring characters are handled correctly.
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r-- | cgit.c | 27 | ||||
-rw-r--r-- | cgit.h | 1 |
2 files changed, 28 insertions, 0 deletions
@@ -117,32 +117,33 @@ void config_cb(const char *name, const char *value) | |||
117 | if (*value == '/') | 117 | if (*value == '/') |
118 | ctx.repo->readme = xstrdup(value); | 118 | ctx.repo->readme = xstrdup(value); |
119 | else | 119 | else |
120 | ctx.repo->readme = xstrdup(fmt("%s/%s", ctx.repo->path, value)); | 120 | ctx.repo->readme = xstrdup(fmt("%s/%s", ctx.repo->path, value)); |
121 | } else if (!strcmp(name, "include")) | 121 | } else if (!strcmp(name, "include")) |
122 | parse_configfile(value, config_cb); | 122 | parse_configfile(value, config_cb); |
123 | } | 123 | } |
124 | 124 | ||
125 | static void querystring_cb(const char *name, const char *value) | 125 | static void querystring_cb(const char *name, const char *value) |
126 | { | 126 | { |
127 | if (!strcmp(name,"r")) { | 127 | if (!strcmp(name,"r")) { |
128 | ctx.qry.repo = xstrdup(value); | 128 | ctx.qry.repo = xstrdup(value); |
129 | ctx.repo = cgit_get_repoinfo(value); | 129 | ctx.repo = cgit_get_repoinfo(value); |
130 | } else if (!strcmp(name, "p")) { | 130 | } else if (!strcmp(name, "p")) { |
131 | ctx.qry.page = xstrdup(value); | 131 | ctx.qry.page = xstrdup(value); |
132 | } else if (!strcmp(name, "url")) { | 132 | } else if (!strcmp(name, "url")) { |
133 | ctx.qry.url = xstrdup(value); | ||
133 | cgit_parse_url(value); | 134 | cgit_parse_url(value); |
134 | } else if (!strcmp(name, "qt")) { | 135 | } else if (!strcmp(name, "qt")) { |
135 | ctx.qry.grep = xstrdup(value); | 136 | ctx.qry.grep = xstrdup(value); |
136 | } else if (!strcmp(name, "q")) { | 137 | } else if (!strcmp(name, "q")) { |
137 | ctx.qry.search = xstrdup(value); | 138 | ctx.qry.search = xstrdup(value); |
138 | } else if (!strcmp(name, "h")) { | 139 | } else if (!strcmp(name, "h")) { |
139 | ctx.qry.head = xstrdup(value); | 140 | ctx.qry.head = xstrdup(value); |
140 | ctx.qry.has_symref = 1; | 141 | ctx.qry.has_symref = 1; |
141 | } else if (!strcmp(name, "id")) { | 142 | } else if (!strcmp(name, "id")) { |
142 | ctx.qry.sha1 = xstrdup(value); | 143 | ctx.qry.sha1 = xstrdup(value); |
143 | ctx.qry.has_sha1 = 1; | 144 | ctx.qry.has_sha1 = 1; |
144 | } else if (!strcmp(name, "id2")) { | 145 | } else if (!strcmp(name, "id2")) { |
145 | ctx.qry.sha2 = xstrdup(value); | 146 | ctx.qry.sha2 = xstrdup(value); |
146 | ctx.qry.has_sha1 = 1; | 147 | ctx.qry.has_sha1 = 1; |
147 | } else if (!strcmp(name, "ofs")) { | 148 | } else if (!strcmp(name, "ofs")) { |
148 | ctx.qry.ofs = atoi(value); | 149 | ctx.qry.ofs = atoi(value); |
@@ -360,44 +361,70 @@ static int calc_ttl() | |||
360 | 361 | ||
361 | if (!ctx.qry.page) | 362 | if (!ctx.qry.page) |
362 | return ctx.cfg.cache_repo_ttl; | 363 | return ctx.cfg.cache_repo_ttl; |
363 | 364 | ||
364 | if (ctx.qry.has_symref) | 365 | if (ctx.qry.has_symref) |
365 | return ctx.cfg.cache_dynamic_ttl; | 366 | return ctx.cfg.cache_dynamic_ttl; |
366 | 367 | ||
367 | if (ctx.qry.has_sha1) | 368 | if (ctx.qry.has_sha1) |
368 | return ctx.cfg.cache_static_ttl; | 369 | return ctx.cfg.cache_static_ttl; |
369 | 370 | ||
370 | return ctx.cfg.cache_repo_ttl; | 371 | return ctx.cfg.cache_repo_ttl; |
371 | } | 372 | } |
372 | 373 | ||
373 | int main(int argc, const char **argv) | 374 | int main(int argc, const char **argv) |
374 | { | 375 | { |
375 | const char *cgit_config_env = getenv("CGIT_CONFIG"); | 376 | const char *cgit_config_env = getenv("CGIT_CONFIG"); |
377 | const char *path; | ||
378 | char *qry; | ||
376 | int err, ttl; | 379 | int err, ttl; |
377 | 380 | ||
378 | prepare_context(&ctx); | 381 | prepare_context(&ctx); |
379 | cgit_repolist.length = 0; | 382 | cgit_repolist.length = 0; |
380 | cgit_repolist.count = 0; | 383 | cgit_repolist.count = 0; |
381 | cgit_repolist.repos = NULL; | 384 | cgit_repolist.repos = NULL; |
382 | 385 | ||
383 | parse_configfile(cgit_config_env ? cgit_config_env : CGIT_CONFIG, | 386 | parse_configfile(cgit_config_env ? cgit_config_env : CGIT_CONFIG, |
384 | config_cb); | 387 | config_cb); |
385 | ctx.repo = NULL; | 388 | ctx.repo = NULL; |
386 | if (getenv("SCRIPT_NAME")) | 389 | if (getenv("SCRIPT_NAME")) |
387 | ctx.cfg.script_name = xstrdup(getenv("SCRIPT_NAME")); | 390 | ctx.cfg.script_name = xstrdup(getenv("SCRIPT_NAME")); |
388 | if (getenv("QUERY_STRING")) | 391 | if (getenv("QUERY_STRING")) |
389 | ctx.qry.raw = xstrdup(getenv("QUERY_STRING")); | 392 | ctx.qry.raw = xstrdup(getenv("QUERY_STRING")); |
390 | cgit_parse_args(argc, argv); | 393 | cgit_parse_args(argc, argv); |
391 | http_parse_querystring(ctx.qry.raw, querystring_cb); | 394 | http_parse_querystring(ctx.qry.raw, querystring_cb); |
392 | 395 | ||
396 | /* If virtual-root isn't specified in cgitrc and no url | ||
397 | * parameter is specified on the querystring, lets pretend | ||
398 | * that virtualroot equals SCRIPT_NAME and use PATH_INFO as | ||
399 | * url. This allows cgit to work with virtual urls without | ||
400 | * the need for rewriterules in the webserver (as long as | ||
401 | * PATH_INFO is included in the cache lookup key). | ||
402 | */ | ||
403 | if (!ctx.cfg.virtual_root && !ctx.qry.url) { | ||
404 | ctx.cfg.virtual_root = ctx.cfg.script_name; | ||
405 | path = getenv("PATH_INFO"); | ||
406 | if (path) { | ||
407 | if (path[0] == '/') | ||
408 | path++; | ||
409 | ctx.qry.url = xstrdup(path); | ||
410 | if (ctx.qry.raw) { | ||
411 | qry = ctx.qry.raw; | ||
412 | ctx.qry.raw = xstrdup(fmt("%s?%s", path, qry)); | ||
413 | free(qry); | ||
414 | } else | ||
415 | ctx.qry.raw = ctx.qry.url; | ||
416 | cgit_parse_url(ctx.qry.url); | ||
417 | } | ||
418 | } | ||
419 | |||
393 | ttl = calc_ttl(); | 420 | ttl = calc_ttl(); |
394 | ctx.page.expires += ttl*60; | 421 | ctx.page.expires += ttl*60; |
395 | if (ctx.cfg.nocache) | 422 | if (ctx.cfg.nocache) |
396 | ctx.cfg.cache_size = 0; | 423 | ctx.cfg.cache_size = 0; |
397 | err = cache_process(ctx.cfg.cache_size, ctx.cfg.cache_root, | 424 | err = cache_process(ctx.cfg.cache_size, ctx.cfg.cache_root, |
398 | ctx.qry.raw, ttl, process_request, &ctx); | 425 | ctx.qry.raw, ttl, process_request, &ctx); |
399 | if (err) | 426 | if (err) |
400 | cgit_print_error(fmt("Error processing page: %s (%d)", | 427 | cgit_print_error(fmt("Error processing page: %s (%d)", |
401 | strerror(err), err)); | 428 | strerror(err), err)); |
402 | return err; | 429 | return err; |
403 | } | 430 | } |
@@ -105,32 +105,33 @@ struct reflist { | |||
105 | }; | 105 | }; |
106 | 106 | ||
107 | struct cgit_query { | 107 | struct cgit_query { |
108 | int has_symref; | 108 | int has_symref; |
109 | int has_sha1; | 109 | int has_sha1; |
110 | char *raw; | 110 | char *raw; |
111 | char *repo; | 111 | char *repo; |
112 | char *page; | 112 | char *page; |
113 | char *search; | 113 | char *search; |
114 | char *grep; | 114 | char *grep; |
115 | char *head; | 115 | char *head; |
116 | char *sha1; | 116 | char *sha1; |
117 | char *sha2; | 117 | char *sha2; |
118 | char *path; | 118 | char *path; |
119 | char *name; | 119 | char *name; |
120 | char *mimetype; | 120 | char *mimetype; |
121 | char *url; | ||
121 | int ofs; | 122 | int ofs; |
122 | }; | 123 | }; |
123 | 124 | ||
124 | struct cgit_config { | 125 | struct cgit_config { |
125 | char *agefile; | 126 | char *agefile; |
126 | char *cache_root; | 127 | char *cache_root; |
127 | char *clone_prefix; | 128 | char *clone_prefix; |
128 | char *css; | 129 | char *css; |
129 | char *favicon; | 130 | char *favicon; |
130 | char *footer; | 131 | char *footer; |
131 | char *index_header; | 132 | char *index_header; |
132 | char *index_info; | 133 | char *index_info; |
133 | char *logo; | 134 | char *logo; |
134 | char *logo_link; | 135 | char *logo_link; |
135 | char *module_link; | 136 | char *module_link; |
136 | char *repo_group; | 137 | char *repo_group; |