cgit.css: try to make diffs look a little bit nicer

This makes the diffview look more like 'git-diff' in a terminal.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>

2 files changed, 32 insertions, 13 deletions

diff --git a/cgit.css b/cgit.css
index 97ae4d1..53c93f2 100644
--- a/cgit.css
+++ b/cgit.css
@@ -249,83 +249,82 @@ table.diffstat tr:hover {
 }
 
 table.diffstat th {
         font-weight: normal;
         text-align: left;
         text-decoration: underline;
         padding: 0.1em 1em 0.1em 0.1em;
         font-size: 100%;
 }
 
 table.diffstat td {
         padding: 0.2em 0.2em 0.1em 0.1em;
         font-size: 100%;
         border: none;
 }
 
 table.diffstat td span.modechange {
         padding-left: 1em;
         color: red;
 }
 
 table.diffstat td.add a {
         color: green;
 }
 
 table.diffstat td.del a {
         color: red;
 }
 
 table.diffstat td.upd a {
         color: blue;
 }
 
 table.diffstat td.graph {
         width: 75%;
         vertical-align: center;
 }
 
 table.diffstat td.graph img {
         border: none;
         height: 8pt;
 }
 
 div.diffstat-summary {
         color: #888;
         padding-top: 0.5em;
 }
 
-table.diff th {
-        padding: 1em 0em 0.1em 0.1em;
-        text-align: left;
-}
-
 table.diff td {
-        border: solid 1px black;
         font-family: monospace;
         white-space: pre;
 }
 
+table.diff td div.head {
+        font-weight: bold;
+        padding-top: 1em;
+}
+
 table.diff td div.hunk {
-        background: #ccc;
+        color: #009;
 }
 
 table.diff td div.add {
         color: green;
 }
 
 table.diff td div.del {
         color: red;
 }
 
 .sha1 {
         font-family: courier;
         font-size: 90%;
 }
 
 .left {
         text-align: left;
 }
 
 .right {
         text-align: right;
 }
diff --git a/ui-diff.c b/ui-diff.c
index 10330d3..7ec5701 100644
--- a/ui-diff.c
+++ b/ui-diff.c
@@ -1,82 +1,102 @@
 /* ui-diff.c: show diff between two blobs
  *
  * Copyright (C) 2006 Lars Hjemli
  *
  * Licensed under GNU General Public License v2
  *   (see COPYING for full license text)
  */
 
 #include "cgit.h"
 
 
 /*
  * print a single line returned from xdiff
  */
 static void print_line(char *line, int len)
 {
         char *class = "ctx";
         char c = line[len-1];
 
         if (line[0] == '+')
                 class = "add";
         else if (line[0] == '-')
                 class = "del";
         else if (line[0] == '@')
                 class = "hunk";
 
         htmlf("<div class='%s'>", class);
         line[len-1] = '\0';
         html_txt(line);
         html("</div>");
         line[len-1] = c;
 }
 
-static void filepair_cb(struct diff_filepair *pair)
+static void header(unsigned char *sha1, char *path1,
+                   unsigned char *sha2, char *path2)
 {
-        html("<tr><th>");
-        html_txt(pair->two->path);
-        html("</th></tr>");
+        char *abbrev1, *abbrev2;
+
         html("<tr><td>");
+        html("<div class='head'>");
+        html("diff --git a/");
+        html_txt(path1);
+        html(" b/");
+        html_txt(path2);
+        abbrev1 = xstrdup(find_unique_abbrev(sha1, DEFAULT_ABBREV));
+        abbrev2 = xstrdup(find_unique_abbrev(sha2, DEFAULT_ABBREV));
+        htmlf("\nindex %s..%s", abbrev1, abbrev2);
+        free(abbrev1);
+        free(abbrev2);
+        html("\n--- a/");
+        html_txt(path1);
+        html("\n+++ b/");
+        html_txt(path2);
+        html("</div>");
+}
+
+static void filepair_cb(struct diff_filepair *pair)
+{
+        header(pair->one->sha1, pair->one->path,
+               pair->two->sha1, pair->two->path);
         if (cgit_diff_files(pair->one->sha1, pair->two->sha1, print_line))
                 cgit_print_error("Error running diff");
         html("</tr></td>");
 }
 
 void cgit_print_diff(const char *old_hex, const char *new_hex, char *path)
 {
         unsigned char sha1[20], sha2[20];
         enum object_type type;
         unsigned long size;
 
         get_sha1(old_hex, sha1);
         get_sha1(new_hex, sha2);
 
         type = sha1_object_info(sha1, &size);
         if (type == OBJ_BAD) {
                 type = sha1_object_info(sha2, &size);
                 if (type == OBJ_BAD) {
                         cgit_print_error(fmt("Bad object names: %s, %s", old_hex, new_hex));
                         return;
                 }
         }
 
         html("<table class='diff'>");
         switch(type) {
         case OBJ_BLOB:
-                if (path)
-                        htmlf("<tr><th>%s</th></tr>", path);
                 html("<tr><td>");
+                header(sha1, path, sha2, path);
                 if (cgit_diff_files(sha1, sha2, print_line))
                         cgit_print_error("Error running diff");
                 html("</tr></td>");
                 break;
         case OBJ_TREE:
                 cgit_diff_tree(sha1, sha2, filepair_cb);
                 break;
         default:
                 cgit_print_error(fmt("Unhandled object type: %s",
                                      typename(type)));
                 break;
         }
         html("</td></tr></table>");
 }