author | Lars Hjemli <hjemli@gmail.com> | 2008-03-25 01:43:51 (UTC) |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2008-04-08 19:35:00 (UTC) |
commit | fa4dfee5489d8c829da92637dd84e8650439f313 (patch) (unidiff) | |
tree | 2c5e6ffd0a20de58de7353acb278e76a56d23bb6 | |
parent | 23296ad648c0e2a9e3cf40a3de322b10ad25cce3 (diff) | |
download | cgit-fa4dfee5489d8c829da92637dd84e8650439f313.zip cgit-fa4dfee5489d8c829da92637dd84e8650439f313.tar.gz cgit-fa4dfee5489d8c829da92637dd84e8650439f313.tar.bz2 |
Don't specify mimetype in ui-blob.c
But be sure to specify correct filename. This way, the client can hopefully
guess a sensible mimetype based on the filename suffix, and cgit can ignore
the issue altogether.
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r-- | ui-blob.c | 2 | ||||
-rw-r--r-- | ui-tree.c | 3 |
2 files changed, 3 insertions, 2 deletions
@@ -1,43 +1,43 @@ | |||
1 | /* ui-blob.c: show blob content | 1 | /* ui-blob.c: show blob content |
2 | * | 2 | * |
3 | * Copyright (C) 2008 Lars Hjemli | 3 | * Copyright (C) 2008 Lars Hjemli |
4 | * | 4 | * |
5 | * Licensed under GNU General Public License v2 | 5 | * Licensed under GNU General Public License v2 |
6 | * (see COPYING for full license text) | 6 | * (see COPYING for full license text) |
7 | */ | 7 | */ |
8 | 8 | ||
9 | #include "cgit.h" | 9 | #include "cgit.h" |
10 | #include "html.h" | 10 | #include "html.h" |
11 | #include "ui-shared.h" | 11 | #include "ui-shared.h" |
12 | 12 | ||
13 | void cgit_print_blob(const char *hex, char *path) | 13 | void cgit_print_blob(const char *hex, char *path) |
14 | { | 14 | { |
15 | 15 | ||
16 | unsigned char sha1[20]; | 16 | unsigned char sha1[20]; |
17 | enum object_type type; | 17 | enum object_type type; |
18 | unsigned char *buf; | 18 | unsigned char *buf; |
19 | unsigned long size; | 19 | unsigned long size; |
20 | 20 | ||
21 | if (get_sha1_hex(hex, sha1)){ | 21 | if (get_sha1_hex(hex, sha1)){ |
22 | cgit_print_error(fmt("Bad hex value: %s", hex)); | 22 | cgit_print_error(fmt("Bad hex value: %s", hex)); |
23 | return; | 23 | return; |
24 | } | 24 | } |
25 | 25 | ||
26 | type = sha1_object_info(sha1, &size); | 26 | type = sha1_object_info(sha1, &size); |
27 | if (type == OBJ_BAD) { | 27 | if (type == OBJ_BAD) { |
28 | cgit_print_error(fmt("Bad object name: %s", hex)); | 28 | cgit_print_error(fmt("Bad object name: %s", hex)); |
29 | return; | 29 | return; |
30 | } | 30 | } |
31 | 31 | ||
32 | buf = read_sha1_file(sha1, &type, &size); | 32 | buf = read_sha1_file(sha1, &type, &size); |
33 | if (!buf) { | 33 | if (!buf) { |
34 | cgit_print_error(fmt("Error reading object %s", hex)); | 34 | cgit_print_error(fmt("Error reading object %s", hex)); |
35 | return; | 35 | return; |
36 | } | 36 | } |
37 | 37 | ||
38 | buf[size] = '\0'; | 38 | buf[size] = '\0'; |
39 | ctx.page.mimetype = "text/plain"; | 39 | ctx.page.mimetype = NULL; |
40 | ctx.page.filename = path; | 40 | ctx.page.filename = path; |
41 | cgit_print_http_headers(&ctx); | 41 | cgit_print_http_headers(&ctx); |
42 | write(htmlfd, buf, size); | 42 | write(htmlfd, buf, size); |
43 | } | 43 | } |
@@ -1,103 +1,104 @@ | |||
1 | /* ui-tree.c: functions for tree output | 1 | /* ui-tree.c: functions for tree output |
2 | * | 2 | * |
3 | * Copyright (C) 2006 Lars Hjemli | 3 | * Copyright (C) 2006 Lars Hjemli |
4 | * | 4 | * |
5 | * Licensed under GNU General Public License v2 | 5 | * Licensed under GNU General Public License v2 |
6 | * (see COPYING for full license text) | 6 | * (see COPYING for full license text) |
7 | */ | 7 | */ |
8 | 8 | ||
9 | #include "cgit.h" | 9 | #include "cgit.h" |
10 | #include "html.h" | 10 | #include "html.h" |
11 | #include "ui-shared.h" | 11 | #include "ui-shared.h" |
12 | 12 | ||
13 | char *curr_rev; | 13 | char *curr_rev; |
14 | char *match_path; | 14 | char *match_path; |
15 | int header = 0; | 15 | int header = 0; |
16 | 16 | ||
17 | static void print_object(const unsigned char *sha1, char *path) | 17 | static void print_object(const unsigned char *sha1, char *path) |
18 | { | 18 | { |
19 | enum object_type type; | 19 | enum object_type type; |
20 | char *buf; | 20 | char *buf; |
21 | unsigned long size, lineno, start, idx; | 21 | unsigned long size, lineno, start, idx; |
22 | const char *linefmt = "<tr><td class='no'><a id='n%1$d' name='n%1$d' href='#n%1$d'>%1$d</a></td><td class='txt'>"; | 22 | const char *linefmt = "<tr><td class='no'><a id='n%1$d' name='n%1$d' href='#n%1$d'>%1$d</a></td><td class='txt'>"; |
23 | 23 | ||
24 | type = sha1_object_info(sha1, &size); | 24 | type = sha1_object_info(sha1, &size); |
25 | if (type == OBJ_BAD) { | 25 | if (type == OBJ_BAD) { |
26 | cgit_print_error(fmt("Bad object name: %s", | 26 | cgit_print_error(fmt("Bad object name: %s", |
27 | sha1_to_hex(sha1))); | 27 | sha1_to_hex(sha1))); |
28 | return; | 28 | return; |
29 | } | 29 | } |
30 | 30 | ||
31 | buf = read_sha1_file(sha1, &type, &size); | 31 | buf = read_sha1_file(sha1, &type, &size); |
32 | if (!buf) { | 32 | if (!buf) { |
33 | cgit_print_error(fmt("Error reading object %s", | 33 | cgit_print_error(fmt("Error reading object %s", |
34 | sha1_to_hex(sha1))); | 34 | sha1_to_hex(sha1))); |
35 | return; | 35 | return; |
36 | } | 36 | } |
37 | 37 | ||
38 | html(" blob: <a href='"); | 38 | html(" blob: <a href='"); |
39 | html_attr(cgit_pageurl(ctx.qry.repo, "blob", fmt("id=%s", sha1_to_hex(sha1)))); | 39 | html_attr(cgit_pageurl(ctx.qry.repo, "blob", |
40 | fmt("id=%s&path=%s", sha1_to_hex(sha1), path))); | ||
40 | htmlf("'>%s</a>",sha1_to_hex(sha1)); | 41 | htmlf("'>%s</a>",sha1_to_hex(sha1)); |
41 | 42 | ||
42 | html("<table summary='blob content' class='blob'>\n"); | 43 | html("<table summary='blob content' class='blob'>\n"); |
43 | idx = 0; | 44 | idx = 0; |
44 | start = 0; | 45 | start = 0; |
45 | lineno = 0; | 46 | lineno = 0; |
46 | while(idx < size) { | 47 | while(idx < size) { |
47 | if (buf[idx] == '\n') { | 48 | if (buf[idx] == '\n') { |
48 | buf[idx] = '\0'; | 49 | buf[idx] = '\0'; |
49 | htmlf(linefmt, ++lineno); | 50 | htmlf(linefmt, ++lineno); |
50 | html_txt(buf + start); | 51 | html_txt(buf + start); |
51 | html("</td></tr>\n"); | 52 | html("</td></tr>\n"); |
52 | start = idx + 1; | 53 | start = idx + 1; |
53 | } | 54 | } |
54 | idx++; | 55 | idx++; |
55 | } | 56 | } |
56 | htmlf(linefmt, ++lineno); | 57 | htmlf(linefmt, ++lineno); |
57 | html_txt(buf + start); | 58 | html_txt(buf + start); |
58 | html("</td></tr>\n"); | 59 | html("</td></tr>\n"); |
59 | html("</table>\n"); | 60 | html("</table>\n"); |
60 | } | 61 | } |
61 | 62 | ||
62 | 63 | ||
63 | static int ls_item(const unsigned char *sha1, const char *base, int baselen, | 64 | static int ls_item(const unsigned char *sha1, const char *base, int baselen, |
64 | const char *pathname, unsigned int mode, int stage) | 65 | const char *pathname, unsigned int mode, int stage) |
65 | { | 66 | { |
66 | char *name; | 67 | char *name; |
67 | char *fullpath; | 68 | char *fullpath; |
68 | enum object_type type; | 69 | enum object_type type; |
69 | unsigned long size = 0; | 70 | unsigned long size = 0; |
70 | 71 | ||
71 | name = xstrdup(pathname); | 72 | name = xstrdup(pathname); |
72 | fullpath = fmt("%s%s%s", ctx.qry.path ? ctx.qry.path : "", | 73 | fullpath = fmt("%s%s%s", ctx.qry.path ? ctx.qry.path : "", |
73 | ctx.qry.path ? "/" : "", name); | 74 | ctx.qry.path ? "/" : "", name); |
74 | 75 | ||
75 | type = sha1_object_info(sha1, &size); | 76 | type = sha1_object_info(sha1, &size); |
76 | if (type == OBJ_BAD && !S_ISGITLINK(mode)) { | 77 | if (type == OBJ_BAD && !S_ISGITLINK(mode)) { |
77 | htmlf("<tr><td colspan='3'>Bad object: %s %s</td></tr>", | 78 | htmlf("<tr><td colspan='3'>Bad object: %s %s</td></tr>", |
78 | name, | 79 | name, |
79 | sha1_to_hex(sha1)); | 80 | sha1_to_hex(sha1)); |
80 | return 0; | 81 | return 0; |
81 | } | 82 | } |
82 | 83 | ||
83 | html("<tr><td class='ls-mode'>"); | 84 | html("<tr><td class='ls-mode'>"); |
84 | cgit_print_filemode(mode); | 85 | cgit_print_filemode(mode); |
85 | html("</td><td>"); | 86 | html("</td><td>"); |
86 | if (S_ISGITLINK(mode)) { | 87 | if (S_ISGITLINK(mode)) { |
87 | htmlf("<a class='ls-mod' href='"); | 88 | htmlf("<a class='ls-mod' href='"); |
88 | html_attr(fmt(ctx.repo->module_link, | 89 | html_attr(fmt(ctx.repo->module_link, |
89 | name, | 90 | name, |
90 | sha1_to_hex(sha1))); | 91 | sha1_to_hex(sha1))); |
91 | html("'>"); | 92 | html("'>"); |
92 | html_txt(name); | 93 | html_txt(name); |
93 | html("</a>"); | 94 | html("</a>"); |
94 | } else if (S_ISDIR(mode)) { | 95 | } else if (S_ISDIR(mode)) { |
95 | cgit_tree_link(name, NULL, "ls-dir", ctx.qry.head, | 96 | cgit_tree_link(name, NULL, "ls-dir", ctx.qry.head, |
96 | curr_rev, fullpath); | 97 | curr_rev, fullpath); |
97 | } else { | 98 | } else { |
98 | cgit_tree_link(name, NULL, "ls-blob", ctx.qry.head, | 99 | cgit_tree_link(name, NULL, "ls-blob", ctx.qry.head, |
99 | curr_rev, fullpath); | 100 | curr_rev, fullpath); |
100 | } | 101 | } |
101 | htmlf("</td><td class='ls-size'>%li</td>", size); | 102 | htmlf("</td><td class='ls-size'>%li</td>", size); |
102 | 103 | ||
103 | html("<td>"); | 104 | html("<td>"); |