| author | Lars Hjemli <hjemli@gmail.com> | 2008-05-20 20:32:22 (UTC) |
|---|---|---|
| committer | Lars Hjemli <hjemli@gmail.com> | 2008-05-20 20:32:22 (UTC) |
| commit | 08a8757fa54ee70d31882344ca7f19de5cbe4690 (patch) (side-by-side diff) | |
| tree | 93cddfcbb81bbaf0fe8b3206d5f2f9c11dc6df9a | |
| parent | dd7c172542440170b5b1aca8be43d2ad6dae7227 (diff) | |
| download | cgit-08a8757fa54ee70d31882344ca7f19de5cbe4690.zip cgit-08a8757fa54ee70d31882344ca7f19de5cbe4690.tar.gz cgit-08a8757fa54ee70d31882344ca7f19de5cbe4690.tar.bz2 | |
ui-tree.c: avoid peeking at GITLINK objects
When an object in the tree has GITLINK mode-bits we don't need to get any
more info about that particular object (and trying to get more info about
it will usually generate an annoying warning on stderr since the object
typically doesn't exist in the repo anyways).
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
| -rw-r--r-- | ui-tree.c | 4 |
1 files changed, 3 insertions, 1 deletions
@@ -68,23 +68,25 @@ static int ls_item(const unsigned char *sha1, const char *base, int baselen, char *fullpath; enum object_type type; unsigned long size = 0; name = xstrdup(pathname); fullpath = fmt("%s%s%s", ctx.qry.path ? ctx.qry.path : "", ctx.qry.path ? "/" : "", name); + if (!S_ISGITLINK(mode)) { type = sha1_object_info(sha1, &size); - if (type == OBJ_BAD && !S_ISGITLINK(mode)) { + if (type == OBJ_BAD) { htmlf("<tr><td colspan='3'>Bad object: %s %s</td></tr>", name, sha1_to_hex(sha1)); return 0; } + } html("<tr><td class='ls-mode'>"); cgit_print_filemode(mode); html("</td><td>"); if (S_ISGITLINK(mode)) { htmlf("<a class='ls-mod' href='"); html_attr(fmt(ctx.repo->module_link, name, |