author | Lars Hjemli <hjemli@gmail.com> | 2007-11-03 13:05:12 (UTC) |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2007-11-03 13:05:12 (UTC) |
commit | 601c76eb15a298ac9529f4dded5dd4297b9c3768 (patch) (side-by-side diff) | |
tree | cb81350b624cb7ef0cdf9cdd23804cc674b8b5d5 | |
parent | e36365c6841703e569fcaf20bfc415ee0489c76f (diff) | |
download | cgit-601c76eb15a298ac9529f4dded5dd4297b9c3768.zip cgit-601c76eb15a298ac9529f4dded5dd4297b9c3768.tar.gz cgit-601c76eb15a298ac9529f4dded5dd4297b9c3768.tar.bz2 |
Do not require javascript-enabled clients
A simple submit-button is all that's required to make the branch selector
drop-down work on any client, so lets add one.
Noticed-by: Olivier Ramonat <olivier@ramonat.fr>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r-- | cgit.css | 12 | ||||
-rw-r--r-- | ui-shared.c | 4 |
2 files changed, 16 insertions, 0 deletions
@@ -41,192 +41,204 @@ a { } a:hover { background-color: #ddd; text-decoration: none; } table.list { border: none; border-collapse: collapse; } table.list tr { background: white; } table.list tr:hover { background: #f8f8f8; } table.list tr.nohover:hover { background: white; } table.list th { font-weight: bold; border-bottom: solid 1px #777; padding: 0.1em 0.5em 0.1em 0.5em; vertical-align: baseline; } table.list td { border: none; padding: 0.1em 0.5em 0.1em 0.5em; } img { border: none; } div#sidebar { vertical-align: top; width: 162px; padding: 0px 0px 0px 0px; margin: 4px; float: left; } div#logo { margin: 0px; padding: 4px 0px 4px 0px; text-align: center; background-color: #ccc; border-top: solid 1px #eee; border-left: solid 1px #eee; border-right: solid 1px #aaa; border-bottom: solid 1px #aaa; } div#sidebar div.infobox { margin: 0px 0px 0px 0px; padding: 0.5em; text-align: left; background-color: #ccc; border-top: solid 1px #eee; border-left: solid 1px #eee; border-right: solid 1px #aaa; border-bottom: solid 1px #aaa; } div#sidebar div.infobox h1 { font-size: 11pt; font-weight: bold; margin: 0px; } div#sidebar div.infobox a.menu { display: block; background-color: #ccc; padding: 0.1em 0.5em; text-decoration: none; } div#sidebar div.infobox a.menu:hover { background-color: #bbb; text-decoration: none; } div#sidebar div.infobox select { width: 100%; border: solid 1px #aaa; background-color: #bbb; margin: 2px 0px 0px 0px; padding: 0px; } +td#branch-dropdown-cell { + width: 99%; +} + +input#switch-btn { + width: 20px; + border: solid 1px #aaa; + background-color: #bbb; + margin: 2px 0px 0px 0px; + padding: 0px; +} + div#sidebar div.infobox input.txt { width: 100%; border: solid 1px #aaa; background-color: #bbb; margin: 2px 0px 0px 0px; padding: 0; } table#grid { margin: 0px; } td#content { vertical-align: top; padding: 1em 2em 1em 1em; border: none; } div#summary { vertical-align: top; margin-bottom: 1em; } table#downloads { float: right; border-collapse: collapse; border: solid 1px #777; margin-left: 0.5em; margin-bottom: 0.5em; } table#downloads th { background-color: #ccc; } div#blob { border: solid 1px black; } div.error { color: red; font-weight: bold; margin: 1em 2em; } a.ls-blob, a.ls-dir, a.ls-mod { font-family: monospace; } td.ls-size { text-align: right; } td.ls-size { font-family: monospace; } td.ls-mode { font-family: monospace; } table.blob { margin-top: 0.5em; border-top: solid 1px black; } table.blob td.no { border-right: solid 1px black; color: black; background-color: #eee; text-align: right; } table.blob td.no a { color: black; } table.blob td.no a:hover { color: black; text-decoration: none; } table.blob td.txt { white-space: pre; font-family: monospace; padding-left: 0.5em; } table.nowrap td { white-space: nowrap; } table.commit-info { border-collapse: collapse; margin-top: 1.5em; } diff --git a/ui-shared.c b/ui-shared.c index ca8dd3d..bd34cc3 100644 --- a/ui-shared.c +++ b/ui-shared.c @@ -394,140 +394,144 @@ int print_archive_ref(const char *refname, const unsigned char *sha1, unsigned char fileid[20]; int *header = (int *)cb_data; if (prefixcmp(refname, "refs/archives")) return 0; strncpy(buf, refname+14, sizeof(buf)); obj = parse_object(sha1); if (!obj) return 1; if (obj->type == OBJ_TAG) { tag = lookup_tag(sha1); if (!tag || parse_tag(tag) || !(info = cgit_parse_tag(tag))) return 0; hashcpy(fileid, tag->tagged->sha1); } else if (obj->type != OBJ_BLOB) { return 0; } else { hashcpy(fileid, sha1); } if (!*header) { html("<p><h1>download</h1>"); *header = 1; } url = cgit_pageurl(cgit_query_repo, "blob", fmt("id=%s&path=%s", sha1_to_hex(fileid), buf)); html_link_open(url, NULL, "menu"); html_txt(strlpart(buf, 20)); html_link_close(); return 0; } void add_hidden_formfields(int incl_head, int incl_search, char *page) { char *url; if (!cgit_virtual_root) { url = fmt("%s/%s", cgit_query_repo, page); if (cgit_query_path) url = fmt("%s/%s", url, cgit_query_path); html_hidden("url", url); } if (incl_head && strcmp(cgit_query_head, cgit_repo->defbranch)) html_hidden("h", cgit_query_head); if (cgit_query_sha1) html_hidden("id", cgit_query_sha1); if (cgit_query_sha2) html_hidden("id2", cgit_query_sha2); if (incl_search) { if (cgit_query_grep) html_hidden("qt", cgit_query_grep); if (cgit_query_search) html_hidden("q", cgit_query_search); } } void cgit_print_pageheader(char *title, int show_search) { static const char *default_info = "This is cgit, a fast webinterface for git repositories"; int header = 0; html("<div id='sidebar'>\n"); html("<a href='"); html_attr(cgit_rooturl()); htmlf("'><div id='logo'><img src='%s' alt='cgit'/></div></a>\n", cgit_logo); html("<div class='infobox'>"); if (cgit_query_repo) { html("<h1>"); html_txt(strrpart(cgit_repo->name, 20)); html("</h1>\n"); html_txt(cgit_repo->desc); if (cgit_repo->owner) { html("<p>\n<h1>owner</h1>\n"); html_txt(cgit_repo->owner); } html("<p>\n<h1>navigate</h1>\n"); reporevlink(NULL, "summary", NULL, "menu", cgit_query_head, NULL, NULL); cgit_log_link("log", NULL, "menu", cgit_query_head, NULL, NULL, 0, NULL, NULL); cgit_tree_link("tree", NULL, "menu", cgit_query_head, cgit_query_sha1, NULL); cgit_commit_link("commit", NULL, "menu", cgit_query_head, cgit_query_sha1); cgit_diff_link("diff", NULL, "menu", cgit_query_head, cgit_query_sha1, cgit_query_sha2, NULL); for_each_ref(print_archive_ref, &header); html("<p>\n<h1>branch</h1>\n"); html("<form method='get' action=''>\n"); add_hidden_formfields(0, 1, cgit_query_page); + html("<table class='grid'><tr><td id='branch-dropdown-cell'>"); html("<select name='h' onchange='this.form.submit();'>\n"); for_each_branch_ref(print_branch_option, cgit_query_head); html("</select>\n"); + html("</td><td>"); + html("<input type='submit' id='switch-btn' value='..'>\n"); + html("</td></tr></table>"); html("</form>\n"); html("<p>\n<h1>search</h1>\n"); html("<form method='get' action='"); if (cgit_virtual_root) html_attr(cgit_fileurl(cgit_query_repo, "log", cgit_query_path, NULL)); html("'>\n"); add_hidden_formfields(1, 0, "log"); html("<select name='qt'>\n"); html_option("grep", "log msg", cgit_query_grep); html_option("author", "author", cgit_query_grep); html_option("committer", "committer", cgit_query_grep); html("</select>\n"); html("<input class='txt' type='text' name='q' value='"); html_attr(cgit_query_search); html("'/>\n"); html("</form>\n"); } else { if (!cgit_index_info || html_include(cgit_index_info)) html(default_info); } html("</div>\n"); html("</div>\n<table class='grid'><tr><td id='content'>\n"); } void cgit_print_snapshot_start(const char *mimetype, const char *filename, struct cacheitem *item) { htmlf("Content-Type: %s\n", mimetype); htmlf("Content-Disposition: inline; filename=\"%s\"\n", filename); htmlf("Last-Modified: %s\n", http_date(item->st.st_mtime)); htmlf("Expires: %s\n", http_date(item->st.st_mtime + ttl_seconds(item->ttl))); html("\n"); } /* vim:set sw=8: */ |