summaryrefslogtreecommitdiffabout
authorLars Hjemli <hjemli@gmail.com>2009-08-17 07:05:13 (UTC)
committer Lars Hjemli <hjemli@gmail.com>2009-08-17 07:26:17 (UTC)
commit435a1da8d1c43bff2f2ccd5649ea8510eec0b2af (patch) (unidiff)
treec07a9d096c99a70e78b017b5edccb1eaaffd0795
parent8a631b1173b1abecc5a737b0e21751ddbabf9df2 (diff)
downloadcgit-435a1da8d1c43bff2f2ccd5649ea8510eec0b2af.zip
cgit-435a1da8d1c43bff2f2ccd5649ea8510eec0b2af.tar.gz
cgit-435a1da8d1c43bff2f2ccd5649ea8510eec0b2af.tar.bz2
cgit.c: do not segfault on unexpected query-string format
The querystring_cb() function will be invoked with a NULL value when the querystring contains a name not followed by a '='. Such a value used to cause a segfault, which this patch fixes. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (more/less context) (show whitespace changes)
-rw-r--r--cgit.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/cgit.c b/cgit.c
index 64d95f9..5301840 100644
--- a/cgit.c
+++ b/cgit.c
@@ -132,6 +132,9 @@ void config_cb(const char *name, const char *value)
132 132
133static void querystring_cb(const char *name, const char *value) 133static void querystring_cb(const char *name, const char *value)
134{ 134{
135 if (!value)
136 value = "";
137
135 if (!strcmp(name,"r")) { 138 if (!strcmp(name,"r")) {
136 ctx.qry.repo = xstrdup(value); 139 ctx.qry.repo = xstrdup(value);
137 ctx.repo = cgit_get_repoinfo(value); 140 ctx.repo = cgit_get_repoinfo(value);