author | Lars Hjemli <hjemli@gmail.com> | 2007-07-22 21:57:48 (UTC) |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2007-07-22 21:57:56 (UTC) |
commit | 1d4aaff696ee1b9085dda0f0f3d84d9d20d96db0 (patch) (unidiff) | |
tree | 6674c5168d967c3efdbf8f445e7e975d54e43629 /ui-commit.c | |
parent | 4e9107abfe8d3edff17826875b417bcf40dc7390 (diff) | |
parent | d6b01dac856efda565d4085e77826fd9ac83348a (diff) | |
download | cgit-1d4aaff696ee1b9085dda0f0f3d84d9d20d96db0.zip cgit-1d4aaff696ee1b9085dda0f0f3d84d9d20d96db0.tar.gz cgit-1d4aaff696ee1b9085dda0f0f3d84d9d20d96db0.tar.bz2 |
Merge branch 'master' of git://git.klever.net/patchwork/cgit
* 'master' of git://git.klever.net/patchwork/cgit:
link raw blob from tree file view
fix: changed view link to blob in summary.
allow selective enabling of snapshots
shorten snapshot names to repo basename
introduce cgit_repobasename
added snapshot filename to the link
add plain uncompressed tar snapshort format
introduced .tar.bz2 snapshots
compress .tar.gz using gzip as a filter
added a chk_non_negative check
css: adjust vertical-align of commit info th cells
add support for snapshot tarballs
Conflicts:
ui-summary.c
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r-- | ui-commit.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/ui-commit.c b/ui-commit.c index 2679b59..50e9e11 100644 --- a/ui-commit.c +++ b/ui-commit.c | |||
@@ -110,119 +110,116 @@ void inspect_filepair(struct diff_filepair *pair) | |||
110 | lines_added = 0; | 110 | lines_added = 0; |
111 | lines_removed = 0; | 111 | lines_removed = 0; |
112 | cgit_diff_files(pair->one->sha1, pair->two->sha1, cgit_count_diff_lines); | 112 | cgit_diff_files(pair->one->sha1, pair->two->sha1, cgit_count_diff_lines); |
113 | if (files >= slots) { | 113 | if (files >= slots) { |
114 | if (slots == 0) | 114 | if (slots == 0) |
115 | slots = 4; | 115 | slots = 4; |
116 | else | 116 | else |
117 | slots = slots * 2; | 117 | slots = slots * 2; |
118 | items = xrealloc(items, slots * sizeof(struct fileinfo)); | 118 | items = xrealloc(items, slots * sizeof(struct fileinfo)); |
119 | } | 119 | } |
120 | items[files-1].status = pair->status; | 120 | items[files-1].status = pair->status; |
121 | hashcpy(items[files-1].old_sha1, pair->one->sha1); | 121 | hashcpy(items[files-1].old_sha1, pair->one->sha1); |
122 | hashcpy(items[files-1].new_sha1, pair->two->sha1); | 122 | hashcpy(items[files-1].new_sha1, pair->two->sha1); |
123 | items[files-1].old_mode = pair->one->mode; | 123 | items[files-1].old_mode = pair->one->mode; |
124 | items[files-1].new_mode = pair->two->mode; | 124 | items[files-1].new_mode = pair->two->mode; |
125 | items[files-1].old_path = xstrdup(pair->one->path); | 125 | items[files-1].old_path = xstrdup(pair->one->path); |
126 | items[files-1].new_path = xstrdup(pair->two->path); | 126 | items[files-1].new_path = xstrdup(pair->two->path); |
127 | items[files-1].added = lines_added; | 127 | items[files-1].added = lines_added; |
128 | items[files-1].removed = lines_removed; | 128 | items[files-1].removed = lines_removed; |
129 | if (lines_added + lines_removed > max_changes) | 129 | if (lines_added + lines_removed > max_changes) |
130 | max_changes = lines_added + lines_removed; | 130 | max_changes = lines_added + lines_removed; |
131 | total_adds += lines_added; | 131 | total_adds += lines_added; |
132 | total_rems += lines_removed; | 132 | total_rems += lines_removed; |
133 | } | 133 | } |
134 | 134 | ||
135 | 135 | ||
136 | void cgit_print_commit(char *hex) | 136 | void cgit_print_commit(char *hex) |
137 | { | 137 | { |
138 | struct commit *commit, *parent; | 138 | struct commit *commit, *parent; |
139 | struct commitinfo *info; | 139 | struct commitinfo *info; |
140 | struct commit_list *p; | 140 | struct commit_list *p; |
141 | unsigned char sha1[20]; | 141 | unsigned char sha1[20]; |
142 | char *filename; | ||
143 | char *tmp; | 142 | char *tmp; |
144 | int i; | 143 | int i; |
145 | 144 | ||
146 | if (!hex) | 145 | if (!hex) |
147 | hex = cgit_query_head; | 146 | hex = cgit_query_head; |
148 | curr_rev = hex; | 147 | curr_rev = hex; |
149 | 148 | ||
150 | if (get_sha1(hex, sha1)) { | 149 | if (get_sha1(hex, sha1)) { |
151 | cgit_print_error(fmt("Bad object id: %s", hex)); | 150 | cgit_print_error(fmt("Bad object id: %s", hex)); |
152 | return; | 151 | return; |
153 | } | 152 | } |
154 | commit = lookup_commit_reference(sha1); | 153 | commit = lookup_commit_reference(sha1); |
155 | if (!commit) { | 154 | if (!commit) { |
156 | cgit_print_error(fmt("Bad commit reference: %s", hex)); | 155 | cgit_print_error(fmt("Bad commit reference: %s", hex)); |
157 | return; | 156 | return; |
158 | } | 157 | } |
159 | info = cgit_parse_commit(commit); | 158 | info = cgit_parse_commit(commit); |
160 | 159 | ||
161 | html("<table class='commit-info'>\n"); | 160 | html("<table class='commit-info'>\n"); |
162 | html("<tr><th>author</th><td>"); | 161 | html("<tr><th>author</th><td>"); |
163 | html_txt(info->author); | 162 | html_txt(info->author); |
164 | html(" "); | 163 | html(" "); |
165 | html_txt(info->author_email); | 164 | html_txt(info->author_email); |
166 | html("</td><td class='right'>"); | 165 | html("</td><td class='right'>"); |
167 | cgit_print_date(info->author_date, FMT_LONGDATE); | 166 | cgit_print_date(info->author_date, FMT_LONGDATE); |
168 | html("</td></tr>\n"); | 167 | html("</td></tr>\n"); |
169 | html("<tr><th>committer</th><td>"); | 168 | html("<tr><th>committer</th><td>"); |
170 | html_txt(info->committer); | 169 | html_txt(info->committer); |
171 | html(" "); | 170 | html(" "); |
172 | html_txt(info->committer_email); | 171 | html_txt(info->committer_email); |
173 | html("</td><td class='right'>"); | 172 | html("</td><td class='right'>"); |
174 | cgit_print_date(info->committer_date, FMT_LONGDATE); | 173 | cgit_print_date(info->committer_date, FMT_LONGDATE); |
175 | html("</td></tr>\n"); | 174 | html("</td></tr>\n"); |
176 | html("<tr><th>tree</th><td colspan='2' class='sha1'>"); | 175 | html("<tr><th>tree</th><td colspan='2' class='sha1'>"); |
177 | tmp = xstrdup(hex); | 176 | tmp = xstrdup(hex); |
178 | cgit_tree_link(sha1_to_hex(commit->tree->object.sha1), NULL, NULL, | 177 | cgit_tree_link(sha1_to_hex(commit->tree->object.sha1), NULL, NULL, |
179 | cgit_query_head, tmp, NULL); | 178 | cgit_query_head, tmp, NULL); |
180 | html("</td></tr>\n"); | 179 | html("</td></tr>\n"); |
181 | for (p = commit->parents; p ; p = p->next) { | 180 | for (p = commit->parents; p ; p = p->next) { |
182 | parent = lookup_commit_reference(p->item->object.sha1); | 181 | parent = lookup_commit_reference(p->item->object.sha1); |
183 | if (!parent) { | 182 | if (!parent) { |
184 | html("<tr><td colspan='3'>"); | 183 | html("<tr><td colspan='3'>"); |
185 | cgit_print_error("Error reading parent commit"); | 184 | cgit_print_error("Error reading parent commit"); |
186 | html("</td></tr>"); | 185 | html("</td></tr>"); |
187 | continue; | 186 | continue; |
188 | } | 187 | } |
189 | html("<tr><th>parent</th>" | 188 | html("<tr><th>parent</th>" |
190 | "<td colspan='2' class='sha1'>"); | 189 | "<td colspan='2' class='sha1'>"); |
191 | cgit_commit_link(sha1_to_hex(p->item->object.sha1), NULL, NULL, | 190 | cgit_commit_link(sha1_to_hex(p->item->object.sha1), NULL, NULL, |
192 | cgit_query_head, sha1_to_hex(p->item->object.sha1)); | 191 | cgit_query_head, sha1_to_hex(p->item->object.sha1)); |
193 | html(" ("); | 192 | html(" ("); |
194 | cgit_diff_link("diff", NULL, NULL, cgit_query_head, hex, | 193 | cgit_diff_link("diff", NULL, NULL, cgit_query_head, hex, |
195 | sha1_to_hex(p->item->object.sha1), NULL); | 194 | sha1_to_hex(p->item->object.sha1), NULL); |
196 | html(")</td></tr>"); | 195 | html(")</td></tr>"); |
197 | } | 196 | } |
198 | if (cgit_repo->snapshots) { | 197 | if (cgit_repo->snapshots) { |
199 | htmlf("<tr><th>download</th><td colspan='2' class='sha1'><a href='"); | 198 | html("<tr><th>download</th><td colspan='2' class='sha1'>"); |
200 | filename = fmt("%s-%s.zip", cgit_query_repo, hex); | 199 | cgit_print_snapshot_links(cgit_query_repo,hex,cgit_repo->snapshots); |
201 | html_attr(cgit_pageurl(cgit_query_repo, "snapshot", | 200 | html("</td></tr>"); |
202 | fmt("id=%s&name=%s", hex, filename))); | ||
203 | htmlf("'>%s</a></td></tr>", filename); | ||
204 | } | 201 | } |
205 | html("</table>\n"); | 202 | html("</table>\n"); |
206 | html("<div class='commit-subject'>"); | 203 | html("<div class='commit-subject'>"); |
207 | html_txt(info->subject); | 204 | html_txt(info->subject); |
208 | html("</div>"); | 205 | html("</div>"); |
209 | html("<div class='commit-msg'>"); | 206 | html("<div class='commit-msg'>"); |
210 | html_txt(info->msg); | 207 | html_txt(info->msg); |
211 | html("</div>"); | 208 | html("</div>"); |
212 | if (!(commit->parents && commit->parents->next && commit->parents->next->next)) { | 209 | if (!(commit->parents && commit->parents->next && commit->parents->next->next)) { |
213 | html("<div class='diffstat-header'>Diffstat</div>"); | 210 | html("<div class='diffstat-header'>Diffstat</div>"); |
214 | html("<table class='diffstat'>"); | 211 | html("<table class='diffstat'>"); |
215 | max_changes = 0; | 212 | max_changes = 0; |
216 | cgit_diff_commit(commit, inspect_filepair); | 213 | cgit_diff_commit(commit, inspect_filepair); |
217 | for(i = 0; i<files; i++) | 214 | for(i = 0; i<files; i++) |
218 | print_fileinfo(&items[i]); | 215 | print_fileinfo(&items[i]); |
219 | html("</table>"); | 216 | html("</table>"); |
220 | html("<div class='diffstat-summary'>"); | 217 | html("<div class='diffstat-summary'>"); |
221 | htmlf("%d files changed, %d insertions, %d deletions (", | 218 | htmlf("%d files changed, %d insertions, %d deletions (", |
222 | files, total_adds, total_rems); | 219 | files, total_adds, total_rems); |
223 | cgit_diff_link("show diff", NULL, NULL, cgit_query_head, hex, | 220 | cgit_diff_link("show diff", NULL, NULL, cgit_query_head, hex, |
224 | NULL, NULL); | 221 | NULL, NULL); |
225 | html(")</div>"); | 222 | html(")</div>"); |
226 | } | 223 | } |
227 | cgit_free_commitinfo(info); | 224 | cgit_free_commitinfo(info); |
228 | } | 225 | } |