author | Lars Hjemli <hjemli@gmail.com> | 2007-05-14 16:31:05 (UTC) |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2007-05-14 20:43:38 (UTC) |
commit | a342ac6b4d7830f82230b0f6a29bc9378d66747e (patch) (unidiff) | |
tree | 49782a205d9eb73c2b63f77cfc554d898681cf1a /ui-diff.c | |
parent | a1a0cd8b5a62fe779d77c210a3d455398ce06bb7 (diff) | |
download | cgit-a342ac6b4d7830f82230b0f6a29bc9378d66747e.zip cgit-a342ac6b4d7830f82230b0f6a29bc9378d66747e.tar.gz cgit-a342ac6b4d7830f82230b0f6a29bc9378d66747e.tar.bz2 |
cgit.css: try to make diffs look a little bit nicer
This makes the diffview look more like 'git-diff' in a terminal.
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r-- | ui-diff.c | 32 |
1 files changed, 26 insertions, 6 deletions
@@ -10,73 +10,93 @@ | |||
10 | 10 | ||
11 | 11 | ||
12 | /* | 12 | /* |
13 | * print a single line returned from xdiff | 13 | * print a single line returned from xdiff |
14 | */ | 14 | */ |
15 | static void print_line(char *line, int len) | 15 | static void print_line(char *line, int len) |
16 | { | 16 | { |
17 | char *class = "ctx"; | 17 | char *class = "ctx"; |
18 | char c = line[len-1]; | 18 | char c = line[len-1]; |
19 | 19 | ||
20 | if (line[0] == '+') | 20 | if (line[0] == '+') |
21 | class = "add"; | 21 | class = "add"; |
22 | else if (line[0] == '-') | 22 | else if (line[0] == '-') |
23 | class = "del"; | 23 | class = "del"; |
24 | else if (line[0] == '@') | 24 | else if (line[0] == '@') |
25 | class = "hunk"; | 25 | class = "hunk"; |
26 | 26 | ||
27 | htmlf("<div class='%s'>", class); | 27 | htmlf("<div class='%s'>", class); |
28 | line[len-1] = '\0'; | 28 | line[len-1] = '\0'; |
29 | html_txt(line); | 29 | html_txt(line); |
30 | html("</div>"); | 30 | html("</div>"); |
31 | line[len-1] = c; | 31 | line[len-1] = c; |
32 | } | 32 | } |
33 | 33 | ||
34 | static void filepair_cb(struct diff_filepair *pair) | 34 | static void header(unsigned char *sha1, char *path1, |
35 | unsigned char *sha2, char *path2) | ||
35 | { | 36 | { |
36 | html("<tr><th>"); | 37 | char *abbrev1, *abbrev2; |
37 | html_txt(pair->two->path); | 38 | |
38 | html("</th></tr>"); | ||
39 | html("<tr><td>"); | 39 | html("<tr><td>"); |
40 | html("<div class='head'>"); | ||
41 | html("diff --git a/"); | ||
42 | html_txt(path1); | ||
43 | html(" b/"); | ||
44 | html_txt(path2); | ||
45 | abbrev1 = xstrdup(find_unique_abbrev(sha1, DEFAULT_ABBREV)); | ||
46 | abbrev2 = xstrdup(find_unique_abbrev(sha2, DEFAULT_ABBREV)); | ||
47 | htmlf("\nindex %s..%s", abbrev1, abbrev2); | ||
48 | free(abbrev1); | ||
49 | free(abbrev2); | ||
50 | html("\n--- a/"); | ||
51 | html_txt(path1); | ||
52 | html("\n+++ b/"); | ||
53 | html_txt(path2); | ||
54 | html("</div>"); | ||
55 | } | ||
56 | |||
57 | static void filepair_cb(struct diff_filepair *pair) | ||
58 | { | ||
59 | header(pair->one->sha1, pair->one->path, | ||
60 | pair->two->sha1, pair->two->path); | ||
40 | if (cgit_diff_files(pair->one->sha1, pair->two->sha1, print_line)) | 61 | if (cgit_diff_files(pair->one->sha1, pair->two->sha1, print_line)) |
41 | cgit_print_error("Error running diff"); | 62 | cgit_print_error("Error running diff"); |
42 | html("</tr></td>"); | 63 | html("</tr></td>"); |
43 | } | 64 | } |
44 | 65 | ||
45 | void cgit_print_diff(const char *old_hex, const char *new_hex, char *path) | 66 | void cgit_print_diff(const char *old_hex, const char *new_hex, char *path) |
46 | { | 67 | { |
47 | unsigned char sha1[20], sha2[20]; | 68 | unsigned char sha1[20], sha2[20]; |
48 | enum object_type type; | 69 | enum object_type type; |
49 | unsigned long size; | 70 | unsigned long size; |
50 | 71 | ||
51 | get_sha1(old_hex, sha1); | 72 | get_sha1(old_hex, sha1); |
52 | get_sha1(new_hex, sha2); | 73 | get_sha1(new_hex, sha2); |
53 | 74 | ||
54 | type = sha1_object_info(sha1, &size); | 75 | type = sha1_object_info(sha1, &size); |
55 | if (type == OBJ_BAD) { | 76 | if (type == OBJ_BAD) { |
56 | type = sha1_object_info(sha2, &size); | 77 | type = sha1_object_info(sha2, &size); |
57 | if (type == OBJ_BAD) { | 78 | if (type == OBJ_BAD) { |
58 | cgit_print_error(fmt("Bad object names: %s, %s", old_hex, new_hex)); | 79 | cgit_print_error(fmt("Bad object names: %s, %s", old_hex, new_hex)); |
59 | return; | 80 | return; |
60 | } | 81 | } |
61 | } | 82 | } |
62 | 83 | ||
63 | html("<table class='diff'>"); | 84 | html("<table class='diff'>"); |
64 | switch(type) { | 85 | switch(type) { |
65 | case OBJ_BLOB: | 86 | case OBJ_BLOB: |
66 | if (path) | ||
67 | htmlf("<tr><th>%s</th></tr>", path); | ||
68 | html("<tr><td>"); | 87 | html("<tr><td>"); |
88 | header(sha1, path, sha2, path); | ||
69 | if (cgit_diff_files(sha1, sha2, print_line)) | 89 | if (cgit_diff_files(sha1, sha2, print_line)) |
70 | cgit_print_error("Error running diff"); | 90 | cgit_print_error("Error running diff"); |
71 | html("</tr></td>"); | 91 | html("</tr></td>"); |
72 | break; | 92 | break; |
73 | case OBJ_TREE: | 93 | case OBJ_TREE: |
74 | cgit_diff_tree(sha1, sha2, filepair_cb); | 94 | cgit_diff_tree(sha1, sha2, filepair_cb); |
75 | break; | 95 | break; |
76 | default: | 96 | default: |
77 | cgit_print_error(fmt("Unhandled object type: %s", | 97 | cgit_print_error(fmt("Unhandled object type: %s", |
78 | typename(type))); | 98 | typename(type))); |
79 | break; | 99 | break; |
80 | } | 100 | } |
81 | html("</td></tr></table>"); | 101 | html("</td></tr></table>"); |
82 | } | 102 | } |