author | Lars Hjemli <hjemli@gmail.com> | 2010-06-22 14:16:12 (UTC) |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2010-06-22 14:16:12 (UTC) |
commit | 6f92f332e6a9ee3e16051bda9fe148607af67f65 (patch) (unidiff) | |
tree | 49cb7d145fbf40793b220efdc92cd80ab2c6ca05 /ui-diff.c | |
parent | 37a24e4e39737edaa5cdde501346a65eeb280e63 (diff) | |
parent | d20313e3daf855ee5d4808e050f54614c200d7b1 (diff) | |
download | cgit-6f92f332e6a9ee3e16051bda9fe148607af67f65.zip cgit-6f92f332e6a9ee3e16051bda9fe148607af67f65.tar.gz cgit-6f92f332e6a9ee3e16051bda9fe148607af67f65.tar.bz2 |
Merge branch 'jh/context-lines'
Conflicts:
cgit.c
cgit.h
-rw-r--r-- | ui-diff.c | 14 |
1 files changed, 11 insertions, 3 deletions
@@ -98,100 +98,108 @@ static void print_fileinfo(struct fileinfo *info) | |||
98 | } | 98 | } |
99 | htmlf("%d", info->added + info->removed); | 99 | htmlf("%d", info->added + info->removed); |
100 | html("</td><td class='graph'>"); | 100 | html("</td><td class='graph'>"); |
101 | htmlf("<table summary='file diffstat' width='%d%%'><tr>", (max_changes > 100 ? 100 : max_changes)); | 101 | htmlf("<table summary='file diffstat' width='%d%%'><tr>", (max_changes > 100 ? 100 : max_changes)); |
102 | htmlf("<td class='add' style='width: %.1f%%;'/>", | 102 | htmlf("<td class='add' style='width: %.1f%%;'/>", |
103 | info->added * 100.0 / max_changes); | 103 | info->added * 100.0 / max_changes); |
104 | htmlf("<td class='rem' style='width: %.1f%%;'/>", | 104 | htmlf("<td class='rem' style='width: %.1f%%;'/>", |
105 | info->removed * 100.0 / max_changes); | 105 | info->removed * 100.0 / max_changes); |
106 | htmlf("<td class='none' style='width: %.1f%%;'/>", | 106 | htmlf("<td class='none' style='width: %.1f%%;'/>", |
107 | (max_changes - info->removed - info->added) * 100.0 / max_changes); | 107 | (max_changes - info->removed - info->added) * 100.0 / max_changes); |
108 | html("</tr></table></td></tr>\n"); | 108 | html("</tr></table></td></tr>\n"); |
109 | } | 109 | } |
110 | 110 | ||
111 | static void count_diff_lines(char *line, int len) | 111 | static void count_diff_lines(char *line, int len) |
112 | { | 112 | { |
113 | if (line && (len > 0)) { | 113 | if (line && (len > 0)) { |
114 | if (line[0] == '+') | 114 | if (line[0] == '+') |
115 | lines_added++; | 115 | lines_added++; |
116 | else if (line[0] == '-') | 116 | else if (line[0] == '-') |
117 | lines_removed++; | 117 | lines_removed++; |
118 | } | 118 | } |
119 | } | 119 | } |
120 | 120 | ||
121 | static void inspect_filepair(struct diff_filepair *pair) | 121 | static void inspect_filepair(struct diff_filepair *pair) |
122 | { | 122 | { |
123 | int binary = 0; | 123 | int binary = 0; |
124 | unsigned long old_size = 0; | 124 | unsigned long old_size = 0; |
125 | unsigned long new_size = 0; | 125 | unsigned long new_size = 0; |
126 | files++; | 126 | files++; |
127 | lines_added = 0; | 127 | lines_added = 0; |
128 | lines_removed = 0; | 128 | lines_removed = 0; |
129 | cgit_diff_files(pair->one->sha1, pair->two->sha1, &old_size, &new_size, | 129 | cgit_diff_files(pair->one->sha1, pair->two->sha1, &old_size, &new_size, |
130 | &binary, count_diff_lines); | 130 | &binary, 0, count_diff_lines); |
131 | if (files >= slots) { | 131 | if (files >= slots) { |
132 | if (slots == 0) | 132 | if (slots == 0) |
133 | slots = 4; | 133 | slots = 4; |
134 | else | 134 | else |
135 | slots = slots * 2; | 135 | slots = slots * 2; |
136 | items = xrealloc(items, slots * sizeof(struct fileinfo)); | 136 | items = xrealloc(items, slots * sizeof(struct fileinfo)); |
137 | } | 137 | } |
138 | items[files-1].status = pair->status; | 138 | items[files-1].status = pair->status; |
139 | hashcpy(items[files-1].old_sha1, pair->one->sha1); | 139 | hashcpy(items[files-1].old_sha1, pair->one->sha1); |
140 | hashcpy(items[files-1].new_sha1, pair->two->sha1); | 140 | hashcpy(items[files-1].new_sha1, pair->two->sha1); |
141 | items[files-1].old_mode = pair->one->mode; | 141 | items[files-1].old_mode = pair->one->mode; |
142 | items[files-1].new_mode = pair->two->mode; | 142 | items[files-1].new_mode = pair->two->mode; |
143 | items[files-1].old_path = xstrdup(pair->one->path); | 143 | items[files-1].old_path = xstrdup(pair->one->path); |
144 | items[files-1].new_path = xstrdup(pair->two->path); | 144 | items[files-1].new_path = xstrdup(pair->two->path); |
145 | items[files-1].added = lines_added; | 145 | items[files-1].added = lines_added; |
146 | items[files-1].removed = lines_removed; | 146 | items[files-1].removed = lines_removed; |
147 | items[files-1].old_size = old_size; | 147 | items[files-1].old_size = old_size; |
148 | items[files-1].new_size = new_size; | 148 | items[files-1].new_size = new_size; |
149 | items[files-1].binary = binary; | 149 | items[files-1].binary = binary; |
150 | if (lines_added + lines_removed > max_changes) | 150 | if (lines_added + lines_removed > max_changes) |
151 | max_changes = lines_added + lines_removed; | 151 | max_changes = lines_added + lines_removed; |
152 | total_adds += lines_added; | 152 | total_adds += lines_added; |
153 | total_rems += lines_removed; | 153 | total_rems += lines_removed; |
154 | } | 154 | } |
155 | 155 | ||
156 | void cgit_print_diffstat(const unsigned char *old_sha1, | 156 | void cgit_print_diffstat(const unsigned char *old_sha1, |
157 | const unsigned char *new_sha1, const char *prefix) | 157 | const unsigned char *new_sha1, const char *prefix) |
158 | { | 158 | { |
159 | int i; | 159 | int i, save_context = ctx.qry.context; |
160 | 160 | ||
161 | html("<div class='diffstat-header'>"); | 161 | html("<div class='diffstat-header'>"); |
162 | cgit_diff_link("Diffstat", NULL, NULL, ctx.qry.head, ctx.qry.sha1, | 162 | cgit_diff_link("Diffstat", NULL, NULL, ctx.qry.head, ctx.qry.sha1, |
163 | ctx.qry.sha2, NULL, 0); | 163 | ctx.qry.sha2, NULL, 0); |
164 | if (prefix) | 164 | if (prefix) |
165 | htmlf(" (limited to '%s')", prefix); | 165 | htmlf(" (limited to '%s')", prefix); |
166 | html(" ("); | ||
167 | ctx.qry.context = (save_context > 0 ? save_context : 3) << 1; | ||
168 | cgit_self_link("more", NULL, NULL, &ctx); | ||
169 | html("/"); | ||
170 | ctx.qry.context = (save_context > 3 ? save_context : 3) >> 1; | ||
171 | cgit_self_link("less", NULL, NULL, &ctx); | ||
172 | ctx.qry.context = save_context; | ||
173 | html(" context)"); | ||
166 | html("</div>"); | 174 | html("</div>"); |
167 | html("<table summary='diffstat' class='diffstat'>"); | 175 | html("<table summary='diffstat' class='diffstat'>"); |
168 | max_changes = 0; | 176 | max_changes = 0; |
169 | cgit_diff_tree(old_sha1, new_sha1, inspect_filepair, prefix); | 177 | cgit_diff_tree(old_sha1, new_sha1, inspect_filepair, prefix); |
170 | for(i = 0; i<files; i++) | 178 | for(i = 0; i<files; i++) |
171 | print_fileinfo(&items[i]); | 179 | print_fileinfo(&items[i]); |
172 | html("</table>"); | 180 | html("</table>"); |
173 | html("<div class='diffstat-summary'>"); | 181 | html("<div class='diffstat-summary'>"); |
174 | htmlf("%d files changed, %d insertions, %d deletions", | 182 | htmlf("%d files changed, %d insertions, %d deletions", |
175 | files, total_adds, total_rems); | 183 | files, total_adds, total_rems); |
176 | html("</div>"); | 184 | html("</div>"); |
177 | } | 185 | } |
178 | 186 | ||
179 | 187 | ||
180 | /* | 188 | /* |
181 | * print a single line returned from xdiff | 189 | * print a single line returned from xdiff |
182 | */ | 190 | */ |
183 | static void print_line(char *line, int len) | 191 | static void print_line(char *line, int len) |
184 | { | 192 | { |
185 | char *class = "ctx"; | 193 | char *class = "ctx"; |
186 | char c = line[len-1]; | 194 | char c = line[len-1]; |
187 | 195 | ||
188 | if (line[0] == '+') | 196 | if (line[0] == '+') |
189 | class = "add"; | 197 | class = "add"; |
190 | else if (line[0] == '-') | 198 | else if (line[0] == '-') |
191 | class = "del"; | 199 | class = "del"; |
192 | else if (line[0] == '@') | 200 | else if (line[0] == '@') |
193 | class = "hunk"; | 201 | class = "hunk"; |
194 | 202 | ||
195 | htmlf("<div class='%s'>", class); | 203 | htmlf("<div class='%s'>", class); |
196 | line[len-1] = '\0'; | 204 | line[len-1] = '\0'; |
197 | html_txt(line); | 205 | html_txt(line); |
@@ -259,65 +267,65 @@ static void print_ssdiff_link() | |||
259 | else | 267 | else |
260 | cgit_diff_link("Side-by-side diff", NULL, NULL, | 268 | cgit_diff_link("Side-by-side diff", NULL, NULL, |
261 | ctx.qry.head, ctx.qry.sha1, | 269 | ctx.qry.head, ctx.qry.sha1, |
262 | ctx.qry.sha2, ctx.qry.path, 1); | 270 | ctx.qry.sha2, ctx.qry.path, 1); |
263 | } | 271 | } |
264 | } | 272 | } |
265 | 273 | ||
266 | static void filepair_cb(struct diff_filepair *pair) | 274 | static void filepair_cb(struct diff_filepair *pair) |
267 | { | 275 | { |
268 | unsigned long old_size = 0; | 276 | unsigned long old_size = 0; |
269 | unsigned long new_size = 0; | 277 | unsigned long new_size = 0; |
270 | int binary = 0; | 278 | int binary = 0; |
271 | linediff_fn print_line_fn = print_line; | 279 | linediff_fn print_line_fn = print_line; |
272 | 280 | ||
273 | if (use_ssdiff) { | 281 | if (use_ssdiff) { |
274 | cgit_ssdiff_header_begin(); | 282 | cgit_ssdiff_header_begin(); |
275 | print_line_fn = cgit_ssdiff_line_cb; | 283 | print_line_fn = cgit_ssdiff_line_cb; |
276 | } | 284 | } |
277 | header(pair->one->sha1, pair->one->path, pair->one->mode, | 285 | header(pair->one->sha1, pair->one->path, pair->one->mode, |
278 | pair->two->sha1, pair->two->path, pair->two->mode); | 286 | pair->two->sha1, pair->two->path, pair->two->mode); |
279 | if (use_ssdiff) | 287 | if (use_ssdiff) |
280 | cgit_ssdiff_header_end(); | 288 | cgit_ssdiff_header_end(); |
281 | if (S_ISGITLINK(pair->one->mode) || S_ISGITLINK(pair->two->mode)) { | 289 | if (S_ISGITLINK(pair->one->mode) || S_ISGITLINK(pair->two->mode)) { |
282 | if (S_ISGITLINK(pair->one->mode)) | 290 | if (S_ISGITLINK(pair->one->mode)) |
283 | print_line_fn(fmt("-Subproject %s", sha1_to_hex(pair->one->sha1)), 52); | 291 | print_line_fn(fmt("-Subproject %s", sha1_to_hex(pair->one->sha1)), 52); |
284 | if (S_ISGITLINK(pair->two->mode)) | 292 | if (S_ISGITLINK(pair->two->mode)) |
285 | print_line_fn(fmt("+Subproject %s", sha1_to_hex(pair->two->sha1)), 52); | 293 | print_line_fn(fmt("+Subproject %s", sha1_to_hex(pair->two->sha1)), 52); |
286 | if (use_ssdiff) | 294 | if (use_ssdiff) |
287 | cgit_ssdiff_footer(); | 295 | cgit_ssdiff_footer(); |
288 | return; | 296 | return; |
289 | } | 297 | } |
290 | if (cgit_diff_files(pair->one->sha1, pair->two->sha1, &old_size, | 298 | if (cgit_diff_files(pair->one->sha1, pair->two->sha1, &old_size, |
291 | &new_size, &binary, print_line_fn)) | 299 | &new_size, &binary, ctx.qry.context, print_line_fn)) |
292 | cgit_print_error("Error running diff"); | 300 | cgit_print_error("Error running diff"); |
293 | if (binary) { | 301 | if (binary) { |
294 | if (use_ssdiff) | 302 | if (use_ssdiff) |
295 | html("<tr><td colspan='4'>Binary files differ</td></tr>"); | 303 | html("<tr><td colspan='4'>Binary files differ</td></tr>"); |
296 | else | 304 | else |
297 | html("Binary files differ"); | 305 | html("Binary files differ"); |
298 | } | 306 | } |
299 | if (use_ssdiff) | 307 | if (use_ssdiff) |
300 | cgit_ssdiff_footer(); | 308 | cgit_ssdiff_footer(); |
301 | } | 309 | } |
302 | 310 | ||
303 | void cgit_print_diff(const char *new_rev, const char *old_rev, const char *prefix) | 311 | void cgit_print_diff(const char *new_rev, const char *old_rev, const char *prefix) |
304 | { | 312 | { |
305 | enum object_type type; | 313 | enum object_type type; |
306 | unsigned long size; | 314 | unsigned long size; |
307 | struct commit *commit, *commit2; | 315 | struct commit *commit, *commit2; |
308 | 316 | ||
309 | if (!new_rev) | 317 | if (!new_rev) |
310 | new_rev = ctx.qry.head; | 318 | new_rev = ctx.qry.head; |
311 | get_sha1(new_rev, new_rev_sha1); | 319 | get_sha1(new_rev, new_rev_sha1); |
312 | type = sha1_object_info(new_rev_sha1, &size); | 320 | type = sha1_object_info(new_rev_sha1, &size); |
313 | if (type == OBJ_BAD) { | 321 | if (type == OBJ_BAD) { |
314 | cgit_print_error(fmt("Bad object name: %s", new_rev)); | 322 | cgit_print_error(fmt("Bad object name: %s", new_rev)); |
315 | return; | 323 | return; |
316 | } | 324 | } |
317 | commit = lookup_commit_reference(new_rev_sha1); | 325 | commit = lookup_commit_reference(new_rev_sha1); |
318 | if (!commit || parse_commit(commit)) | 326 | if (!commit || parse_commit(commit)) |
319 | cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(new_rev_sha1))); | 327 | cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(new_rev_sha1))); |
320 | 328 | ||
321 | if (old_rev) | 329 | if (old_rev) |
322 | get_sha1(old_rev, old_rev_sha1); | 330 | get_sha1(old_rev, old_rev_sha1); |
323 | else if (commit->parents && commit->parents->item) | 331 | else if (commit->parents && commit->parents->item) |