author | Johan Herland <johan@herland.net> | 2010-06-24 15:53:20 (UTC) |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2010-07-18 08:54:02 (UTC) |
commit | 72ef913514288bd2aae23509581097bfd3edf8c4 (patch) (unidiff) | |
tree | 3a8b48aa0ebcc74a7e8b7f05f964432c6d577921 /ui-diff.c | |
parent | 2cc8b99f083014c58d8937bfa4dcd2bc47cd7e58 (diff) | |
download | cgit-72ef913514288bd2aae23509581097bfd3edf8c4.zip cgit-72ef913514288bd2aae23509581097bfd3edf8c4.tar.gz cgit-72ef913514288bd2aae23509581097bfd3edf8c4.tar.bz2 |
ui-diff: Add link to ignore/show whitespace changes in diffs
Add a link to the "Diffstat" line to ignore/show whitespace changes in the
generated diff.
To support this, cgit_commit_link() and cgit_diff_link() has learned to
preserve the ctx.qry.ignorews variable.
Signed-off-by: Johan Herland <johan@herland.net>
-rw-r--r-- | ui-diff.c | 5 |
1 files changed, 5 insertions, 0 deletions
@@ -110,128 +110,133 @@ static void print_fileinfo(struct fileinfo *info) | |||
110 | 110 | ||
111 | static void count_diff_lines(char *line, int len) | 111 | static void count_diff_lines(char *line, int len) |
112 | { | 112 | { |
113 | if (line && (len > 0)) { | 113 | if (line && (len > 0)) { |
114 | if (line[0] == '+') | 114 | if (line[0] == '+') |
115 | lines_added++; | 115 | lines_added++; |
116 | else if (line[0] == '-') | 116 | else if (line[0] == '-') |
117 | lines_removed++; | 117 | lines_removed++; |
118 | } | 118 | } |
119 | } | 119 | } |
120 | 120 | ||
121 | static void inspect_filepair(struct diff_filepair *pair) | 121 | static void inspect_filepair(struct diff_filepair *pair) |
122 | { | 122 | { |
123 | int binary = 0; | 123 | int binary = 0; |
124 | unsigned long old_size = 0; | 124 | unsigned long old_size = 0; |
125 | unsigned long new_size = 0; | 125 | unsigned long new_size = 0; |
126 | files++; | 126 | files++; |
127 | lines_added = 0; | 127 | lines_added = 0; |
128 | lines_removed = 0; | 128 | lines_removed = 0; |
129 | cgit_diff_files(pair->one->sha1, pair->two->sha1, &old_size, &new_size, | 129 | cgit_diff_files(pair->one->sha1, pair->two->sha1, &old_size, &new_size, |
130 | &binary, 0, ctx.qry.ignorews, count_diff_lines); | 130 | &binary, 0, ctx.qry.ignorews, count_diff_lines); |
131 | if (files >= slots) { | 131 | if (files >= slots) { |
132 | if (slots == 0) | 132 | if (slots == 0) |
133 | slots = 4; | 133 | slots = 4; |
134 | else | 134 | else |
135 | slots = slots * 2; | 135 | slots = slots * 2; |
136 | items = xrealloc(items, slots * sizeof(struct fileinfo)); | 136 | items = xrealloc(items, slots * sizeof(struct fileinfo)); |
137 | } | 137 | } |
138 | items[files-1].status = pair->status; | 138 | items[files-1].status = pair->status; |
139 | hashcpy(items[files-1].old_sha1, pair->one->sha1); | 139 | hashcpy(items[files-1].old_sha1, pair->one->sha1); |
140 | hashcpy(items[files-1].new_sha1, pair->two->sha1); | 140 | hashcpy(items[files-1].new_sha1, pair->two->sha1); |
141 | items[files-1].old_mode = pair->one->mode; | 141 | items[files-1].old_mode = pair->one->mode; |
142 | items[files-1].new_mode = pair->two->mode; | 142 | items[files-1].new_mode = pair->two->mode; |
143 | items[files-1].old_path = xstrdup(pair->one->path); | 143 | items[files-1].old_path = xstrdup(pair->one->path); |
144 | items[files-1].new_path = xstrdup(pair->two->path); | 144 | items[files-1].new_path = xstrdup(pair->two->path); |
145 | items[files-1].added = lines_added; | 145 | items[files-1].added = lines_added; |
146 | items[files-1].removed = lines_removed; | 146 | items[files-1].removed = lines_removed; |
147 | items[files-1].old_size = old_size; | 147 | items[files-1].old_size = old_size; |
148 | items[files-1].new_size = new_size; | 148 | items[files-1].new_size = new_size; |
149 | items[files-1].binary = binary; | 149 | items[files-1].binary = binary; |
150 | if (lines_added + lines_removed > max_changes) | 150 | if (lines_added + lines_removed > max_changes) |
151 | max_changes = lines_added + lines_removed; | 151 | max_changes = lines_added + lines_removed; |
152 | total_adds += lines_added; | 152 | total_adds += lines_added; |
153 | total_rems += lines_removed; | 153 | total_rems += lines_removed; |
154 | } | 154 | } |
155 | 155 | ||
156 | void cgit_print_diffstat(const unsigned char *old_sha1, | 156 | void cgit_print_diffstat(const unsigned char *old_sha1, |
157 | const unsigned char *new_sha1, const char *prefix) | 157 | const unsigned char *new_sha1, const char *prefix) |
158 | { | 158 | { |
159 | int i, save_context = ctx.qry.context; | 159 | int i, save_context = ctx.qry.context; |
160 | 160 | ||
161 | html("<div class='diffstat-header'>"); | 161 | html("<div class='diffstat-header'>"); |
162 | cgit_diff_link("Diffstat", NULL, NULL, ctx.qry.head, ctx.qry.sha1, | 162 | cgit_diff_link("Diffstat", NULL, NULL, ctx.qry.head, ctx.qry.sha1, |
163 | ctx.qry.sha2, NULL, 0); | 163 | ctx.qry.sha2, NULL, 0); |
164 | if (prefix) | 164 | if (prefix) |
165 | htmlf(" (limited to '%s')", prefix); | 165 | htmlf(" (limited to '%s')", prefix); |
166 | html(" ("); | 166 | html(" ("); |
167 | ctx.qry.context = (save_context > 0 ? save_context : 3) << 1; | 167 | ctx.qry.context = (save_context > 0 ? save_context : 3) << 1; |
168 | cgit_self_link("more", NULL, NULL, &ctx); | 168 | cgit_self_link("more", NULL, NULL, &ctx); |
169 | html("/"); | 169 | html("/"); |
170 | ctx.qry.context = (save_context > 3 ? save_context : 3) >> 1; | 170 | ctx.qry.context = (save_context > 3 ? save_context : 3) >> 1; |
171 | cgit_self_link("less", NULL, NULL, &ctx); | 171 | cgit_self_link("less", NULL, NULL, &ctx); |
172 | ctx.qry.context = save_context; | 172 | ctx.qry.context = save_context; |
173 | html(" context)"); | 173 | html(" context)"); |
174 | html(" ("); | ||
175 | ctx.qry.ignorews = (ctx.qry.ignorews + 1) % 2; | ||
176 | cgit_self_link(ctx.qry.ignorews ? "ignore" : "show", NULL, NULL, &ctx); | ||
177 | ctx.qry.ignorews = (ctx.qry.ignorews + 1) % 2; | ||
178 | html(" whitespace changes)"); | ||
174 | html("</div>"); | 179 | html("</div>"); |
175 | html("<table summary='diffstat' class='diffstat'>"); | 180 | html("<table summary='diffstat' class='diffstat'>"); |
176 | max_changes = 0; | 181 | max_changes = 0; |
177 | cgit_diff_tree(old_sha1, new_sha1, inspect_filepair, prefix, | 182 | cgit_diff_tree(old_sha1, new_sha1, inspect_filepair, prefix, |
178 | ctx.qry.ignorews); | 183 | ctx.qry.ignorews); |
179 | for(i = 0; i<files; i++) | 184 | for(i = 0; i<files; i++) |
180 | print_fileinfo(&items[i]); | 185 | print_fileinfo(&items[i]); |
181 | html("</table>"); | 186 | html("</table>"); |
182 | html("<div class='diffstat-summary'>"); | 187 | html("<div class='diffstat-summary'>"); |
183 | htmlf("%d files changed, %d insertions, %d deletions", | 188 | htmlf("%d files changed, %d insertions, %d deletions", |
184 | files, total_adds, total_rems); | 189 | files, total_adds, total_rems); |
185 | html("</div>"); | 190 | html("</div>"); |
186 | } | 191 | } |
187 | 192 | ||
188 | 193 | ||
189 | /* | 194 | /* |
190 | * print a single line returned from xdiff | 195 | * print a single line returned from xdiff |
191 | */ | 196 | */ |
192 | static void print_line(char *line, int len) | 197 | static void print_line(char *line, int len) |
193 | { | 198 | { |
194 | char *class = "ctx"; | 199 | char *class = "ctx"; |
195 | char c = line[len-1]; | 200 | char c = line[len-1]; |
196 | 201 | ||
197 | if (line[0] == '+') | 202 | if (line[0] == '+') |
198 | class = "add"; | 203 | class = "add"; |
199 | else if (line[0] == '-') | 204 | else if (line[0] == '-') |
200 | class = "del"; | 205 | class = "del"; |
201 | else if (line[0] == '@') | 206 | else if (line[0] == '@') |
202 | class = "hunk"; | 207 | class = "hunk"; |
203 | 208 | ||
204 | htmlf("<div class='%s'>", class); | 209 | htmlf("<div class='%s'>", class); |
205 | line[len-1] = '\0'; | 210 | line[len-1] = '\0'; |
206 | html_txt(line); | 211 | html_txt(line); |
207 | html("</div>"); | 212 | html("</div>"); |
208 | line[len-1] = c; | 213 | line[len-1] = c; |
209 | } | 214 | } |
210 | 215 | ||
211 | static void header(unsigned char *sha1, char *path1, int mode1, | 216 | static void header(unsigned char *sha1, char *path1, int mode1, |
212 | unsigned char *sha2, char *path2, int mode2) | 217 | unsigned char *sha2, char *path2, int mode2) |
213 | { | 218 | { |
214 | char *abbrev1, *abbrev2; | 219 | char *abbrev1, *abbrev2; |
215 | int subproject; | 220 | int subproject; |
216 | 221 | ||
217 | subproject = (S_ISGITLINK(mode1) || S_ISGITLINK(mode2)); | 222 | subproject = (S_ISGITLINK(mode1) || S_ISGITLINK(mode2)); |
218 | html("<div class='head'>"); | 223 | html("<div class='head'>"); |
219 | html("diff --git a/"); | 224 | html("diff --git a/"); |
220 | html_txt(path1); | 225 | html_txt(path1); |
221 | html(" b/"); | 226 | html(" b/"); |
222 | html_txt(path2); | 227 | html_txt(path2); |
223 | 228 | ||
224 | if (is_null_sha1(sha1)) | 229 | if (is_null_sha1(sha1)) |
225 | path1 = "dev/null"; | 230 | path1 = "dev/null"; |
226 | if (is_null_sha1(sha2)) | 231 | if (is_null_sha1(sha2)) |
227 | path2 = "dev/null"; | 232 | path2 = "dev/null"; |
228 | 233 | ||
229 | if (mode1 == 0) | 234 | if (mode1 == 0) |
230 | htmlf("<br/>new file mode %.6o", mode2); | 235 | htmlf("<br/>new file mode %.6o", mode2); |
231 | 236 | ||
232 | if (mode2 == 0) | 237 | if (mode2 == 0) |
233 | htmlf("<br/>deleted file mode %.6o", mode1); | 238 | htmlf("<br/>deleted file mode %.6o", mode1); |
234 | 239 | ||
235 | if (!subproject) { | 240 | if (!subproject) { |
236 | abbrev1 = xstrdup(find_unique_abbrev(sha1, DEFAULT_ABBREV)); | 241 | abbrev1 = xstrdup(find_unique_abbrev(sha1, DEFAULT_ABBREV)); |
237 | abbrev2 = xstrdup(find_unique_abbrev(sha2, DEFAULT_ABBREV)); | 242 | abbrev2 = xstrdup(find_unique_abbrev(sha2, DEFAULT_ABBREV)); |