author | Lars Hjemli <hjemli@gmail.com> | 2008-03-17 22:13:16 (UTC) |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2008-03-17 22:51:47 (UTC) |
commit | e01f1403b9b501c563b1fe0e0052460a95945528 (patch) (unidiff) | |
tree | eff9fd11272714db70bf2ac7116511f03d800af6 /ui-patch.c | |
parent | 0537a7d1cfdf7934d91798a623030fd454b356af (diff) | |
download | cgit-e01f1403b9b501c563b1fe0e0052460a95945528.zip cgit-e01f1403b9b501c563b1fe0e0052460a95945528.tar.gz cgit-e01f1403b9b501c563b1fe0e0052460a95945528.tar.bz2 |
Fix segfault in patch view for root commit
The code for patch view assumed the current commit would always have a parent,
which made cgit segfault when that wasn't the case.
This fixes the bug and adds a test-script for patch view which includes a test
for the inital commit.
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r-- | ui-patch.c | 6 |
1 files changed, 5 insertions, 1 deletions
@@ -79,25 +79,29 @@ void cgit_print_patch(char *hex, struct cacheitem *item) | |||
79 | hex = cgit_query_head; | 79 | hex = cgit_query_head; |
80 | 80 | ||
81 | if (get_sha1(hex, sha1)) { | 81 | if (get_sha1(hex, sha1)) { |
82 | cgit_print_error(fmt("Bad object id: %s", hex)); | 82 | cgit_print_error(fmt("Bad object id: %s", hex)); |
83 | return; | 83 | return; |
84 | } | 84 | } |
85 | commit = lookup_commit_reference(sha1); | 85 | commit = lookup_commit_reference(sha1); |
86 | if (!commit) { | 86 | if (!commit) { |
87 | cgit_print_error(fmt("Bad commit reference: %s", hex)); | 87 | cgit_print_error(fmt("Bad commit reference: %s", hex)); |
88 | return; | 88 | return; |
89 | } | 89 | } |
90 | info = cgit_parse_commit(commit); | 90 | info = cgit_parse_commit(commit); |
91 | hashcpy(old_sha1, commit->parents->item->object.sha1); | 91 | |
92 | if (commit->parents && commit->parents->item) | ||
93 | hashcpy(old_sha1, commit->parents->item->object.sha1); | ||
94 | else | ||
95 | hashclr(old_sha1); | ||
92 | 96 | ||
93 | patchname = fmt("%s.patch", sha1_to_hex(sha1)); | 97 | patchname = fmt("%s.patch", sha1_to_hex(sha1)); |
94 | cgit_print_snapshot_start("text/plain", patchname, item); | 98 | cgit_print_snapshot_start("text/plain", patchname, item); |
95 | htmlf("From %s Mon Sep 17 00:00:00 2001\n", sha1_to_hex(sha1)); | 99 | htmlf("From %s Mon Sep 17 00:00:00 2001\n", sha1_to_hex(sha1)); |
96 | htmlf("From: %s%s\n", info->author, info->author_email); | 100 | htmlf("From: %s%s\n", info->author, info->author_email); |
97 | html("Date: "); | 101 | html("Date: "); |
98 | cgit_print_date(info->author_date, "%a, %d %b %Y %H:%M:%S %z%n"); | 102 | cgit_print_date(info->author_date, "%a, %d %b %Y %H:%M:%S %z%n"); |
99 | htmlf("Subject: %s\n\n", info->subject); | 103 | htmlf("Subject: %s\n\n", info->subject); |
100 | if (info->msg && *info->msg) { | 104 | if (info->msg && *info->msg) { |
101 | htmlf("%s", info->msg); | 105 | htmlf("%s", info->msg); |
102 | if (info->msg[strlen(info->msg) - 1] != '\n') | 106 | if (info->msg[strlen(info->msg) - 1] != '\n') |
103 | html("\n"); | 107 | html("\n"); |