summaryrefslogtreecommitdiffabout
Unidiff
Diffstat (more/less context) (ignore whitespace changes)
-rwxr-xr-xtests/t0105-commit.sh2
-rw-r--r--ui-diff.c1
2 files changed, 2 insertions, 1 deletions
diff --git a/tests/t0105-commit.sh b/tests/t0105-commit.sh
index 4e1236b..a864612 100755
--- a/tests/t0105-commit.sh
+++ b/tests/t0105-commit.sh
@@ -1,37 +1,37 @@
1#!/bin/sh 1#!/bin/sh
2 2
3. ./setup.sh 3. ./setup.sh
4 4
5prepare_tests "Check content on commit page" 5prepare_tests "Check content on commit page"
6 6
7run_test 'generate foo/commit' 'cgit_url "foo/commit" >trash/tmp' 7run_test 'generate foo/commit' 'cgit_url "foo/commit" >trash/tmp'
8run_test 'find tree link' 'grep -e "<a href=./foo/tree/.>" trash/tmp' 8run_test 'find tree link' 'grep -e "<a href=./foo/tree/.>" trash/tmp'
9run_test 'find parent link' 'grep -E "<a href=./foo/commit/\?id=.+>" trash/tmp' 9run_test 'find parent link' 'grep -E "<a href=./foo/commit/\?id=.+>" trash/tmp'
10 10
11run_test 'find commit subject' ' 11run_test 'find commit subject' '
12 grep -e "<div class=.commit-subject.>commit 5</div>" trash/tmp 12 grep -e "<div class=.commit-subject.>commit 5</div>" trash/tmp
13' 13'
14 14
15run_test 'find commit msg' 'grep -e "<div class=.commit-msg.></div>" trash/tmp' 15run_test 'find commit msg' 'grep -e "<div class=.commit-msg.></div>" trash/tmp'
16run_test 'find diffstat' 'grep -e "<table summary=.diffstat. class=.diffstat.>" trash/tmp' 16run_test 'find diffstat' 'grep -e "<table summary=.diffstat. class=.diffstat.>" trash/tmp'
17 17
18run_test 'find diff summary' ' 18run_test 'find diff summary' '
19 grep -e "1 files changed, 1 insertions, 0 deletions" trash/tmp 19 grep -e "1 files changed, 1 insertions, 0 deletions" trash/tmp
20' 20'
21 21
22run_test 'get root commit' ' 22run_test 'get root commit' '
23 root=$(cd trash/repos/foo && git rev-list --reverse HEAD | head -1) && 23 root=$(cd trash/repos/foo && git rev-list --reverse HEAD | head -1) &&
24 cgit_url "foo/commit&id=$root" >trash/tmp && 24 cgit_url "foo/commit&id=$root" >trash/tmp &&
25 grep "</html>" trash/tmp 25 grep "</html>" trash/tmp
26' 26'
27 27
28run_test 'root commit contains diffstat' ' 28run_test 'root commit contains diffstat' '
29 grep "<a href=./foo/diff/file-1.>file-1</a>" trash/tmp 29 grep "<a href=./foo/diff/file-1.id=[0-9a-f]\{40\}.>file-1</a>" trash/tmp
30' 30'
31 31
32run_test 'root commit contains diff' ' 32run_test 'root commit contains diff' '
33 grep ">diff --git a/file-1 b/file-1<" trash/tmp && 33 grep ">diff --git a/file-1 b/file-1<" trash/tmp &&
34 grep -e "<div class=.add.>+1</div>" trash/tmp 34 grep -e "<div class=.add.>+1</div>" trash/tmp
35' 35'
36 36
37tests_done 37tests_done
diff --git a/ui-diff.c b/ui-diff.c
index 12e78b1..1c182aa 100644
--- a/ui-diff.c
+++ b/ui-diff.c
@@ -1,289 +1,290 @@
1/* ui-diff.c: show diff between two blobs 1/* ui-diff.c: show diff between two blobs
2 * 2 *
3 * Copyright (C) 2006 Lars Hjemli 3 * Copyright (C) 2006 Lars Hjemli
4 * 4 *
5 * Licensed under GNU General Public License v2 5 * Licensed under GNU General Public License v2
6 * (see COPYING for full license text) 6 * (see COPYING for full license text)
7 */ 7 */
8 8
9#include "cgit.h" 9#include "cgit.h"
10#include "html.h" 10#include "html.h"
11#include "ui-shared.h" 11#include "ui-shared.h"
12 12
13unsigned char old_rev_sha1[20]; 13unsigned char old_rev_sha1[20];
14unsigned char new_rev_sha1[20]; 14unsigned char new_rev_sha1[20];
15 15
16static int files, slots; 16static int files, slots;
17static int total_adds, total_rems, max_changes; 17static int total_adds, total_rems, max_changes;
18static int lines_added, lines_removed; 18static int lines_added, lines_removed;
19static char *curr_rev; 19static char *curr_rev;
20 20
21static struct fileinfo { 21static struct fileinfo {
22 char status; 22 char status;
23 unsigned char old_sha1[20]; 23 unsigned char old_sha1[20];
24 unsigned char new_sha1[20]; 24 unsigned char new_sha1[20];
25 unsigned short old_mode; 25 unsigned short old_mode;
26 unsigned short new_mode; 26 unsigned short new_mode;
27 char *old_path; 27 char *old_path;
28 char *new_path; 28 char *new_path;
29 unsigned int added; 29 unsigned int added;
30 unsigned int removed; 30 unsigned int removed;
31} *items; 31} *items;
32 32
33 33
34static void print_fileinfo(struct fileinfo *info) 34static void print_fileinfo(struct fileinfo *info)
35{ 35{
36 char *class; 36 char *class;
37 37
38 switch (info->status) { 38 switch (info->status) {
39 case DIFF_STATUS_ADDED: 39 case DIFF_STATUS_ADDED:
40 class = "add"; 40 class = "add";
41 break; 41 break;
42 case DIFF_STATUS_COPIED: 42 case DIFF_STATUS_COPIED:
43 class = "cpy"; 43 class = "cpy";
44 break; 44 break;
45 case DIFF_STATUS_DELETED: 45 case DIFF_STATUS_DELETED:
46 class = "del"; 46 class = "del";
47 break; 47 break;
48 case DIFF_STATUS_MODIFIED: 48 case DIFF_STATUS_MODIFIED:
49 class = "upd"; 49 class = "upd";
50 break; 50 break;
51 case DIFF_STATUS_RENAMED: 51 case DIFF_STATUS_RENAMED:
52 class = "mov"; 52 class = "mov";
53 break; 53 break;
54 case DIFF_STATUS_TYPE_CHANGED: 54 case DIFF_STATUS_TYPE_CHANGED:
55 class = "typ"; 55 class = "typ";
56 break; 56 break;
57 case DIFF_STATUS_UNKNOWN: 57 case DIFF_STATUS_UNKNOWN:
58 class = "unk"; 58 class = "unk";
59 break; 59 break;
60 case DIFF_STATUS_UNMERGED: 60 case DIFF_STATUS_UNMERGED:
61 class = "stg"; 61 class = "stg";
62 break; 62 break;
63 default: 63 default:
64 die("bug: unhandled diff status %c", info->status); 64 die("bug: unhandled diff status %c", info->status);
65 } 65 }
66 66
67 html("<tr>"); 67 html("<tr>");
68 htmlf("<td class='mode'>"); 68 htmlf("<td class='mode'>");
69 if (is_null_sha1(info->new_sha1)) { 69 if (is_null_sha1(info->new_sha1)) {
70 cgit_print_filemode(info->old_mode); 70 cgit_print_filemode(info->old_mode);
71 } else { 71 } else {
72 cgit_print_filemode(info->new_mode); 72 cgit_print_filemode(info->new_mode);
73 } 73 }
74 74
75 if (info->old_mode != info->new_mode && 75 if (info->old_mode != info->new_mode &&
76 !is_null_sha1(info->old_sha1) && 76 !is_null_sha1(info->old_sha1) &&
77 !is_null_sha1(info->new_sha1)) { 77 !is_null_sha1(info->new_sha1)) {
78 html("<span class='modechange'>["); 78 html("<span class='modechange'>[");
79 cgit_print_filemode(info->old_mode); 79 cgit_print_filemode(info->old_mode);
80 html("]</span>"); 80 html("]</span>");
81 } 81 }
82 htmlf("</td><td class='%s'>", class); 82 htmlf("</td><td class='%s'>", class);
83 cgit_diff_link(info->new_path, NULL, NULL, ctx.qry.head, curr_rev, 83 cgit_diff_link(info->new_path, NULL, NULL, ctx.qry.head, curr_rev,
84 NULL, info->new_path); 84 NULL, info->new_path);
85 if (info->status == DIFF_STATUS_COPIED || info->status == DIFF_STATUS_RENAMED) 85 if (info->status == DIFF_STATUS_COPIED || info->status == DIFF_STATUS_RENAMED)
86 htmlf(" (%s from %s)", 86 htmlf(" (%s from %s)",
87 info->status == DIFF_STATUS_COPIED ? "copied" : "renamed", 87 info->status == DIFF_STATUS_COPIED ? "copied" : "renamed",
88 info->old_path); 88 info->old_path);
89 html("</td><td class='right'>"); 89 html("</td><td class='right'>");
90 htmlf("%d", info->added + info->removed); 90 htmlf("%d", info->added + info->removed);
91 html("</td><td class='graph'>"); 91 html("</td><td class='graph'>");
92 htmlf("<table summary='file diffstat' width='%d%%'><tr>", (max_changes > 100 ? 100 : max_changes)); 92 htmlf("<table summary='file diffstat' width='%d%%'><tr>", (max_changes > 100 ? 100 : max_changes));
93 htmlf("<td class='add' style='width: %.1f%%;'/>", 93 htmlf("<td class='add' style='width: %.1f%%;'/>",
94 info->added * 100.0 / max_changes); 94 info->added * 100.0 / max_changes);
95 htmlf("<td class='rem' style='width: %.1f%%;'/>", 95 htmlf("<td class='rem' style='width: %.1f%%;'/>",
96 info->removed * 100.0 / max_changes); 96 info->removed * 100.0 / max_changes);
97 htmlf("<td class='none' style='width: %.1f%%;'/>", 97 htmlf("<td class='none' style='width: %.1f%%;'/>",
98 (max_changes - info->removed - info->added) * 100.0 / max_changes); 98 (max_changes - info->removed - info->added) * 100.0 / max_changes);
99 html("</tr></table></td></tr>\n"); 99 html("</tr></table></td></tr>\n");
100} 100}
101 101
102static void count_diff_lines(char *line, int len) 102static void count_diff_lines(char *line, int len)
103{ 103{
104 if (line && (len > 0)) { 104 if (line && (len > 0)) {
105 if (line[0] == '+') 105 if (line[0] == '+')
106 lines_added++; 106 lines_added++;
107 else if (line[0] == '-') 107 else if (line[0] == '-')
108 lines_removed++; 108 lines_removed++;
109 } 109 }
110} 110}
111 111
112static void inspect_filepair(struct diff_filepair *pair) 112static void inspect_filepair(struct diff_filepair *pair)
113{ 113{
114 files++; 114 files++;
115 lines_added = 0; 115 lines_added = 0;
116 lines_removed = 0; 116 lines_removed = 0;
117 cgit_diff_files(pair->one->sha1, pair->two->sha1, count_diff_lines); 117 cgit_diff_files(pair->one->sha1, pair->two->sha1, count_diff_lines);
118 if (files >= slots) { 118 if (files >= slots) {
119 if (slots == 0) 119 if (slots == 0)
120 slots = 4; 120 slots = 4;
121 else 121 else
122 slots = slots * 2; 122 slots = slots * 2;
123 items = xrealloc(items, slots * sizeof(struct fileinfo)); 123 items = xrealloc(items, slots * sizeof(struct fileinfo));
124 } 124 }
125 items[files-1].status = pair->status; 125 items[files-1].status = pair->status;
126 hashcpy(items[files-1].old_sha1, pair->one->sha1); 126 hashcpy(items[files-1].old_sha1, pair->one->sha1);
127 hashcpy(items[files-1].new_sha1, pair->two->sha1); 127 hashcpy(items[files-1].new_sha1, pair->two->sha1);
128 items[files-1].old_mode = pair->one->mode; 128 items[files-1].old_mode = pair->one->mode;
129 items[files-1].new_mode = pair->two->mode; 129 items[files-1].new_mode = pair->two->mode;
130 items[files-1].old_path = xstrdup(pair->one->path); 130 items[files-1].old_path = xstrdup(pair->one->path);
131 items[files-1].new_path = xstrdup(pair->two->path); 131 items[files-1].new_path = xstrdup(pair->two->path);
132 items[files-1].added = lines_added; 132 items[files-1].added = lines_added;
133 items[files-1].removed = lines_removed; 133 items[files-1].removed = lines_removed;
134 if (lines_added + lines_removed > max_changes) 134 if (lines_added + lines_removed > max_changes)
135 max_changes = lines_added + lines_removed; 135 max_changes = lines_added + lines_removed;
136 total_adds += lines_added; 136 total_adds += lines_added;
137 total_rems += lines_removed; 137 total_rems += lines_removed;
138} 138}
139 139
140void cgit_print_diffstat(const unsigned char *old_sha1, 140void cgit_print_diffstat(const unsigned char *old_sha1,
141 const unsigned char *new_sha1) 141 const unsigned char *new_sha1)
142{ 142{
143 int i; 143 int i;
144 144
145 html("<div class='diffstat-header'>Diffstat</div>"); 145 html("<div class='diffstat-header'>Diffstat</div>");
146 html("<table summary='diffstat' class='diffstat'>"); 146 html("<table summary='diffstat' class='diffstat'>");
147 max_changes = 0; 147 max_changes = 0;
148 curr_rev = xstrdup(sha1_to_hex(new_sha1));
148 cgit_diff_tree(old_sha1, new_sha1, inspect_filepair, NULL); 149 cgit_diff_tree(old_sha1, new_sha1, inspect_filepair, NULL);
149 for(i = 0; i<files; i++) 150 for(i = 0; i<files; i++)
150 print_fileinfo(&items[i]); 151 print_fileinfo(&items[i]);
151 html("</table>"); 152 html("</table>");
152 html("<div class='diffstat-summary'>"); 153 html("<div class='diffstat-summary'>");
153 htmlf("%d files changed, %d insertions, %d deletions", 154 htmlf("%d files changed, %d insertions, %d deletions",
154 files, total_adds, total_rems); 155 files, total_adds, total_rems);
155 html("</div>"); 156 html("</div>");
156} 157}
157 158
158 159
159/* 160/*
160 * print a single line returned from xdiff 161 * print a single line returned from xdiff
161 */ 162 */
162static void print_line(char *line, int len) 163static void print_line(char *line, int len)
163{ 164{
164 char *class = "ctx"; 165 char *class = "ctx";
165 char c = line[len-1]; 166 char c = line[len-1];
166 167
167 if (line[0] == '+') 168 if (line[0] == '+')
168 class = "add"; 169 class = "add";
169 else if (line[0] == '-') 170 else if (line[0] == '-')
170 class = "del"; 171 class = "del";
171 else if (line[0] == '@') 172 else if (line[0] == '@')
172 class = "hunk"; 173 class = "hunk";
173 174
174 htmlf("<div class='%s'>", class); 175 htmlf("<div class='%s'>", class);
175 line[len-1] = '\0'; 176 line[len-1] = '\0';
176 html_txt(line); 177 html_txt(line);
177 html("</div>"); 178 html("</div>");
178 line[len-1] = c; 179 line[len-1] = c;
179} 180}
180 181
181static void header(unsigned char *sha1, char *path1, int mode1, 182static void header(unsigned char *sha1, char *path1, int mode1,
182 unsigned char *sha2, char *path2, int mode2) 183 unsigned char *sha2, char *path2, int mode2)
183{ 184{
184 char *abbrev1, *abbrev2; 185 char *abbrev1, *abbrev2;
185 int subproject; 186 int subproject;
186 187
187 subproject = (S_ISGITLINK(mode1) || S_ISGITLINK(mode2)); 188 subproject = (S_ISGITLINK(mode1) || S_ISGITLINK(mode2));
188 html("<div class='head'>"); 189 html("<div class='head'>");
189 html("diff --git a/"); 190 html("diff --git a/");
190 html_txt(path1); 191 html_txt(path1);
191 html(" b/"); 192 html(" b/");
192 html_txt(path2); 193 html_txt(path2);
193 194
194 if (is_null_sha1(sha1)) 195 if (is_null_sha1(sha1))
195 path1 = "dev/null"; 196 path1 = "dev/null";
196 if (is_null_sha1(sha2)) 197 if (is_null_sha1(sha2))
197 path2 = "dev/null"; 198 path2 = "dev/null";
198 199
199 if (mode1 == 0) 200 if (mode1 == 0)
200 htmlf("<br/>new file mode %.6o", mode2); 201 htmlf("<br/>new file mode %.6o", mode2);
201 202
202 if (mode2 == 0) 203 if (mode2 == 0)
203 htmlf("<br/>deleted file mode %.6o", mode1); 204 htmlf("<br/>deleted file mode %.6o", mode1);
204 205
205 if (!subproject) { 206 if (!subproject) {
206 abbrev1 = xstrdup(find_unique_abbrev(sha1, DEFAULT_ABBREV)); 207 abbrev1 = xstrdup(find_unique_abbrev(sha1, DEFAULT_ABBREV));
207 abbrev2 = xstrdup(find_unique_abbrev(sha2, DEFAULT_ABBREV)); 208 abbrev2 = xstrdup(find_unique_abbrev(sha2, DEFAULT_ABBREV));
208 htmlf("<br/>index %s..%s", abbrev1, abbrev2); 209 htmlf("<br/>index %s..%s", abbrev1, abbrev2);
209 free(abbrev1); 210 free(abbrev1);
210 free(abbrev2); 211 free(abbrev2);
211 if (mode1 != 0 && mode2 != 0) { 212 if (mode1 != 0 && mode2 != 0) {
212 htmlf(" %.6o", mode1); 213 htmlf(" %.6o", mode1);
213 if (mode2 != mode1) 214 if (mode2 != mode1)
214 htmlf("..%.6o", mode2); 215 htmlf("..%.6o", mode2);
215 } 216 }
216 html("<br/>--- a/"); 217 html("<br/>--- a/");
217 if (mode1 != 0) 218 if (mode1 != 0)
218 cgit_tree_link(path1, NULL, NULL, ctx.qry.head, 219 cgit_tree_link(path1, NULL, NULL, ctx.qry.head,
219 sha1_to_hex(old_rev_sha1), path1); 220 sha1_to_hex(old_rev_sha1), path1);
220 else 221 else
221 html_txt(path1); 222 html_txt(path1);
222 html("<br/>+++ b/"); 223 html("<br/>+++ b/");
223 if (mode2 != 0) 224 if (mode2 != 0)
224 cgit_tree_link(path2, NULL, NULL, ctx.qry.head, 225 cgit_tree_link(path2, NULL, NULL, ctx.qry.head,
225 sha1_to_hex(new_rev_sha1), path2); 226 sha1_to_hex(new_rev_sha1), path2);
226 else 227 else
227 html_txt(path2); 228 html_txt(path2);
228 } 229 }
229 html("</div>"); 230 html("</div>");
230} 231}
231 232
232static void filepair_cb(struct diff_filepair *pair) 233static void filepair_cb(struct diff_filepair *pair)
233{ 234{
234 header(pair->one->sha1, pair->one->path, pair->one->mode, 235 header(pair->one->sha1, pair->one->path, pair->one->mode,
235 pair->two->sha1, pair->two->path, pair->two->mode); 236 pair->two->sha1, pair->two->path, pair->two->mode);
236 if (S_ISGITLINK(pair->one->mode) || S_ISGITLINK(pair->two->mode)) { 237 if (S_ISGITLINK(pair->one->mode) || S_ISGITLINK(pair->two->mode)) {
237 if (S_ISGITLINK(pair->one->mode)) 238 if (S_ISGITLINK(pair->one->mode))
238 print_line(fmt("-Subproject %s", sha1_to_hex(pair->one->sha1)), 52); 239 print_line(fmt("-Subproject %s", sha1_to_hex(pair->one->sha1)), 52);
239 if (S_ISGITLINK(pair->two->mode)) 240 if (S_ISGITLINK(pair->two->mode))
240 print_line(fmt("+Subproject %s", sha1_to_hex(pair->two->sha1)), 52); 241 print_line(fmt("+Subproject %s", sha1_to_hex(pair->two->sha1)), 52);
241 return; 242 return;
242 } 243 }
243 if (cgit_diff_files(pair->one->sha1, pair->two->sha1, print_line)) 244 if (cgit_diff_files(pair->one->sha1, pair->two->sha1, print_line))
244 cgit_print_error("Error running diff"); 245 cgit_print_error("Error running diff");
245} 246}
246 247
247void cgit_print_diff(const char *new_rev, const char *old_rev, const char *prefix) 248void cgit_print_diff(const char *new_rev, const char *old_rev, const char *prefix)
248{ 249{
249 enum object_type type; 250 enum object_type type;
250 unsigned long size; 251 unsigned long size;
251 struct commit *commit, *commit2; 252 struct commit *commit, *commit2;
252 253
253 if (!new_rev) 254 if (!new_rev)
254 new_rev = ctx.qry.head; 255 new_rev = ctx.qry.head;
255 get_sha1(new_rev, new_rev_sha1); 256 get_sha1(new_rev, new_rev_sha1);
256 type = sha1_object_info(new_rev_sha1, &size); 257 type = sha1_object_info(new_rev_sha1, &size);
257 if (type == OBJ_BAD) { 258 if (type == OBJ_BAD) {
258 cgit_print_error(fmt("Bad object name: %s", new_rev)); 259 cgit_print_error(fmt("Bad object name: %s", new_rev));
259 return; 260 return;
260 } 261 }
261 commit = lookup_commit_reference(new_rev_sha1); 262 commit = lookup_commit_reference(new_rev_sha1);
262 if (!commit || parse_commit(commit)) 263 if (!commit || parse_commit(commit))
263 cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(new_rev_sha1))); 264 cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(new_rev_sha1)));
264 265
265 if (old_rev) 266 if (old_rev)
266 get_sha1(old_rev, old_rev_sha1); 267 get_sha1(old_rev, old_rev_sha1);
267 else if (commit->parents && commit->parents->item) 268 else if (commit->parents && commit->parents->item)
268 hashcpy(old_rev_sha1, commit->parents->item->object.sha1); 269 hashcpy(old_rev_sha1, commit->parents->item->object.sha1);
269 else 270 else
270 hashclr(old_rev_sha1); 271 hashclr(old_rev_sha1);
271 272
272 if (!is_null_sha1(old_rev_sha1)) { 273 if (!is_null_sha1(old_rev_sha1)) {
273 type = sha1_object_info(old_rev_sha1, &size); 274 type = sha1_object_info(old_rev_sha1, &size);
274 if (type == OBJ_BAD) { 275 if (type == OBJ_BAD) {
275 cgit_print_error(fmt("Bad object name: %s", sha1_to_hex(old_rev_sha1))); 276 cgit_print_error(fmt("Bad object name: %s", sha1_to_hex(old_rev_sha1)));
276 return; 277 return;
277 } 278 }
278 commit2 = lookup_commit_reference(old_rev_sha1); 279 commit2 = lookup_commit_reference(old_rev_sha1);
279 if (!commit2 || parse_commit(commit2)) 280 if (!commit2 || parse_commit(commit2))
280 cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(old_rev_sha1))); 281 cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(old_rev_sha1)));
281 } 282 }
282 cgit_print_diffstat(old_rev_sha1, new_rev_sha1); 283 cgit_print_diffstat(old_rev_sha1, new_rev_sha1);
283 284
284 html("<table summary='diff' class='diff'>"); 285 html("<table summary='diff' class='diff'>");
285 html("<tr><td>"); 286 html("<tr><td>");
286 cgit_diff_tree(old_rev_sha1, new_rev_sha1, filepair_cb, prefix); 287 cgit_diff_tree(old_rev_sha1, new_rev_sha1, filepair_cb, prefix);
287 html("</td></tr>"); 288 html("</td></tr>");
288 html("</table>"); 289 html("</table>");
289} 290}