summaryrefslogtreecommitdiffabout
Unidiff
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--cache.c4
-rw-r--r--ui-plain.c2
2 files changed, 3 insertions, 3 deletions
diff --git a/cache.c b/cache.c
index 57068a1..d7a8d5a 100644
--- a/cache.c
+++ b/cache.c
@@ -227,213 +227,213 @@ static int process_slot(struct cache_slot *slot)
227 227
228 err = open_slot(slot); 228 err = open_slot(slot);
229 if (!err && slot->match) { 229 if (!err && slot->match) {
230 if (is_expired(slot)) { 230 if (is_expired(slot)) {
231 if (!lock_slot(slot)) { 231 if (!lock_slot(slot)) {
232 /* If the cachefile has been replaced between 232 /* If the cachefile has been replaced between
233 * `open_slot` and `lock_slot`, we'll just 233 * `open_slot` and `lock_slot`, we'll just
234 * serve the stale content from the original 234 * serve the stale content from the original
235 * cachefile. This way we avoid pruning the 235 * cachefile. This way we avoid pruning the
236 * newly generated slot. The same code-path 236 * newly generated slot. The same code-path
237 * is chosen if fill_slot() fails for some 237 * is chosen if fill_slot() fails for some
238 * reason. 238 * reason.
239 * 239 *
240 * TODO? check if the new slot contains the 240 * TODO? check if the new slot contains the
241 * same key as the old one, since we would 241 * same key as the old one, since we would
242 * prefer to serve the newest content. 242 * prefer to serve the newest content.
243 * This will require us to open yet another 243 * This will require us to open yet another
244 * file-descriptor and read and compare the 244 * file-descriptor and read and compare the
245 * key from the new file, so for now we're 245 * key from the new file, so for now we're
246 * lazy and just ignore the new file. 246 * lazy and just ignore the new file.
247 */ 247 */
248 if (is_modified(slot) || fill_slot(slot)) { 248 if (is_modified(slot) || fill_slot(slot)) {
249 unlock_slot(slot, 0); 249 unlock_slot(slot, 0);
250 close_lock(slot); 250 close_lock(slot);
251 } else { 251 } else {
252 close_slot(slot); 252 close_slot(slot);
253 unlock_slot(slot, 1); 253 unlock_slot(slot, 1);
254 slot->cache_fd = slot->lock_fd; 254 slot->cache_fd = slot->lock_fd;
255 } 255 }
256 } 256 }
257 } 257 }
258 if ((err = print_slot(slot)) != 0) { 258 if ((err = print_slot(slot)) != 0) {
259 cache_log("[cgit] error printing cache %s: %s (%d)\n", 259 cache_log("[cgit] error printing cache %s: %s (%d)\n",
260 slot->cache_name, 260 slot->cache_name,
261 strerror(err), 261 strerror(err),
262 err); 262 err);
263 } 263 }
264 close_slot(slot); 264 close_slot(slot);
265 return err; 265 return err;
266 } 266 }
267 267
268 /* If the cache slot does not exist (or its key doesn't match the 268 /* If the cache slot does not exist (or its key doesn't match the
269 * current key), lets try to create a new cache slot for this 269 * current key), lets try to create a new cache slot for this
270 * request. If this fails (for whatever reason), lets just generate 270 * request. If this fails (for whatever reason), lets just generate
271 * the content without caching it and fool the caller to belive 271 * the content without caching it and fool the caller to belive
272 * everything worked out (but print a warning on stdout). 272 * everything worked out (but print a warning on stdout).
273 */ 273 */
274 274
275 close_slot(slot); 275 close_slot(slot);
276 if ((err = lock_slot(slot)) != 0) { 276 if ((err = lock_slot(slot)) != 0) {
277 cache_log("[cgit] Unable to lock slot %s: %s (%d)\n", 277 cache_log("[cgit] Unable to lock slot %s: %s (%d)\n",
278 slot->lock_name, strerror(err), err); 278 slot->lock_name, strerror(err), err);
279 slot->fn(slot->cbdata); 279 slot->fn(slot->cbdata);
280 return 0; 280 return 0;
281 } 281 }
282 282
283 if ((err = fill_slot(slot)) != 0) { 283 if ((err = fill_slot(slot)) != 0) {
284 cache_log("[cgit] Unable to fill slot %s: %s (%d)\n", 284 cache_log("[cgit] Unable to fill slot %s: %s (%d)\n",
285 slot->lock_name, strerror(err), err); 285 slot->lock_name, strerror(err), err);
286 unlock_slot(slot, 0); 286 unlock_slot(slot, 0);
287 close_lock(slot); 287 close_lock(slot);
288 slot->fn(slot->cbdata); 288 slot->fn(slot->cbdata);
289 return 0; 289 return 0;
290 } 290 }
291 // We've got a valid cache slot in the lock file, which 291 // We've got a valid cache slot in the lock file, which
292 // is about to replace the old cache slot. But if we 292 // is about to replace the old cache slot. But if we
293 // release the lockfile and then try to open the new cache 293 // release the lockfile and then try to open the new cache
294 // slot, we might get a race condition with a concurrent 294 // slot, we might get a race condition with a concurrent
295 // writer for the same cache slot (with a different key). 295 // writer for the same cache slot (with a different key).
296 // Lets avoid such a race by just printing the content of 296 // Lets avoid such a race by just printing the content of
297 // the lock file. 297 // the lock file.
298 slot->cache_fd = slot->lock_fd; 298 slot->cache_fd = slot->lock_fd;
299 unlock_slot(slot, 1); 299 unlock_slot(slot, 1);
300 if ((err = print_slot(slot)) != 0) { 300 if ((err = print_slot(slot)) != 0) {
301 cache_log("[cgit] error printing cache %s: %s (%d)\n", 301 cache_log("[cgit] error printing cache %s: %s (%d)\n",
302 slot->cache_name, 302 slot->cache_name,
303 strerror(err), 303 strerror(err),
304 err); 304 err);
305 } 305 }
306 close_slot(slot); 306 close_slot(slot);
307 return err; 307 return err;
308} 308}
309 309
310/* Print cached content to stdout, generate the content if necessary. */ 310/* Print cached content to stdout, generate the content if necessary. */
311int cache_process(int size, const char *path, const char *key, int ttl, 311int cache_process(int size, const char *path, const char *key, int ttl,
312 cache_fill_fn fn, void *cbdata) 312 cache_fill_fn fn, void *cbdata)
313{ 313{
314 unsigned long hash; 314 unsigned long hash;
315 int len, i; 315 int len, i;
316 char filename[1024]; 316 char filename[1024];
317 char lockname[1024 + 5]; /* 5 = ".lock" */ 317 char lockname[1024 + 5]; /* 5 = ".lock" */
318 struct cache_slot slot; 318 struct cache_slot slot;
319 319
320 /* If the cache is disabled, just generate the content */ 320 /* If the cache is disabled, just generate the content */
321 if (size <= 0) { 321 if (size <= 0) {
322 fn(cbdata); 322 fn(cbdata);
323 return 0; 323 return 0;
324 } 324 }
325 325
326 /* Verify input, calculate filenames */ 326 /* Verify input, calculate filenames */
327 if (!path) { 327 if (!path) {
328 cache_log("[cgit] Cache path not specified, caching is disabled\n"); 328 cache_log("[cgit] Cache path not specified, caching is disabled\n");
329 fn(cbdata); 329 fn(cbdata);
330 return 0; 330 return 0;
331 } 331 }
332 len = strlen(path); 332 len = strlen(path);
333 if (len > sizeof(filename) - 10) { /* 10 = "/01234567\0" */ 333 if (len > sizeof(filename) - 10) { /* 10 = "/01234567\0" */
334 cache_log("[cgit] Cache path too long, caching is disabled: %s\n", 334 cache_log("[cgit] Cache path too long, caching is disabled: %s\n",
335 path); 335 path);
336 fn(cbdata); 336 fn(cbdata);
337 return 0; 337 return 0;
338 } 338 }
339 if (!key) 339 if (!key)
340 key = ""; 340 key = "";
341 hash = hash_str(key) % size; 341 hash = hash_str(key) % size;
342 strcpy(filename, path); 342 strcpy(filename, path);
343 if (filename[len - 1] != '/') 343 if (filename[len - 1] != '/')
344 filename[len++] = '/'; 344 filename[len++] = '/';
345 for(i = 0; i < 8; i++) { 345 for(i = 0; i < 8; i++) {
346 sprintf(filename + len++, "%x", 346 sprintf(filename + len++, "%x",
347 (unsigned char)(hash & 0xf)); 347 (unsigned char)(hash & 0xf));
348 hash >>= 4; 348 hash >>= 4;
349 } 349 }
350 filename[len] = '\0'; 350 filename[len] = '\0';
351 strcpy(lockname, filename); 351 strcpy(lockname, filename);
352 strcpy(lockname + len, ".lock"); 352 strcpy(lockname + len, ".lock");
353 slot.fn = fn; 353 slot.fn = fn;
354 slot.cbdata = cbdata; 354 slot.cbdata = cbdata;
355 slot.ttl = ttl; 355 slot.ttl = ttl;
356 slot.cache_name = filename; 356 slot.cache_name = filename;
357 slot.lock_name = lockname; 357 slot.lock_name = lockname;
358 slot.key = key; 358 slot.key = key;
359 slot.keylen = strlen(key); 359 slot.keylen = strlen(key);
360 return process_slot(&slot); 360 return process_slot(&slot);
361} 361}
362 362
363/* Return a strftime formatted date/time 363/* Return a strftime formatted date/time
364 * NB: the result from this function is to shared memory 364 * NB: the result from this function is to shared memory
365 */ 365 */
366char *sprintftime(const char *format, time_t time) 366char *sprintftime(const char *format, time_t time)
367{ 367{
368 static char buf[64]; 368 static char buf[64];
369 struct tm *tm; 369 struct tm *tm;
370 370
371 if (!time) 371 if (!time)
372 return NULL; 372 return NULL;
373 tm = gmtime(&time); 373 tm = gmtime(&time);
374 strftime(buf, sizeof(buf)-1, format, tm); 374 strftime(buf, sizeof(buf)-1, format, tm);
375 return buf; 375 return buf;
376} 376}
377 377
378int cache_ls(const char *path) 378int cache_ls(const char *path)
379{ 379{
380 DIR *dir; 380 DIR *dir;
381 struct dirent *ent; 381 struct dirent *ent;
382 int err = 0; 382 int err = 0;
383 struct cache_slot slot; 383 struct cache_slot slot;
384 char fullname[1024]; 384 char fullname[1024];
385 char *name; 385 char *name;
386 386
387 if (!path) { 387 if (!path) {
388 cache_log("[cgit] cache path not specified\n"); 388 cache_log("[cgit] cache path not specified\n");
389 return -1; 389 return -1;
390 } 390 }
391 if (strlen(path) > 1024 - 10) { 391 if (strlen(path) > 1024 - 10) {
392 cache_log("[cgit] cache path too long: %s\n", 392 cache_log("[cgit] cache path too long: %s\n",
393 path); 393 path);
394 return -1; 394 return -1;
395 } 395 }
396 dir = opendir(path); 396 dir = opendir(path);
397 if (!dir) { 397 if (!dir) {
398 err = errno; 398 err = errno;
399 cache_log("[cgit] unable to open path %s: %s (%d)\n", 399 cache_log("[cgit] unable to open path %s: %s (%d)\n",
400 path, strerror(err), err); 400 path, strerror(err), err);
401 return err; 401 return err;
402 } 402 }
403 strcpy(fullname, path); 403 strcpy(fullname, path);
404 name = fullname + strlen(path); 404 name = fullname + strlen(path);
405 if (*(name - 1) != '/') { 405 if (*(name - 1) != '/') {
406 *name++ = '/'; 406 *name++ = '/';
407 *name = '\0'; 407 *name = '\0';
408 } 408 }
409 slot.cache_name = fullname; 409 slot.cache_name = fullname;
410 while((ent = readdir(dir)) != NULL) { 410 while((ent = readdir(dir)) != NULL) {
411 if (strlen(ent->d_name) != 8) 411 if (strlen(ent->d_name) != 8)
412 continue; 412 continue;
413 strcpy(name, ent->d_name); 413 strcpy(name, ent->d_name);
414 if ((err = open_slot(&slot)) != 0) { 414 if ((err = open_slot(&slot)) != 0) {
415 cache_log("[cgit] unable to open path %s: %s (%d)\n", 415 cache_log("[cgit] unable to open path %s: %s (%d)\n",
416 fullname, strerror(err), err); 416 fullname, strerror(err), err);
417 continue; 417 continue;
418 } 418 }
419 printf("%s %s %10zd %s\n", 419 printf("%s %s %10"PRIuMAX" %s\n",
420 name, 420 name,
421 sprintftime("%Y-%m-%d %H:%M:%S", 421 sprintftime("%Y-%m-%d %H:%M:%S",
422 slot.cache_st.st_mtime), 422 slot.cache_st.st_mtime),
423 slot.cache_st.st_size, 423 (uintmax_t)slot.cache_st.st_size,
424 slot.buf); 424 slot.buf);
425 close_slot(&slot); 425 close_slot(&slot);
426 } 426 }
427 closedir(dir); 427 closedir(dir);
428 return 0; 428 return 0;
429} 429}
430 430
431/* Print a message to stdout */ 431/* Print a message to stdout */
432void cache_log(const char *format, ...) 432void cache_log(const char *format, ...)
433{ 433{
434 va_list args; 434 va_list args;
435 va_start(args, format); 435 va_start(args, format);
436 vfprintf(stderr, format, args); 436 vfprintf(stderr, format, args);
437 va_end(args); 437 va_end(args);
438} 438}
439 439
diff --git a/ui-plain.c b/ui-plain.c
index be559e0..5addd9e 100644
--- a/ui-plain.c
+++ b/ui-plain.c
@@ -1,79 +1,79 @@
1/* ui-plain.c: functions for output of plain blobs by path 1/* ui-plain.c: functions for output of plain blobs by path
2 * 2 *
3 * Copyright (C) 2008 Lars Hjemli 3 * Copyright (C) 2008 Lars Hjemli
4 * 4 *
5 * Licensed under GNU General Public License v2 5 * Licensed under GNU General Public License v2
6 * (see COPYING for full license text) 6 * (see COPYING for full license text)
7 */ 7 */
8 8
9#include "cgit.h" 9#include "cgit.h"
10#include "html.h" 10#include "html.h"
11#include "ui-shared.h" 11#include "ui-shared.h"
12 12
13char *curr_rev; 13char *curr_rev;
14char *match_path; 14char *match_path;
15int match; 15int match;
16 16
17static void print_object(const unsigned char *sha1, const char *path) 17static void print_object(const unsigned char *sha1, const char *path)
18{ 18{
19 enum object_type type; 19 enum object_type type;
20 char *buf; 20 char *buf;
21 size_t size; 21 unsigned long size;
22 22
23 type = sha1_object_info(sha1, &size); 23 type = sha1_object_info(sha1, &size);
24 if (type == OBJ_BAD) { 24 if (type == OBJ_BAD) {
25 html_status(404, "Not found", 0); 25 html_status(404, "Not found", 0);
26 return; 26 return;
27 } 27 }
28 28
29 buf = read_sha1_file(sha1, &type, &size); 29 buf = read_sha1_file(sha1, &type, &size);
30 if (!buf) { 30 if (!buf) {
31 html_status(404, "Not found", 0); 31 html_status(404, "Not found", 0);
32 return; 32 return;
33 } 33 }
34 ctx.page.mimetype = "text/plain"; 34 ctx.page.mimetype = "text/plain";
35 ctx.page.filename = fmt("%s", path); 35 ctx.page.filename = fmt("%s", path);
36 ctx.page.size = size; 36 ctx.page.size = size;
37 cgit_print_http_headers(&ctx); 37 cgit_print_http_headers(&ctx);
38 html_raw(buf, size); 38 html_raw(buf, size);
39 match = 1; 39 match = 1;
40} 40}
41 41
42static int walk_tree(const unsigned char *sha1, const char *base, int baselen, 42static int walk_tree(const unsigned char *sha1, const char *base, int baselen,
43 const char *pathname, unsigned mode, int stage, 43 const char *pathname, unsigned mode, int stage,
44 void *cbdata) 44 void *cbdata)
45{ 45{
46 if (S_ISDIR(mode)) 46 if (S_ISDIR(mode))
47 return READ_TREE_RECURSIVE; 47 return READ_TREE_RECURSIVE;
48 48
49 if (S_ISREG(mode)) 49 if (S_ISREG(mode))
50 print_object(sha1, pathname); 50 print_object(sha1, pathname);
51 51
52 return 0; 52 return 0;
53} 53}
54 54
55void cgit_print_plain(struct cgit_context *ctx) 55void cgit_print_plain(struct cgit_context *ctx)
56{ 56{
57 const char *rev = ctx->qry.sha1; 57 const char *rev = ctx->qry.sha1;
58 unsigned char sha1[20]; 58 unsigned char sha1[20];
59 struct commit *commit; 59 struct commit *commit;
60 const char *paths[] = {ctx->qry.path, NULL}; 60 const char *paths[] = {ctx->qry.path, NULL};
61 61
62 if (!rev) 62 if (!rev)
63 rev = ctx->qry.head; 63 rev = ctx->qry.head;
64 64
65 curr_rev = xstrdup(rev); 65 curr_rev = xstrdup(rev);
66 if (get_sha1(rev, sha1)) { 66 if (get_sha1(rev, sha1)) {
67 html_status(404, "Not found", 0); 67 html_status(404, "Not found", 0);
68 return; 68 return;
69 } 69 }
70 commit = lookup_commit_reference(sha1); 70 commit = lookup_commit_reference(sha1);
71 if (!commit || parse_commit(commit)) { 71 if (!commit || parse_commit(commit)) {
72 html_status(404, "Not found", 0); 72 html_status(404, "Not found", 0);
73 return; 73 return;
74 } 74 }
75 match_path = ctx->qry.path; 75 match_path = ctx->qry.path;
76 read_tree_recursive(commit->tree, NULL, 0, 0, paths, walk_tree, NULL); 76 read_tree_recursive(commit->tree, NULL, 0, 0, paths, walk_tree, NULL);
77 if (!match) 77 if (!match)
78 html_status(404, "Not found", 0); 78 html_status(404, "Not found", 0);
79} 79}