|
diff --git a/ui-diff.c b/ui-diff.c index 7ab1e49..878496d 100644 --- a/ ui-diff.c+++ b/ ui-diff.c |
|
@@ -1,288 +1,291 @@ |
1 | /* ui-diff.c: show diff between two blobs |
1 | /* ui-diff.c: show diff between two blobs |
2 | * |
2 | * |
3 | * Copyright (C) 2006 Lars Hjemli |
3 | * Copyright (C) 2006 Lars Hjemli |
4 | * |
4 | * |
5 | * Licensed under GNU General Public License v2 |
5 | * Licensed under GNU General Public License v2 |
6 | * (see COPYING for full license text) |
6 | * (see COPYING for full license text) |
7 | */ |
7 | */ |
8 | |
8 | |
9 | #include "cgit.h" |
9 | #include "cgit.h" |
10 | #include "html.h" |
10 | #include "html.h" |
11 | #include "ui-shared.h" |
11 | #include "ui-shared.h" |
12 | |
12 | |
13 | unsigned char old_rev_sha1[20]; |
13 | unsigned char old_rev_sha1[20]; |
14 | unsigned char new_rev_sha1[20]; |
14 | unsigned char new_rev_sha1[20]; |
15 | |
15 | |
16 | static int files, slots; |
16 | static int files, slots; |
17 | static int total_adds, total_rems, max_changes; |
17 | static int total_adds, total_rems, max_changes; |
18 | static int lines_added, lines_removed; |
18 | static int lines_added, lines_removed; |
19 | |
19 | |
20 | static struct fileinfo { |
20 | static struct fileinfo { |
21 | char status; |
21 | char status; |
22 | unsigned char old_sha1[20]; |
22 | unsigned char old_sha1[20]; |
23 | unsigned char new_sha1[20]; |
23 | unsigned char new_sha1[20]; |
24 | unsigned short old_mode; |
24 | unsigned short old_mode; |
25 | unsigned short new_mode; |
25 | unsigned short new_mode; |
26 | char *old_path; |
26 | char *old_path; |
27 | char *new_path; |
27 | char *new_path; |
28 | unsigned int added; |
28 | unsigned int added; |
29 | unsigned int removed; |
29 | unsigned int removed; |
30 | } *items; |
30 | } *items; |
31 | |
31 | |
32 | |
32 | |
33 | static void print_fileinfo(struct fileinfo *info) |
33 | static void print_fileinfo(struct fileinfo *info) |
34 | { |
34 | { |
35 | char *class; |
35 | char *class; |
36 | |
36 | |
37 | switch (info->status) { |
37 | switch (info->status) { |
38 | case DIFF_STATUS_ADDED: |
38 | case DIFF_STATUS_ADDED: |
39 | class = "add"; |
39 | class = "add"; |
40 | break; |
40 | break; |
41 | case DIFF_STATUS_COPIED: |
41 | case DIFF_STATUS_COPIED: |
42 | class = "cpy"; |
42 | class = "cpy"; |
43 | break; |
43 | break; |
44 | case DIFF_STATUS_DELETED: |
44 | case DIFF_STATUS_DELETED: |
45 | class = "del"; |
45 | class = "del"; |
46 | break; |
46 | break; |
47 | case DIFF_STATUS_MODIFIED: |
47 | case DIFF_STATUS_MODIFIED: |
48 | class = "upd"; |
48 | class = "upd"; |
49 | break; |
49 | break; |
50 | case DIFF_STATUS_RENAMED: |
50 | case DIFF_STATUS_RENAMED: |
51 | class = "mov"; |
51 | class = "mov"; |
52 | break; |
52 | break; |
53 | case DIFF_STATUS_TYPE_CHANGED: |
53 | case DIFF_STATUS_TYPE_CHANGED: |
54 | class = "typ"; |
54 | class = "typ"; |
55 | break; |
55 | break; |
56 | case DIFF_STATUS_UNKNOWN: |
56 | case DIFF_STATUS_UNKNOWN: |
57 | class = "unk"; |
57 | class = "unk"; |
58 | break; |
58 | break; |
59 | case DIFF_STATUS_UNMERGED: |
59 | case DIFF_STATUS_UNMERGED: |
60 | class = "stg"; |
60 | class = "stg"; |
61 | break; |
61 | break; |
62 | default: |
62 | default: |
63 | die("bug: unhandled diff status %c", info->status); |
63 | die("bug: unhandled diff status %c", info->status); |
64 | } |
64 | } |
65 | |
65 | |
66 | html("<tr>"); |
66 | html("<tr>"); |
67 | htmlf("<td class='mode'>"); |
67 | htmlf("<td class='mode'>"); |
68 | if (is_null_sha1(info->new_sha1)) { |
68 | if (is_null_sha1(info->new_sha1)) { |
69 | cgit_print_filemode(info->old_mode); |
69 | cgit_print_filemode(info->old_mode); |
70 | } else { |
70 | } else { |
71 | cgit_print_filemode(info->new_mode); |
71 | cgit_print_filemode(info->new_mode); |
72 | } |
72 | } |
73 | |
73 | |
74 | if (info->old_mode != info->new_mode && |
74 | if (info->old_mode != info->new_mode && |
75 | !is_null_sha1(info->old_sha1) && |
75 | !is_null_sha1(info->old_sha1) && |
76 | !is_null_sha1(info->new_sha1)) { |
76 | !is_null_sha1(info->new_sha1)) { |
77 | html("<span class='modechange'>["); |
77 | html("<span class='modechange'>["); |
78 | cgit_print_filemode(info->old_mode); |
78 | cgit_print_filemode(info->old_mode); |
79 | html("]</span>"); |
79 | html("]</span>"); |
80 | } |
80 | } |
81 | htmlf("</td><td class='%s'>", class); |
81 | htmlf("</td><td class='%s'>", class); |
82 | cgit_diff_link(info->new_path, NULL, NULL, ctx.qry.head, ctx.qry.sha1, |
82 | cgit_diff_link(info->new_path, NULL, NULL, ctx.qry.head, ctx.qry.sha1, |
83 | ctx.qry.sha2, info->new_path); |
83 | ctx.qry.sha2, info->new_path); |
84 | if (info->status == DIFF_STATUS_COPIED || info->status == DIFF_STATUS_RENAMED) |
84 | if (info->status == DIFF_STATUS_COPIED || info->status == DIFF_STATUS_RENAMED) |
85 | htmlf(" (%s from %s)", |
85 | htmlf(" (%s from %s)", |
86 | info->status == DIFF_STATUS_COPIED ? "copied" : "renamed", |
86 | info->status == DIFF_STATUS_COPIED ? "copied" : "renamed", |
87 | info->old_path); |
87 | info->old_path); |
88 | html("</td><td class='right'>"); |
88 | html("</td><td class='right'>"); |
89 | htmlf("%d", info->added + info->removed); |
89 | htmlf("%d", info->added + info->removed); |
90 | html("</td><td class='graph'>"); |
90 | html("</td><td class='graph'>"); |
91 | htmlf("<table summary='file diffstat' width='%d%%'><tr>", (max_changes > 100 ? 100 : max_changes)); |
91 | htmlf("<table summary='file diffstat' width='%d%%'><tr>", (max_changes > 100 ? 100 : max_changes)); |
92 | htmlf("<td class='add' style='width: %.1f%%;'/>", |
92 | htmlf("<td class='add' style='width: %.1f%%;'/>", |
93 | info->added * 100.0 / max_changes); |
93 | info->added * 100.0 / max_changes); |
94 | htmlf("<td class='rem' style='width: %.1f%%;'/>", |
94 | htmlf("<td class='rem' style='width: %.1f%%;'/>", |
95 | info->removed * 100.0 / max_changes); |
95 | info->removed * 100.0 / max_changes); |
96 | htmlf("<td class='none' style='width: %.1f%%;'/>", |
96 | htmlf("<td class='none' style='width: %.1f%%;'/>", |
97 | (max_changes - info->removed - info->added) * 100.0 / max_changes); |
97 | (max_changes - info->removed - info->added) * 100.0 / max_changes); |
98 | html("</tr></table></td></tr>\n"); |
98 | html("</tr></table></td></tr>\n"); |
99 | } |
99 | } |
100 | |
100 | |
101 | static void count_diff_lines(char *line, int len) |
101 | static void count_diff_lines(char *line, int len) |
102 | { |
102 | { |
103 | if (line && (len > 0)) { |
103 | if (line && (len > 0)) { |
104 | if (line[0] == '+') |
104 | if (line[0] == '+') |
105 | lines_added++; |
105 | lines_added++; |
106 | else if (line[0] == '-') |
106 | else if (line[0] == '-') |
107 | lines_removed++; |
107 | lines_removed++; |
108 | } |
108 | } |
109 | } |
109 | } |
110 | |
110 | |
111 | static void inspect_filepair(struct diff_filepair *pair) |
111 | static void inspect_filepair(struct diff_filepair *pair) |
112 | { |
112 | { |
113 | files++; |
113 | files++; |
114 | lines_added = 0; |
114 | lines_added = 0; |
115 | lines_removed = 0; |
115 | lines_removed = 0; |
116 | cgit_diff_files(pair->one->sha1, pair->two->sha1, count_diff_lines); |
116 | cgit_diff_files(pair->one->sha1, pair->two->sha1, count_diff_lines); |
117 | if (files >= slots) { |
117 | if (files >= slots) { |
118 | if (slots == 0) |
118 | if (slots == 0) |
119 | slots = 4; |
119 | slots = 4; |
120 | else |
120 | else |
121 | slots = slots * 2; |
121 | slots = slots * 2; |
122 | items = xrealloc(items, slots * sizeof(struct fileinfo)); |
122 | items = xrealloc(items, slots * sizeof(struct fileinfo)); |
123 | } |
123 | } |
124 | items[files-1].status = pair->status; |
124 | items[files-1].status = pair->status; |
125 | hashcpy(items[files-1].old_sha1, pair->one->sha1); |
125 | hashcpy(items[files-1].old_sha1, pair->one->sha1); |
126 | hashcpy(items[files-1].new_sha1, pair->two->sha1); |
126 | hashcpy(items[files-1].new_sha1, pair->two->sha1); |
127 | items[files-1].old_mode = pair->one->mode; |
127 | items[files-1].old_mode = pair->one->mode; |
128 | items[files-1].new_mode = pair->two->mode; |
128 | items[files-1].new_mode = pair->two->mode; |
129 | items[files-1].old_path = xstrdup(pair->one->path); |
129 | items[files-1].old_path = xstrdup(pair->one->path); |
130 | items[files-1].new_path = xstrdup(pair->two->path); |
130 | items[files-1].new_path = xstrdup(pair->two->path); |
131 | items[files-1].added = lines_added; |
131 | items[files-1].added = lines_added; |
132 | items[files-1].removed = lines_removed; |
132 | items[files-1].removed = lines_removed; |
133 | if (lines_added + lines_removed > max_changes) |
133 | if (lines_added + lines_removed > max_changes) |
134 | max_changes = lines_added + lines_removed; |
134 | max_changes = lines_added + lines_removed; |
135 | total_adds += lines_added; |
135 | total_adds += lines_added; |
136 | total_rems += lines_removed; |
136 | total_rems += lines_removed; |
137 | } |
137 | } |
138 | |
138 | |
139 | void cgit_print_diffstat(const unsigned char *old_sha1, |
139 | void cgit_print_diffstat(const unsigned char *old_sha1, |
140 | const unsigned char *new_sha1) |
140 | const unsigned char *new_sha1) |
141 | { |
141 | { |
142 | int i; |
142 | int i; |
143 | |
143 | |
144 | html("<div class='diffstat-header'>Diffstat</div>"); |
144 | html("<div class='diffstat-header'>"); |
| |
145 | cgit_diff_link("Diffstat", NULL, NULL, ctx.qry.head, ctx.qry.sha1, |
| |
146 | ctx.qry.sha2, NULL); |
| |
147 | html("</div>"); |
145 | html("<table summary='diffstat' class='diffstat'>"); |
148 | html("<table summary='diffstat' class='diffstat'>"); |
146 | max_changes = 0; |
149 | max_changes = 0; |
147 | cgit_diff_tree(old_sha1, new_sha1, inspect_filepair, NULL); |
150 | cgit_diff_tree(old_sha1, new_sha1, inspect_filepair, NULL); |
148 | for(i = 0; i<files; i++) |
151 | for(i = 0; i<files; i++) |
149 | print_fileinfo(&items[i]); |
152 | print_fileinfo(&items[i]); |
150 | html("</table>"); |
153 | html("</table>"); |
151 | html("<div class='diffstat-summary'>"); |
154 | html("<div class='diffstat-summary'>"); |
152 | htmlf("%d files changed, %d insertions, %d deletions", |
155 | htmlf("%d files changed, %d insertions, %d deletions", |
153 | files, total_adds, total_rems); |
156 | files, total_adds, total_rems); |
154 | html("</div>"); |
157 | html("</div>"); |
155 | } |
158 | } |
156 | |
159 | |
157 | |
160 | |
158 | /* |
161 | /* |
159 | * print a single line returned from xdiff |
162 | * print a single line returned from xdiff |
160 | */ |
163 | */ |
161 | static void print_line(char *line, int len) |
164 | static void print_line(char *line, int len) |
162 | { |
165 | { |
163 | char *class = "ctx"; |
166 | char *class = "ctx"; |
164 | char c = line[len-1]; |
167 | char c = line[len-1]; |
165 | |
168 | |
166 | if (line[0] == '+') |
169 | if (line[0] == '+') |
167 | class = "add"; |
170 | class = "add"; |
168 | else if (line[0] == '-') |
171 | else if (line[0] == '-') |
169 | class = "del"; |
172 | class = "del"; |
170 | else if (line[0] == '@') |
173 | else if (line[0] == '@') |
171 | class = "hunk"; |
174 | class = "hunk"; |
172 | |
175 | |
173 | htmlf("<div class='%s'>", class); |
176 | htmlf("<div class='%s'>", class); |
174 | line[len-1] = '\0'; |
177 | line[len-1] = '\0'; |
175 | html_txt(line); |
178 | html_txt(line); |
176 | html("</div>"); |
179 | html("</div>"); |
177 | line[len-1] = c; |
180 | line[len-1] = c; |
178 | } |
181 | } |
179 | |
182 | |
180 | static void header(unsigned char *sha1, char *path1, int mode1, |
183 | static void header(unsigned char *sha1, char *path1, int mode1, |
181 | unsigned char *sha2, char *path2, int mode2) |
184 | unsigned char *sha2, char *path2, int mode2) |
182 | { |
185 | { |
183 | char *abbrev1, *abbrev2; |
186 | char *abbrev1, *abbrev2; |
184 | int subproject; |
187 | int subproject; |
185 | |
188 | |
186 | subproject = (S_ISGITLINK(mode1) || S_ISGITLINK(mode2)); |
189 | subproject = (S_ISGITLINK(mode1) || S_ISGITLINK(mode2)); |
187 | html("<div class='head'>"); |
190 | html("<div class='head'>"); |
188 | html("diff --git a/"); |
191 | html("diff --git a/"); |
189 | html_txt(path1); |
192 | html_txt(path1); |
190 | html(" b/"); |
193 | html(" b/"); |
191 | html_txt(path2); |
194 | html_txt(path2); |
192 | |
195 | |
193 | if (is_null_sha1(sha1)) |
196 | if (is_null_sha1(sha1)) |
194 | path1 = "dev/null"; |
197 | path1 = "dev/null"; |
195 | if (is_null_sha1(sha2)) |
198 | if (is_null_sha1(sha2)) |
196 | path2 = "dev/null"; |
199 | path2 = "dev/null"; |
197 | |
200 | |
198 | if (mode1 == 0) |
201 | if (mode1 == 0) |
199 | htmlf("<br/>new file mode %.6o", mode2); |
202 | htmlf("<br/>new file mode %.6o", mode2); |
200 | |
203 | |
201 | if (mode2 == 0) |
204 | if (mode2 == 0) |
202 | htmlf("<br/>deleted file mode %.6o", mode1); |
205 | htmlf("<br/>deleted file mode %.6o", mode1); |
203 | |
206 | |
204 | if (!subproject) { |
207 | if (!subproject) { |
205 | abbrev1 = xstrdup(find_unique_abbrev(sha1, DEFAULT_ABBREV)); |
208 | abbrev1 = xstrdup(find_unique_abbrev(sha1, DEFAULT_ABBREV)); |
206 | abbrev2 = xstrdup(find_unique_abbrev(sha2, DEFAULT_ABBREV)); |
209 | abbrev2 = xstrdup(find_unique_abbrev(sha2, DEFAULT_ABBREV)); |
207 | htmlf("<br/>index %s..%s", abbrev1, abbrev2); |
210 | htmlf("<br/>index %s..%s", abbrev1, abbrev2); |
208 | free(abbrev1); |
211 | free(abbrev1); |
209 | free(abbrev2); |
212 | free(abbrev2); |
210 | if (mode1 != 0 && mode2 != 0) { |
213 | if (mode1 != 0 && mode2 != 0) { |
211 | htmlf(" %.6o", mode1); |
214 | htmlf(" %.6o", mode1); |
212 | if (mode2 != mode1) |
215 | if (mode2 != mode1) |
213 | htmlf("..%.6o", mode2); |
216 | htmlf("..%.6o", mode2); |
214 | } |
217 | } |
215 | html("<br/>--- a/"); |
218 | html("<br/>--- a/"); |
216 | if (mode1 != 0) |
219 | if (mode1 != 0) |
217 | cgit_tree_link(path1, NULL, NULL, ctx.qry.head, |
220 | cgit_tree_link(path1, NULL, NULL, ctx.qry.head, |
218 | sha1_to_hex(old_rev_sha1), path1); |
221 | sha1_to_hex(old_rev_sha1), path1); |
219 | else |
222 | else |
220 | html_txt(path1); |
223 | html_txt(path1); |
221 | html("<br/>+++ b/"); |
224 | html("<br/>+++ b/"); |
222 | if (mode2 != 0) |
225 | if (mode2 != 0) |
223 | cgit_tree_link(path2, NULL, NULL, ctx.qry.head, |
226 | cgit_tree_link(path2, NULL, NULL, ctx.qry.head, |
224 | sha1_to_hex(new_rev_sha1), path2); |
227 | sha1_to_hex(new_rev_sha1), path2); |
225 | else |
228 | else |
226 | html_txt(path2); |
229 | html_txt(path2); |
227 | } |
230 | } |
228 | html("</div>"); |
231 | html("</div>"); |
229 | } |
232 | } |
230 | |
233 | |
231 | static void filepair_cb(struct diff_filepair *pair) |
234 | static void filepair_cb(struct diff_filepair *pair) |
232 | { |
235 | { |
233 | header(pair->one->sha1, pair->one->path, pair->one->mode, |
236 | header(pair->one->sha1, pair->one->path, pair->one->mode, |
234 | pair->two->sha1, pair->two->path, pair->two->mode); |
237 | pair->two->sha1, pair->two->path, pair->two->mode); |
235 | if (S_ISGITLINK(pair->one->mode) || S_ISGITLINK(pair->two->mode)) { |
238 | if (S_ISGITLINK(pair->one->mode) || S_ISGITLINK(pair->two->mode)) { |
236 | if (S_ISGITLINK(pair->one->mode)) |
239 | if (S_ISGITLINK(pair->one->mode)) |
237 | print_line(fmt("-Subproject %s", sha1_to_hex(pair->one->sha1)), 52); |
240 | print_line(fmt("-Subproject %s", sha1_to_hex(pair->one->sha1)), 52); |
238 | if (S_ISGITLINK(pair->two->mode)) |
241 | if (S_ISGITLINK(pair->two->mode)) |
239 | print_line(fmt("+Subproject %s", sha1_to_hex(pair->two->sha1)), 52); |
242 | print_line(fmt("+Subproject %s", sha1_to_hex(pair->two->sha1)), 52); |
240 | return; |
243 | return; |
241 | } |
244 | } |
242 | if (cgit_diff_files(pair->one->sha1, pair->two->sha1, print_line)) |
245 | if (cgit_diff_files(pair->one->sha1, pair->two->sha1, print_line)) |
243 | cgit_print_error("Error running diff"); |
246 | cgit_print_error("Error running diff"); |
244 | } |
247 | } |
245 | |
248 | |
246 | void cgit_print_diff(const char *new_rev, const char *old_rev, const char *prefix) |
249 | void cgit_print_diff(const char *new_rev, const char *old_rev, const char *prefix) |
247 | { |
250 | { |
248 | enum object_type type; |
251 | enum object_type type; |
249 | unsigned long size; |
252 | unsigned long size; |
250 | struct commit *commit, *commit2; |
253 | struct commit *commit, *commit2; |
251 | |
254 | |
252 | if (!new_rev) |
255 | if (!new_rev) |
253 | new_rev = ctx.qry.head; |
256 | new_rev = ctx.qry.head; |
254 | get_sha1(new_rev, new_rev_sha1); |
257 | get_sha1(new_rev, new_rev_sha1); |
255 | type = sha1_object_info(new_rev_sha1, &size); |
258 | type = sha1_object_info(new_rev_sha1, &size); |
256 | if (type == OBJ_BAD) { |
259 | if (type == OBJ_BAD) { |
257 | cgit_print_error(fmt("Bad object name: %s", new_rev)); |
260 | cgit_print_error(fmt("Bad object name: %s", new_rev)); |
258 | return; |
261 | return; |
259 | } |
262 | } |
260 | commit = lookup_commit_reference(new_rev_sha1); |
263 | commit = lookup_commit_reference(new_rev_sha1); |
261 | if (!commit || parse_commit(commit)) |
264 | if (!commit || parse_commit(commit)) |
262 | cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(new_rev_sha1))); |
265 | cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(new_rev_sha1))); |
263 | |
266 | |
264 | if (old_rev) |
267 | if (old_rev) |
265 | get_sha1(old_rev, old_rev_sha1); |
268 | get_sha1(old_rev, old_rev_sha1); |
266 | else if (commit->parents && commit->parents->item) |
269 | else if (commit->parents && commit->parents->item) |
267 | hashcpy(old_rev_sha1, commit->parents->item->object.sha1); |
270 | hashcpy(old_rev_sha1, commit->parents->item->object.sha1); |
268 | else |
271 | else |
269 | hashclr(old_rev_sha1); |
272 | hashclr(old_rev_sha1); |
270 | |
273 | |
271 | if (!is_null_sha1(old_rev_sha1)) { |
274 | if (!is_null_sha1(old_rev_sha1)) { |
272 | type = sha1_object_info(old_rev_sha1, &size); |
275 | type = sha1_object_info(old_rev_sha1, &size); |
273 | if (type == OBJ_BAD) { |
276 | if (type == OBJ_BAD) { |
274 | cgit_print_error(fmt("Bad object name: %s", sha1_to_hex(old_rev_sha1))); |
277 | cgit_print_error(fmt("Bad object name: %s", sha1_to_hex(old_rev_sha1))); |
275 | return; |
278 | return; |
276 | } |
279 | } |
277 | commit2 = lookup_commit_reference(old_rev_sha1); |
280 | commit2 = lookup_commit_reference(old_rev_sha1); |
278 | if (!commit2 || parse_commit(commit2)) |
281 | if (!commit2 || parse_commit(commit2)) |
279 | cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(old_rev_sha1))); |
282 | cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(old_rev_sha1))); |
280 | } |
283 | } |
281 | cgit_print_diffstat(old_rev_sha1, new_rev_sha1); |
284 | cgit_print_diffstat(old_rev_sha1, new_rev_sha1); |
282 | |
285 | |
283 | html("<table summary='diff' class='diff'>"); |
286 | html("<table summary='diff' class='diff'>"); |
284 | html("<tr><td>"); |
287 | html("<tr><td>"); |
285 | cgit_diff_tree(old_rev_sha1, new_rev_sha1, filepair_cb, prefix); |
288 | cgit_diff_tree(old_rev_sha1, new_rev_sha1, filepair_cb, prefix); |
286 | html("</td></tr>"); |
289 | html("</td></tr>"); |
287 | html("</table>"); |
290 | html("</table>"); |
288 | } |
291 | } |
|