summaryrefslogtreecommitdiffabout
Unidiff
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--html.c16
-rw-r--r--html.h1
-rwxr-xr-xtests/setup.sh13
-rwxr-xr-xtests/t0101-index.sh2
-rwxr-xr-xtests/t0104-tree.sh12
-rw-r--r--ui-shared.c20
6 files changed, 53 insertions, 11 deletions
diff --git a/html.c b/html.c
index 36e9a2f..167127f 100644
--- a/html.c
+++ b/html.c
@@ -1,257 +1,273 @@
1/* html.c: helper functions for html output 1/* html.c: helper functions for html output
2 * 2 *
3 * Copyright (C) 2006 Lars Hjemli 3 * Copyright (C) 2006 Lars Hjemli
4 * 4 *
5 * Licensed under GNU General Public License v2 5 * Licensed under GNU General Public License v2
6 * (see COPYING for full license text) 6 * (see COPYING for full license text)
7 */ 7 */
8 8
9#include <unistd.h> 9#include <unistd.h>
10#include <stdio.h> 10#include <stdio.h>
11#include <stdlib.h> 11#include <stdlib.h>
12#include <stdarg.h> 12#include <stdarg.h>
13#include <string.h> 13#include <string.h>
14#include <errno.h> 14#include <errno.h>
15 15
16int htmlfd = STDOUT_FILENO; 16int htmlfd = STDOUT_FILENO;
17 17
18char *fmt(const char *format, ...) 18char *fmt(const char *format, ...)
19{ 19{
20 static char buf[8][1024]; 20 static char buf[8][1024];
21 static int bufidx; 21 static int bufidx;
22 int len; 22 int len;
23 va_list args; 23 va_list args;
24 24
25 bufidx++; 25 bufidx++;
26 bufidx &= 7; 26 bufidx &= 7;
27 27
28 va_start(args, format); 28 va_start(args, format);
29 len = vsnprintf(buf[bufidx], sizeof(buf[bufidx]), format, args); 29 len = vsnprintf(buf[bufidx], sizeof(buf[bufidx]), format, args);
30 va_end(args); 30 va_end(args);
31 if (len>sizeof(buf[bufidx])) { 31 if (len>sizeof(buf[bufidx])) {
32 fprintf(stderr, "[html.c] string truncated: %s\n", format); 32 fprintf(stderr, "[html.c] string truncated: %s\n", format);
33 exit(1); 33 exit(1);
34 } 34 }
35 return buf[bufidx]; 35 return buf[bufidx];
36} 36}
37 37
38void html_raw(const char *data, size_t size) 38void html_raw(const char *data, size_t size)
39{ 39{
40 write(htmlfd, data, size); 40 write(htmlfd, data, size);
41} 41}
42 42
43void html(const char *txt) 43void html(const char *txt)
44{ 44{
45 write(htmlfd, txt, strlen(txt)); 45 write(htmlfd, txt, strlen(txt));
46} 46}
47 47
48void htmlf(const char *format, ...) 48void htmlf(const char *format, ...)
49{ 49{
50 static char buf[65536]; 50 static char buf[65536];
51 va_list args; 51 va_list args;
52 52
53 va_start(args, format); 53 va_start(args, format);
54 vsnprintf(buf, sizeof(buf), format, args); 54 vsnprintf(buf, sizeof(buf), format, args);
55 va_end(args); 55 va_end(args);
56 html(buf); 56 html(buf);
57} 57}
58 58
59void html_status(int code, const char *msg, int more_headers) 59void html_status(int code, const char *msg, int more_headers)
60{ 60{
61 htmlf("Status: %d %s\n", code, msg); 61 htmlf("Status: %d %s\n", code, msg);
62 if (!more_headers) 62 if (!more_headers)
63 html("\n"); 63 html("\n");
64} 64}
65 65
66void html_txt(char *txt) 66void html_txt(char *txt)
67{ 67{
68 char *t = txt; 68 char *t = txt;
69 while(t && *t){ 69 while(t && *t){
70 int c = *t; 70 int c = *t;
71 if (c=='<' || c=='>' || c=='&') { 71 if (c=='<' || c=='>' || c=='&') {
72 write(htmlfd, txt, t - txt); 72 write(htmlfd, txt, t - txt);
73 if (c=='>') 73 if (c=='>')
74 html("&gt;"); 74 html("&gt;");
75 else if (c=='<') 75 else if (c=='<')
76 html("&lt;"); 76 html("&lt;");
77 else if (c=='&') 77 else if (c=='&')
78 html("&amp;"); 78 html("&amp;");
79 txt = t+1; 79 txt = t+1;
80 } 80 }
81 t++; 81 t++;
82 } 82 }
83 if (t!=txt) 83 if (t!=txt)
84 html(txt); 84 html(txt);
85} 85}
86 86
87void html_ntxt(int len, char *txt) 87void html_ntxt(int len, char *txt)
88{ 88{
89 char *t = txt; 89 char *t = txt;
90 while(t && *t && len--){ 90 while(t && *t && len--){
91 int c = *t; 91 int c = *t;
92 if (c=='<' || c=='>' || c=='&') { 92 if (c=='<' || c=='>' || c=='&') {
93 write(htmlfd, txt, t - txt); 93 write(htmlfd, txt, t - txt);
94 if (c=='>') 94 if (c=='>')
95 html("&gt;"); 95 html("&gt;");
96 else if (c=='<') 96 else if (c=='<')
97 html("&lt;"); 97 html("&lt;");
98 else if (c=='&') 98 else if (c=='&')
99 html("&amp;"); 99 html("&amp;");
100 txt = t+1; 100 txt = t+1;
101 } 101 }
102 t++; 102 t++;
103 } 103 }
104 if (t!=txt) 104 if (t!=txt)
105 write(htmlfd, txt, t - txt); 105 write(htmlfd, txt, t - txt);
106 if (len<0) 106 if (len<0)
107 html("..."); 107 html("...");
108} 108}
109 109
110void html_attr(char *txt) 110void html_attr(char *txt)
111{ 111{
112 char *t = txt; 112 char *t = txt;
113 while(t && *t){ 113 while(t && *t){
114 int c = *t; 114 int c = *t;
115 if (c=='<' || c=='>' || c=='\'') { 115 if (c=='<' || c=='>' || c=='\'') {
116 write(htmlfd, txt, t - txt); 116 write(htmlfd, txt, t - txt);
117 if (c=='>') 117 if (c=='>')
118 html("&gt;"); 118 html("&gt;");
119 else if (c=='<') 119 else if (c=='<')
120 html("&lt;"); 120 html("&lt;");
121 else if (c=='\'') 121 else if (c=='\'')
122 html("&quote;"); 122 html("&quote;");
123 txt = t+1; 123 txt = t+1;
124 } 124 }
125 t++; 125 t++;
126 } 126 }
127 if (t!=txt) 127 if (t!=txt)
128 html(txt); 128 html(txt);
129} 129}
130 130
131void html_url_arg(char *txt)
132{
133 char *t = txt;
134 while(t && *t){
135 int c = *t;
136 if (c=='"' || c=='#' || c=='%' || c=='&' || c=='\'' || c=='+' || c=='?') {
137 write(htmlfd, txt, t - txt);
138 write(htmlfd, fmt("%%%2x", c), 3);
139 txt = t+1;
140 }
141 t++;
142 }
143 if (t!=txt)
144 html(txt);
145}
146
131void html_hidden(char *name, char *value) 147void html_hidden(char *name, char *value)
132{ 148{
133 html("<input type='hidden' name='"); 149 html("<input type='hidden' name='");
134 html_attr(name); 150 html_attr(name);
135 html("' value='"); 151 html("' value='");
136 html_attr(value); 152 html_attr(value);
137 html("'/>"); 153 html("'/>");
138} 154}
139 155
140void html_option(char *value, char *text, char *selected_value) 156void html_option(char *value, char *text, char *selected_value)
141{ 157{
142 html("<option value='"); 158 html("<option value='");
143 html_attr(value); 159 html_attr(value);
144 html("'"); 160 html("'");
145 if (selected_value && !strcmp(selected_value, value)) 161 if (selected_value && !strcmp(selected_value, value))
146 html(" selected='selected'"); 162 html(" selected='selected'");
147 html(">"); 163 html(">");
148 html_txt(text); 164 html_txt(text);
149 html("</option>\n"); 165 html("</option>\n");
150} 166}
151 167
152void html_link_open(char *url, char *title, char *class) 168void html_link_open(char *url, char *title, char *class)
153{ 169{
154 html("<a href='"); 170 html("<a href='");
155 html_attr(url); 171 html_attr(url);
156 if (title) { 172 if (title) {
157 html("' title='"); 173 html("' title='");
158 html_attr(title); 174 html_attr(title);
159 } 175 }
160 if (class) { 176 if (class) {
161 html("' class='"); 177 html("' class='");
162 html_attr(class); 178 html_attr(class);
163 } 179 }
164 html("'>"); 180 html("'>");
165} 181}
166 182
167void html_link_close(void) 183void html_link_close(void)
168{ 184{
169 html("</a>"); 185 html("</a>");
170} 186}
171 187
172void html_fileperm(unsigned short mode) 188void html_fileperm(unsigned short mode)
173{ 189{
174 htmlf("%c%c%c", (mode & 4 ? 'r' : '-'), 190 htmlf("%c%c%c", (mode & 4 ? 'r' : '-'),
175 (mode & 2 ? 'w' : '-'), (mode & 1 ? 'x' : '-')); 191 (mode & 2 ? 'w' : '-'), (mode & 1 ? 'x' : '-'));
176} 192}
177 193
178int html_include(const char *filename) 194int html_include(const char *filename)
179{ 195{
180 FILE *f; 196 FILE *f;
181 char buf[4096]; 197 char buf[4096];
182 size_t len; 198 size_t len;
183 199
184 if (!(f = fopen(filename, "r"))) { 200 if (!(f = fopen(filename, "r"))) {
185 fprintf(stderr, "[cgit] Failed to include file %s: %s (%d).\n", 201 fprintf(stderr, "[cgit] Failed to include file %s: %s (%d).\n",
186 filename, strerror(errno), errno); 202 filename, strerror(errno), errno);
187 return -1; 203 return -1;
188 } 204 }
189 while((len = fread(buf, 1, 4096, f)) > 0) 205 while((len = fread(buf, 1, 4096, f)) > 0)
190 write(htmlfd, buf, len); 206 write(htmlfd, buf, len);
191 fclose(f); 207 fclose(f);
192 return 0; 208 return 0;
193} 209}
194 210
195int hextoint(char c) 211int hextoint(char c)
196{ 212{
197 if (c >= 'a' && c <= 'f') 213 if (c >= 'a' && c <= 'f')
198 return 10 + c - 'a'; 214 return 10 + c - 'a';
199 else if (c >= 'A' && c <= 'F') 215 else if (c >= 'A' && c <= 'F')
200 return 10 + c - 'A'; 216 return 10 + c - 'A';
201 else if (c >= '0' && c <= '9') 217 else if (c >= '0' && c <= '9')
202 return c - '0'; 218 return c - '0';
203 else 219 else
204 return -1; 220 return -1;
205} 221}
206 222
207char *convert_query_hexchar(char *txt) 223char *convert_query_hexchar(char *txt)
208{ 224{
209 int d1, d2; 225 int d1, d2;
210 if (strlen(txt) < 3) { 226 if (strlen(txt) < 3) {
211 *txt = '\0'; 227 *txt = '\0';
212 return txt-1; 228 return txt-1;
213 } 229 }
214 d1 = hextoint(*(txt+1)); 230 d1 = hextoint(*(txt+1));
215 d2 = hextoint(*(txt+2)); 231 d2 = hextoint(*(txt+2));
216 if (d1<0 || d2<0) { 232 if (d1<0 || d2<0) {
217 strcpy(txt, txt+3); 233 strcpy(txt, txt+3);
218 return txt-1; 234 return txt-1;
219 } else { 235 } else {
220 *txt = d1 * 16 + d2; 236 *txt = d1 * 16 + d2;
221 strcpy(txt+1, txt+3); 237 strcpy(txt+1, txt+3);
222 return txt; 238 return txt;
223 } 239 }
224} 240}
225 241
226int http_parse_querystring(char *txt, void (*fn)(const char *name, const char *value)) 242int http_parse_querystring(char *txt, void (*fn)(const char *name, const char *value))
227{ 243{
228 char *t, *value = NULL, c; 244 char *t, *value = NULL, c;
229 245
230 if (!txt) 246 if (!txt)
231 return 0; 247 return 0;
232 248
233 t = txt = strdup(txt); 249 t = txt = strdup(txt);
234 if (t == NULL) { 250 if (t == NULL) {
235 printf("Out of memory\n"); 251 printf("Out of memory\n");
236 exit(1); 252 exit(1);
237 } 253 }
238 while((c=*t) != '\0') { 254 while((c=*t) != '\0') {
239 if (c=='=') { 255 if (c=='=') {
240 *t = '\0'; 256 *t = '\0';
241 value = t+1; 257 value = t+1;
242 } else if (c=='+') { 258 } else if (c=='+') {
243 *t = ' '; 259 *t = ' ';
244 } else if (c=='%') { 260 } else if (c=='%') {
245 t = convert_query_hexchar(t); 261 t = convert_query_hexchar(t);
246 } else if (c=='&') { 262 } else if (c=='&') {
247 *t = '\0'; 263 *t = '\0';
248 (*fn)(txt, value); 264 (*fn)(txt, value);
249 txt = t+1; 265 txt = t+1;
250 value = NULL; 266 value = NULL;
251 } 267 }
252 t++; 268 t++;
253 } 269 }
254 if (t!=txt) 270 if (t!=txt)
255 (*fn)(txt, value); 271 (*fn)(txt, value);
256 return 0; 272 return 0;
257} 273}
diff --git a/html.h b/html.h
index 3c32935..038cf60 100644
--- a/html.h
+++ b/html.h
@@ -1,22 +1,23 @@
1#ifndef HTML_H 1#ifndef HTML_H
2#define HTML_H 2#define HTML_H
3 3
4extern int htmlfd; 4extern int htmlfd;
5 5
6extern void html_raw(const char *txt, size_t size); 6extern void html_raw(const char *txt, size_t size);
7extern void html(const char *txt); 7extern void html(const char *txt);
8extern void htmlf(const char *format,...); 8extern void htmlf(const char *format,...);
9extern void html_status(int code, const char *msg, int more_headers); 9extern void html_status(int code, const char *msg, int more_headers);
10extern void html_txt(char *txt); 10extern void html_txt(char *txt);
11extern void html_ntxt(int len, char *txt); 11extern void html_ntxt(int len, char *txt);
12extern void html_attr(char *txt); 12extern void html_attr(char *txt);
13extern void html_url_arg(char *txt);
13extern void html_hidden(char *name, char *value); 14extern void html_hidden(char *name, char *value);
14extern void html_option(char *value, char *text, char *selected_value); 15extern void html_option(char *value, char *text, char *selected_value);
15extern void html_link_open(char *url, char *title, char *class); 16extern void html_link_open(char *url, char *title, char *class);
16extern void html_link_close(void); 17extern void html_link_close(void);
17extern void html_fileperm(unsigned short mode); 18extern void html_fileperm(unsigned short mode);
18extern int html_include(const char *filename); 19extern int html_include(const char *filename);
19 20
20extern int http_parse_querystring(char *txt, void (*fn)(const char *name, const char *value)); 21extern int http_parse_querystring(char *txt, void (*fn)(const char *name, const char *value));
21 22
22#endif /* HTML_H */ 23#endif /* HTML_H */
diff --git a/tests/setup.sh b/tests/setup.sh
index e37306e..1457dd5 100755
--- a/tests/setup.sh
+++ b/tests/setup.sh
@@ -1,116 +1,127 @@
1# This file should be sourced by all test-scripts 1# This file should be sourced by all test-scripts
2# 2#
3# Main functions: 3# Main functions:
4# prepare_tests(description) - setup for testing, i.e. create repos+config 4# prepare_tests(description) - setup for testing, i.e. create repos+config
5# run_test(description, script) - run one test, i.e. eval script 5# run_test(description, script) - run one test, i.e. eval script
6# 6#
7# Helper functions 7# Helper functions
8# cgit_query(querystring) - call cgit with the specified querystring 8# cgit_query(querystring) - call cgit with the specified querystring
9# cgit_url(url) - call cgit with the specified virtual url 9# cgit_url(url) - call cgit with the specified virtual url
10# 10#
11# Example script: 11# Example script:
12# 12#
13# . setup.sh 13# . setup.sh
14# prepare_tests "html validation" 14# prepare_tests "html validation"
15# run_test 'repo index' 'cgit_url "/" | tidy -e' 15# run_test 'repo index' 'cgit_url "/" | tidy -e'
16# run_test 'repo summary' 'cgit_url "/foo" | tidy -e' 16# run_test 'repo summary' 'cgit_url "/foo" | tidy -e'
17 17
18 18
19mkrepo() { 19mkrepo() {
20 name=$1 20 name=$1
21 count=$2 21 count=$2
22 dir=$PWD 22 dir=$PWD
23 test -d $name && return 23 test -d $name && return
24 printf "Creating testrepo %s\n" $name 24 printf "Creating testrepo %s\n" $name
25 mkdir -p $name 25 mkdir -p $name
26 cd $name 26 cd $name
27 git init 27 git init
28 for ((n=1; n<=count; n++)) 28 for ((n=1; n<=count; n++))
29 do 29 do
30 echo $n >file-$n 30 echo $n >file-$n
31 git add file-$n 31 git add file-$n
32 git commit -m "commit $n" 32 git commit -m "commit $n"
33 done 33 done
34 if test "$3" = "testplus"
35 then
36 echo "hello" >a+b
37 git add a+b
38 git commit -m "add a+b"
39 git branch "1+2"
40 fi
34 cd $dir 41 cd $dir
35} 42}
36 43
37setup_repos() 44setup_repos()
38{ 45{
39 rm -rf trash/cache 46 rm -rf trash/cache
40 mkdir -p trash/cache 47 mkdir -p trash/cache
41 mkrepo trash/repos/foo 5 >/dev/null 48 mkrepo trash/repos/foo 5 >/dev/null
42 mkrepo trash/repos/bar 50 >/dev/null 49 mkrepo trash/repos/bar 50 >/dev/null
50 mkrepo trash/repos/foo+bar 10 testplus >/dev/null
43 cat >trash/cgitrc <<EOF 51 cat >trash/cgitrc <<EOF
44virtual-root=/ 52virtual-root=/
45cache-root=$PWD/trash/cache 53cache-root=$PWD/trash/cache
46 54
47cache-size=1021 55cache-size=1021
48snapshots=tar.gz tar.bz zip 56snapshots=tar.gz tar.bz zip
49enable-log-filecount=1 57enable-log-filecount=1
50enable-log-linecount=1 58enable-log-linecount=1
51summary-log=5 59summary-log=5
52summary-branches=5 60summary-branches=5
53summary-tags=5 61summary-tags=5
54 62
55repo.url=foo 63repo.url=foo
56repo.path=$PWD/trash/repos/foo/.git 64repo.path=$PWD/trash/repos/foo/.git
57# Do not specify a description for this repo, as it then will be assigned 65# Do not specify a description for this repo, as it then will be assigned
58# the constant value "[no description]" (which actually used to cause a 66# the constant value "[no description]" (which actually used to cause a
59# segfault). 67# segfault).
60 68
61repo.url=bar 69repo.url=bar
62repo.path=$PWD/trash/repos/bar/.git 70repo.path=$PWD/trash/repos/bar/.git
63repo.desc=the bar repo 71repo.desc=the bar repo
72
73repo.url=foo+bar
74repo.path=$PWD/trash/repos/foo+bar/.git
75repo.desc=the foo+bar repo
64EOF 76EOF
65} 77}
66 78
67prepare_tests() 79prepare_tests()
68{ 80{
69 setup_repos 81 setup_repos
70 rm -f test-output.log 2>/dev/null 82 rm -f test-output.log 2>/dev/null
71 test_count=0 83 test_count=0
72 test_failed=0 84 test_failed=0
73 echo "[$0]" "$@" >test-output.log 85 echo "[$0]" "$@" >test-output.log
74 echo "$@" "($0)" 86 echo "$@" "($0)"
75} 87}
76 88
77tests_done() 89tests_done()
78{ 90{
79 printf "\n" 91 printf "\n"
80 if test $test_failed -gt 0 92 if test $test_failed -gt 0
81 then 93 then
82 printf "test: *** %s failure(s), logfile=%s\n" \ 94 printf "test: *** %s failure(s), logfile=%s\n" \
83 $test_failed "$(pwd)/test-output.log" 95 $test_failed "$(pwd)/test-output.log"
84 false 96 false
85 fi 97 fi
86} 98}
87 99
88run_test() 100run_test()
89{ 101{
90 desc=$1 102 desc=$1
91 script=$2 103 script=$2
92 ((test_count++)) 104 ((test_count++))
93 printf "\ntest %d: name='%s'\n" $test_count "$desc" >>test-output.log 105 printf "\ntest %d: name='%s'\n" $test_count "$desc" >>test-output.log
94 printf "test %d: eval='%s'\n" $test_count "$2" >>test-output.log 106 printf "test %d: eval='%s'\n" $test_count "$2" >>test-output.log
95 eval "$2" >>test-output.log 2>>test-output.log 107 eval "$2" >>test-output.log 2>>test-output.log
96 res=$? 108 res=$?
97 printf "test %d: exitcode=%d\n" $test_count $res >>test-output.log 109 printf "test %d: exitcode=%d\n" $test_count $res >>test-output.log
98 if test $res = 0 110 if test $res = 0
99 then 111 then
100 printf " %2d) %-60s [ok]\n" $test_count "$desc" 112 printf " %2d) %-60s [ok]\n" $test_count "$desc"
101 else 113 else
102 ((test_failed++)) 114 ((test_failed++))
103 printf " %2d) %-60s [failed]\n" $test_count "$desc" 115 printf " %2d) %-60s [failed]\n" $test_count "$desc"
104 fi 116 fi
105} 117}
106 118
107cgit_query() 119cgit_query()
108{ 120{
109 CGIT_CONFIG="$PWD/trash/cgitrc" QUERY_STRING="$1" "$PWD/../cgit" 121 CGIT_CONFIG="$PWD/trash/cgitrc" QUERY_STRING="$1" "$PWD/../cgit"
110} 122}
111 123
112cgit_url() 124cgit_url()
113{ 125{
114 CGIT_CONFIG="$PWD/trash/cgitrc" QUERY_STRING="url=$1" "$PWD/../cgit" 126 CGIT_CONFIG="$PWD/trash/cgitrc" QUERY_STRING="url=$1" "$PWD/../cgit"
115} 127}
116
diff --git a/tests/t0101-index.sh b/tests/t0101-index.sh
index 445af6a..07e39f9 100755
--- a/tests/t0101-index.sh
+++ b/tests/t0101-index.sh
@@ -1,15 +1,17 @@
1#!/bin/sh 1#!/bin/sh
2 2
3. ./setup.sh 3. ./setup.sh
4 4
5prepare_tests "Check content on index page" 5prepare_tests "Check content on index page"
6 6
7run_test 'generate index page' 'cgit_url "" >trash/tmp' 7run_test 'generate index page' 'cgit_url "" >trash/tmp'
8run_test 'find foo repo' 'grep -e "foo" trash/tmp' 8run_test 'find foo repo' 'grep -e "foo" trash/tmp'
9run_test 'find foo description' 'grep -e "\[no description\]" trash/tmp' 9run_test 'find foo description' 'grep -e "\[no description\]" trash/tmp'
10run_test 'find bar repo' 'grep -e "bar" trash/tmp' 10run_test 'find bar repo' 'grep -e "bar" trash/tmp'
11run_test 'find bar description' 'grep -e "the bar repo" trash/tmp' 11run_test 'find bar description' 'grep -e "the bar repo" trash/tmp'
12run_test 'find foo+bar repo' 'grep -e ">foo+bar<" trash/tmp'
13run_test 'verify foo+bar link' 'grep -e "/foo+bar/" trash/tmp'
12run_test 'no tree-link' '! grep -e "foo/tree" trash/tmp' 14run_test 'no tree-link' '! grep -e "foo/tree" trash/tmp'
13run_test 'no log-link' '! grep -e "foo/log" trash/tmp' 15run_test 'no log-link' '! grep -e "foo/log" trash/tmp'
14 16
15tests_done 17tests_done
diff --git a/tests/t0104-tree.sh b/tests/t0104-tree.sh
index 2516c72..0d62cc8 100755
--- a/tests/t0104-tree.sh
+++ b/tests/t0104-tree.sh
@@ -1,21 +1,33 @@
1#!/bin/sh 1#!/bin/sh
2 2
3. ./setup.sh 3. ./setup.sh
4 4
5prepare_tests "Check content on tree page" 5prepare_tests "Check content on tree page"
6 6
7run_test 'generate bar/tree' 'cgit_url "bar/tree" >trash/tmp' 7run_test 'generate bar/tree' 'cgit_url "bar/tree" >trash/tmp'
8run_test 'find file-1' 'grep -e "file-1" trash/tmp' 8run_test 'find file-1' 'grep -e "file-1" trash/tmp'
9run_test 'find file-50' 'grep -e "file-50" trash/tmp' 9run_test 'find file-50' 'grep -e "file-50" trash/tmp'
10 10
11run_test 'generate bar/tree/file-50' 'cgit_url "bar/tree/file-50" >trash/tmp' 11run_test 'generate bar/tree/file-50' 'cgit_url "bar/tree/file-50" >trash/tmp'
12 12
13run_test 'find line 1' ' 13run_test 'find line 1' '
14 grep -e "<a id=.n1. name=.n1. href=.#n1.>1</a>" trash/tmp 14 grep -e "<a id=.n1. name=.n1. href=.#n1.>1</a>" trash/tmp
15' 15'
16 16
17run_test 'no line 2' ' 17run_test 'no line 2' '
18 grep -e "<a id=.n2. name=.n2. href=.#n2.>2</a>" trash/tmp 18 grep -e "<a id=.n2. name=.n2. href=.#n2.>2</a>" trash/tmp
19' 19'
20 20
21run_test 'generate foo+bar/tree' 'cgit_url "foo%2bbar/tree" >trash/tmp'
22
23run_test 'verify a+b link' '
24 grep -e "/foo+bar/tree/a+b" trash/tmp
25'
26
27run_test 'generate foo+bar/tree?h=1+2' 'cgit_url "foo%2bbar/tree&h=1%2b2" >trash/tmp'
28
29run_test 'verify a+b?h=1+2 link' '
30 grep -e "/foo+bar/tree/a+b?h=1%2b2" trash/tmp
31'
32
21tests_done 33tests_done
diff --git a/ui-shared.c b/ui-shared.c
index c23bc75..a2f636c 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -1,712 +1,712 @@
1/* ui-shared.c: common web output functions 1/* ui-shared.c: common web output functions
2 * 2 *
3 * Copyright (C) 2006 Lars Hjemli 3 * Copyright (C) 2006 Lars Hjemli
4 * 4 *
5 * Licensed under GNU General Public License v2 5 * Licensed under GNU General Public License v2
6 * (see COPYING for full license text) 6 * (see COPYING for full license text)
7 */ 7 */
8 8
9#include "cgit.h" 9#include "cgit.h"
10#include "cmd.h" 10#include "cmd.h"
11#include "html.h" 11#include "html.h"
12 12
13const char cgit_doctype[] = 13const char cgit_doctype[] =
14"<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Transitional//EN\"\n" 14"<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Transitional//EN\"\n"
15" \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\">\n"; 15" \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\">\n";
16 16
17static char *http_date(time_t t) 17static char *http_date(time_t t)
18{ 18{
19 static char day[][4] = 19 static char day[][4] =
20 {"Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat"}; 20 {"Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat"};
21 static char month[][4] = 21 static char month[][4] =
22 {"Jan", "Feb", "Mar", "Apr", "May", "Jun", 22 {"Jan", "Feb", "Mar", "Apr", "May", "Jun",
23 "Jul", "Aug", "Sep", "Oct", "Now", "Dec"}; 23 "Jul", "Aug", "Sep", "Oct", "Now", "Dec"};
24 struct tm *tm = gmtime(&t); 24 struct tm *tm = gmtime(&t);
25 return fmt("%s, %02d %s %04d %02d:%02d:%02d GMT", day[tm->tm_wday], 25 return fmt("%s, %02d %s %04d %02d:%02d:%02d GMT", day[tm->tm_wday],
26 tm->tm_mday, month[tm->tm_mon], 1900+tm->tm_year, 26 tm->tm_mday, month[tm->tm_mon], 1900+tm->tm_year,
27 tm->tm_hour, tm->tm_min, tm->tm_sec); 27 tm->tm_hour, tm->tm_min, tm->tm_sec);
28} 28}
29 29
30void cgit_print_error(char *msg) 30void cgit_print_error(char *msg)
31{ 31{
32 html("<div class='error'>"); 32 html("<div class='error'>");
33 html_txt(msg); 33 html_txt(msg);
34 html("</div>\n"); 34 html("</div>\n");
35} 35}
36 36
37char *cgit_hosturl() 37char *cgit_hosturl()
38{ 38{
39 char *host, *port; 39 char *host, *port;
40 40
41 host = getenv("HTTP_HOST"); 41 host = getenv("HTTP_HOST");
42 if (host) { 42 if (host) {
43 host = xstrdup(host); 43 host = xstrdup(host);
44 } else { 44 } else {
45 host = getenv("SERVER_NAME"); 45 host = getenv("SERVER_NAME");
46 if (!host) 46 if (!host)
47 return NULL; 47 return NULL;
48 port = getenv("SERVER_PORT"); 48 port = getenv("SERVER_PORT");
49 if (port && atoi(port) != 80) 49 if (port && atoi(port) != 80)
50 host = xstrdup(fmt("%s:%d", host, atoi(port))); 50 host = xstrdup(fmt("%s:%d", host, atoi(port)));
51 else 51 else
52 host = xstrdup(host); 52 host = xstrdup(host);
53 } 53 }
54 return host; 54 return host;
55} 55}
56 56
57char *cgit_rooturl() 57char *cgit_rooturl()
58{ 58{
59 if (ctx.cfg.virtual_root) 59 if (ctx.cfg.virtual_root)
60 return fmt("%s/", ctx.cfg.virtual_root); 60 return fmt("%s/", ctx.cfg.virtual_root);
61 else 61 else
62 return ctx.cfg.script_name; 62 return ctx.cfg.script_name;
63} 63}
64 64
65char *cgit_repourl(const char *reponame) 65char *cgit_repourl(const char *reponame)
66{ 66{
67 if (ctx.cfg.virtual_root) { 67 if (ctx.cfg.virtual_root) {
68 return fmt("%s/%s/", ctx.cfg.virtual_root, reponame); 68 return fmt("%s/%s/", ctx.cfg.virtual_root, reponame);
69 } else { 69 } else {
70 return fmt("?r=%s", reponame); 70 return fmt("?r=%s", reponame);
71 } 71 }
72} 72}
73 73
74char *cgit_fileurl(const char *reponame, const char *pagename, 74char *cgit_fileurl(const char *reponame, const char *pagename,
75 const char *filename, const char *query) 75 const char *filename, const char *query)
76{ 76{
77 char *tmp; 77 char *tmp;
78 char *delim; 78 char *delim;
79 79
80 if (ctx.cfg.virtual_root) { 80 if (ctx.cfg.virtual_root) {
81 tmp = fmt("%s/%s/%s/%s", ctx.cfg.virtual_root, reponame, 81 tmp = fmt("%s/%s/%s/%s", ctx.cfg.virtual_root, reponame,
82 pagename, (filename ? filename:"")); 82 pagename, (filename ? filename:""));
83 delim = "?"; 83 delim = "?";
84 } else { 84 } else {
85 tmp = fmt("?url=%s/%s/%s", reponame, pagename, 85 tmp = fmt("?url=%s/%s/%s", reponame, pagename,
86 (filename ? filename : "")); 86 (filename ? filename : ""));
87 delim = "&"; 87 delim = "&";
88 } 88 }
89 if (query) 89 if (query)
90 tmp = fmt("%s%s%s", tmp, delim, query); 90 tmp = fmt("%s%s%s", tmp, delim, query);
91 return tmp; 91 return tmp;
92} 92}
93 93
94char *cgit_pageurl(const char *reponame, const char *pagename, 94char *cgit_pageurl(const char *reponame, const char *pagename,
95 const char *query) 95 const char *query)
96{ 96{
97 return cgit_fileurl(reponame,pagename,0,query); 97 return cgit_fileurl(reponame,pagename,0,query);
98} 98}
99 99
100const char *cgit_repobasename(const char *reponame) 100const char *cgit_repobasename(const char *reponame)
101{ 101{
102 /* I assume we don't need to store more than one repo basename */ 102 /* I assume we don't need to store more than one repo basename */
103 static char rvbuf[1024]; 103 static char rvbuf[1024];
104 int p; 104 int p;
105 const char *rv; 105 const char *rv;
106 strncpy(rvbuf,reponame,sizeof(rvbuf)); 106 strncpy(rvbuf,reponame,sizeof(rvbuf));
107 if(rvbuf[sizeof(rvbuf)-1]) 107 if(rvbuf[sizeof(rvbuf)-1])
108 die("cgit_repobasename: truncated repository name '%s'", reponame); 108 die("cgit_repobasename: truncated repository name '%s'", reponame);
109 p = strlen(rvbuf)-1; 109 p = strlen(rvbuf)-1;
110 /* strip trailing slashes */ 110 /* strip trailing slashes */
111 while(p && rvbuf[p]=='/') rvbuf[p--]=0; 111 while(p && rvbuf[p]=='/') rvbuf[p--]=0;
112 /* strip trailing .git */ 112 /* strip trailing .git */
113 if(p>=3 && !strncmp(&rvbuf[p-3],".git",4)) { 113 if(p>=3 && !strncmp(&rvbuf[p-3],".git",4)) {
114 p -= 3; rvbuf[p--] = 0; 114 p -= 3; rvbuf[p--] = 0;
115 } 115 }
116 /* strip more trailing slashes if any */ 116 /* strip more trailing slashes if any */
117 while( p && rvbuf[p]=='/') rvbuf[p--]=0; 117 while( p && rvbuf[p]=='/') rvbuf[p--]=0;
118 /* find last slash in the remaining string */ 118 /* find last slash in the remaining string */
119 rv = strrchr(rvbuf,'/'); 119 rv = strrchr(rvbuf,'/');
120 if(rv) 120 if(rv)
121 return ++rv; 121 return ++rv;
122 return rvbuf; 122 return rvbuf;
123} 123}
124 124
125char *cgit_currurl() 125char *cgit_currurl()
126{ 126{
127 if (!ctx.cfg.virtual_root) 127 if (!ctx.cfg.virtual_root)
128 return ctx.cfg.script_name; 128 return ctx.cfg.script_name;
129 else if (ctx.qry.page) 129 else if (ctx.qry.page)
130 return fmt("%s/%s/%s/", ctx.cfg.virtual_root, ctx.qry.repo, ctx.qry.page); 130 return fmt("%s/%s/%s/", ctx.cfg.virtual_root, ctx.qry.repo, ctx.qry.page);
131 else if (ctx.qry.repo) 131 else if (ctx.qry.repo)
132 return fmt("%s/%s/", ctx.cfg.virtual_root, ctx.qry.repo); 132 return fmt("%s/%s/", ctx.cfg.virtual_root, ctx.qry.repo);
133 else 133 else
134 return fmt("%s/", ctx.cfg.virtual_root); 134 return fmt("%s/", ctx.cfg.virtual_root);
135} 135}
136 136
137static void site_url(char *page, char *search, int ofs) 137static void site_url(char *page, char *search, int ofs)
138{ 138{
139 char *delim = "?"; 139 char *delim = "?";
140 140
141 if (ctx.cfg.virtual_root) { 141 if (ctx.cfg.virtual_root) {
142 html_attr(ctx.cfg.virtual_root); 142 html_attr(ctx.cfg.virtual_root);
143 if (ctx.cfg.virtual_root[strlen(ctx.cfg.virtual_root) - 1] != '/') 143 if (ctx.cfg.virtual_root[strlen(ctx.cfg.virtual_root) - 1] != '/')
144 html("/"); 144 html("/");
145 } else 145 } else
146 html(ctx.cfg.script_name); 146 html(ctx.cfg.script_name);
147 147
148 if (page) { 148 if (page) {
149 htmlf("?p=%s", page); 149 htmlf("?p=%s", page);
150 delim = "&"; 150 delim = "&";
151 } 151 }
152 if (search) { 152 if (search) {
153 html(delim); 153 html(delim);
154 html("q="); 154 html("q=");
155 html_attr(search); 155 html_attr(search);
156 delim = "&"; 156 delim = "&";
157 } 157 }
158 if (ofs) { 158 if (ofs) {
159 html(delim); 159 html(delim);
160 htmlf("ofs=%d", ofs); 160 htmlf("ofs=%d", ofs);
161 } 161 }
162} 162}
163 163
164static void site_link(char *page, char *name, char *title, char *class, 164static void site_link(char *page, char *name, char *title, char *class,
165 char *search, int ofs) 165 char *search, int ofs)
166{ 166{
167 html("<a"); 167 html("<a");
168 if (title) { 168 if (title) {
169 html(" title='"); 169 html(" title='");
170 html_attr(title); 170 html_attr(title);
171 html("'"); 171 html("'");
172 } 172 }
173 if (class) { 173 if (class) {
174 html(" class='"); 174 html(" class='");
175 html_attr(class); 175 html_attr(class);
176 html("'"); 176 html("'");
177 } 177 }
178 html(" href='"); 178 html(" href='");
179 site_url(page, search, ofs); 179 site_url(page, search, ofs);
180 html("'>"); 180 html("'>");
181 html_txt(name); 181 html_txt(name);
182 html("</a>"); 182 html("</a>");
183} 183}
184 184
185void cgit_index_link(char *name, char *title, char *class, char *pattern, 185void cgit_index_link(char *name, char *title, char *class, char *pattern,
186 int ofs) 186 int ofs)
187{ 187{
188 site_link(NULL, name, title, class, pattern, ofs); 188 site_link(NULL, name, title, class, pattern, ofs);
189} 189}
190 190
191static char *repolink(char *title, char *class, char *page, char *head, 191static char *repolink(char *title, char *class, char *page, char *head,
192 char *path) 192 char *path)
193{ 193{
194 char *delim = "?"; 194 char *delim = "?";
195 195
196 html("<a"); 196 html("<a");
197 if (title) { 197 if (title) {
198 html(" title='"); 198 html(" title='");
199 html_attr(title); 199 html_attr(title);
200 html("'"); 200 html("'");
201 } 201 }
202 if (class) { 202 if (class) {
203 html(" class='"); 203 html(" class='");
204 html_attr(class); 204 html_attr(class);
205 html("'"); 205 html("'");
206 } 206 }
207 html(" href='"); 207 html(" href='");
208 if (ctx.cfg.virtual_root) { 208 if (ctx.cfg.virtual_root) {
209 html_attr(ctx.cfg.virtual_root); 209 html_attr(ctx.cfg.virtual_root);
210 if (ctx.cfg.virtual_root[strlen(ctx.cfg.virtual_root) - 1] != '/') 210 if (ctx.cfg.virtual_root[strlen(ctx.cfg.virtual_root) - 1] != '/')
211 html("/"); 211 html("/");
212 html_attr(ctx.repo->url); 212 html_attr(ctx.repo->url);
213 if (ctx.repo->url[strlen(ctx.repo->url) - 1] != '/') 213 if (ctx.repo->url[strlen(ctx.repo->url) - 1] != '/')
214 html("/"); 214 html("/");
215 if (page) { 215 if (page) {
216 html(page); 216 html(page);
217 html("/"); 217 html("/");
218 if (path) 218 if (path)
219 html_attr(path); 219 html_attr(path);
220 } 220 }
221 } else { 221 } else {
222 html(ctx.cfg.script_name); 222 html(ctx.cfg.script_name);
223 html("?url="); 223 html("?url=");
224 html_attr(ctx.repo->url); 224 html_url_arg(ctx.repo->url);
225 if (ctx.repo->url[strlen(ctx.repo->url) - 1] != '/') 225 if (ctx.repo->url[strlen(ctx.repo->url) - 1] != '/')
226 html("/"); 226 html("/");
227 if (page) { 227 if (page) {
228 html(page); 228 html_url_arg(page);
229 html("/"); 229 html("/");
230 if (path) 230 if (path)
231 html_attr(path); 231 html_url_arg(path);
232 } 232 }
233 delim = "&amp;"; 233 delim = "&amp;";
234 } 234 }
235 if (head && strcmp(head, ctx.repo->defbranch)) { 235 if (head && strcmp(head, ctx.repo->defbranch)) {
236 html(delim); 236 html(delim);
237 html("h="); 237 html("h=");
238 html_attr(head); 238 html_url_arg(head);
239 delim = "&amp;"; 239 delim = "&amp;";
240 } 240 }
241 return fmt("%s", delim); 241 return fmt("%s", delim);
242} 242}
243 243
244static void reporevlink(char *page, char *name, char *title, char *class, 244static void reporevlink(char *page, char *name, char *title, char *class,
245 char *head, char *rev, char *path) 245 char *head, char *rev, char *path)
246{ 246{
247 char *delim; 247 char *delim;
248 248
249 delim = repolink(title, class, page, head, path); 249 delim = repolink(title, class, page, head, path);
250 if (rev && strcmp(rev, ctx.qry.head)) { 250 if (rev && strcmp(rev, ctx.qry.head)) {
251 html(delim); 251 html(delim);
252 html("id="); 252 html("id=");
253 html_attr(rev); 253 html_url_arg(rev);
254 } 254 }
255 html("'>"); 255 html("'>");
256 html_txt(name); 256 html_txt(name);
257 html("</a>"); 257 html("</a>");
258} 258}
259 259
260void cgit_tree_link(char *name, char *title, char *class, char *head, 260void cgit_tree_link(char *name, char *title, char *class, char *head,
261 char *rev, char *path) 261 char *rev, char *path)
262{ 262{
263 reporevlink("tree", name, title, class, head, rev, path); 263 reporevlink("tree", name, title, class, head, rev, path);
264} 264}
265 265
266void cgit_plain_link(char *name, char *title, char *class, char *head, 266void cgit_plain_link(char *name, char *title, char *class, char *head,
267 char *rev, char *path) 267 char *rev, char *path)
268{ 268{
269 reporevlink("plain", name, title, class, head, rev, path); 269 reporevlink("plain", name, title, class, head, rev, path);
270} 270}
271 271
272void cgit_log_link(char *name, char *title, char *class, char *head, 272void cgit_log_link(char *name, char *title, char *class, char *head,
273 char *rev, char *path, int ofs, char *grep, char *pattern) 273 char *rev, char *path, int ofs, char *grep, char *pattern)
274{ 274{
275 char *delim; 275 char *delim;
276 276
277 delim = repolink(title, class, "log", head, path); 277 delim = repolink(title, class, "log", head, path);
278 if (rev && strcmp(rev, ctx.qry.head)) { 278 if (rev && strcmp(rev, ctx.qry.head)) {
279 html(delim); 279 html(delim);
280 html("id="); 280 html("id=");
281 html_attr(rev); 281 html_url_arg(rev);
282 delim = "&"; 282 delim = "&";
283 } 283 }
284 if (grep && pattern) { 284 if (grep && pattern) {
285 html(delim); 285 html(delim);
286 html("qt="); 286 html("qt=");
287 html_attr(grep); 287 html_url_arg(grep);
288 delim = "&"; 288 delim = "&";
289 html(delim); 289 html(delim);
290 html("q="); 290 html("q=");
291 html_attr(pattern); 291 html_url_arg(pattern);
292 } 292 }
293 if (ofs > 0) { 293 if (ofs > 0) {
294 html(delim); 294 html(delim);
295 html("ofs="); 295 html("ofs=");
296 htmlf("%d", ofs); 296 htmlf("%d", ofs);
297 } 297 }
298 html("'>"); 298 html("'>");
299 html_txt(name); 299 html_txt(name);
300 html("</a>"); 300 html("</a>");
301} 301}
302 302
303void cgit_commit_link(char *name, char *title, char *class, char *head, 303void cgit_commit_link(char *name, char *title, char *class, char *head,
304 char *rev) 304 char *rev)
305{ 305{
306 if (strlen(name) > ctx.cfg.max_msg_len && ctx.cfg.max_msg_len >= 15) { 306 if (strlen(name) > ctx.cfg.max_msg_len && ctx.cfg.max_msg_len >= 15) {
307 name[ctx.cfg.max_msg_len] = '\0'; 307 name[ctx.cfg.max_msg_len] = '\0';
308 name[ctx.cfg.max_msg_len - 1] = '.'; 308 name[ctx.cfg.max_msg_len - 1] = '.';
309 name[ctx.cfg.max_msg_len - 2] = '.'; 309 name[ctx.cfg.max_msg_len - 2] = '.';
310 name[ctx.cfg.max_msg_len - 3] = '.'; 310 name[ctx.cfg.max_msg_len - 3] = '.';
311 } 311 }
312 reporevlink("commit", name, title, class, head, rev, NULL); 312 reporevlink("commit", name, title, class, head, rev, NULL);
313} 313}
314 314
315void cgit_refs_link(char *name, char *title, char *class, char *head, 315void cgit_refs_link(char *name, char *title, char *class, char *head,
316 char *rev, char *path) 316 char *rev, char *path)
317{ 317{
318 reporevlink("refs", name, title, class, head, rev, path); 318 reporevlink("refs", name, title, class, head, rev, path);
319} 319}
320 320
321void cgit_snapshot_link(char *name, char *title, char *class, char *head, 321void cgit_snapshot_link(char *name, char *title, char *class, char *head,
322 char *rev, char *archivename) 322 char *rev, char *archivename)
323{ 323{
324 reporevlink("snapshot", name, title, class, head, rev, archivename); 324 reporevlink("snapshot", name, title, class, head, rev, archivename);
325} 325}
326 326
327void cgit_diff_link(char *name, char *title, char *class, char *head, 327void cgit_diff_link(char *name, char *title, char *class, char *head,
328 char *new_rev, char *old_rev, char *path) 328 char *new_rev, char *old_rev, char *path)
329{ 329{
330 char *delim; 330 char *delim;
331 331
332 delim = repolink(title, class, "diff", head, path); 332 delim = repolink(title, class, "diff", head, path);
333 if (new_rev && strcmp(new_rev, ctx.qry.head)) { 333 if (new_rev && strcmp(new_rev, ctx.qry.head)) {
334 html(delim); 334 html(delim);
335 html("id="); 335 html("id=");
336 html_attr(new_rev); 336 html_url_arg(new_rev);
337 delim = "&amp;"; 337 delim = "&amp;";
338 } 338 }
339 if (old_rev) { 339 if (old_rev) {
340 html(delim); 340 html(delim);
341 html("id2="); 341 html("id2=");
342 html_attr(old_rev); 342 html_url_arg(old_rev);
343 } 343 }
344 html("'>"); 344 html("'>");
345 html_txt(name); 345 html_txt(name);
346 html("</a>"); 346 html("</a>");
347} 347}
348 348
349void cgit_patch_link(char *name, char *title, char *class, char *head, 349void cgit_patch_link(char *name, char *title, char *class, char *head,
350 char *rev) 350 char *rev)
351{ 351{
352 reporevlink("patch", name, title, class, head, rev, NULL); 352 reporevlink("patch", name, title, class, head, rev, NULL);
353} 353}
354 354
355void cgit_object_link(struct object *obj) 355void cgit_object_link(struct object *obj)
356{ 356{
357 char *page, *arg, *url; 357 char *page, *arg, *url;
358 358
359 if (obj->type == OBJ_COMMIT) { 359 if (obj->type == OBJ_COMMIT) {
360 cgit_commit_link(fmt("commit %s", sha1_to_hex(obj->sha1)), NULL, NULL, 360 cgit_commit_link(fmt("commit %s", sha1_to_hex(obj->sha1)), NULL, NULL,
361 ctx.qry.head, sha1_to_hex(obj->sha1)); 361 ctx.qry.head, sha1_to_hex(obj->sha1));
362 return; 362 return;
363 } else if (obj->type == OBJ_TREE) { 363 } else if (obj->type == OBJ_TREE) {
364 page = "tree"; 364 page = "tree";
365 arg = "id"; 365 arg = "id";
366 } else if (obj->type == OBJ_TAG) { 366 } else if (obj->type == OBJ_TAG) {
367 page = "tag"; 367 page = "tag";
368 arg = "id"; 368 arg = "id";
369 } else { 369 } else {
370 page = "blob"; 370 page = "blob";
371 arg = "id"; 371 arg = "id";
372 } 372 }
373 373
374 url = cgit_pageurl(ctx.qry.repo, page, 374 url = cgit_pageurl(ctx.qry.repo, page,
375 fmt("%s=%s", arg, sha1_to_hex(obj->sha1))); 375 fmt("%s=%s", arg, sha1_to_hex(obj->sha1)));
376 html_link_open(url, NULL, NULL); 376 html_link_open(url, NULL, NULL);
377 htmlf("%s %s", typename(obj->type), 377 htmlf("%s %s", typename(obj->type),
378 sha1_to_hex(obj->sha1)); 378 sha1_to_hex(obj->sha1));
379 html_link_close(); 379 html_link_close();
380} 380}
381 381
382void cgit_print_date(time_t secs, char *format, int local_time) 382void cgit_print_date(time_t secs, char *format, int local_time)
383{ 383{
384 char buf[64]; 384 char buf[64];
385 struct tm *time; 385 struct tm *time;
386 386
387 if (!secs) 387 if (!secs)
388 return; 388 return;
389 if(local_time) 389 if(local_time)
390 time = localtime(&secs); 390 time = localtime(&secs);
391 else 391 else
392 time = gmtime(&secs); 392 time = gmtime(&secs);
393 strftime(buf, sizeof(buf)-1, format, time); 393 strftime(buf, sizeof(buf)-1, format, time);
394 html_txt(buf); 394 html_txt(buf);
395} 395}
396 396
397void cgit_print_age(time_t t, time_t max_relative, char *format) 397void cgit_print_age(time_t t, time_t max_relative, char *format)
398{ 398{
399 time_t now, secs; 399 time_t now, secs;
400 400
401 if (!t) 401 if (!t)
402 return; 402 return;
403 time(&now); 403 time(&now);
404 secs = now - t; 404 secs = now - t;
405 405
406 if (secs > max_relative && max_relative >= 0) { 406 if (secs > max_relative && max_relative >= 0) {
407 cgit_print_date(t, format, ctx.cfg.local_time); 407 cgit_print_date(t, format, ctx.cfg.local_time);
408 return; 408 return;
409 } 409 }
410 410
411 if (secs < TM_HOUR * 2) { 411 if (secs < TM_HOUR * 2) {
412 htmlf("<span class='age-mins'>%.0f min.</span>", 412 htmlf("<span class='age-mins'>%.0f min.</span>",
413 secs * 1.0 / TM_MIN); 413 secs * 1.0 / TM_MIN);
414 return; 414 return;
415 } 415 }
416 if (secs < TM_DAY * 2) { 416 if (secs < TM_DAY * 2) {
417 htmlf("<span class='age-hours'>%.0f hours</span>", 417 htmlf("<span class='age-hours'>%.0f hours</span>",
418 secs * 1.0 / TM_HOUR); 418 secs * 1.0 / TM_HOUR);
419 return; 419 return;
420 } 420 }
421 if (secs < TM_WEEK * 2) { 421 if (secs < TM_WEEK * 2) {
422 htmlf("<span class='age-days'>%.0f days</span>", 422 htmlf("<span class='age-days'>%.0f days</span>",
423 secs * 1.0 / TM_DAY); 423 secs * 1.0 / TM_DAY);
424 return; 424 return;
425 } 425 }
426 if (secs < TM_MONTH * 2) { 426 if (secs < TM_MONTH * 2) {
427 htmlf("<span class='age-weeks'>%.0f weeks</span>", 427 htmlf("<span class='age-weeks'>%.0f weeks</span>",
428 secs * 1.0 / TM_WEEK); 428 secs * 1.0 / TM_WEEK);
429 return; 429 return;
430 } 430 }
431 if (secs < TM_YEAR * 2) { 431 if (secs < TM_YEAR * 2) {
432 htmlf("<span class='age-months'>%.0f months</span>", 432 htmlf("<span class='age-months'>%.0f months</span>",
433 secs * 1.0 / TM_MONTH); 433 secs * 1.0 / TM_MONTH);
434 return; 434 return;
435 } 435 }
436 htmlf("<span class='age-years'>%.0f years</span>", 436 htmlf("<span class='age-years'>%.0f years</span>",
437 secs * 1.0 / TM_YEAR); 437 secs * 1.0 / TM_YEAR);
438} 438}
439 439
440void cgit_print_http_headers(struct cgit_context *ctx) 440void cgit_print_http_headers(struct cgit_context *ctx)
441{ 441{
442 if (ctx->page.mimetype && ctx->page.charset) 442 if (ctx->page.mimetype && ctx->page.charset)
443 htmlf("Content-Type: %s; charset=%s\n", ctx->page.mimetype, 443 htmlf("Content-Type: %s; charset=%s\n", ctx->page.mimetype,
444 ctx->page.charset); 444 ctx->page.charset);
445 else if (ctx->page.mimetype) 445 else if (ctx->page.mimetype)
446 htmlf("Content-Type: %s\n", ctx->page.mimetype); 446 htmlf("Content-Type: %s\n", ctx->page.mimetype);
447 if (ctx->page.size) 447 if (ctx->page.size)
448 htmlf("Content-Length: %ld\n", ctx->page.size); 448 htmlf("Content-Length: %ld\n", ctx->page.size);
449 if (ctx->page.filename) 449 if (ctx->page.filename)
450 htmlf("Content-Disposition: inline; filename=\"%s\"\n", 450 htmlf("Content-Disposition: inline; filename=\"%s\"\n",
451 ctx->page.filename); 451 ctx->page.filename);
452 htmlf("Last-Modified: %s\n", http_date(ctx->page.modified)); 452 htmlf("Last-Modified: %s\n", http_date(ctx->page.modified));
453 htmlf("Expires: %s\n", http_date(ctx->page.expires)); 453 htmlf("Expires: %s\n", http_date(ctx->page.expires));
454 html("\n"); 454 html("\n");
455} 455}
456 456
457void cgit_print_docstart(struct cgit_context *ctx) 457void cgit_print_docstart(struct cgit_context *ctx)
458{ 458{
459 char *host = cgit_hosturl(); 459 char *host = cgit_hosturl();
460 html(cgit_doctype); 460 html(cgit_doctype);
461 html("<html xmlns='http://www.w3.org/1999/xhtml' xml:lang='en' lang='en'>\n"); 461 html("<html xmlns='http://www.w3.org/1999/xhtml' xml:lang='en' lang='en'>\n");
462 html("<head>\n"); 462 html("<head>\n");
463 html("<title>"); 463 html("<title>");
464 html_txt(ctx->page.title); 464 html_txt(ctx->page.title);
465 html("</title>\n"); 465 html("</title>\n");
466 htmlf("<meta name='generator' content='cgit %s'/>\n", cgit_version); 466 htmlf("<meta name='generator' content='cgit %s'/>\n", cgit_version);
467 if (ctx->cfg.robots && *ctx->cfg.robots) 467 if (ctx->cfg.robots && *ctx->cfg.robots)
468 htmlf("<meta name='robots' content='%s'/>\n", ctx->cfg.robots); 468 htmlf("<meta name='robots' content='%s'/>\n", ctx->cfg.robots);
469 html("<link rel='stylesheet' type='text/css' href='"); 469 html("<link rel='stylesheet' type='text/css' href='");
470 html_attr(ctx->cfg.css); 470 html_attr(ctx->cfg.css);
471 html("'/>\n"); 471 html("'/>\n");
472 if (ctx->cfg.favicon) { 472 if (ctx->cfg.favicon) {
473 html("<link rel='shortcut icon' href='"); 473 html("<link rel='shortcut icon' href='");
474 html_attr(ctx->cfg.favicon); 474 html_attr(ctx->cfg.favicon);
475 html("'/>\n"); 475 html("'/>\n");
476 } 476 }
477 if (host && ctx->repo) { 477 if (host && ctx->repo) {
478 html("<link rel='alternate' title='Atom feed' href='http://"); 478 html("<link rel='alternate' title='Atom feed' href='http://");
479 html_attr(cgit_hosturl()); 479 html_attr(cgit_hosturl());
480 html_attr(cgit_fileurl(ctx->repo->url, "atom", ctx->qry.path, 480 html_attr(cgit_fileurl(ctx->repo->url, "atom", ctx->qry.path,
481 fmt("h=%s", ctx->qry.head))); 481 fmt("h=%s", ctx->qry.head)));
482 html("' type='application/atom+xml'/>"); 482 html("' type='application/atom+xml'/>");
483 } 483 }
484 html("</head>\n"); 484 html("</head>\n");
485 html("<body>\n"); 485 html("<body>\n");
486} 486}
487 487
488void cgit_print_docend() 488void cgit_print_docend()
489{ 489{
490 html("</div>"); 490 html("</div>");
491 if (ctx.cfg.footer) 491 if (ctx.cfg.footer)
492 html_include(ctx.cfg.footer); 492 html_include(ctx.cfg.footer);
493 else { 493 else {
494 html("<div class='footer'>generated "); 494 html("<div class='footer'>generated ");
495 cgit_print_date(time(NULL), FMT_LONGDATE, ctx.cfg.local_time); 495 cgit_print_date(time(NULL), FMT_LONGDATE, ctx.cfg.local_time);
496 htmlf(" by cgit %s", cgit_version); 496 htmlf(" by cgit %s", cgit_version);
497 html("</div>\n"); 497 html("</div>\n");
498 } 498 }
499 html("</body>\n</html>\n"); 499 html("</body>\n</html>\n");
500} 500}
501 501
502int print_branch_option(const char *refname, const unsigned char *sha1, 502int print_branch_option(const char *refname, const unsigned char *sha1,
503 int flags, void *cb_data) 503 int flags, void *cb_data)
504{ 504{
505 char *name = (char *)refname; 505 char *name = (char *)refname;
506 html_option(name, name, ctx.qry.head); 506 html_option(name, name, ctx.qry.head);
507 return 0; 507 return 0;
508} 508}
509 509
510int print_archive_ref(const char *refname, const unsigned char *sha1, 510int print_archive_ref(const char *refname, const unsigned char *sha1,
511 int flags, void *cb_data) 511 int flags, void *cb_data)
512{ 512{
513 struct tag *tag; 513 struct tag *tag;
514 struct taginfo *info; 514 struct taginfo *info;
515 struct object *obj; 515 struct object *obj;
516 char buf[256], *url; 516 char buf[256], *url;
517 unsigned char fileid[20]; 517 unsigned char fileid[20];
518 int *header = (int *)cb_data; 518 int *header = (int *)cb_data;
519 519
520 if (prefixcmp(refname, "refs/archives")) 520 if (prefixcmp(refname, "refs/archives"))
521 return 0; 521 return 0;
522 strncpy(buf, refname+14, sizeof(buf)); 522 strncpy(buf, refname+14, sizeof(buf));
523 obj = parse_object(sha1); 523 obj = parse_object(sha1);
524 if (!obj) 524 if (!obj)
525 return 1; 525 return 1;
526 if (obj->type == OBJ_TAG) { 526 if (obj->type == OBJ_TAG) {
527 tag = lookup_tag(sha1); 527 tag = lookup_tag(sha1);
528 if (!tag || parse_tag(tag) || !(info = cgit_parse_tag(tag))) 528 if (!tag || parse_tag(tag) || !(info = cgit_parse_tag(tag)))
529 return 0; 529 return 0;
530 hashcpy(fileid, tag->tagged->sha1); 530 hashcpy(fileid, tag->tagged->sha1);
531 } else if (obj->type != OBJ_BLOB) { 531 } else if (obj->type != OBJ_BLOB) {
532 return 0; 532 return 0;
533 } else { 533 } else {
534 hashcpy(fileid, sha1); 534 hashcpy(fileid, sha1);
535 } 535 }
536 if (!*header) { 536 if (!*header) {
537 html("<h1>download</h1>\n"); 537 html("<h1>download</h1>\n");
538 *header = 1; 538 *header = 1;
539 } 539 }
540 url = cgit_pageurl(ctx.qry.repo, "blob", 540 url = cgit_pageurl(ctx.qry.repo, "blob",
541 fmt("id=%s&amp;path=%s", sha1_to_hex(fileid), 541 fmt("id=%s&amp;path=%s", sha1_to_hex(fileid),
542 buf)); 542 buf));
543 html_link_open(url, NULL, "menu"); 543 html_link_open(url, NULL, "menu");
544 html_txt(strlpart(buf, 20)); 544 html_txt(strlpart(buf, 20));
545 html_link_close(); 545 html_link_close();
546 return 0; 546 return 0;
547} 547}
548 548
549void add_hidden_formfields(int incl_head, int incl_search, char *page) 549void add_hidden_formfields(int incl_head, int incl_search, char *page)
550{ 550{
551 char *url; 551 char *url;
552 552
553 if (!ctx.cfg.virtual_root) { 553 if (!ctx.cfg.virtual_root) {
554 url = fmt("%s/%s", ctx.qry.repo, page); 554 url = fmt("%s/%s", ctx.qry.repo, page);
555 if (ctx.qry.path) 555 if (ctx.qry.path)
556 url = fmt("%s/%s", url, ctx.qry.path); 556 url = fmt("%s/%s", url, ctx.qry.path);
557 html_hidden("url", url); 557 html_hidden("url", url);
558 } 558 }
559 559
560 if (incl_head && ctx.qry.head && ctx.repo->defbranch && 560 if (incl_head && ctx.qry.head && ctx.repo->defbranch &&
561 strcmp(ctx.qry.head, ctx.repo->defbranch)) 561 strcmp(ctx.qry.head, ctx.repo->defbranch))
562 html_hidden("h", ctx.qry.head); 562 html_hidden("h", ctx.qry.head);
563 563
564 if (ctx.qry.sha1) 564 if (ctx.qry.sha1)
565 html_hidden("id", ctx.qry.sha1); 565 html_hidden("id", ctx.qry.sha1);
566 if (ctx.qry.sha2) 566 if (ctx.qry.sha2)
567 html_hidden("id2", ctx.qry.sha2); 567 html_hidden("id2", ctx.qry.sha2);
568 568
569 if (incl_search) { 569 if (incl_search) {
570 if (ctx.qry.grep) 570 if (ctx.qry.grep)
571 html_hidden("qt", ctx.qry.grep); 571 html_hidden("qt", ctx.qry.grep);
572 if (ctx.qry.search) 572 if (ctx.qry.search)
573 html_hidden("q", ctx.qry.search); 573 html_hidden("q", ctx.qry.search);
574 } 574 }
575} 575}
576 576
577char *hc(struct cgit_cmd *cmd, const char *page) 577char *hc(struct cgit_cmd *cmd, const char *page)
578{ 578{
579 return (strcmp(cmd->name, page) ? NULL : "active"); 579 return (strcmp(cmd->name, page) ? NULL : "active");
580} 580}
581 581
582void cgit_print_pageheader(struct cgit_context *ctx) 582void cgit_print_pageheader(struct cgit_context *ctx)
583{ 583{
584 struct cgit_cmd *cmd = cgit_get_cmd(ctx); 584 struct cgit_cmd *cmd = cgit_get_cmd(ctx);
585 585
586 html("<table id='header'>\n"); 586 html("<table id='header'>\n");
587 html("<tr>\n"); 587 html("<tr>\n");
588 html("<td class='logo' rowspan='2'><a href='"); 588 html("<td class='logo' rowspan='2'><a href='");
589 if (ctx->cfg.logo_link) 589 if (ctx->cfg.logo_link)
590 html_attr(ctx->cfg.logo_link); 590 html_attr(ctx->cfg.logo_link);
591 else 591 else
592 html_attr(cgit_rooturl()); 592 html_attr(cgit_rooturl());
593 html("'><img src='"); 593 html("'><img src='");
594 html_attr(ctx->cfg.logo); 594 html_attr(ctx->cfg.logo);
595 html("' alt='cgit logo'/></a></td>\n"); 595 html("' alt='cgit logo'/></a></td>\n");
596 596
597 html("<td class='main'>"); 597 html("<td class='main'>");
598 if (ctx->repo) { 598 if (ctx->repo) {
599 cgit_index_link("index", NULL, NULL, NULL, 0); 599 cgit_index_link("index", NULL, NULL, NULL, 0);
600 html(" : "); 600 html(" : ");
601 reporevlink(NULL, ctx->repo->name, NULL, hc(cmd, "summary"), 601 reporevlink(NULL, ctx->repo->name, NULL, hc(cmd, "summary"),
602 ctx->qry.head, NULL, NULL); 602 ctx->qry.head, NULL, NULL);
603 html("</td><td class='form'>"); 603 html("</td><td class='form'>");
604 html("<form method='get' action=''>\n"); 604 html("<form method='get' action=''>\n");
605 add_hidden_formfields(0, 1, ctx->qry.page); 605 add_hidden_formfields(0, 1, ctx->qry.page);
606 html("<select name='h' onchange='this.form.submit();'>\n"); 606 html("<select name='h' onchange='this.form.submit();'>\n");
607 for_each_branch_ref(print_branch_option, ctx->qry.head); 607 for_each_branch_ref(print_branch_option, ctx->qry.head);
608 html("</select> "); 608 html("</select> ");
609 html("<input type='submit' name='' value='switch'/>"); 609 html("<input type='submit' name='' value='switch'/>");
610 html("</form>"); 610 html("</form>");
611 } else 611 } else
612 html_txt(ctx->cfg.root_title); 612 html_txt(ctx->cfg.root_title);
613 html("</td></tr>\n"); 613 html("</td></tr>\n");
614 614
615 html("<tr><td class='sub'>"); 615 html("<tr><td class='sub'>");
616 if (ctx->repo) { 616 if (ctx->repo) {
617 html_txt(ctx->repo->desc); 617 html_txt(ctx->repo->desc);
618 html("</td><td class='sub right'>"); 618 html("</td><td class='sub right'>");
619 html_txt(ctx->repo->owner); 619 html_txt(ctx->repo->owner);
620 } else { 620 } else {
621 if (ctx->cfg.root_desc) 621 if (ctx->cfg.root_desc)
622 html_txt(ctx->cfg.root_desc); 622 html_txt(ctx->cfg.root_desc);
623 else if (ctx->cfg.index_info) 623 else if (ctx->cfg.index_info)
624 html_include(ctx->cfg.index_info); 624 html_include(ctx->cfg.index_info);
625 } 625 }
626 html("</td></tr></table>\n"); 626 html("</td></tr></table>\n");
627 627
628 html("<table class='tabs'><tr><td>\n"); 628 html("<table class='tabs'><tr><td>\n");
629 if (ctx->repo) { 629 if (ctx->repo) {
630 reporevlink(NULL, "summary", NULL, hc(cmd, "summary"), 630 reporevlink(NULL, "summary", NULL, hc(cmd, "summary"),
631 ctx->qry.head, NULL, NULL); 631 ctx->qry.head, NULL, NULL);
632 cgit_refs_link("refs", NULL, hc(cmd, "refs"), ctx->qry.head, 632 cgit_refs_link("refs", NULL, hc(cmd, "refs"), ctx->qry.head,
633 ctx->qry.sha1, NULL); 633 ctx->qry.sha1, NULL);
634 cgit_log_link("log", NULL, hc(cmd, "log"), ctx->qry.head, 634 cgit_log_link("log", NULL, hc(cmd, "log"), ctx->qry.head,
635 NULL, NULL, 0, NULL, NULL); 635 NULL, NULL, 0, NULL, NULL);
636 cgit_tree_link("tree", NULL, hc(cmd, "tree"), ctx->qry.head, 636 cgit_tree_link("tree", NULL, hc(cmd, "tree"), ctx->qry.head,
637 ctx->qry.sha1, NULL); 637 ctx->qry.sha1, NULL);
638 cgit_commit_link("commit", NULL, hc(cmd, "commit"), 638 cgit_commit_link("commit", NULL, hc(cmd, "commit"),
639 ctx->qry.head, ctx->qry.sha1); 639 ctx->qry.head, ctx->qry.sha1);
640 cgit_diff_link("diff", NULL, hc(cmd, "diff"), ctx->qry.head, 640 cgit_diff_link("diff", NULL, hc(cmd, "diff"), ctx->qry.head,
641 ctx->qry.sha1, ctx->qry.sha2, NULL); 641 ctx->qry.sha1, ctx->qry.sha2, NULL);
642 if (ctx->repo->readme) 642 if (ctx->repo->readme)
643 reporevlink("about", "about", NULL, 643 reporevlink("about", "about", NULL,
644 hc(cmd, "about"), ctx->qry.head, NULL, 644 hc(cmd, "about"), ctx->qry.head, NULL,
645 NULL); 645 NULL);
646 html("</td><td class='form'>"); 646 html("</td><td class='form'>");
647 html("<form class='right' method='get' action='"); 647 html("<form class='right' method='get' action='");
648 if (ctx->cfg.virtual_root) 648 if (ctx->cfg.virtual_root)
649 html_attr(cgit_fileurl(ctx->qry.repo, "log", 649 html_attr(cgit_fileurl(ctx->qry.repo, "log",
650 ctx->qry.path, NULL)); 650 ctx->qry.path, NULL));
651 html("'>\n"); 651 html("'>\n");
652 add_hidden_formfields(1, 0, "log"); 652 add_hidden_formfields(1, 0, "log");
653 html("<select name='qt'>\n"); 653 html("<select name='qt'>\n");
654 html_option("grep", "log msg", ctx->qry.grep); 654 html_option("grep", "log msg", ctx->qry.grep);
655 html_option("author", "author", ctx->qry.grep); 655 html_option("author", "author", ctx->qry.grep);
656 html_option("committer", "committer", ctx->qry.grep); 656 html_option("committer", "committer", ctx->qry.grep);
657 html("</select>\n"); 657 html("</select>\n");
658 html("<input class='txt' type='text' size='10' name='q' value='"); 658 html("<input class='txt' type='text' size='10' name='q' value='");
659 html_attr(ctx->qry.search); 659 html_attr(ctx->qry.search);
660 html("'/>\n"); 660 html("'/>\n");
661 html("<input type='submit' value='search'/>\n"); 661 html("<input type='submit' value='search'/>\n");
662 html("</form>\n"); 662 html("</form>\n");
663 } else { 663 } else {
664 site_link(NULL, "index", NULL, hc(cmd, "repolist"), NULL, 0); 664 site_link(NULL, "index", NULL, hc(cmd, "repolist"), NULL, 0);
665 if (ctx->cfg.root_readme) 665 if (ctx->cfg.root_readme)
666 site_link("about", "about", NULL, hc(cmd, "about"), 666 site_link("about", "about", NULL, hc(cmd, "about"),
667 NULL, 0); 667 NULL, 0);
668 html("</td><td class='form'>"); 668 html("</td><td class='form'>");
669 html("<form method='get' action='"); 669 html("<form method='get' action='");
670 html_attr(cgit_rooturl()); 670 html_attr(cgit_rooturl());
671 html("'>\n"); 671 html("'>\n");
672 html("<input type='text' name='q' size='10' value='"); 672 html("<input type='text' name='q' size='10' value='");
673 html_attr(ctx->qry.search); 673 html_attr(ctx->qry.search);
674 html("'/>\n"); 674 html("'/>\n");
675 html("<input type='submit' value='search'/>\n"); 675 html("<input type='submit' value='search'/>\n");
676 html("</form>"); 676 html("</form>");
677 } 677 }
678 html("</td></tr></table>\n"); 678 html("</td></tr></table>\n");
679 html("<div class='content'>"); 679 html("<div class='content'>");
680} 680}
681 681
682void cgit_print_filemode(unsigned short mode) 682void cgit_print_filemode(unsigned short mode)
683{ 683{
684 if (S_ISDIR(mode)) 684 if (S_ISDIR(mode))
685 html("d"); 685 html("d");
686 else if (S_ISLNK(mode)) 686 else if (S_ISLNK(mode))
687 html("l"); 687 html("l");
688 else if (S_ISGITLINK(mode)) 688 else if (S_ISGITLINK(mode))
689 html("m"); 689 html("m");
690 else 690 else
691 html("-"); 691 html("-");
692 html_fileperm(mode >> 6); 692 html_fileperm(mode >> 6);
693 html_fileperm(mode >> 3); 693 html_fileperm(mode >> 3);
694 html_fileperm(mode); 694 html_fileperm(mode);
695} 695}
696 696
697void cgit_print_snapshot_links(const char *repo, const char *head, 697void cgit_print_snapshot_links(const char *repo, const char *head,
698 const char *hex, int snapshots) 698 const char *hex, int snapshots)
699{ 699{
700 const struct cgit_snapshot_format* f; 700 const struct cgit_snapshot_format* f;
701 char *filename; 701 char *filename;
702 702
703 for (f = cgit_snapshot_formats; f->suffix; f++) { 703 for (f = cgit_snapshot_formats; f->suffix; f++) {
704 if (!(snapshots & f->bit)) 704 if (!(snapshots & f->bit))
705 continue; 705 continue;
706 filename = fmt("%s-%s%s", cgit_repobasename(repo), hex, 706 filename = fmt("%s-%s%s", cgit_repobasename(repo), hex,
707 f->suffix); 707 f->suffix);
708 cgit_snapshot_link(filename, NULL, NULL, (char *)head, 708 cgit_snapshot_link(filename, NULL, NULL, (char *)head,
709 (char *)hex, filename); 709 (char *)hex, filename);
710 html("<br/>"); 710 html("<br/>");
711 } 711 }
712} 712}