|
diff --git a/shared.c b/shared.c index a27ab30..9362d21 100644 --- a/ shared.c+++ b/ shared.c |
|
@@ -355,68 +355,70 @@ int cgit_parse_snapshots_mask(const char *str) |
355 | break; |
355 | break; |
356 | } |
356 | } |
357 | } |
357 | } |
358 | str += tl; |
358 | str += tl; |
359 | } |
359 | } |
360 | return rv; |
360 | return rv; |
361 | } |
361 | } |
362 | |
362 | |
363 | int cgit_open_filter(struct cgit_filter *filter) |
363 | int cgit_open_filter(struct cgit_filter *filter) |
364 | { |
364 | { |
365 | |
365 | |
366 | filter->old_stdout = chk_positive(dup(STDOUT_FILENO), |
366 | filter->old_stdout = chk_positive(dup(STDOUT_FILENO), |
367 | "Unable to duplicate STDOUT"); |
367 | "Unable to duplicate STDOUT"); |
368 | chk_zero(pipe(filter->pipe_fh), "Unable to create pipe to subprocess"); |
368 | chk_zero(pipe(filter->pipe_fh), "Unable to create pipe to subprocess"); |
369 | filter->pid = chk_non_negative(fork(), "Unable to create subprocess"); |
369 | filter->pid = chk_non_negative(fork(), "Unable to create subprocess"); |
370 | if (filter->pid == 0) { |
370 | if (filter->pid == 0) { |
371 | close(filter->pipe_fh[1]); |
371 | close(filter->pipe_fh[1]); |
372 | chk_non_negative(dup2(filter->pipe_fh[0], STDIN_FILENO), |
372 | chk_non_negative(dup2(filter->pipe_fh[0], STDIN_FILENO), |
373 | "Unable to use pipe as STDIN"); |
373 | "Unable to use pipe as STDIN"); |
374 | execvp(filter->cmd, filter->argv); |
374 | execvp(filter->cmd, filter->argv); |
375 | die("Unable to exec subprocess %s: %s (%d)", filter->cmd, |
375 | die("Unable to exec subprocess %s: %s (%d)", filter->cmd, |
376 | strerror(errno), errno); |
376 | strerror(errno), errno); |
377 | } |
377 | } |
378 | close(filter->pipe_fh[0]); |
378 | close(filter->pipe_fh[0]); |
379 | chk_non_negative(dup2(filter->pipe_fh[1], STDOUT_FILENO), |
379 | chk_non_negative(dup2(filter->pipe_fh[1], STDOUT_FILENO), |
380 | "Unable to use pipe as STDOUT"); |
380 | "Unable to use pipe as STDOUT"); |
381 | close(filter->pipe_fh[1]); |
381 | close(filter->pipe_fh[1]); |
382 | return 0; |
382 | return 0; |
383 | } |
383 | } |
384 | |
384 | |
385 | int cgit_close_filter(struct cgit_filter *filter) |
385 | int cgit_close_filter(struct cgit_filter *filter) |
386 | { |
386 | { |
387 | chk_non_negative(dup2(filter->old_stdout, STDOUT_FILENO), |
387 | chk_non_negative(dup2(filter->old_stdout, STDOUT_FILENO), |
388 | "Unable to restore STDOUT"); |
388 | "Unable to restore STDOUT"); |
389 | close(filter->old_stdout); |
389 | close(filter->old_stdout); |
390 | if (filter->pid < 0) |
390 | if (filter->pid < 0) |
391 | return 0; |
391 | return 0; |
392 | waitpid(filter->pid, &filter->exitstatus, 0); |
392 | waitpid(filter->pid, &filter->exitstatus, 0); |
393 | if (WIFEXITED(filter->exitstatus) && !WEXITSTATUS(filter->exitstatus)) |
393 | if (WIFEXITED(filter->exitstatus) && !WEXITSTATUS(filter->exitstatus)) |
394 | return 0; |
394 | return 0; |
395 | die("Subprocess %s exited abnormally", filter->cmd); |
395 | die("Subprocess %s exited abnormally", filter->cmd); |
396 | } |
396 | } |
397 | |
397 | |
398 | /* Read the content of the specified file into a newly allocated buffer, |
398 | /* Read the content of the specified file into a newly allocated buffer, |
399 | * zeroterminate the buffer and return 0 on success, errno otherwise. |
399 | * zeroterminate the buffer and return 0 on success, errno otherwise. |
400 | */ |
400 | */ |
401 | int readfile(const char *path, char **buf, size_t *size) |
401 | int readfile(const char *path, char **buf, size_t *size) |
402 | { |
402 | { |
403 | int fd; |
403 | int fd, e; |
404 | struct stat st; |
404 | struct stat st; |
405 | |
405 | |
406 | fd = open(path, O_RDONLY); |
406 | fd = open(path, O_RDONLY); |
407 | if (fd == -1) |
407 | if (fd == -1) |
408 | return errno; |
408 | return errno; |
409 | if (fstat(fd, &st)) { |
409 | if (fstat(fd, &st)) { |
| |
410 | e = errno; |
410 | close(fd); |
411 | close(fd); |
411 | return errno; |
412 | return e; |
412 | } |
413 | } |
413 | if (!S_ISREG(st.st_mode)) { |
414 | if (!S_ISREG(st.st_mode)) { |
414 | close(fd); |
415 | close(fd); |
415 | return EISDIR; |
416 | return EISDIR; |
416 | } |
417 | } |
417 | *buf = xmalloc(st.st_size + 1); |
418 | *buf = xmalloc(st.st_size + 1); |
418 | *size = read_in_full(fd, *buf, st.st_size); |
419 | *size = read_in_full(fd, *buf, st.st_size); |
| |
420 | e = errno; |
419 | (*buf)[*size] = '\0'; |
421 | (*buf)[*size] = '\0'; |
420 | close(fd); |
422 | close(fd); |
421 | return (*size == st.st_size ? 0 : errno); |
423 | return (*size == st.st_size ? 0 : e); |
422 | } |
424 | } |
|