summaryrefslogtreecommitdiffabout
Unidiff
Diffstat (more/less context) (ignore whitespace changes)
-rwxr-xr-xtests/t0108-patch.sh37
-rw-r--r--ui-patch.c6
2 files changed, 42 insertions, 1 deletions
diff --git a/tests/t0108-patch.sh b/tests/t0108-patch.sh
new file mode 100755
index 0000000..33351d6
--- a/dev/null
+++ b/tests/t0108-patch.sh
@@ -0,0 +1,37 @@
1#!/bin/sh
2
3. ./setup.sh
4
5prepare_tests "Check content on patch page"
6
7run_test 'generate foo/patch' '
8 cgit_query "url=foo/patch" >trash/tmp
9'
10
11run_test 'find `From:` line' '
12 grep -e "^From: " trash/tmp
13'
14
15run_test 'find `Date:` line' '
16 grep -e "^Date: " trash/tmp
17'
18
19run_test 'find `Subject:` line' '
20 grep -e "^Subject: commit 5" trash/tmp
21'
22
23run_test 'find `cgit` signature' '
24 tail -1 trash/tmp | grep -e "^cgit"
25'
26
27run_test 'find initial commit' '
28 root=$(git --git-dir=$PWD/trash/repos/foo/.git rev-list HEAD | tail -1)
29'
30
31run_test 'generate patch for initial commit' '
32 cgit_query "url=foo/patch&id=$root" >trash/tmp
33'
34
35run_test 'find `cgit` signature' '
36 tail -1 trash/tmp | grep -e "^cgit"
37'
diff --git a/ui-patch.c b/ui-patch.c
index e7a010a..7ee2c41 100644
--- a/ui-patch.c
+++ b/ui-patch.c
@@ -43,68 +43,72 @@ static void header(unsigned char *sha1, char *path1, int mode1,
43 htmlf("index %s..%s", abbrev1, abbrev2); 43 htmlf("index %s..%s", abbrev1, abbrev2);
44 free(abbrev1); 44 free(abbrev1);
45 free(abbrev2); 45 free(abbrev2);
46 if (mode1 != 0 && mode2 != 0) { 46 if (mode1 != 0 && mode2 != 0) {
47 htmlf(" %.6o", mode1); 47 htmlf(" %.6o", mode1);
48 if (mode2 != mode1) 48 if (mode2 != mode1)
49 htmlf("..%.6o", mode2); 49 htmlf("..%.6o", mode2);
50 } 50 }
51 htmlf("\n--- a/%s\n", path1); 51 htmlf("\n--- a/%s\n", path1);
52 htmlf("+++ b/%s\n", path2); 52 htmlf("+++ b/%s\n", path2);
53 } 53 }
54} 54}
55 55
56static void filepair_cb(struct diff_filepair *pair) 56static void filepair_cb(struct diff_filepair *pair)
57{ 57{
58 header(pair->one->sha1, pair->one->path, pair->one->mode, 58 header(pair->one->sha1, pair->one->path, pair->one->mode,
59 pair->two->sha1, pair->two->path, pair->two->mode); 59 pair->two->sha1, pair->two->path, pair->two->mode);
60 if (S_ISGITLINK(pair->one->mode) || S_ISGITLINK(pair->two->mode)) { 60 if (S_ISGITLINK(pair->one->mode) || S_ISGITLINK(pair->two->mode)) {
61 if (S_ISGITLINK(pair->one->mode)) 61 if (S_ISGITLINK(pair->one->mode))
62 print_line(fmt("-Subproject %s", sha1_to_hex(pair->one->sha1)), 52); 62 print_line(fmt("-Subproject %s", sha1_to_hex(pair->one->sha1)), 52);
63 if (S_ISGITLINK(pair->two->mode)) 63 if (S_ISGITLINK(pair->two->mode))
64 print_line(fmt("+Subproject %s", sha1_to_hex(pair->two->sha1)), 52); 64 print_line(fmt("+Subproject %s", sha1_to_hex(pair->two->sha1)), 52);
65 return; 65 return;
66 } 66 }
67 if (cgit_diff_files(pair->one->sha1, pair->two->sha1, print_line)) 67 if (cgit_diff_files(pair->one->sha1, pair->two->sha1, print_line))
68 html("Error running diff"); 68 html("Error running diff");
69} 69}
70 70
71void cgit_print_patch(char *hex, struct cacheitem *item) 71void cgit_print_patch(char *hex, struct cacheitem *item)
72{ 72{
73 struct commit *commit; 73 struct commit *commit;
74 struct commitinfo *info; 74 struct commitinfo *info;
75 unsigned char sha1[20], old_sha1[20]; 75 unsigned char sha1[20], old_sha1[20];
76 char *patchname; 76 char *patchname;
77 77
78 if (!hex) 78 if (!hex)
79 hex = cgit_query_head; 79 hex = cgit_query_head;
80 80
81 if (get_sha1(hex, sha1)) { 81 if (get_sha1(hex, sha1)) {
82 cgit_print_error(fmt("Bad object id: %s", hex)); 82 cgit_print_error(fmt("Bad object id: %s", hex));
83 return; 83 return;
84 } 84 }
85 commit = lookup_commit_reference(sha1); 85 commit = lookup_commit_reference(sha1);
86 if (!commit) { 86 if (!commit) {
87 cgit_print_error(fmt("Bad commit reference: %s", hex)); 87 cgit_print_error(fmt("Bad commit reference: %s", hex));
88 return; 88 return;
89 } 89 }
90 info = cgit_parse_commit(commit); 90 info = cgit_parse_commit(commit);
91 hashcpy(old_sha1, commit->parents->item->object.sha1); 91
92 if (commit->parents && commit->parents->item)
93 hashcpy(old_sha1, commit->parents->item->object.sha1);
94 else
95 hashclr(old_sha1);
92 96
93 patchname = fmt("%s.patch", sha1_to_hex(sha1)); 97 patchname = fmt("%s.patch", sha1_to_hex(sha1));
94 cgit_print_snapshot_start("text/plain", patchname, item); 98 cgit_print_snapshot_start("text/plain", patchname, item);
95 htmlf("From %s Mon Sep 17 00:00:00 2001\n", sha1_to_hex(sha1)); 99 htmlf("From %s Mon Sep 17 00:00:00 2001\n", sha1_to_hex(sha1));
96 htmlf("From: %s%s\n", info->author, info->author_email); 100 htmlf("From: %s%s\n", info->author, info->author_email);
97 html("Date: "); 101 html("Date: ");
98 cgit_print_date(info->author_date, "%a, %d %b %Y %H:%M:%S %z%n"); 102 cgit_print_date(info->author_date, "%a, %d %b %Y %H:%M:%S %z%n");
99 htmlf("Subject: %s\n\n", info->subject); 103 htmlf("Subject: %s\n\n", info->subject);
100 if (info->msg && *info->msg) { 104 if (info->msg && *info->msg) {
101 htmlf("%s", info->msg); 105 htmlf("%s", info->msg);
102 if (info->msg[strlen(info->msg) - 1] != '\n') 106 if (info->msg[strlen(info->msg) - 1] != '\n')
103 html("\n"); 107 html("\n");
104 } 108 }
105 html("---\n"); 109 html("---\n");
106 cgit_diff_tree(old_sha1, sha1, filepair_cb, NULL); 110 cgit_diff_tree(old_sha1, sha1, filepair_cb, NULL);
107 html("--\n"); 111 html("--\n");
108 htmlf("cgit %s\n", CGIT_VERSION); 112 htmlf("cgit %s\n", CGIT_VERSION);
109 cgit_free_commitinfo(info); 113 cgit_free_commitinfo(info);
110} 114}