-rw-r--r-- | ui-commit.c | 19 |
1 files changed, 15 insertions, 4 deletions
diff --git a/ui-commit.c b/ui-commit.c index ce33cf9..b3d1c28 100644 --- a/ui-commit.c +++ b/ui-commit.c | |||
@@ -63,34 +63,34 @@ void print_fileinfo(struct fileinfo *info) | |||
63 | html("<tr>"); | 63 | html("<tr>"); |
64 | htmlf("<td class='mode'>"); | 64 | htmlf("<td class='mode'>"); |
65 | if (is_null_sha1(info->new_sha1)) { | 65 | if (is_null_sha1(info->new_sha1)) { |
66 | html_filemode(info->old_mode); | 66 | html_filemode(info->old_mode); |
67 | } else { | 67 | } else { |
68 | html_filemode(info->new_mode); | 68 | html_filemode(info->new_mode); |
69 | } | 69 | } |
70 | 70 | ||
71 | if (info->old_mode != info->new_mode && | 71 | if (info->old_mode != info->new_mode && |
72 | !is_null_sha1(info->old_sha1) && | 72 | !is_null_sha1(info->old_sha1) && |
73 | !is_null_sha1(info->new_sha1)) { | 73 | !is_null_sha1(info->new_sha1)) { |
74 | html("<span class='modechange'>["); | 74 | html("<span class='modechange'>["); |
75 | html_filemode(info->old_mode); | 75 | html_filemode(info->old_mode); |
76 | html("]</span>"); | 76 | html("]</span>"); |
77 | } | 77 | } |
78 | htmlf("</td><td class='%s'>", class); | 78 | htmlf("</td><td class='%s'>", class); |
79 | query = fmt("id=%s&id2=%s", sha1_to_hex(info->old_sha1), | 79 | query = fmt("id=%s&id2=%s&path=%s", sha1_to_hex(info->old_sha1), |
80 | sha1_to_hex(info->new_sha1)); | 80 | sha1_to_hex(info->new_sha1), info->new_path); |
81 | html_link_open(cgit_pageurl(cgit_query_repo, "diff", query), | 81 | html_link_open(cgit_pageurl(cgit_query_repo, "diff", query), |
82 | NULL, NULL); | 82 | NULL, NULL); |
83 | if (info->status == DIFF_STATUS_COPIED || | 83 | if (info->status == DIFF_STATUS_COPIED || |
84 | info->status == DIFF_STATUS_RENAMED) { | 84 | info->status == DIFF_STATUS_RENAMED) { |
85 | html_txt(info->new_path); | 85 | html_txt(info->new_path); |
86 | htmlf("</a> (%s from ", info->status == DIFF_STATUS_COPIED ? | 86 | htmlf("</a> (%s from ", info->status == DIFF_STATUS_COPIED ? |
87 | "copied" : "renamed"); | 87 | "copied" : "renamed"); |
88 | query2 = fmt("id=%s", sha1_to_hex(info->old_sha1)); | 88 | query2 = fmt("id=%s", sha1_to_hex(info->old_sha1)); |
89 | html_link_open(cgit_pageurl(cgit_query_repo, "view", query2), | 89 | html_link_open(cgit_pageurl(cgit_query_repo, "view", query2), |
90 | NULL, NULL); | 90 | NULL, NULL); |
91 | html_txt(info->old_path); | 91 | html_txt(info->old_path); |
92 | html("</a>)"); | 92 | html("</a>)"); |
93 | } else { | 93 | } else { |
94 | html_txt(info->new_path); | 94 | html_txt(info->new_path); |
95 | html("</a>"); | 95 | html("</a>"); |
96 | } | 96 | } |
@@ -138,33 +138,33 @@ void inspect_filepair(struct diff_filepair *pair) | |||
138 | hashcpy(items[files-1].new_sha1, pair->two->sha1); | 138 | hashcpy(items[files-1].new_sha1, pair->two->sha1); |
139 | items[files-1].old_mode = pair->one->mode; | 139 | items[files-1].old_mode = pair->one->mode; |
140 | items[files-1].new_mode = pair->two->mode; | 140 | items[files-1].new_mode = pair->two->mode; |
141 | items[files-1].old_path = xstrdup(pair->one->path); | 141 | items[files-1].old_path = xstrdup(pair->one->path); |
142 | items[files-1].new_path = xstrdup(pair->two->path); | 142 | items[files-1].new_path = xstrdup(pair->two->path); |
143 | items[files-1].added = lines_added; | 143 | items[files-1].added = lines_added; |
144 | items[files-1].removed = lines_removed; | 144 | items[files-1].removed = lines_removed; |
145 | if (lines_added + lines_removed > max_changes) | 145 | if (lines_added + lines_removed > max_changes) |
146 | max_changes = lines_added + lines_removed; | 146 | max_changes = lines_added + lines_removed; |
147 | total_adds += lines_added; | 147 | total_adds += lines_added; |
148 | total_rems += lines_removed; | 148 | total_rems += lines_removed; |
149 | } | 149 | } |
150 | 150 | ||
151 | 151 | ||
152 | void cgit_print_commit(const char *hex) | 152 | void cgit_print_commit(const char *hex) |
153 | { | 153 | { |
154 | struct commit *commit; | 154 | struct commit *commit, *parent; |
155 | struct commitinfo *info; | 155 | struct commitinfo *info; |
156 | struct commit_list *p; | 156 | struct commit_list *p; |
157 | unsigned char sha1[20]; | 157 | unsigned char sha1[20]; |
158 | char *query; | 158 | char *query; |
159 | char *filename; | 159 | char *filename; |
160 | int i; | 160 | int i; |
161 | 161 | ||
162 | if (get_sha1(hex, sha1)) { | 162 | if (get_sha1(hex, sha1)) { |
163 | cgit_print_error(fmt("Bad object id: %s", hex)); | 163 | cgit_print_error(fmt("Bad object id: %s", hex)); |
164 | return; | 164 | return; |
165 | } | 165 | } |
166 | commit = lookup_commit_reference(sha1); | 166 | commit = lookup_commit_reference(sha1); |
167 | if (!commit) { | 167 | if (!commit) { |
168 | cgit_print_error(fmt("Bad commit reference: %s", hex)); | 168 | cgit_print_error(fmt("Bad commit reference: %s", hex)); |
169 | return; | 169 | return; |
170 | } | 170 | } |
@@ -177,39 +177,50 @@ void cgit_print_commit(const char *hex) | |||
177 | html_txt(info->author_email); | 177 | html_txt(info->author_email); |
178 | html("</td><td class='right'>"); | 178 | html("</td><td class='right'>"); |
179 | cgit_print_date(info->author_date); | 179 | cgit_print_date(info->author_date); |
180 | html("</td></tr>\n"); | 180 | html("</td></tr>\n"); |
181 | html("<tr><th>committer</th><td>"); | 181 | html("<tr><th>committer</th><td>"); |
182 | html_txt(info->committer); | 182 | html_txt(info->committer); |
183 | html(" "); | 183 | html(" "); |
184 | html_txt(info->committer_email); | 184 | html_txt(info->committer_email); |
185 | html("</td><td class='right'>"); | 185 | html("</td><td class='right'>"); |
186 | cgit_print_date(info->committer_date); | 186 | cgit_print_date(info->committer_date); |
187 | html("</td></tr>\n"); | 187 | html("</td></tr>\n"); |
188 | html("<tr><th>tree</th><td colspan='2' class='sha1'><a href='"); | 188 | html("<tr><th>tree</th><td colspan='2' class='sha1'><a href='"); |
189 | query = fmt("id=%s", sha1_to_hex(commit->tree->object.sha1)); | 189 | query = fmt("id=%s", sha1_to_hex(commit->tree->object.sha1)); |
190 | html_attr(cgit_pageurl(cgit_query_repo, "tree", query)); | 190 | html_attr(cgit_pageurl(cgit_query_repo, "tree", query)); |
191 | htmlf("'>%s</a></td></tr>\n", sha1_to_hex(commit->tree->object.sha1)); | 191 | htmlf("'>%s</a></td></tr>\n", sha1_to_hex(commit->tree->object.sha1)); |
192 | for (p = commit->parents; p ; p = p->next) { | 192 | for (p = commit->parents; p ; p = p->next) { |
193 | parent = lookup_commit_reference(p->item->object.sha1); | ||
194 | if (!parent) { | ||
195 | html("<tr><td colspan='3'>"); | ||
196 | cgit_print_error("Error reading parent commit"); | ||
197 | html("</td></tr>"); | ||
198 | continue; | ||
199 | } | ||
193 | html("<tr><th>parent</th>" | 200 | html("<tr><th>parent</th>" |
194 | "<td colspan='2' class='sha1'>" | 201 | "<td colspan='2' class='sha1'>" |
195 | "<a href='"); | 202 | "<a href='"); |
196 | query = fmt("id=%s", sha1_to_hex(p->item->object.sha1)); | 203 | query = fmt("id=%s", sha1_to_hex(p->item->object.sha1)); |
197 | html_attr(cgit_pageurl(cgit_query_repo, "commit", query)); | 204 | html_attr(cgit_pageurl(cgit_query_repo, "commit", query)); |
198 | htmlf("'>%s</a></td></tr>\n", | 205 | htmlf("'>%s</a> (<a href='", |
199 | sha1_to_hex(p->item->object.sha1)); | 206 | sha1_to_hex(p->item->object.sha1)); |
207 | query = fmt("id=%s&id2=%s", sha1_to_hex(parent->tree->object.sha1), | ||
208 | sha1_to_hex(commit->tree->object.sha1)); | ||
209 | html_attr(cgit_pageurl(cgit_query_repo, "diff", query)); | ||
210 | html("'>diff</a>)</td></tr>"); | ||
200 | } | 211 | } |
201 | if (cgit_repo->snapshots) { | 212 | if (cgit_repo->snapshots) { |
202 | htmlf("<tr><th>download</th><td colspan='2' class='sha1'><a href='"); | 213 | htmlf("<tr><th>download</th><td colspan='2' class='sha1'><a href='"); |
203 | filename = fmt("%s-%s.zip", cgit_query_repo, hex); | 214 | filename = fmt("%s-%s.zip", cgit_query_repo, hex); |
204 | html_attr(cgit_pageurl(cgit_query_repo, "snapshot", | 215 | html_attr(cgit_pageurl(cgit_query_repo, "snapshot", |
205 | fmt("id=%s&name=%s", hex, filename))); | 216 | fmt("id=%s&name=%s", hex, filename))); |
206 | htmlf("'>%s</a></td></tr>", filename); | 217 | htmlf("'>%s</a></td></tr>", filename); |
207 | } | 218 | } |
208 | html("</table>\n"); | 219 | html("</table>\n"); |
209 | html("<div class='commit-subject'>"); | 220 | html("<div class='commit-subject'>"); |
210 | html_txt(info->subject); | 221 | html_txt(info->subject); |
211 | html("</div>"); | 222 | html("</div>"); |
212 | html("<div class='commit-msg'>"); | 223 | html("<div class='commit-msg'>"); |
213 | html_txt(info->msg); | 224 | html_txt(info->msg); |
214 | html("</div>"); | 225 | html("</div>"); |
215 | if (!(commit->parents && commit->parents->next && commit->parents->next->next)) { | 226 | if (!(commit->parents && commit->parents->next && commit->parents->next->next)) { |