summaryrefslogtreecommitdiffabout
path: root/ui-diff.c
Unidiff
Diffstat (limited to 'ui-diff.c') (more/less context) (ignore whitespace changes)
-rw-r--r--ui-diff.c11
1 files changed, 7 insertions, 4 deletions
diff --git a/ui-diff.c b/ui-diff.c
index e0a72f7..1656b77 100644
--- a/ui-diff.c
+++ b/ui-diff.c
@@ -1,363 +1,366 @@
1/* ui-diff.c: show diff between two blobs 1/* ui-diff.c: show diff between two blobs
2 * 2 *
3 * Copyright (C) 2006 Lars Hjemli 3 * Copyright (C) 2006 Lars Hjemli
4 * 4 *
5 * Licensed under GNU General Public License v2 5 * Licensed under GNU General Public License v2
6 * (see COPYING for full license text) 6 * (see COPYING for full license text)
7 */ 7 */
8 8
9#include "cgit.h" 9#include "cgit.h"
10#include "html.h" 10#include "html.h"
11#include "ui-shared.h" 11#include "ui-shared.h"
12#include "ui-ssdiff.h" 12#include "ui-ssdiff.h"
13 13
14unsigned char old_rev_sha1[20]; 14unsigned char old_rev_sha1[20];
15unsigned char new_rev_sha1[20]; 15unsigned char new_rev_sha1[20];
16 16
17static int files, slots; 17static int files, slots;
18static int total_adds, total_rems, max_changes; 18static int total_adds, total_rems, max_changes;
19static int lines_added, lines_removed; 19static int lines_added, lines_removed;
20 20
21static struct fileinfo { 21static struct fileinfo {
22 char status; 22 char status;
23 unsigned char old_sha1[20]; 23 unsigned char old_sha1[20];
24 unsigned char new_sha1[20]; 24 unsigned char new_sha1[20];
25 unsigned short old_mode; 25 unsigned short old_mode;
26 unsigned short new_mode; 26 unsigned short new_mode;
27 char *old_path; 27 char *old_path;
28 char *new_path; 28 char *new_path;
29 unsigned int added; 29 unsigned int added;
30 unsigned int removed; 30 unsigned int removed;
31 unsigned long old_size; 31 unsigned long old_size;
32 unsigned long new_size; 32 unsigned long new_size;
33 int binary:1; 33 int binary:1;
34} *items; 34} *items;
35 35
36static int use_ssdiff = 0; 36static int use_ssdiff = 0;
37 37
38static void print_fileinfo(struct fileinfo *info) 38static void print_fileinfo(struct fileinfo *info)
39{ 39{
40 char *class; 40 char *class;
41 41
42 switch (info->status) { 42 switch (info->status) {
43 case DIFF_STATUS_ADDED: 43 case DIFF_STATUS_ADDED:
44 class = "add"; 44 class = "add";
45 break; 45 break;
46 case DIFF_STATUS_COPIED: 46 case DIFF_STATUS_COPIED:
47 class = "cpy"; 47 class = "cpy";
48 break; 48 break;
49 case DIFF_STATUS_DELETED: 49 case DIFF_STATUS_DELETED:
50 class = "del"; 50 class = "del";
51 break; 51 break;
52 case DIFF_STATUS_MODIFIED: 52 case DIFF_STATUS_MODIFIED:
53 class = "upd"; 53 class = "upd";
54 break; 54 break;
55 case DIFF_STATUS_RENAMED: 55 case DIFF_STATUS_RENAMED:
56 class = "mov"; 56 class = "mov";
57 break; 57 break;
58 case DIFF_STATUS_TYPE_CHANGED: 58 case DIFF_STATUS_TYPE_CHANGED:
59 class = "typ"; 59 class = "typ";
60 break; 60 break;
61 case DIFF_STATUS_UNKNOWN: 61 case DIFF_STATUS_UNKNOWN:
62 class = "unk"; 62 class = "unk";
63 break; 63 break;
64 case DIFF_STATUS_UNMERGED: 64 case DIFF_STATUS_UNMERGED:
65 class = "stg"; 65 class = "stg";
66 break; 66 break;
67 default: 67 default:
68 die("bug: unhandled diff status %c", info->status); 68 die("bug: unhandled diff status %c", info->status);
69 } 69 }
70 70
71 html("<tr>"); 71 html("<tr>");
72 htmlf("<td class='mode'>"); 72 htmlf("<td class='mode'>");
73 if (is_null_sha1(info->new_sha1)) { 73 if (is_null_sha1(info->new_sha1)) {
74 cgit_print_filemode(info->old_mode); 74 cgit_print_filemode(info->old_mode);
75 } else { 75 } else {
76 cgit_print_filemode(info->new_mode); 76 cgit_print_filemode(info->new_mode);
77 } 77 }
78 78
79 if (info->old_mode != info->new_mode && 79 if (info->old_mode != info->new_mode &&
80 !is_null_sha1(info->old_sha1) && 80 !is_null_sha1(info->old_sha1) &&
81 !is_null_sha1(info->new_sha1)) { 81 !is_null_sha1(info->new_sha1)) {
82 html("<span class='modechange'>["); 82 html("<span class='modechange'>[");
83 cgit_print_filemode(info->old_mode); 83 cgit_print_filemode(info->old_mode);
84 html("]</span>"); 84 html("]</span>");
85 } 85 }
86 htmlf("</td><td class='%s'>", class); 86 htmlf("</td><td class='%s'>", class);
87 cgit_diff_link(info->new_path, NULL, NULL, ctx.qry.head, ctx.qry.sha1, 87 cgit_diff_link(info->new_path, NULL, NULL, ctx.qry.head, ctx.qry.sha1,
88 ctx.qry.sha2, info->new_path, 0); 88 ctx.qry.sha2, info->new_path, 0);
89 if (info->status == DIFF_STATUS_COPIED || info->status == DIFF_STATUS_RENAMED) 89 if (info->status == DIFF_STATUS_COPIED || info->status == DIFF_STATUS_RENAMED)
90 htmlf(" (%s from %s)", 90 htmlf(" (%s from %s)",
91 info->status == DIFF_STATUS_COPIED ? "copied" : "renamed", 91 info->status == DIFF_STATUS_COPIED ? "copied" : "renamed",
92 info->old_path); 92 info->old_path);
93 html("</td><td class='right'>"); 93 html("</td><td class='right'>");
94 if (info->binary) { 94 if (info->binary) {
95 htmlf("bin</td><td class='graph'>%d -> %d bytes", 95 htmlf("bin</td><td class='graph'>%d -> %d bytes",
96 info->old_size, info->new_size); 96 info->old_size, info->new_size);
97 return; 97 return;
98 } 98 }
99 htmlf("%d", info->added + info->removed); 99 htmlf("%d", info->added + info->removed);
100 html("</td><td class='graph'>"); 100 html("</td><td class='graph'>");
101 htmlf("<table summary='file diffstat' width='%d%%'><tr>", (max_changes > 100 ? 100 : max_changes)); 101 htmlf("<table summary='file diffstat' width='%d%%'><tr>", (max_changes > 100 ? 100 : max_changes));
102 htmlf("<td class='add' style='width: %.1f%%;'/>", 102 htmlf("<td class='add' style='width: %.1f%%;'/>",
103 info->added * 100.0 / max_changes); 103 info->added * 100.0 / max_changes);
104 htmlf("<td class='rem' style='width: %.1f%%;'/>", 104 htmlf("<td class='rem' style='width: %.1f%%;'/>",
105 info->removed * 100.0 / max_changes); 105 info->removed * 100.0 / max_changes);
106 htmlf("<td class='none' style='width: %.1f%%;'/>", 106 htmlf("<td class='none' style='width: %.1f%%;'/>",
107 (max_changes - info->removed - info->added) * 100.0 / max_changes); 107 (max_changes - info->removed - info->added) * 100.0 / max_changes);
108 html("</tr></table></td></tr>\n"); 108 html("</tr></table></td></tr>\n");
109} 109}
110 110
111static void count_diff_lines(char *line, int len) 111static void count_diff_lines(char *line, int len)
112{ 112{
113 if (line && (len > 0)) { 113 if (line && (len > 0)) {
114 if (line[0] == '+') 114 if (line[0] == '+')
115 lines_added++; 115 lines_added++;
116 else if (line[0] == '-') 116 else if (line[0] == '-')
117 lines_removed++; 117 lines_removed++;
118 } 118 }
119} 119}
120 120
121static void inspect_filepair(struct diff_filepair *pair) 121static void inspect_filepair(struct diff_filepair *pair)
122{ 122{
123 int binary = 0; 123 int binary = 0;
124 unsigned long old_size = 0; 124 unsigned long old_size = 0;
125 unsigned long new_size = 0; 125 unsigned long new_size = 0;
126 files++; 126 files++;
127 lines_added = 0; 127 lines_added = 0;
128 lines_removed = 0; 128 lines_removed = 0;
129 cgit_diff_files(pair->one->sha1, pair->two->sha1, &old_size, &new_size, 129 cgit_diff_files(pair->one->sha1, pair->two->sha1, &old_size, &new_size,
130 &binary, 0, count_diff_lines); 130 &binary, 0, ctx.qry.ignorews, count_diff_lines);
131 if (files >= slots) { 131 if (files >= slots) {
132 if (slots == 0) 132 if (slots == 0)
133 slots = 4; 133 slots = 4;
134 else 134 else
135 slots = slots * 2; 135 slots = slots * 2;
136 items = xrealloc(items, slots * sizeof(struct fileinfo)); 136 items = xrealloc(items, slots * sizeof(struct fileinfo));
137 } 137 }
138 items[files-1].status = pair->status; 138 items[files-1].status = pair->status;
139 hashcpy(items[files-1].old_sha1, pair->one->sha1); 139 hashcpy(items[files-1].old_sha1, pair->one->sha1);
140 hashcpy(items[files-1].new_sha1, pair->two->sha1); 140 hashcpy(items[files-1].new_sha1, pair->two->sha1);
141 items[files-1].old_mode = pair->one->mode; 141 items[files-1].old_mode = pair->one->mode;
142 items[files-1].new_mode = pair->two->mode; 142 items[files-1].new_mode = pair->two->mode;
143 items[files-1].old_path = xstrdup(pair->one->path); 143 items[files-1].old_path = xstrdup(pair->one->path);
144 items[files-1].new_path = xstrdup(pair->two->path); 144 items[files-1].new_path = xstrdup(pair->two->path);
145 items[files-1].added = lines_added; 145 items[files-1].added = lines_added;
146 items[files-1].removed = lines_removed; 146 items[files-1].removed = lines_removed;
147 items[files-1].old_size = old_size; 147 items[files-1].old_size = old_size;
148 items[files-1].new_size = new_size; 148 items[files-1].new_size = new_size;
149 items[files-1].binary = binary; 149 items[files-1].binary = binary;
150 if (lines_added + lines_removed > max_changes) 150 if (lines_added + lines_removed > max_changes)
151 max_changes = lines_added + lines_removed; 151 max_changes = lines_added + lines_removed;
152 total_adds += lines_added; 152 total_adds += lines_added;
153 total_rems += lines_removed; 153 total_rems += lines_removed;
154} 154}
155 155
156void cgit_print_diffstat(const unsigned char *old_sha1, 156void cgit_print_diffstat(const unsigned char *old_sha1,
157 const unsigned char *new_sha1, const char *prefix) 157 const unsigned char *new_sha1, const char *prefix)
158{ 158{
159 int i, save_context = ctx.qry.context; 159 int i, save_context = ctx.qry.context;
160 160
161 html("<div class='diffstat-header'>"); 161 html("<div class='diffstat-header'>");
162 cgit_diff_link("Diffstat", NULL, NULL, ctx.qry.head, ctx.qry.sha1, 162 cgit_diff_link("Diffstat", NULL, NULL, ctx.qry.head, ctx.qry.sha1,
163 ctx.qry.sha2, NULL, 0); 163 ctx.qry.sha2, NULL, 0);
164 if (prefix) 164 if (prefix)
165 htmlf(" (limited to '%s')", prefix); 165 htmlf(" (limited to '%s')", prefix);
166 html(" ("); 166 html(" (");
167 ctx.qry.context = (save_context > 0 ? save_context : 3) << 1; 167 ctx.qry.context = (save_context > 0 ? save_context : 3) << 1;
168 cgit_self_link("more", NULL, NULL, &ctx); 168 cgit_self_link("more", NULL, NULL, &ctx);
169 html("/"); 169 html("/");
170 ctx.qry.context = (save_context > 3 ? save_context : 3) >> 1; 170 ctx.qry.context = (save_context > 3 ? save_context : 3) >> 1;
171 cgit_self_link("less", NULL, NULL, &ctx); 171 cgit_self_link("less", NULL, NULL, &ctx);
172 ctx.qry.context = save_context; 172 ctx.qry.context = save_context;
173 html(" context)"); 173 html(" context)");
174 html("</div>"); 174 html("</div>");
175 html("<table summary='diffstat' class='diffstat'>"); 175 html("<table summary='diffstat' class='diffstat'>");
176 max_changes = 0; 176 max_changes = 0;
177 cgit_diff_tree(old_sha1, new_sha1, inspect_filepair, prefix); 177 cgit_diff_tree(old_sha1, new_sha1, inspect_filepair, prefix,
178 ctx.qry.ignorews);
178 for(i = 0; i<files; i++) 179 for(i = 0; i<files; i++)
179 print_fileinfo(&items[i]); 180 print_fileinfo(&items[i]);
180 html("</table>"); 181 html("</table>");
181 html("<div class='diffstat-summary'>"); 182 html("<div class='diffstat-summary'>");
182 htmlf("%d files changed, %d insertions, %d deletions", 183 htmlf("%d files changed, %d insertions, %d deletions",
183 files, total_adds, total_rems); 184 files, total_adds, total_rems);
184 html("</div>"); 185 html("</div>");
185} 186}
186 187
187 188
188/* 189/*
189 * print a single line returned from xdiff 190 * print a single line returned from xdiff
190 */ 191 */
191static void print_line(char *line, int len) 192static void print_line(char *line, int len)
192{ 193{
193 char *class = "ctx"; 194 char *class = "ctx";
194 char c = line[len-1]; 195 char c = line[len-1];
195 196
196 if (line[0] == '+') 197 if (line[0] == '+')
197 class = "add"; 198 class = "add";
198 else if (line[0] == '-') 199 else if (line[0] == '-')
199 class = "del"; 200 class = "del";
200 else if (line[0] == '@') 201 else if (line[0] == '@')
201 class = "hunk"; 202 class = "hunk";
202 203
203 htmlf("<div class='%s'>", class); 204 htmlf("<div class='%s'>", class);
204 line[len-1] = '\0'; 205 line[len-1] = '\0';
205 html_txt(line); 206 html_txt(line);
206 html("</div>"); 207 html("</div>");
207 line[len-1] = c; 208 line[len-1] = c;
208} 209}
209 210
210static void header(unsigned char *sha1, char *path1, int mode1, 211static void header(unsigned char *sha1, char *path1, int mode1,
211 unsigned char *sha2, char *path2, int mode2) 212 unsigned char *sha2, char *path2, int mode2)
212{ 213{
213 char *abbrev1, *abbrev2; 214 char *abbrev1, *abbrev2;
214 int subproject; 215 int subproject;
215 216
216 subproject = (S_ISGITLINK(mode1) || S_ISGITLINK(mode2)); 217 subproject = (S_ISGITLINK(mode1) || S_ISGITLINK(mode2));
217 html("<div class='head'>"); 218 html("<div class='head'>");
218 html("diff --git a/"); 219 html("diff --git a/");
219 html_txt(path1); 220 html_txt(path1);
220 html(" b/"); 221 html(" b/");
221 html_txt(path2); 222 html_txt(path2);
222 223
223 if (is_null_sha1(sha1)) 224 if (is_null_sha1(sha1))
224 path1 = "dev/null"; 225 path1 = "dev/null";
225 if (is_null_sha1(sha2)) 226 if (is_null_sha1(sha2))
226 path2 = "dev/null"; 227 path2 = "dev/null";
227 228
228 if (mode1 == 0) 229 if (mode1 == 0)
229 htmlf("<br/>new file mode %.6o", mode2); 230 htmlf("<br/>new file mode %.6o", mode2);
230 231
231 if (mode2 == 0) 232 if (mode2 == 0)
232 htmlf("<br/>deleted file mode %.6o", mode1); 233 htmlf("<br/>deleted file mode %.6o", mode1);
233 234
234 if (!subproject) { 235 if (!subproject) {
235 abbrev1 = xstrdup(find_unique_abbrev(sha1, DEFAULT_ABBREV)); 236 abbrev1 = xstrdup(find_unique_abbrev(sha1, DEFAULT_ABBREV));
236 abbrev2 = xstrdup(find_unique_abbrev(sha2, DEFAULT_ABBREV)); 237 abbrev2 = xstrdup(find_unique_abbrev(sha2, DEFAULT_ABBREV));
237 htmlf("<br/>index %s..%s", abbrev1, abbrev2); 238 htmlf("<br/>index %s..%s", abbrev1, abbrev2);
238 free(abbrev1); 239 free(abbrev1);
239 free(abbrev2); 240 free(abbrev2);
240 if (mode1 != 0 && mode2 != 0) { 241 if (mode1 != 0 && mode2 != 0) {
241 htmlf(" %.6o", mode1); 242 htmlf(" %.6o", mode1);
242 if (mode2 != mode1) 243 if (mode2 != mode1)
243 htmlf("..%.6o", mode2); 244 htmlf("..%.6o", mode2);
244 } 245 }
245 html("<br/>--- a/"); 246 html("<br/>--- a/");
246 if (mode1 != 0) 247 if (mode1 != 0)
247 cgit_tree_link(path1, NULL, NULL, ctx.qry.head, 248 cgit_tree_link(path1, NULL, NULL, ctx.qry.head,
248 sha1_to_hex(old_rev_sha1), path1); 249 sha1_to_hex(old_rev_sha1), path1);
249 else 250 else
250 html_txt(path1); 251 html_txt(path1);
251 html("<br/>+++ b/"); 252 html("<br/>+++ b/");
252 if (mode2 != 0) 253 if (mode2 != 0)
253 cgit_tree_link(path2, NULL, NULL, ctx.qry.head, 254 cgit_tree_link(path2, NULL, NULL, ctx.qry.head,
254 sha1_to_hex(new_rev_sha1), path2); 255 sha1_to_hex(new_rev_sha1), path2);
255 else 256 else
256 html_txt(path2); 257 html_txt(path2);
257 } 258 }
258 html("</div>"); 259 html("</div>");
259} 260}
260 261
261static void print_ssdiff_link() 262static void print_ssdiff_link()
262{ 263{
263 if (!strcmp(ctx.qry.page, "diff")) { 264 if (!strcmp(ctx.qry.page, "diff")) {
264 if (use_ssdiff) 265 if (use_ssdiff)
265 cgit_diff_link("Unidiff", NULL, NULL, ctx.qry.head, 266 cgit_diff_link("Unidiff", NULL, NULL, ctx.qry.head,
266 ctx.qry.sha1, ctx.qry.sha2, ctx.qry.path, 1); 267 ctx.qry.sha1, ctx.qry.sha2, ctx.qry.path, 1);
267 else 268 else
268 cgit_diff_link("Side-by-side diff", NULL, NULL, 269 cgit_diff_link("Side-by-side diff", NULL, NULL,
269 ctx.qry.head, ctx.qry.sha1, 270 ctx.qry.head, ctx.qry.sha1,
270 ctx.qry.sha2, ctx.qry.path, 1); 271 ctx.qry.sha2, ctx.qry.path, 1);
271 } 272 }
272} 273}
273 274
274static void filepair_cb(struct diff_filepair *pair) 275static void filepair_cb(struct diff_filepair *pair)
275{ 276{
276 unsigned long old_size = 0; 277 unsigned long old_size = 0;
277 unsigned long new_size = 0; 278 unsigned long new_size = 0;
278 int binary = 0; 279 int binary = 0;
279 linediff_fn print_line_fn = print_line; 280 linediff_fn print_line_fn = print_line;
280 281
281 if (use_ssdiff) { 282 if (use_ssdiff) {
282 cgit_ssdiff_header_begin(); 283 cgit_ssdiff_header_begin();
283 print_line_fn = cgit_ssdiff_line_cb; 284 print_line_fn = cgit_ssdiff_line_cb;
284 } 285 }
285 header(pair->one->sha1, pair->one->path, pair->one->mode, 286 header(pair->one->sha1, pair->one->path, pair->one->mode,
286 pair->two->sha1, pair->two->path, pair->two->mode); 287 pair->two->sha1, pair->two->path, pair->two->mode);
287 if (use_ssdiff) 288 if (use_ssdiff)
288 cgit_ssdiff_header_end(); 289 cgit_ssdiff_header_end();
289 if (S_ISGITLINK(pair->one->mode) || S_ISGITLINK(pair->two->mode)) { 290 if (S_ISGITLINK(pair->one->mode) || S_ISGITLINK(pair->two->mode)) {
290 if (S_ISGITLINK(pair->one->mode)) 291 if (S_ISGITLINK(pair->one->mode))
291 print_line_fn(fmt("-Subproject %s", sha1_to_hex(pair->one->sha1)), 52); 292 print_line_fn(fmt("-Subproject %s", sha1_to_hex(pair->one->sha1)), 52);
292 if (S_ISGITLINK(pair->two->mode)) 293 if (S_ISGITLINK(pair->two->mode))
293 print_line_fn(fmt("+Subproject %s", sha1_to_hex(pair->two->sha1)), 52); 294 print_line_fn(fmt("+Subproject %s", sha1_to_hex(pair->two->sha1)), 52);
294 if (use_ssdiff) 295 if (use_ssdiff)
295 cgit_ssdiff_footer(); 296 cgit_ssdiff_footer();
296 return; 297 return;
297 } 298 }
298 if (cgit_diff_files(pair->one->sha1, pair->two->sha1, &old_size, 299 if (cgit_diff_files(pair->one->sha1, pair->two->sha1, &old_size,
299 &new_size, &binary, ctx.qry.context, print_line_fn)) 300 &new_size, &binary, ctx.qry.context,
301 ctx.qry.ignorews, print_line_fn))
300 cgit_print_error("Error running diff"); 302 cgit_print_error("Error running diff");
301 if (binary) { 303 if (binary) {
302 if (use_ssdiff) 304 if (use_ssdiff)
303 html("<tr><td colspan='4'>Binary files differ</td></tr>"); 305 html("<tr><td colspan='4'>Binary files differ</td></tr>");
304 else 306 else
305 html("Binary files differ"); 307 html("Binary files differ");
306 } 308 }
307 if (use_ssdiff) 309 if (use_ssdiff)
308 cgit_ssdiff_footer(); 310 cgit_ssdiff_footer();
309} 311}
310 312
311void cgit_print_diff(const char *new_rev, const char *old_rev, const char *prefix) 313void cgit_print_diff(const char *new_rev, const char *old_rev, const char *prefix)
312{ 314{
313 enum object_type type; 315 enum object_type type;
314 unsigned long size; 316 unsigned long size;
315 struct commit *commit, *commit2; 317 struct commit *commit, *commit2;
316 318
317 if (!new_rev) 319 if (!new_rev)
318 new_rev = ctx.qry.head; 320 new_rev = ctx.qry.head;
319 get_sha1(new_rev, new_rev_sha1); 321 get_sha1(new_rev, new_rev_sha1);
320 type = sha1_object_info(new_rev_sha1, &size); 322 type = sha1_object_info(new_rev_sha1, &size);
321 if (type == OBJ_BAD) { 323 if (type == OBJ_BAD) {
322 cgit_print_error(fmt("Bad object name: %s", new_rev)); 324 cgit_print_error(fmt("Bad object name: %s", new_rev));
323 return; 325 return;
324 } 326 }
325 commit = lookup_commit_reference(new_rev_sha1); 327 commit = lookup_commit_reference(new_rev_sha1);
326 if (!commit || parse_commit(commit)) 328 if (!commit || parse_commit(commit))
327 cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(new_rev_sha1))); 329 cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(new_rev_sha1)));
328 330
329 if (old_rev) 331 if (old_rev)
330 get_sha1(old_rev, old_rev_sha1); 332 get_sha1(old_rev, old_rev_sha1);
331 else if (commit->parents && commit->parents->item) 333 else if (commit->parents && commit->parents->item)
332 hashcpy(old_rev_sha1, commit->parents->item->object.sha1); 334 hashcpy(old_rev_sha1, commit->parents->item->object.sha1);
333 else 335 else
334 hashclr(old_rev_sha1); 336 hashclr(old_rev_sha1);
335 337
336 if (!is_null_sha1(old_rev_sha1)) { 338 if (!is_null_sha1(old_rev_sha1)) {
337 type = sha1_object_info(old_rev_sha1, &size); 339 type = sha1_object_info(old_rev_sha1, &size);
338 if (type == OBJ_BAD) { 340 if (type == OBJ_BAD) {
339 cgit_print_error(fmt("Bad object name: %s", sha1_to_hex(old_rev_sha1))); 341 cgit_print_error(fmt("Bad object name: %s", sha1_to_hex(old_rev_sha1)));
340 return; 342 return;
341 } 343 }
342 commit2 = lookup_commit_reference(old_rev_sha1); 344 commit2 = lookup_commit_reference(old_rev_sha1);
343 if (!commit2 || parse_commit(commit2)) 345 if (!commit2 || parse_commit(commit2))
344 cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(old_rev_sha1))); 346 cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(old_rev_sha1)));
345 } 347 }
346 348
347 if ((ctx.qry.ssdiff && !ctx.cfg.ssdiff) || (!ctx.qry.ssdiff && ctx.cfg.ssdiff)) 349 if ((ctx.qry.ssdiff && !ctx.cfg.ssdiff) || (!ctx.qry.ssdiff && ctx.cfg.ssdiff))
348 use_ssdiff = 1; 350 use_ssdiff = 1;
349 351
350 print_ssdiff_link(); 352 print_ssdiff_link();
351 cgit_print_diffstat(old_rev_sha1, new_rev_sha1, prefix); 353 cgit_print_diffstat(old_rev_sha1, new_rev_sha1, prefix);
352 354
353 if (use_ssdiff) { 355 if (use_ssdiff) {
354 html("<table summary='ssdiff' class='ssdiff'>"); 356 html("<table summary='ssdiff' class='ssdiff'>");
355 } else { 357 } else {
356 html("<table summary='diff' class='diff'>"); 358 html("<table summary='diff' class='diff'>");
357 html("<tr><td>"); 359 html("<tr><td>");
358 } 360 }
359 cgit_diff_tree(old_rev_sha1, new_rev_sha1, filepair_cb, prefix); 361 cgit_diff_tree(old_rev_sha1, new_rev_sha1, filepair_cb, prefix,
362 ctx.qry.ignorews);
360 if (!use_ssdiff) 363 if (!use_ssdiff)
361 html("</td></tr>"); 364 html("</td></tr>");
362 html("</table>"); 365 html("</table>");
363} 366}