|
diff --git a/ui-diff.c b/ui-diff.c index 2a22009..625b5fd 100644 --- a/ ui-diff.c+++ b/ ui-diff.c |
|
@@ -1,150 +1,295 @@ |
1 | /* ui-diff.c: show diff between two blobs |
1 | /* ui-diff.c: show diff between two blobs |
2 | * |
2 | * |
3 | * Copyright (C) 2006 Lars Hjemli |
3 | * Copyright (C) 2006 Lars Hjemli |
4 | * |
4 | * |
5 | * Licensed under GNU General Public License v2 |
5 | * Licensed under GNU General Public License v2 |
6 | * (see COPYING for full license text) |
6 | * (see COPYING for full license text) |
7 | */ |
7 | */ |
8 | |
8 | |
9 | #include "cgit.h" |
9 | #include "cgit.h" |
10 | #include "html.h" |
10 | #include "html.h" |
11 | #include "ui-shared.h" |
11 | #include "ui-shared.h" |
12 | |
12 | |
13 | unsigned char old_rev_sha1[20]; |
13 | unsigned char old_rev_sha1[20]; |
14 | unsigned char new_rev_sha1[20]; |
14 | unsigned char new_rev_sha1[20]; |
15 | |
15 | |
| |
16 | static int files, slots; |
| |
17 | static int total_adds, total_rems, max_changes; |
| |
18 | static int lines_added, lines_removed; |
| |
19 | static char *curr_rev; |
| |
20 | |
| |
21 | static struct fileinfo { |
| |
22 | char status; |
| |
23 | unsigned char old_sha1[20]; |
| |
24 | unsigned char new_sha1[20]; |
| |
25 | unsigned short old_mode; |
| |
26 | unsigned short new_mode; |
| |
27 | char *old_path; |
| |
28 | char *new_path; |
| |
29 | unsigned int added; |
| |
30 | unsigned int removed; |
| |
31 | } *items; |
| |
32 | |
| |
33 | |
| |
34 | static void print_fileinfo(struct fileinfo *info) |
| |
35 | { |
| |
36 | char *class; |
| |
37 | |
| |
38 | switch (info->status) { |
| |
39 | case DIFF_STATUS_ADDED: |
| |
40 | class = "add"; |
| |
41 | break; |
| |
42 | case DIFF_STATUS_COPIED: |
| |
43 | class = "cpy"; |
| |
44 | break; |
| |
45 | case DIFF_STATUS_DELETED: |
| |
46 | class = "del"; |
| |
47 | break; |
| |
48 | case DIFF_STATUS_MODIFIED: |
| |
49 | class = "upd"; |
| |
50 | break; |
| |
51 | case DIFF_STATUS_RENAMED: |
| |
52 | class = "mov"; |
| |
53 | break; |
| |
54 | case DIFF_STATUS_TYPE_CHANGED: |
| |
55 | class = "typ"; |
| |
56 | break; |
| |
57 | case DIFF_STATUS_UNKNOWN: |
| |
58 | class = "unk"; |
| |
59 | break; |
| |
60 | case DIFF_STATUS_UNMERGED: |
| |
61 | class = "stg"; |
| |
62 | break; |
| |
63 | default: |
| |
64 | die("bug: unhandled diff status %c", info->status); |
| |
65 | } |
| |
66 | |
| |
67 | html("<tr>"); |
| |
68 | htmlf("<td class='mode'>"); |
| |
69 | if (is_null_sha1(info->new_sha1)) { |
| |
70 | cgit_print_filemode(info->old_mode); |
| |
71 | } else { |
| |
72 | cgit_print_filemode(info->new_mode); |
| |
73 | } |
| |
74 | |
| |
75 | if (info->old_mode != info->new_mode && |
| |
76 | !is_null_sha1(info->old_sha1) && |
| |
77 | !is_null_sha1(info->new_sha1)) { |
| |
78 | html("<span class='modechange'>["); |
| |
79 | cgit_print_filemode(info->old_mode); |
| |
80 | html("]</span>"); |
| |
81 | } |
| |
82 | htmlf("</td><td class='%s'>", class); |
| |
83 | cgit_diff_link(info->new_path, NULL, NULL, ctx.qry.head, curr_rev, |
| |
84 | NULL, info->new_path); |
| |
85 | if (info->status == DIFF_STATUS_COPIED || info->status == DIFF_STATUS_RENAMED) |
| |
86 | htmlf(" (%s from %s)", |
| |
87 | info->status == DIFF_STATUS_COPIED ? "copied" : "renamed", |
| |
88 | info->old_path); |
| |
89 | html("</td><td class='right'>"); |
| |
90 | htmlf("%d", info->added + info->removed); |
| |
91 | html("</td><td class='graph'>"); |
| |
92 | htmlf("<table summary='file diffstat' width='%d%%'><tr>", (max_changes > 100 ? 100 : max_changes)); |
| |
93 | htmlf("<td class='add' style='width: %.1f%%;'/>", |
| |
94 | info->added * 100.0 / max_changes); |
| |
95 | htmlf("<td class='rem' style='width: %.1f%%;'/>", |
| |
96 | info->removed * 100.0 / max_changes); |
| |
97 | htmlf("<td class='none' style='width: %.1f%%;'/>", |
| |
98 | (max_changes - info->removed - info->added) * 100.0 / max_changes); |
| |
99 | html("</tr></table></td></tr>\n"); |
| |
100 | } |
| |
101 | |
| |
102 | static void count_diff_lines(char *line, int len) |
| |
103 | { |
| |
104 | if (line && (len > 0)) { |
| |
105 | if (line[0] == '+') |
| |
106 | lines_added++; |
| |
107 | else if (line[0] == '-') |
| |
108 | lines_removed++; |
| |
109 | } |
| |
110 | } |
| |
111 | |
| |
112 | static void inspect_filepair(struct diff_filepair *pair) |
| |
113 | { |
| |
114 | files++; |
| |
115 | lines_added = 0; |
| |
116 | lines_removed = 0; |
| |
117 | cgit_diff_files(pair->one->sha1, pair->two->sha1, count_diff_lines); |
| |
118 | if (files >= slots) { |
| |
119 | if (slots == 0) |
| |
120 | slots = 4; |
| |
121 | else |
| |
122 | slots = slots * 2; |
| |
123 | items = xrealloc(items, slots * sizeof(struct fileinfo)); |
| |
124 | } |
| |
125 | items[files-1].status = pair->status; |
| |
126 | hashcpy(items[files-1].old_sha1, pair->one->sha1); |
| |
127 | hashcpy(items[files-1].new_sha1, pair->two->sha1); |
| |
128 | items[files-1].old_mode = pair->one->mode; |
| |
129 | items[files-1].new_mode = pair->two->mode; |
| |
130 | items[files-1].old_path = xstrdup(pair->one->path); |
| |
131 | items[files-1].new_path = xstrdup(pair->two->path); |
| |
132 | items[files-1].added = lines_added; |
| |
133 | items[files-1].removed = lines_removed; |
| |
134 | if (lines_added + lines_removed > max_changes) |
| |
135 | max_changes = lines_added + lines_removed; |
| |
136 | total_adds += lines_added; |
| |
137 | total_rems += lines_removed; |
| |
138 | } |
| |
139 | |
| |
140 | void cgit_print_diffstat(const unsigned char *old_sha1, |
| |
141 | const unsigned char *new_sha1) |
| |
142 | { |
| |
143 | int i; |
| |
144 | |
| |
145 | html("<div class='diffstat-header'>Diffstat</div>"); |
| |
146 | html("<table summary='diffstat' class='diffstat'>"); |
| |
147 | max_changes = 0; |
| |
148 | cgit_diff_tree(old_sha1, new_sha1, inspect_filepair, NULL); |
| |
149 | for(i = 0; i<files; i++) |
| |
150 | print_fileinfo(&items[i]); |
| |
151 | html("</table>"); |
| |
152 | html("<div class='diffstat-summary'>"); |
| |
153 | htmlf("%d files changed, %d insertions, %d deletions", |
| |
154 | files, total_adds, total_rems); |
| |
155 | html("</div>"); |
| |
156 | } |
| |
157 | |
| |
158 | |
16 | /* |
159 | /* |
17 | * print a single line returned from xdiff |
160 | * print a single line returned from xdiff |
18 | */ |
161 | */ |
19 | static void print_line(char *line, int len) |
162 | static void print_line(char *line, int len) |
20 | { |
163 | { |
21 | char *class = "ctx"; |
164 | char *class = "ctx"; |
22 | char c = line[len-1]; |
165 | char c = line[len-1]; |
23 | |
166 | |
24 | if (line[0] == '+') |
167 | if (line[0] == '+') |
25 | class = "add"; |
168 | class = "add"; |
26 | else if (line[0] == '-') |
169 | else if (line[0] == '-') |
27 | class = "del"; |
170 | class = "del"; |
28 | else if (line[0] == '@') |
171 | else if (line[0] == '@') |
29 | class = "hunk"; |
172 | class = "hunk"; |
30 | |
173 | |
31 | htmlf("<div class='%s'>", class); |
174 | htmlf("<div class='%s'>", class); |
32 | line[len-1] = '\0'; |
175 | line[len-1] = '\0'; |
33 | html_txt(line); |
176 | html_txt(line); |
34 | html("</div>"); |
177 | html("</div>"); |
35 | line[len-1] = c; |
178 | line[len-1] = c; |
36 | } |
179 | } |
37 | |
180 | |
38 | static void header(unsigned char *sha1, char *path1, int mode1, |
181 | static void header(unsigned char *sha1, char *path1, int mode1, |
39 | unsigned char *sha2, char *path2, int mode2) |
182 | unsigned char *sha2, char *path2, int mode2) |
40 | { |
183 | { |
41 | char *abbrev1, *abbrev2; |
184 | char *abbrev1, *abbrev2; |
42 | int subproject; |
185 | int subproject; |
43 | |
186 | |
44 | subproject = (S_ISGITLINK(mode1) || S_ISGITLINK(mode2)); |
187 | subproject = (S_ISGITLINK(mode1) || S_ISGITLINK(mode2)); |
45 | html("<div class='head'>"); |
188 | html("<div class='head'>"); |
46 | html("diff --git a/"); |
189 | html("diff --git a/"); |
47 | html_txt(path1); |
190 | html_txt(path1); |
48 | html(" b/"); |
191 | html(" b/"); |
49 | html_txt(path2); |
192 | html_txt(path2); |
50 | |
193 | |
51 | if (is_null_sha1(sha1)) |
194 | if (is_null_sha1(sha1)) |
52 | path1 = "dev/null"; |
195 | path1 = "dev/null"; |
53 | if (is_null_sha1(sha2)) |
196 | if (is_null_sha1(sha2)) |
54 | path2 = "dev/null"; |
197 | path2 = "dev/null"; |
55 | |
198 | |
56 | if (mode1 == 0) |
199 | if (mode1 == 0) |
57 | htmlf("<br/>new file mode %.6o", mode2); |
200 | htmlf("<br/>new file mode %.6o", mode2); |
58 | |
201 | |
59 | if (mode2 == 0) |
202 | if (mode2 == 0) |
60 | htmlf("<br/>deleted file mode %.6o", mode1); |
203 | htmlf("<br/>deleted file mode %.6o", mode1); |
61 | |
204 | |
62 | if (!subproject) { |
205 | if (!subproject) { |
63 | abbrev1 = xstrdup(find_unique_abbrev(sha1, DEFAULT_ABBREV)); |
206 | abbrev1 = xstrdup(find_unique_abbrev(sha1, DEFAULT_ABBREV)); |
64 | abbrev2 = xstrdup(find_unique_abbrev(sha2, DEFAULT_ABBREV)); |
207 | abbrev2 = xstrdup(find_unique_abbrev(sha2, DEFAULT_ABBREV)); |
65 | htmlf("<br/>index %s..%s", abbrev1, abbrev2); |
208 | htmlf("<br/>index %s..%s", abbrev1, abbrev2); |
66 | free(abbrev1); |
209 | free(abbrev1); |
67 | free(abbrev2); |
210 | free(abbrev2); |
68 | if (mode1 != 0 && mode2 != 0) { |
211 | if (mode1 != 0 && mode2 != 0) { |
69 | htmlf(" %.6o", mode1); |
212 | htmlf(" %.6o", mode1); |
70 | if (mode2 != mode1) |
213 | if (mode2 != mode1) |
71 | htmlf("..%.6o", mode2); |
214 | htmlf("..%.6o", mode2); |
72 | } |
215 | } |
73 | html("<br/>--- a/"); |
216 | html("<br/>--- a/"); |
74 | if (mode1 != 0) |
217 | if (mode1 != 0) |
75 | cgit_tree_link(path1, NULL, NULL, ctx.qry.head, |
218 | cgit_tree_link(path1, NULL, NULL, ctx.qry.head, |
76 | sha1_to_hex(old_rev_sha1), path1); |
219 | sha1_to_hex(old_rev_sha1), path1); |
77 | else |
220 | else |
78 | html_txt(path1); |
221 | html_txt(path1); |
79 | html("<br/>+++ b/"); |
222 | html("<br/>+++ b/"); |
80 | if (mode2 != 0) |
223 | if (mode2 != 0) |
81 | cgit_tree_link(path2, NULL, NULL, ctx.qry.head, |
224 | cgit_tree_link(path2, NULL, NULL, ctx.qry.head, |
82 | sha1_to_hex(new_rev_sha1), path2); |
225 | sha1_to_hex(new_rev_sha1), path2); |
83 | else |
226 | else |
84 | html_txt(path2); |
227 | html_txt(path2); |
85 | } |
228 | } |
86 | html("</div>"); |
229 | html("</div>"); |
87 | } |
230 | } |
88 | |
231 | |
89 | static void filepair_cb(struct diff_filepair *pair) |
232 | static void filepair_cb(struct diff_filepair *pair) |
90 | { |
233 | { |
91 | header(pair->one->sha1, pair->one->path, pair->one->mode, |
234 | header(pair->one->sha1, pair->one->path, pair->one->mode, |
92 | pair->two->sha1, pair->two->path, pair->two->mode); |
235 | pair->two->sha1, pair->two->path, pair->two->mode); |
93 | if (S_ISGITLINK(pair->one->mode) || S_ISGITLINK(pair->two->mode)) { |
236 | if (S_ISGITLINK(pair->one->mode) || S_ISGITLINK(pair->two->mode)) { |
94 | if (S_ISGITLINK(pair->one->mode)) |
237 | if (S_ISGITLINK(pair->one->mode)) |
95 | print_line(fmt("-Subproject %s", sha1_to_hex(pair->one->sha1)), 52); |
238 | print_line(fmt("-Subproject %s", sha1_to_hex(pair->one->sha1)), 52); |
96 | if (S_ISGITLINK(pair->two->mode)) |
239 | if (S_ISGITLINK(pair->two->mode)) |
97 | print_line(fmt("+Subproject %s", sha1_to_hex(pair->two->sha1)), 52); |
240 | print_line(fmt("+Subproject %s", sha1_to_hex(pair->two->sha1)), 52); |
98 | return; |
241 | return; |
99 | } |
242 | } |
100 | if (cgit_diff_files(pair->one->sha1, pair->two->sha1, print_line)) |
243 | if (cgit_diff_files(pair->one->sha1, pair->two->sha1, print_line)) |
101 | cgit_print_error("Error running diff"); |
244 | cgit_print_error("Error running diff"); |
102 | } |
245 | } |
103 | |
246 | |
104 | void cgit_print_diff(const char *new_rev, const char *old_rev, const char *prefix) |
247 | void cgit_print_diff(const char *new_rev, const char *old_rev, const char *prefix) |
105 | { |
248 | { |
106 | enum object_type type; |
249 | enum object_type type; |
107 | unsigned long size; |
250 | unsigned long size; |
108 | struct commit *commit, *commit2; |
251 | struct commit *commit, *commit2; |
109 | |
252 | |
110 | if (!new_rev) |
253 | if (!new_rev) |
111 | new_rev = ctx.qry.head; |
254 | new_rev = ctx.qry.head; |
112 | get_sha1(new_rev, new_rev_sha1); |
255 | get_sha1(new_rev, new_rev_sha1); |
113 | type = sha1_object_info(new_rev_sha1, &size); |
256 | type = sha1_object_info(new_rev_sha1, &size); |
114 | if (type == OBJ_BAD) { |
257 | if (type == OBJ_BAD) { |
115 | cgit_print_error(fmt("Bad object name: %s", new_rev)); |
258 | cgit_print_error(fmt("Bad object name: %s", new_rev)); |
116 | return; |
259 | return; |
117 | } |
260 | } |
118 | if (type != OBJ_COMMIT) { |
261 | if (type != OBJ_COMMIT) { |
119 | cgit_print_error(fmt("Unhandled object type: %s", |
262 | cgit_print_error(fmt("Unhandled object type: %s", |
120 | typename(type))); |
263 | typename(type))); |
121 | return; |
264 | return; |
122 | } |
265 | } |
123 | |
266 | |
124 | commit = lookup_commit_reference(new_rev_sha1); |
267 | commit = lookup_commit_reference(new_rev_sha1); |
125 | if (!commit || parse_commit(commit)) |
268 | if (!commit || parse_commit(commit)) |
126 | cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(new_rev_sha1))); |
269 | cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(new_rev_sha1))); |
127 | |
270 | |
128 | if (old_rev) |
271 | if (old_rev) |
129 | get_sha1(old_rev, old_rev_sha1); |
272 | get_sha1(old_rev, old_rev_sha1); |
130 | else if (commit->parents && commit->parents->item) |
273 | else if (commit->parents && commit->parents->item) |
131 | hashcpy(old_rev_sha1, commit->parents->item->object.sha1); |
274 | hashcpy(old_rev_sha1, commit->parents->item->object.sha1); |
132 | else |
275 | else |
133 | hashclr(old_rev_sha1); |
276 | hashclr(old_rev_sha1); |
134 | |
277 | |
135 | if (!is_null_sha1(old_rev_sha1)) { |
278 | if (!is_null_sha1(old_rev_sha1)) { |
136 | type = sha1_object_info(old_rev_sha1, &size); |
279 | type = sha1_object_info(old_rev_sha1, &size); |
137 | if (type == OBJ_BAD) { |
280 | if (type == OBJ_BAD) { |
138 | cgit_print_error(fmt("Bad object name: %s", sha1_to_hex(old_rev_sha1))); |
281 | cgit_print_error(fmt("Bad object name: %s", sha1_to_hex(old_rev_sha1))); |
139 | return; |
282 | return; |
140 | } |
283 | } |
141 | commit2 = lookup_commit_reference(old_rev_sha1); |
284 | commit2 = lookup_commit_reference(old_rev_sha1); |
142 | if (!commit2 || parse_commit(commit2)) |
285 | if (!commit2 || parse_commit(commit2)) |
143 | cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(old_rev_sha1))); |
286 | cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(old_rev_sha1))); |
144 | } |
287 | } |
| |
288 | cgit_print_diffstat(old_rev_sha1, new_rev_sha1); |
| |
289 | |
145 | html("<table summary='diff' class='diff'>"); |
290 | html("<table summary='diff' class='diff'>"); |
146 | html("<tr><td>"); |
291 | html("<tr><td>"); |
147 | cgit_diff_tree(old_rev_sha1, new_rev_sha1, filepair_cb, prefix); |
292 | cgit_diff_tree(old_rev_sha1, new_rev_sha1, filepair_cb, prefix); |
148 | html("</td></tr>"); |
293 | html("</td></tr>"); |
149 | html("</table>"); |
294 | html("</table>"); |
150 | } |
295 | } |
|