From 69382320d96232ee8c73e664797da61e733c2427 Mon Sep 17 00:00:00 2001 From: Lukas Fleischer Date: Tue, 24 May 2011 18:38:40 +0000 Subject: Properly escape ampersands inside HTML attributes Ampersands ("&") appearing inside HTML attributes need to be translated to "&". Otherwise, invalid XHTML will be generated at various places, such as at tree views containing links to submodules. Signed-off-by: Lukas Fleischer Signed-off-by: Lars Hjemli --- diff --git a/html.c b/html.c index a0f6db4..24a03a5 100644 --- a/html.c +++ b/html.c @@ -138,7 +138,7 @@ void html_attr(const char *txt) const char *t = txt; while(t && *t){ int c = *t; - if (c=='<' || c=='>' || c=='\'' || c=='\"') { + if (c=='<' || c=='>' || c=='\'' || c=='\"' || c=='&') { html_raw(txt, t - txt); if (c=='>') html(">"); @@ -148,6 +148,8 @@ void html_attr(const char *txt) html("'"); else if (c=='"') html("""); + else if (c=='&') + html("&"); txt = t+1; } t++; -- cgit v0.9.0.2