Fix of the address type == other problem

1 files changed, 21 insertions, 0 deletions

diff --git a/kabc/address.cpp b/kabc/address.cpp
index 26e0b6a..c820a6c 100644
--- a/kabc/address.cpp
+++ b/kabc/address.cpp
@@ -101,410 +101,431 @@ void Address::setId( const QString &id )
 }
 
 QString Address::id() const
 {
   return mId;
 }
 
 void Address::setType( int type )
 {
   mEmpty = false;
 
   mType = type;
 }
 
 int Address::type() const
 {
   return mType;
 }
 
 QString Address::typeLabel() const
 {
   QString label;
   bool first = true;
 
   TypeList list = typeList();
 
   TypeList::Iterator it;
   for ( it = list.begin(); it != list.end(); ++it ) {
     if ( ( type() & (*it) ) && ( (*it) != Pref ) ) {
       label.append( ( first ? "" : "/" ) + typeLabel( *it ) );
       if ( first )
         first = false;
     }
   }
 
   return label;
 }
 
 void Address::setPostOfficeBox( const QString &s )
 {
   mEmpty = false;
 
   mPostOfficeBox = s;
 }
 
 QString Address::postOfficeBox() const
 {
   return mPostOfficeBox;
 }
 
 QString Address::postOfficeBoxLabel()
 {
   return i18n("Post Office Box");
 }
 
 
 void Address::setExtended( const QString &s )
 {
   mEmpty = false;
 
   mExtended = s;
 }
 
 QString Address::extended() const
 {
   return mExtended;
 }
 
 QString Address::extendedLabel()
 {
   return i18n("Extended Address Information");
 }
 
 
 void Address::setStreet( const QString &s )
 {
   mEmpty = false;
 
   mStreet = s;
 }
 
 QString Address::street() const
 {
   return mStreet;
 }
 
 QString Address::streetLabel()
 {
   return i18n("Street");
 }
 
 
 void Address::setLocality( const QString &s )
 {
   mEmpty = false;
 
   mLocality = s;
 }
 
 QString Address::locality() const
 {
   return mLocality;
 }
 
 QString Address::localityLabel()
 {
   return i18n("Locality");
 }
 
 
 void Address::setRegion( const QString &s )
 {
   mEmpty = false;
 
   mRegion = s;
 }
 
 QString Address::region() const
 {
   return mRegion;
 }
 
 QString Address::regionLabel()
 {
   return i18n("Region");
 }
 
 
 void Address::setPostalCode( const QString &s )
 {
   mEmpty = false;
 
   mPostalCode = s;
 }
 
 QString Address::postalCode() const
 {
   return mPostalCode;
 }
 
 QString Address::postalCodeLabel()
 {
   return i18n("Postal Code");
 }
 
 
 void Address::setCountry( const QString &s )
 {
   mEmpty = false;
 
   mCountry = s;
 }
 
 QString Address::country() const
 {
   return mCountry;
 }
 
 QString Address::countryLabel()
 {
   return i18n("Country");
 }
 
 
 void Address::setLabel( const QString &s )
 {
   mEmpty = false;
 
   mLabel = s;
 }
 
 QString Address::label() const
 {
   return mLabel;
 }
 
 QString Address::labelLabel()
 {
   return i18n("Delivery Label");
 }
 
 Address::TypeList Address::typeList()
 {
   TypeList list;
 
   list << Dom << Intl << Postal << Parcel << Home << Work << Pref;
 
   return list;
 }
 
 QString Address::typeLabel( int type )
 {
+    QString label;
+    if ( type & Dom )
+        label +=  i18n("Domestic")+" ";
+    if ( type & Intl )
+        label +=  i18n("International")+" ";
+    if ( type &  Postal )
+        label +=  i18n("Postal")+" ";
+    if ( type & Parcel  )
+        label +=  i18n("Parcel")+" ";
+    if ( type & Work )
+        label +=  i18n("Work Address", "Work")+" ";
+    if ( type & Home )
+        label +=  i18n("Home Address", "Home") +" ";
+    if ( type & Pref )
+        label +=  i18n("Preferred Address", "(p)");
+    if ( label.isEmpty() )
+        label =  i18n("Other");
+    return label;
+
+#if 0
   switch ( type ) {
     case Dom:
       return i18n("Domestic");
       break;
     case Intl:
       return i18n("International");
       break;
     case Postal:
       return i18n("Postal");
       break;
     case Parcel:
       return i18n("Parcel");
       break;
     case Home:
       return i18n("Home Address", "Home");
       break;
     case Work:
       return i18n("Work Address", "Work");
       break;
     case Pref:
       return i18n("Preferred Address");
       break;
     default:
       return i18n("Other");
       break;
   }
+#endif
 }
 
 void Address::dump() const
 {
     qDebug("Address::dump() +++++++++++++++++ ");
 #if 0
   kdDebug(5700) << "  Address {" << endl;
   kdDebug(5700) << "    Id: " << id() << endl;
   kdDebug(5700) << "    Extended: " << extended() << endl;
   kdDebug(5700) << "    Street: " << street() << endl;
   kdDebug(5700) << "    Postal Code: " << postalCode() << endl;
   kdDebug(5700) << "    Locality: " << locality() << endl;
   kdDebug(5700) << "  }" << endl;
 #endif
 }
 
 
 QString Address::formattedAddress( const QString &realName
                                  , const QString &orgaName ) const
 {
   QString ciso;
   QString addrTemplate;
   QString ret;
 
   // **************************************************************
   // LR:  currently we have no iso handling - we will format the address manually here
 
  QString text;
       if ( !street().isEmpty() )
         text += street() + "\n";
 
       if ( !postOfficeBox().isEmpty() )
         text += postOfficeBox() + "\n";
 
       text += locality() + QString(" ") + region();
 
       if ( !postalCode().isEmpty() )
         text += QString(", ") + postalCode();
 
       text += "\n";
 
       if ( !country().isEmpty() )
         text += country() + "\n";
 
       text += extended();
 
 
   return text;
   // **************************************************************
 
   // FIXME: first check for iso-country-field and prefer that one
   if ( !country().isEmpty() ) {
     ciso = countryToISO( country() );
   } else {
     // fall back to our own country
     ciso = KGlobal::locale()->country();
   }
   //qDebug("ciso %s ",ciso.latin1() );
   KSimpleConfig entry( locate( "locale", 
         QString( "l10n/" ) + ciso + QString( "/entry.desktop" ) ) );
   entry.setGroup( "KCM Locale" );
   
   // decide whether this needs special business address formatting
   if ( orgaName.isNull() ) {
     addrTemplate = entry.readEntry( "AddressFormat" );
   } else {
     addrTemplate = entry.readEntry( "BusinessAddressFormat" );
     if ( addrTemplate.isEmpty() )
       addrTemplate = entry.readEntry( "AddressFormat" );
   }
   
   // in the case there's no format found at all, default to what we've always
   // used:
   if ( addrTemplate.isEmpty() ) {
       qDebug("address format database incomplete****************** ");
     kdWarning(5700) << "address format database incomplete "
         << "(no format for locale " << ciso 
         << " found). Using default address formatting." << endl;
     addrTemplate = "%0(%n\\n)%0(%cm\\n)%0(%s\\n)%0(PO BOX %p\\n)%0(%l%w%r)%,%z";
   }
   
   // scan
   parseAddressTemplateSection( addrTemplate, ret, realName, orgaName );
 
   // now add the country line if needed (formatting this time according to
   // the rules of our own system country )
   if ( !country().isEmpty() ) {
     KSimpleConfig entry( locate( "locale", QString( "l10n/" )
           + KGlobal::locale()->country() + QString( "/entry.desktop" ) ) );
     entry.setGroup( "KCM Locale" );
     QString cpos = entry.readEntry( "AddressCountryPosition" );
     if ( "BELOW" == cpos || cpos.isEmpty() ) {
       ret = ret + "\n\n" + country().upper();
     } else if ( "below" == cpos ) {
       ret = ret + "\n\n" + country();
     } else if ( "ABOVE" == cpos ) {
       ret = country().upper() + "\n\n" + ret;
     } else if ( "above" == cpos ) {
       ret = country() + "\n\n" + ret;
     }
   }
   
   return ret;
 }
 
 bool Address::parseAddressTemplateSection( const QString &tsection, 
     QString &result, const QString &realName, const QString &orgaName ) const
 {
   // This method first parses and substitutes any bracketed sections and
   // after that replaces any tags with their values. If a bracketed section
   // or a tag evaluate to zero, they are not just removed but replaced
   // with a placeholder. This is because in the last step conditionals are
   // resolved which depend on information about zero-evaluations.
   result = tsection;
   int stpos = 0;
   bool ret = false;
   
   // first check for brackets that have to be evaluated first 
   int fpos = result.find( KABC_FMTTAG_purgeempty, stpos );
   while ( -1 != fpos ) {
     int bpos1 = fpos + KABC_FMTTAG_purgeempty.length();
     int bpos2;
     // expect opening bracket and find next balanced closing bracket. If 
     // next char is no opening bracket, continue parsing (no valid tag)
     if ( '(' == result[bpos1] ) {
       bpos2 = findBalancedBracket( result, bpos1 );
       if ( -1 != bpos2 ) {
         // we have balanced brackets, recursively parse:
         QString rplstr;
         bool purge = !parseAddressTemplateSection( result.mid( bpos1+1,
                                                    bpos2-bpos1-1 ), rplstr,
                                                    realName, orgaName );
         if ( purge ) {
           // purge -> remove all
           // replace with !_P_!, so conditional tags work later
           result.replace( fpos, bpos2 - fpos + 1, "!_P_!" );
           // leave stpos as it is
         } else {
           // no purge -> replace with recursively parsed string
           result.replace( fpos, bpos2 - fpos + 1, rplstr );
           ret = true;
           stpos = fpos + rplstr.length();
         }
       } else {
         // unbalanced brackets:  keep on parsing (should not happen 
         // and will result in bad formatting)
         stpos = bpos1; 
       }
     }
     fpos = result.find( KABC_FMTTAG_purgeempty, stpos );
   }
 
   // after sorting out all purge tags, we just search'n'replace the rest,
   // keeping track of whether at least one tag evaluates to something.
   // The following macro needs QString for R_FIELD
   // It substitutes !_P_! for empty fields so conditional tags work later
 #define REPLTAG(R_TAG,R_FIELD) \
   if ( result.contains(R_TAG, false) ) { \
     QString rpl = R_FIELD.isEmpty() ? QString("!_P_!") : R_FIELD; \
     result.replace( R_TAG, rpl ); \
     if ( !R_FIELD.isEmpty() ) { \
       ret = true; \
     } \
   }
   REPLTAG( KABC_FMTTAG_realname, realName );
   REPLTAG( KABC_FMTTAG_REALNAME, realName.upper() );
   REPLTAG( KABC_FMTTAG_company, orgaName );
   REPLTAG( KABC_FMTTAG_COMPANY, orgaName.upper() );
   REPLTAG( KABC_FMTTAG_pobox, postOfficeBox() );
   REPLTAG( KABC_FMTTAG_street, street() );
   REPLTAG( KABC_FMTTAG_STREET, street().upper() );
   REPLTAG( KABC_FMTTAG_zipcode, postalCode() );
   REPLTAG( KABC_FMTTAG_location, locality() );
   REPLTAG( KABC_FMTTAG_LOCATION, locality().upper() );
   REPLTAG( KABC_FMTTAG_region, region() );
   REPLTAG( KABC_FMTTAG_REGION, region().upper() );
   result.replace( KABC_FMTTAG_newline, "\n" );
 #undef REPLTAG
  
   // conditional comma 
   fpos = result.find( KABC_FMTTAG_condcomma, 0 );
   while ( -1 != fpos ) {
     QString str1 = result.mid( fpos - 5, 5 );
     QString str2 = result.mid( fpos + 2, 5 );
     if ( str1 != "!_P_!" && str2 != "!_P_!" ) {
       result.replace( fpos, 2, ", " );
     } else {
       result.remove( fpos, 2 );
     }
     fpos = result.find( KABC_FMTTAG_condcomma, fpos );
   }
   // conditional whitespace