Made sync code more readable by using defines

5 files changed, 62 insertions, 62 deletions

diff --git a/Makefile b/Makefile
index 826e70e..19c57e5 100644
--- a/Makefile
+++ b/Makefile
@@ -27,17 +27,11 @@ SUBDIRS_MICROKDE = \
 
 SUBDIRS_QTOPIA_PLUGIN = \
-   kabc/converter/qtopia \
-   kabc/plugins/qtopia \
-   kaddressbook/xxport/qtopia
+   kabc/plugins/qtopia 
 
 SUBDIRS_OPIE_PLUGIN = \
-   kabc/converter/opie \
-   kabc/plugins/opie \
-   kaddressbook/xxport/opie
+   kabc/plugins/opie
 
 SUBDIRS_SHARP_PLUGIN = \
-   kabc/converter/sharpdtm \
-   kabc/plugins/sharpdtm \
-   kaddressbook/xxport/sharpdtm
+   kabc/plugins/sharpdtm 
 
 SUBDIRS_LDAP_PLUGIN = \
@@ -149,8 +143,8 @@ variable_test: variable_info
         @echo SHARP PLUGIN will not be build, because BUILD_NO_SHARP_PLUGIN is set to $(BUILD_NO_SHARP_PLUGIN)
   else
-          ifndef SHARPDTMSDK
+        ifndef SHARPDTMSDK
         @echo SHARP PLUGIN can not be build, because SHARPDTMSDK is set to $(SHARPDTMSDK)
         $(error SHARPDTMSDK is not defined)
-          endif
+        endif
   endif
         @echo --------------------------------------
@@ -197,7 +191,4 @@ tmake: objects \
        libical/src/libicalss/Makefile$(PLATFORM) \
        kabc/Makefile$(PLATFORM) \
-       kabc/converter/opie/Makefile$(PLATFORM) \
-       kabc/converter/qtopia/Makefile$(PLATFORM) \
-       kabc/converter/sharpdtm/Makefile$(PLATFORM) \
        kabc/formats/binary/Makefile$(PLATFORM) \
        kabc/plugins/file/Makefile$(PLATFORM) \
@@ -214,5 +205,4 @@ tmake: objects \
        kmicromail/libetpan/Makefile$(PLATFORM) \
        kmicromail/libmailwrapper/Makefile$(PLATFORM) 
-       
 
 
@@ -246,14 +236,4 @@ kabc/Makefile$(PLATFORM): kabc/kabcE.pro
         cd kabc; tmake "CONFIG+=$(RELEASE_DEBUG)" kabcE.pro -o Makefile$(PLATFORM)
 
-kabc/converter/opie/Makefile$(PLATFORM): kabc/converter/opie/opieE.pro
-        cd kabc/converter/opie; tmake "CONFIG+=$(RELEASE_DEBUG)" opieE.pro -o Makefile$(PLATFORM)
-
-kabc/converter/qtopia/Makefile$(PLATFORM): kabc/converter/qtopia/qtopiaE.pro
-        cd kabc/converter/qtopia; tmake "CONFIG+=$(RELEASE_DEBUG)" qtopiaE.pro -o Makefile$(PLATFORM)
-   
-kabc/converter/sharpdtm/Makefile$(PLATFORM): kabc/converter/sharpdtm/sharpdtmE.pro
-        cd kabc/converter/sharpdtm; tmake "CONFIG+=$(RELEASE_DEBUG)" sharpdtmE.pro -o Makefile$(PLATFORM)
-
- 
 kabc/formats/binary/Makefile$(PLATFORM): kabc/formats/binary/kabcformat_binaryE.pro
         cd kabc/formats/binary; tmake "CONFIG+=$(RELEASE_DEBUG)" kabcformat_binaryE.pro -o Makefile$(PLATFORM)
diff --git a/korganizer/calendarview.cpp b/korganizer/calendarview.cpp
index 58b3d70..fd68dc4 100644
--- a/korganizer/calendarview.cpp
+++ b/korganizer/calendarview.cpp
@@ -130,7 +130,5 @@ extern int globalFlagBlockAgenda;
 extern int globalFlagBlockStartup;
 
-#define SYNC_MODE_NORMAL 0
-#define SYNC_MODE_SHARP 1
-#define SYNC_MODE_QTOPIA 2
+
 
 class KOBeamPrefs : public QDialog
@@ -728,8 +726,8 @@ int  CalendarView::takeEvent( Incidence* local,  Incidence* remote, int mode , b
     // 3 cancel 
     QDateTime lastSync = mLastCalendarSync;
-    if ( mGlobalSyncMode == SYNC_MODE_SHARP ) {
+    if ( mGlobalSyncMode == SYNC_MODE_EXTERNAL ) {
         bool remCh, locCh;
         remCh = ( remote->zaurusUid() != local->zaurusUid() );
-        locCh = ( local->zaurusStat() != local->revision() );
+        locCh = ( local->lastModified() > mLastCalendarSync );
         //qDebug("locCh %d remCh %d locuid %d remuid %d", locCh, remCh,local->zaurusUid(), remote->zaurusUid() );
         if ( !remCh && ! locCh ) {
@@ -751,6 +749,6 @@ int  CalendarView::takeEvent( Incidence* local,  Incidence* remote, int mode , b
         }
         full = true;  
-        if ( mode < 3 )
-            mode = 3;
+        if ( mode < SYNC_PREF_ASK )
+            mode = SYNC_PREF_ASK;
     } else {
           if ( local->lastModified() == remote->lastModified() )
@@ -775,8 +773,8 @@ int  CalendarView::takeEvent( Incidence* local,  Incidence* remote, int mode , b
         if ( equ ) {
             //qDebug("equal ");
-            if ( mGlobalSyncMode == SYNC_MODE_SHARP ) {
+            if ( mGlobalSyncMode == SYNC_MODE_EXTERNAL ) {
                 local->setZaurusUid( remote->zaurusUid() );
             }
-            if ( mode < 4 )
+            if ( mode < SYNC_PREF_FORCE_LOCAL )
                 return 0;
               
@@ -786,9 +784,9 @@ int  CalendarView::takeEvent( Incidence* local,  Incidence* remote, int mode , b
     int result;
     bool localIsNew;
-    if ( full && mode < 2 )
-        mode = 3;
+    if ( full && mode < SYNC_PREF_NEWEST )
+        mode = SYNC_PREF_ASK;
 
     switch( mode ) {
-    case 0:
+    case SYNC_PREF_LOCAL:
         if ( lastSync > remote->lastModified() )
             return 1;
@@ -797,5 +795,5 @@ int  CalendarView::takeEvent( Incidence* local,  Incidence* remote, int mode , b
         return 1;
         break;
-    case 1:
+    case SYNC_PREF_REMOTE:
         if ( lastSync > remote->lastModified() )
             return 1;
@@ -804,5 +802,5 @@ int  CalendarView::takeEvent( Incidence* local,  Incidence* remote, int mode , b
         return 2;
         break;
-    case 2:
+    case SYNC_PREF_NEWEST:
         if ( local->lastModified() > remote->lastModified() )
             return 1;
@@ -810,5 +808,5 @@ int  CalendarView::takeEvent( Incidence* local,  Incidence* remote, int mode , b
             return 2;
         break;
-    case 3: 
+    case SYNC_PREF_ASK: 
         //qDebug("lsy %s  ---  lo %s  --- re %s ", lastSync.toString().latin1(), local->lastModified().toString().latin1(), remote->lastModified().toString().latin1()  );
         if ( lastSync > remote->lastModified() )
@@ -836,12 +834,13 @@ int  CalendarView::takeEvent( Incidence* local,  Incidence* remote, int mode , b
           
         break;
-    case 4:
+    case SYNC_PREF_FORCE_LOCAL:
         return 1;
         break;
-    case 5:
+    case SYNC_PREF_FORCE_REMOTE:
         return 2;
         break;
        
     default:
+        // SYNC_PREF_TAKE_BOTH not implemented
         break;
     }
@@ -997,5 +996,5 @@ bool  CalendarView::synchronizeCalendar( Calendar* local,  Calendar* remote, int
                 }
             } else { //  no conflict
-                if ( mGlobalSyncMode == SYNC_MODE_SHARP ) {
+                if ( mGlobalSyncMode == SYNC_MODE_EXTERNAL ) {
                     QString des = eventLSync->description(); 
                     QString pref = "e";
@@ -1003,5 +1002,5 @@ bool  CalendarView::synchronizeCalendar( Calendar* local,  Calendar* remote, int
                         pref = "t";
                     if ( des.find(pref+QString::number( inR->zaurusId() ) +"," ) >= 0 && mode != 5) { // delete it
-                        inR->setZaurusStat( -3 );
+                        inR->setZaurusStat( SYNC_TEMPSTATE_DELETE );
                         //remote->deleteIncidence( inR );
                         ++deletedEventR; 
@@ -1046,10 +1045,10 @@ bool  CalendarView::synchronizeCalendar( Calendar* local,  Calendar* remote, int
         if ( uid.left(21) == QString("last-syncEvent-device") )
             skipIncidence = true;
-        if ( mGlobalSyncMode == SYNC_MODE_SHARP && inL->type() == "Journal" )
+        if ( mGlobalSyncMode == SYNC_MODE_EXTERNAL && inL->type() == "Journal" )
             skipIncidence = true;
         if ( !skipIncidence )  {
             inR = remote->incidence( uid );
             if ( ! inR ) { 
-                if ( mGlobalSyncMode == SYNC_MODE_SHARP ) {
+                if ( mGlobalSyncMode == SYNC_MODE_EXTERNAL ) {
                     if ( inL->zaurusId() >= 0 && mode != 4 ) {
                         local->deleteIncidence( inL );
@@ -1142,5 +1141,5 @@ void CalendarView::syncSharp()
 {
 #ifndef DESKTOP_VERSION
-    mGlobalSyncMode = SYNC_MODE_SHARP;
+    mGlobalSyncMode = SYNC_MODE_EXTERNAL;
     //mCurrentSyncDevice = "sharp-DTM";
     if ( KOPrefs::instance()->mAskForPreferences )
@@ -1161,8 +1160,10 @@ void CalendarView::syncSharp()
                 QPtrList<Incidence> iL = mCalendar->rawIncidences(); 
                 Incidence* inc = iL.first();
+                /* obsolete
                 while ( inc ) {
                     inc->setZaurusStat( inc->revision () );
                     inc =  iL.next();
                 }
+                */
                 // pending: clean last sync event description
                 sharpFormat.save(calendar);
@@ -1171,5 +1172,5 @@ void CalendarView::syncSharp()
                 Incidence* loc;
                 while ( inc ) {
-                    if ( inc->zaurusStat() == -4 ) {
+                    if ( inc->zaurusStat() == SYNC_TEMPSTATE_NEW_ID ) {
                         loc = mCalendar->incidence(inc->uid() );
                         if ( loc ) {
diff --git a/libkcal/sharpformat.cpp b/libkcal/sharpformat.cpp
index f83f72e..973f19d 100644
--- a/libkcal/sharpformat.cpp
+++ b/libkcal/sharpformat.cpp
@@ -43,4 +43,5 @@
 
 #include "sharpformat.h"
+#include "syncdefines.h"
 
 using namespace KCal;
@@ -92,5 +93,5 @@ class SharpParser : public QObject
             event->setZaurusId( attList[0].toInt() );
             event->setZaurusUid( cSum );
-            event->setZaurusStat( -2 );
+            event->setZaurusStat(SYNC_TEMPSTATE_NEW_EXTERNAL );
 
             event->setSummary( attList[2] );
@@ -203,5 +204,5 @@ class SharpParser : public QObject
             todo->setZaurusId( attList[0].toInt() );
             todo->setZaurusUid( cSum );
-            todo->setZaurusStat( -2 );
+            todo->setZaurusStat( SYNC_TEMPSTATE_NEW_EXTERNAL );
       
             todo->setSummary( attList[7] );
@@ -468,5 +469,5 @@ int  SharpFormat::getNumFromRecord( QString answer, Incidence* inc )
                 inc->setZaurusId( newnum );
                 inc->setZaurusUid( getCsum( templist ) );
-                inc->setZaurusStat( -4 );
+                inc->setZaurusStat( SYNC_TEMPSTATE_NEW_ID );
             }
         }
@@ -507,9 +508,9 @@ bool SharpFormat::save( Calendar *calendar)
     while ( ev ) {
         //qDebug("i %d ", ++i);
-        if ( ev->zaurusStat() != -2 ) {
+        if ( ev->zaurusStat() != SYNC_TEMPSTATE_NEW_EXTERNAL ) {
             status.setText ( message + QString::number ( ++procCount ) );
              qApp->processEvents();
             QString eString = getEventString( ev );
-            if ( ev->zaurusStat() == -3 ) { // delete
+            if ( ev->zaurusStat() == SYNC_TEMPSTATE_DELETE ) { // delete
                 // deleting empty strings does not work.
                 // we write first and x  and then delete the record with the x
@@ -593,9 +594,9 @@ bool SharpFormat::save( Calendar *calendar)
     procCount = 0;
     while ( to ) {
-       if ( to->zaurusStat() != -2 ) {
+       if ( to->zaurusStat() != SYNC_TEMPSTATE_NEW_EXTERNAL ) {
              status.setText ( message + QString::number ( ++procCount ) );
              qApp->processEvents();
             QString eString = getTodoString( to );
-            if ( to->zaurusStat() == -3 ) { // delete
+            if ( to->zaurusStat() == SYNC_TEMPSTATE_DELETE ) { // delete
                 // deleting empty strings does not work.
                 // we write first and x  and then delete the record with the x
diff --git a/libkcal/syncdefines.h b/libkcal/syncdefines.h
new file mode 100644
index 0000000..57642ec
--- a/dev/null
+++ b/libkcal/syncdefines.h
@@ -0,0 +1,22 @@
+ 
+#ifndef _KSYNC_DEFINES_H_
+#define _KSYNC_DEFINES_H_
+
+#define SYNC_PREF_LOCAL 0
+#define SYNC_PREF_REMOTE 1
+#define SYNC_PREF_NEWEST 2
+#define SYNC_PREF_ASK 3
+#define SYNC_PREF_FORCE_LOCAL 4
+#define SYNC_PREF_FORCE_REMOTE 5
+#define SYNC_PREF_TAKE_BOTH 6
+
+#define SYNC_MODE_NORMAL 0
+#define SYNC_MODE_EXTERNAL 1
+
+#define SYNC_TEMPSTATE_INITIAL 0
+#define SYNC_TEMPSTATE_NEW_EXTERNAL  -2
+#define SYNC_TEMPSTATE_DELETE -3
+#define SYNC_TEMPSTATE_NEW_ID -4
+
+
+#endif
diff --git a/libkdepim/ksyncprofile.h b/libkdepim/ksyncprofile.h
index 238ffad..3f7f1ac 100644
--- a/libkdepim/ksyncprofile.h
+++ b/libkdepim/ksyncprofile.h
@@ -28,11 +28,7 @@
 #include <qstring.h>
 
-#define SYNC_PREF_LOCAL 0
-#define SYNC_PREF_REMOTE 1
-#define SYNC_PREF_NEWEST 2
-#define SYNC_PREF_ASK 3
-#define SYNC_PREF_FORCE_LOCAL 4
-#define SYNC_PREF_FORCE_REMOTE 5
-#define SYNC_PREF_TAKE_BOTH 6
+#include <libkcal/syncdefines.h>
+
+
 
 class KConfig;