fixed a potential crash when loading adresses from any adressbook file.

3 files changed, 16 insertions, 5 deletions

diff --git a/kabc/vcard/ContentLine.cpp b/kabc/vcard/ContentLine.cpp
index 0fb5b5d..f7e04a9 100644
--- a/kabc/vcard/ContentLine.cpp
+++ b/kabc/vcard/ContentLine.cpp
@@ -1,196 +1,202 @@
 /*
 	libvcard - vCard parsing library for vCard version 3.0
 
 	Copyright (C) 1999 Rik Hemsley rik@kde.org
 
   Permission is hereby granted, free of charge, to any person obtaining a copy
   of this software and associated documentation files (the "Software"), to
   deal in the Software without restriction, including without limitation the
   rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
   sell copies of the Software, and to permit persons to whom the Software is
   furnished to do so, subject to the following conditions:
 
   The above copyright notice and this permission notice shall be included in
   all copies or substantial portions of the Software.
 
   THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
   IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
   FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
   AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
   ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
   WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 */
 
 #include <qcstring.h>
 #include <qstrlist.h>
 #include <qregexp.h>
 
 #include <kdebug.h>
 
 #include <VCardAdrParam.h>
 #include <VCardAgentParam.h>
 #include <VCardDateParam.h>
 #include <VCardEmailParam.h>
 #include <VCardImageParam.h>
 #include <VCardSourceParam.h>
 #include <VCardTelParam.h>
 #include <VCardTextBinParam.h>
 #include <VCardTextParam.h>
 
 #include <VCardAdrValue.h>
 #include <VCardAgentValue.h>
 #include <VCardDateValue.h>
 #include <VCardImageValue.h>
 #include <VCardTextValue.h>
 #include <VCardTextBinValue.h>
 #include <VCardLangValue.h>
 #include <VCardNValue.h>
 #include <VCardURIValue.h>
 #include <VCardSoundValue.h>
 #include <VCardClassValue.h>
 #include <VCardFloatValue.h>
 #include <VCardOrgValue.h>
 #include <VCardTelValue.h>
 #include <VCardTextListValue.h>
 #include <VCardUTCValue.h>
 #include <VCardGeoValue.h>
 
 #include <VCardRToken.h>
 #include <VCardContentLine.h>
 
 #include <VCardEntity.h>
 #include <VCardEnum.h>
 #include <VCardDefines.h>
 
 using namespace VCARD;
 
 ContentLine::ContentLine()
 	:	Entity(),
-		value_(0)
+		value_(0),
+		paramType_( ParamUnknown ),
+		valueType_( ValueUnknown ),
+		entityType_( EntityUnknown )
 {
   paramList_.setAutoDelete( TRUE );
 }
 
 ContentLine::ContentLine(const ContentLine & x)
 	:	Entity(x),
                 group_ (x.group_),
                 name_ (x.name_),
 /*US		paramList_(x.paramList_),*/
 		value_(x.value_->clone()),
 		paramType_(x.paramType_),
 		valueType_(x.valueType_),
 		entityType_(x.entityType_)
 {
   paramList_.setAutoDelete( TRUE );
 
 
   ParamListIterator it(x.paramList_);
   for (; it.current(); ++it)
   {
     Param *p = new Param;
 	p->setName( it.current()->name() );
 	p->setValue( it.current()->value() );
     paramList_.append(p);
   }
 
 }
 
 ContentLine::ContentLine(const QCString & s)
 	:	Entity(s),
-		value_(0)
+		value_(0),
+		paramType_( ParamUnknown ),
+		valueType_( ValueUnknown ),
+		entityType_( EntityUnknown )
 {
   paramList_.setAutoDelete( TRUE );
 }
 
 	ContentLine &
 ContentLine::operator = (ContentLine & x)
 {
 	if (*this == x) return *this;
 
     ParamListIterator it(x.paramList_);
     for (; it.current(); ++it)
     {
       Param *p = new Param;
       p->setName( it.current()->name() );
       p->setValue( it.current()->value() );
       paramList_.append(p);
     }
 
 	value_ = x.value_->clone();
 
 	Entity::operator = (x);
 	return *this;
 }
 
 	ContentLine &
 ContentLine::operator = (const QCString & s)
 {
 	Entity::operator = (s);
 	delete value_;
 	value_ = 0;
 	return *this;
 }
 
 	bool
 ContentLine::operator == (ContentLine & x)
 {
 	x.parse();
 
 	QPtrListIterator<Param> it(x.paramList());
 
 	if (!paramList_.find(it.current()))
 		return false;
 
 	return true;
 }
 
 ContentLine::~ContentLine()
 {
 	delete value_;
 	value_ = 0;
 }
 
 	void
 ContentLine::_parse()
 {
 	vDebug("parse");
 
 	// Unqote newlines
 	strRep_ = strRep_.replace( QRegExp( "\\\\n" ), "\n" );
 
 	int split = strRep_.find(':');
 
 	if (split == -1) { // invalid content line
 		vDebug("No ':'");
 		return;
 	}
 
 	QCString firstPart(strRep_.left(split));
 	QCString valuePart(strRep_.mid(split + 1));
 
 	split = firstPart.find('.');
 
 	if (split != -1) {
 		group_		= firstPart.left(split);
 		firstPart	= firstPart.mid(split + 1);
 	}
 
 	vDebug("Group == " + group_);
 	vDebug("firstPart == " + firstPart);
 	vDebug("valuePart == " + valuePart);
 
 	// Now we have the group, the name and param list together and the value.
 
 	QStrList l;
 
 	RTokenise(firstPart, ";", l);
 
 	if (l.count() == 0) {// invalid - no name !
 		vDebug("No name for this content line !");
 		return;
 	}
 
 	name_ = l.at(0);
 
 	// Now we have the name, so the rest of 'l' is the params.
 	// Remove the name part.
diff --git a/kabc/vcard/VCardv.cpp b/kabc/vcard/VCardv.cpp
index 391a69e..d19a004 100644
--- a/kabc/vcard/VCardv.cpp
+++ b/kabc/vcard/VCardv.cpp
@@ -95,198 +95,202 @@ VCard::~VCard()
 
 	void
 VCard::_parse()
 {
 	vDebug("parse() called");
 	QStrList l;
 
 	RTokenise(strRep_, "\r\n", l);
 
 	if (l.count() < 3) { // Invalid VCARD !
 		vDebug("Invalid vcard");
 		return;
 	}
 
 	// Get the first line
 	QCString beginLine = QCString(l.at(0)).stripWhiteSpace();
 
 	vDebug("Begin line == \"" + beginLine + "\"");
 
 	// Remove extra blank lines
 	while (QCString(l.last()).isEmpty())
 		l.remove(l.last());
 
 	// Now we know this is the last line
 	QCString endLine = l.last();
 
 	// Trash the first and last lines as we have seen them.
 	l.remove(0u);
 	l.remove(l.last());
 
 	///////////////////////////////////////////////////////////////
 	// FIRST LINE
 
 	int split = beginLine.find(':');
 
 	if (split == -1) { // invalid, no BEGIN
 		vDebug("No split");
 		return;
 	}
 
 	QCString firstPart(beginLine.left(split));
 	QCString valuePart(beginLine.mid(split + 1));
 
 	split = firstPart.find('.');
 
 	if (split != -1) {
 		group_		= firstPart.left(split);
 		firstPart	= firstPart.right(firstPart.length() - split - 1);
 	}
 
 	if (qstrnicmp(firstPart, "BEGIN", 5) != 0) { // No BEGIN !
 		vDebug("No BEGIN");
 		return;
 	}
 
 	if (qstrnicmp(valuePart, "VCARD", 5) != 0) { // Not a vcard !
 		vDebug("No VCARD");
 		return;
 	}
 
 	///////////////////////////////////////////////////////////////
 	// CONTENT LINES
 	//
 	vDebug("Content lines");
 
 	// Handle folded lines.
 
 	QStrList refolded;
 
 	QStrListIterator it(l);
 
 	QCString cur;
 
 	for (; it.current(); ++it) {
 
 		cur = it.current();
 
 		++it;
 
 		while (
 			it.current()		&&
 			it.current()[0] == ' '	&&
 			strlen(it.current()) != 1)
 		{
 			cur += it.current() + 1;
 			++it;
 		}
 
 		--it;
 
 		refolded.append(cur);
 	}
 
 	QStrListIterator it2(refolded);
 
 	for (; it2.current(); ++it2) {
-
 		vDebug("New contentline using \"" + QCString(it2.current()) + "\"");
 		ContentLine * cl = new ContentLine(it2.current());
 
 		cl->parse();
-
+		if (cl->value() == 0)
+		{
+		    qDebug("Content line could not be parsed. Discarded: %s" + QCString(it2.current()));
+		    delete cl;
+		}
+		else
 		contentLineList_.append(cl);
 	}
 
 	///////////////////////////////////////////////////////////////
 	// LAST LINE
 
 	split = endLine.find(':');
 
 	if (split == -1) // invalid, no END
 		return;
 
 	firstPart = endLine.left(split);
 	valuePart = endLine.right(firstPart.length() - split - 1);
 
 	split = firstPart.find('.');
 
 	if (split != -1) {
 		group_		= firstPart.left(split);
 		firstPart	= firstPart.right(firstPart.length() - split - 1);
 	}
 
 	if (qstricmp(firstPart, "END") != 0) // No END !
 		return;
 
 	if (qstricmp(valuePart, "VCARD") != 0) // Not a vcard !
 		return;
 }
 
 	void
 VCard::_assemble()
 {
 	vDebug("Assembling vcard");
 	strRep_ = "BEGIN:VCARD\r\n";
 	strRep_ += "VERSION:3.0\r\n";
 
 	QPtrListIterator<ContentLine> it(contentLineList_);
 
 	for (; it.current(); ++it)
 		strRep_ += it.current()->asString() + "\r\n";
 
 	strRep_ += "END:VCARD\r\n";
 }
 
 	bool
 VCard::has(EntityType t)
 {
 	parse();
 	return contentLine(t) == 0 ? false : true;
 }
 
 	bool
 VCard::has(const QCString & s)
 {
 	parse();
 	return contentLine(s) == 0 ? false : true;
 }
 
 	void
 VCard::add(const ContentLine & cl)
 {
 	parse();
 	ContentLine * c = new ContentLine(cl);
 	contentLineList_.append(c);
 }
 
 	void
 VCard::add(const QCString & s)
 {
 	parse();
 	ContentLine * c = new ContentLine(s);
 	contentLineList_.append(c);
 }
 
 	ContentLine *
 VCard::contentLine(EntityType t)
 {
 	parse();
 	QPtrListIterator<ContentLine> it(contentLineList_);
 
 	for (; it.current(); ++it)
 		if (it.current()->entityType() == t)
 			return it.current();
 
 	return 0;
 }
 
 	ContentLine *
 VCard::contentLine(const QCString & s)
 {
 	parse();
 	QPtrListIterator<ContentLine> it(contentLineList_);
 
 	for (; it.current(); ++it)
 		if (it.current()->entityType() == EntityNameToEntityType(s))
 			return it.current();
 
diff --git a/kabc/vcard/include/VCardDefines.h b/kabc/vcard/include/VCardDefines.h
index dd38ae2..557410f 100644
--- a/kabc/vcard/include/VCardDefines.h
+++ b/kabc/vcard/include/VCardDefines.h
@@ -1,52 +1,53 @@
 /*
 	libvcard - vCard parsing library for vCard version 3.0
 	
 	Copyright (C) 1998 Rik Hemsley rik@kde.org
 	
   Permission is hereby granted, free of charge, to any person obtaining a copy
   of this software and associated documentation files (the "Software"), to
   deal in the Software without restriction, including without limitation the
   rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
   sell copies of the Software, and to permit persons to whom the Software is
   furnished to do so, subject to the following conditions:
 
   The above copyright notice and this permission notice shall be included in
   all copies or substantial portions of the Software.
 
   THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
   IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
   FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
   AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
   ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
   WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 */
 
 #ifndef VCARD_DEFINES_H
 #define VCARD_DEFINES_H
 
 #include <kdebug.h>
 
 #ifdef VCARD_DEBUG
-#define vDebug(a) kdDebug(5710) << a << endl;
+//US #define vDebug(a) kdDebug(5710) << a << endl;
+#define vDebug(a) qDebug(a);
 #else
 #define vDebug(a)
 #endif
 
 #if 0
 #ifndef NDEBUG
 #	include <qcstring.h>
 #	include <iostream>
 #	ifdef __GNUG__
 #		define vDebug(a) cerr << className() << ":" << __FUNCTION__ << " (" \
 						<< __LINE__ << "): " << QCString((a)).data() << endl;
 #	else
 #		define vDebug(a) cerr << className() << ": " \
 						<< QCString((a)).data() << endl;
 #	endif
 #else
 #	define vDebug(a)
 #endif
 #endif
 
 #endif // Included this file