fixed a potential crash when loading adresses from any adressbook file.

4 files changed, 20 insertions, 7 deletions

diff --git a/kabc/vcard/ContentLine.cpp b/kabc/vcard/ContentLine.cpp
index 0fb5b5d..f7e04a9 100644
--- a/kabc/vcard/ContentLine.cpp
+++ b/kabc/vcard/ContentLine.cpp
@@ -57,25 +57,28 @@
 
 #include <VCardRToken.h>
 #include <VCardContentLine.h>
 
 #include <VCardEntity.h>
 #include <VCardEnum.h>
 #include <VCardDefines.h>
 
 using namespace VCARD;
 
 ContentLine::ContentLine()
 	:	Entity(),
-		value_(0)
+		value_(0),
+		paramType_( ParamUnknown ),
+		valueType_( ValueUnknown ),
+		entityType_( EntityUnknown )
 {
   paramList_.setAutoDelete( TRUE );
 }
 
 ContentLine::ContentLine(const ContentLine & x)
 	:	Entity(x),
                 group_ (x.group_),
                 name_ (x.name_),
 /*US		paramList_(x.paramList_),*/
 		value_(x.value_->clone()),
 		paramType_(x.paramType_),
 		valueType_(x.valueType_),
@@ -88,25 +91,28 @@ ContentLine::ContentLine(const ContentLine & x)
   for (; it.current(); ++it)
   {
     Param *p = new Param;
 	p->setName( it.current()->name() );
 	p->setValue( it.current()->value() );
     paramList_.append(p);
   }
 
 }
 
 ContentLine::ContentLine(const QCString & s)
 	:	Entity(s),
-		value_(0)
+		value_(0),
+		paramType_( ParamUnknown ),
+		valueType_( ValueUnknown ),
+		entityType_( EntityUnknown )
 {
   paramList_.setAutoDelete( TRUE );
 }
 
 	ContentLine &
 ContentLine::operator = (ContentLine & x)
 {
 	if (*this == x) return *this;
 
     ParamListIterator it(x.paramList_);
     for (; it.current(); ++it)
     {
diff --git a/kabc/vcard/VCardv.cpp b/kabc/vcard/VCardv.cpp
index 391a69e..d19a004 100644
--- a/kabc/vcard/VCardv.cpp
+++ b/kabc/vcard/VCardv.cpp
@@ -179,31 +179,35 @@ VCard::_parse()
 			cur += it.current() + 1;
 			++it;
 		}
 
 		--it;
 
 		refolded.append(cur);
 	}
 
 	QStrListIterator it2(refolded);
 
 	for (; it2.current(); ++it2) {
-
-		vDebug("New contentline using \"" + QCString(it2.current()) + "\"");
+	  vDebug("New contentline using \"" + QCString(it2.current()) + "\"");
 		ContentLine * cl = new ContentLine(it2.current());
 
 		cl->parse();
-
-		contentLineList_.append(cl);
+		if (cl->value() == 0)
+		{
+		    qDebug("Content line could not be parsed. Discarded: %s" + QCString(it2.current()));
+		    delete cl;
+		}
+		else
+		  contentLineList_.append(cl);
 	}
 
 	///////////////////////////////////////////////////////////////
 	// LAST LINE
 
 	split = endLine.find(':');
 
 	if (split == -1) // invalid, no END
 		return;
 
 	firstPart = endLine.left(split);
 	valuePart = endLine.right(firstPart.length() - split - 1);
diff --git a/kabc/vcard/include/VCardDefines.h b/kabc/vcard/include/VCardDefines.h
index dd38ae2..557410f 100644
--- a/kabc/vcard/include/VCardDefines.h
+++ b/kabc/vcard/include/VCardDefines.h
@@ -18,25 +18,26 @@
   FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
   AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
   ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
   WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 */
 
 #ifndef VCARD_DEFINES_H
 #define VCARD_DEFINES_H
 
 #include <kdebug.h>
 
 #ifdef VCARD_DEBUG
-#define vDebug(a) kdDebug(5710) << a << endl;
+//US #define vDebug(a) kdDebug(5710) << a << endl;
+#define vDebug(a) qDebug(a);
 #else
 #define vDebug(a)
 #endif
 
 #if 0
 #ifndef NDEBUG
 #	include <qcstring.h>
 #	include <iostream>
 #	ifdef __GNUG__
 #		define vDebug(a) cerr << className() << ":" << __FUNCTION__ << " (" \
 						<< __LINE__ << "): " << QCString((a)).data() << endl;
 #	else
diff --git a/kabc/vcardformatimpl.cpp b/kabc/vcardformatimpl.cpp
index 2d6eb3d..1bf2cde 100644
--- a/kabc/vcardformatimpl.cpp
+++ b/kabc/vcardformatimpl.cpp
@@ -252,24 +252,25 @@ bool VCardFormatImpl::loadAddressee( Addressee& addressee, VCard *v )
 
       case EntityAgent:
         addressee.setAgent( readAgentValue( cl ) );
         break;
 
       case EntitySound:
         addressee.setSound( readSoundValue( cl, addressee ) );
         break;
 
       default:
         kdDebug(5700) << "VCardFormat::load(): Unsupported entity: "
                     << int( type ) << ": " << cl->asString() << endl;
+	qDebug("VCardFormat::load(): Unsupported entity: %i: %s ", int(type), (const char*)cl->asString());
         break;
     }
   }
 
   for( cl = contentLines.first(); cl; cl = contentLines.next() ) {
     EntityType type = cl->entityType();
     if ( type == EntityLabel ) {
       int type = readAddressParam( cl );
       Address address = addressee.address( type );
       if ( address.isEmpty() )
         address.setType( type );
 
@@ -630,24 +631,25 @@ PhoneNumber VCardFormatImpl::readTelephoneValue( ContentLine *cl )
   p.setType( type );
 
   return p;
 }
 
 QString VCardFormatImpl::readTextValue( ContentLine *cl )
 {
   VCARD::Value *value = cl->value();
   if ( value ) {
     return QString::fromUtf8( value->asString() );
   } else {
     kdDebug(5700) << "No value: " << cl->asString() << endl;
+    qDebug("No value: %s", (const char*)(cl->asString()));
     return QString::null;
   }
 }
 
 QDate VCardFormatImpl::readDateValue( ContentLine *cl )
 {
   DateValue *dateValue = (DateValue *)cl->value();
   if ( dateValue )
     return dateValue->qdate();
   else
     return QDate();
 }