kcmultidialog can now handle the configuration of multiple applications at once

9 files changed, 78 insertions, 184 deletions

diff --git a/kaddressbook/kabcore.cpp b/kaddressbook/kabcore.cpp
index 2494aa2..1667400 100644
--- a/kaddressbook/kabcore.cpp
+++ b/kaddressbook/kabcore.cpp
@@ -78,3 +78,2 @@
 
-#include <kcmkabconfig.h>
 
@@ -90,3 +89,4 @@
 #endif // KAB_EMBEDDED
-#include <kcmkabconfig.h>
+#include "kcmconfigs/kcmkabconfig.h"
+#include "kcmconfigs/kcmkdepimconfig.h"
 
@@ -1199,5 +1199,11 @@ void KABCore::openConfigDialog()
 {
-    KCMultiDialog*  ConfigureDialog = new KCMultiDialog( "PIM", this ,"kabconfigdialog", true );
+        KABPrefs* prefs = KABPrefs::instance();
+    KCMultiDialog*  ConfigureDialog = new KCMultiDialog( prefs, "PIM", this ,"kabconfigdialog", true );
     KCMKabConfig* kabcfg = new KCMKabConfig( ConfigureDialog->getNewVBoxPage(i18n( "Addressbook")) , "KCMKabConfig" );
     ConfigureDialog->addModule(kabcfg );
+    KCMKdePimConfig* kdelibcfg = new KCMKdePimConfig( ConfigureDialog->getNewVBoxPage(i18n( "Pim")) , "KCMKdeLibConfig" );
+    ConfigureDialog->addModule(kdelibcfg );
+
+
+
     connect( ConfigureDialog, SIGNAL( applyClicked() ),
@@ -1516,3 +1522,3 @@ void KABCore::initActions()
                                "kaddressbook_beam_vcard" );
- 
+
     mActionBeam = new KAction( i18n( "&Beam personal vCard" ), "beam", 0, this,
@@ -1623,3 +1629,3 @@ void KABCore::initActions()
 
- 
+
 
diff --git a/kaddressbook/kabprefs.cpp b/kaddressbook/kabprefs.cpp
index 8bd4b15..0c192dd 100644
--- a/kaddressbook/kabprefs.cpp
+++ b/kaddressbook/kabprefs.cpp
@@ -52,4 +52,2 @@ KABPrefs::KABPrefs()
   addItemBool("ToolBarUp",&mToolBarUp, false );
-  addItemInt( "EmailChannelType", &mEmailClient, OMPI );
-  addItemString( "EmailChannelOther", &mEmailChannel, "" );
 
diff --git a/kaddressbook/kabprefs.h b/kaddressbook/kabprefs.h
index c81a9a9..8f149ac 100644
--- a/kaddressbook/kabprefs.h
+++ b/kaddressbook/kabprefs.h
@@ -39,10 +39,2 @@ class KABPrefs : public KPimPrefs
 
-  enum EMailClients {
-    OMPI = 0,
-    QTOPIA = 1,
-    OPIE = 2,
-    OTHER = 3
-  };
-
-
     // General
@@ -60,4 +52,2 @@ class KABPrefs : public KPimPrefs
 
-    int mEmailClient;
-    QString mEmailChannel;
 
diff --git a/kaddressbook/kaddressbook.pro b/kaddressbook/kaddressbook.pro
index 0da5842..b57317f 100644
--- a/kaddressbook/kaddressbook.pro
+++ b/kaddressbook/kaddressbook.pro
@@ -8,3 +8,3 @@ include( ../variables.pri )
 
-INCLUDEPATH += . ./details  ./features ./kcmconfigs  ./xxport ../microkde ../microkde/kdecore ../microkde/kutils ../microkde/kio/kfile ../microkde/kio/kio ../microkde/kdeui ../microkde/kresources ../kabc  ../ interfaces 
+INCLUDEPATH += . ./details  ./features  ./xxport ../libkdepim ../microkde ../microkde/kdecore ../microkde/kutils ../microkde/kio/kfile ../microkde/kio/kio ../microkde/kdeui ../microkde/kresources ../kabc  ../ interfaces 
 DEFINES += KAB_EMBEDDED KAB_NOSPLITTER DESKTOP_VERSION
diff --git a/kaddressbook/kaddressbookE.pro b/kaddressbook/kaddressbookE.pro
index 95e6641..41f293d 100644
--- a/kaddressbook/kaddressbookE.pro
+++ b/kaddressbook/kaddressbookE.pro
@@ -12,3 +12,3 @@ DESTDIR=$(QPEDIR)/bin
 
-INCLUDEPATH += . ./details ./features ./kcmconfigs ./xxport ../microkde ../microkde/kdecore ../microkde/kutils ../microkde/kio/kfile ../microkde/kio/kio ../microkde/kdeui ../microkde/kresources ../kabc ../qtcompat ../ interfaces $(QPEDIR)/include
+INCLUDEPATH += . ./details ./features ./xxport ../libkdepim ../microkde ../microkde/kdecore ../microkde/kutils ../microkde/kio/kfile ../microkde/kio/kio ../microkde/kdeui ../microkde/kresources ../kabc ../qtcompat ../ interfaces $(QPEDIR)/include
 DEFINES += KAB_EMBEDDED KAB_NOSPLITTER
diff --git a/kaddressbook/kcmconfigs/kabconfigwidget.cpp b/kaddressbook/kcmconfigs/kabconfigwidget.cpp
index 1bac26f..b5309c0 100644
--- a/kaddressbook/kcmconfigs/kabconfigwidget.cpp
+++ b/kaddressbook/kcmconfigs/kabconfigwidget.cpp
@@ -155,36 +155,2 @@ KABConfigWidget::KABConfigWidget( QWidget *parent, const char *name )
 
-  // mailclient page
-  QWidget *mailclientPage = new QWidget( this );
-  layout = new QVBoxLayout( mailclientPage, KDialog::marginHintSmall(),
-                                            KDialog::spacingHintSmall() );
-
-  groupBox = new QGroupBox( 0, Qt::Vertical, i18n( "Used Mail Client" ), mailclientPage );
-  boxLayout = new QVBoxLayout( groupBox->layout() );
-  boxLayout->setAlignment( Qt::AlignTop );
-//  boxLayout->setMargin(KDialog::marginHintSmall() );
-//  groupBox->layout()->setMargin(KDialog::marginHintSmall()) ;
-//  groupBox->layout()->setSpacing(KDialog::spacingHintSmall());
-//  boxLayout->setSpacing( KDialog::spacingHintSmall() );
-
-  mEmailClient = new QComboBox( groupBox );
-  mEmailClient->insertItem( i18n("OM/Pi"), KABPrefs::OMPI );
-  mEmailClient->insertItem( i18n("Qtopia mail"), KABPrefs::QTOPIA );
-  mEmailClient->insertItem( i18n("Opie mail"), KABPrefs::OPIE );
-  mEmailClient->insertItem( i18n("Other"), KABPrefs::OTHER );
-  boxLayout->addWidget( mEmailClient );
-
-  connect( mEmailClient, SIGNAL( activated( int ) ),
-           this, SLOT (emailclient_changed( int ) ) );
-
-  QLabel* lab = new QLabel( i18n("Channel:"), groupBox);
-  boxLayout->addWidget( lab );
-  mEmailChannel = new QLineEdit(groupBox);
-  mEmailChannel->setReadOnly(true);
-  boxLayout->addWidget( mEmailChannel );
-
-  layout->addWidget( groupBox );
-  tabWidget->addTab( mailclientPage, i18n( "Mail" ) );
-
-
-
 }
@@ -192,56 +158,6 @@ KABConfigWidget::KABConfigWidget( QWidget *parent, const char *name )
 
-
-void KABConfigWidget::emailclient_changed( int newClient )
+void KABConfigWidget::restoreSettings(KABPrefs* prefs)
 {
-  if (newClient == KABPrefs::OTHER)
-    mEmailChannel->setReadOnly(false);
-  else
-    mEmailChannel->setReadOnly(true);
-
-  QString opiepath = QString::fromLatin1( getenv("OPIEDIR") );
-  QString qtopiapath = QString::fromLatin1( getenv("QPEDIR") );
-
-  if (opiepath.isEmpty())
-    opiepath = qtopiapath;
-
-  QString text = mEmailChannel->text();
-
-  if (newClient == KABPrefs::OPIE)
-  {
-    if ( QFile::exists( opiepath + "/bin/opiemail" ))
-      text = "QPE/Application/opiemail";
-    else
-      text = "FILENOTFOUND: " + opiepath + "/bin/opiemail";
-  }
-  else  if (newClient == KABPrefs::QTOPIA)
-  {
-    if ( QFile::exists( qtopiapath + "/bin/qtmail" ))
-      text = "QPE/Application/qtmail";
-    else
-      text = "FILENOTFOUND: " + qtopiapath + "/bin/qtmail";
+//US  prefs was KABPrefs::instance() before
 
-  }
-  else  if (newClient == KABPrefs::OMPI)
-  {
-    if ( QFile::exists( qtopiapath + "/bin/ompi" ))
-      text = "QPE/Application/ompi";
-    else if ( QFile::exists( opiepath + "/bin/ompi" ))
-      text = "QPE/Application/ompi";
-    else
-      text = "FILENOTFOUND: " + qtopiapath + "/bin/ompi";
-
-  }
-  else
-  {
-    //do nothing if we choosed other
-  }
-
-  mEmailChannel->setText( text );
-
-
-}
-
-
-void KABConfigWidget::restoreSettings()
-{
   bool blocked = signalsBlocked();
@@ -249,7 +165,4 @@ void KABConfigWidget::restoreSettings()
 
-  mNameParsing->setChecked( KABPrefs::instance()->mAutomaticNameParsing );
-  mViewsSingleClickBox->setChecked( KABPrefs::instance()->mHonorSingleClick );
-
-  mEmailChannel->setText( KABPrefs::instance()->mEmailChannel );
-  mEmailClient->setCurrentItem(KABPrefs::instance()->mEmailClient);
+  mNameParsing->setChecked( prefs->mAutomaticNameParsing );
+  mViewsSingleClickBox->setChecked( prefs->mHonorSingleClick );
 
@@ -264,9 +177,6 @@ void KABConfigWidget::restoreSettings()
 
-void KABConfigWidget::saveSettings()
+void KABConfigWidget::saveSettings(KABPrefs* prefs)
 {
-  KABPrefs::instance()->mAutomaticNameParsing = mNameParsing->isChecked();
-  KABPrefs::instance()->mHonorSingleClick = mViewsSingleClickBox->isChecked();
-
-  KABPrefs::instance()->mEmailClient = mEmailClient->currentItem();
-  KABPrefs::instance()->mEmailChannel = mEmailChannel->text();
+  prefs->mAutomaticNameParsing = mNameParsing->isChecked();
+  prefs->mHonorSingleClick = mViewsSingleClickBox->isChecked();
 
@@ -280,3 +190,3 @@ void KABConfigWidget::saveSettings()
 
-void KABConfigWidget::defaults()
+void KABConfigWidget::defaults(KABPrefs* prefs)
 {
@@ -285,6 +195,2 @@ void KABConfigWidget::defaults()
 
-  mEmailClient->setCurrentItem(KABPrefs::OMPI);
-  emailclient_changed( KABPrefs::OMPI );
-
-
   emit changed( true );
diff --git a/kaddressbook/kcmconfigs/kabconfigwidget.h b/kaddressbook/kcmconfigs/kabconfigwidget.h
index 9d1363b..8c0c436 100644
--- a/kaddressbook/kcmconfigs/kabconfigwidget.h
+++ b/kaddressbook/kcmconfigs/kabconfigwidget.h
@@ -34,2 +34,3 @@ class QLineEdit;
 class KListView;
+class KABPrefs;
 
@@ -44,5 +45,5 @@ class KABConfigWidget : public QWidget
 
-    void restoreSettings();
-    void saveSettings();
-    void defaults();
+    void restoreSettings(KABPrefs* prefs);
+    void saveSettings(KABPrefs* prefs);
+    void defaults(KABPrefs* prefs);
 
@@ -60,3 +61,2 @@ class KABConfigWidget : public QWidget
     void itemClicked( QListViewItem* );
-    void emailclient_changed( int newClient );
 
@@ -71,4 +71,2 @@ class KABConfigWidget : public QWidget
     QPushButton *mConfigureButton;
-    QComboBox* mEmailClient;
-    QLineEdit* mEmailChannel;
 
diff --git a/kaddressbook/kcmconfigs/kcmkabconfig.cpp b/kaddressbook/kcmconfigs/kcmkabconfig.cpp
index a278042..26398f8 100644
--- a/kaddressbook/kcmconfigs/kcmkabconfig.cpp
+++ b/kaddressbook/kcmconfigs/kcmkabconfig.cpp
@@ -1,23 +1,23 @@
-/*                                                                      
-    This file is part of KAddressBook.                                  
+/*
+    This file is part of KAddressBook.
     Copyright (c) 2003 Tobias Koenig <tokoe@kde.org>
-                                                                        
+
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
-    the Free Software Foundation; either version 2 of the License, or   
-    (at your option) any later version.                                 
-                                                                        
-    This program is distributed in the hope that it will be useful,     
-    but WITHOUT ANY WARRANTY; without even the implied warranty of      
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the        
-    GNU General Public License for more details.                        
-                                                                        
-    You should have received a copy of the GNU General Public License   
-    along with this program; if not, write to the Free Software         
-    Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.           
-                                                                        
-    As a special exception, permission is given to link this program    
-    with any edition of Qt, and distribute the resulting executable,    
+    the Free Software Foundation; either version 2 of the License, or
+    (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+    GNU General Public License for more details.
+
+    You should have received a copy of the GNU General Public License
+    along with this program; if not, write to the Free Software
+    Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
+
+    As a special exception, permission is given to link this program
+    with any edition of Qt, and distribute the resulting executable,
     without including the source code for Qt in the source distribution.
-*/                                                                      
+*/
 
@@ -29,4 +29,4 @@
 #include <kdebug.h>
-#include <klocale.h>
-#include <stdlib.h>
+//#include <klocale.h>
+//#include <stdlib.h>
 
@@ -36,2 +36,5 @@
 
+#include "kabprefs.h"
+#include "kprefs.h"
+
 extern "C"
@@ -52,20 +55,19 @@ KCMKabConfig::KCMKabConfig( QWidget *parent, const char *name )
   layout->setMargin( 0 );
-  
+
   connect( mConfigWidget, SIGNAL( changed( bool ) ), SIGNAL( changed( bool ) ) );
-  load();
 }
 
-void KCMKabConfig::load()
+void KCMKabConfig::load(KPrefs* prefs)
 {
-  mConfigWidget->restoreSettings();
+  mConfigWidget->restoreSettings((KABPrefs*)prefs);
 }
 
-void KCMKabConfig::save()
+void KCMKabConfig::save(KPrefs* prefs)
 {
-  mConfigWidget->saveSettings();
+  mConfigWidget->saveSettings((KABPrefs*)prefs);
 }
 
-void KCMKabConfig::defaults()
+void KCMKabConfig::defaults(KPrefs* prefs)
 {
-  mConfigWidget->defaults();
+  mConfigWidget->defaults((KABPrefs*)prefs);
 }
@@ -83,3 +85,3 @@ const KAboutData* KCMKabConfig::aboutData() const
   return about;
-  
+
 }
diff --git a/kaddressbook/kcmconfigs/kcmkabconfig.h b/kaddressbook/kcmconfigs/kcmkabconfig.h
index be345b8..b4858c1 100644
--- a/kaddressbook/kcmconfigs/kcmkabconfig.h
+++ b/kaddressbook/kcmconfigs/kcmkabconfig.h
@@ -1,23 +1,23 @@
-/*                                                                      
-    This file is part of KAddressBook.                                  
+/*
+    This file is part of KAddressBook.
     Copyright (c) 2003 Tobias Koenig <tokoe@kde.org>
-                                                                        
+
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
-    the Free Software Foundation; either version 2 of the License, or   
-    (at your option) any later version.                                 
-                                                                        
-    This program is distributed in the hope that it will be useful,     
-    but WITHOUT ANY WARRANTY; without even the implied warranty of      
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the        
-    GNU General Public License for more details.                        
-                                                                        
-    You should have received a copy of the GNU General Public License   
-    along with this program; if not, write to the Free Software         
-    Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.           
-                                                                        
-    As a special exception, permission is given to link this program    
-    with any edition of Qt, and distribute the resulting executable,    
+    the Free Software Foundation; either version 2 of the License, or
+    (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+    GNU General Public License for more details.
+
+    You should have received a copy of the GNU General Public License
+    along with this program; if not, write to the Free Software
+    Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
+
+    As a special exception, permission is given to link this program
+    with any edition of Qt, and distribute the resulting executable,
     without including the source code for Qt in the source distribution.
-*/                                                                      
+*/
 
@@ -29,6 +29,3 @@
 class KABConfigWidget;
-
-#ifndef KAB_EMBEDDED
-class KAboutData;
-#endif //KAB_EMBEDDED
+class KPrefs;
 
@@ -41,8 +38,5 @@ class KCMKabConfig : public KCModule
 
-    virtual void load();
-    virtual void save();
-    virtual void defaults();
-#ifndef KAB_EMBEDDED
-    virtual const KAboutData* aboutData() const;
-#endif //KAB_EMBEDDED
+    virtual void load(KPrefs* prefs);
+    virtual void save(KPrefs* prefs);
+    virtual void defaults(KPrefs* prefs);