comments added

1 files changed, 5 insertions, 0 deletions

diff --git a/kmicromail/libetpan/mh/mailmh.c b/kmicromail/libetpan/mh/mailmh.c
index 5e2b4cc..1087ce1 100644
--- a/kmicromail/libetpan/mh/mailmh.c
+++ b/kmicromail/libetpan/mh/mailmh.c
@@ -354,96 +354,101 @@ int mailmh_folder_update(struct mailmh_folder * folder)
     if (ent != NULL) {
 
       snprintf(filename, PATH_MAX,
 	       "%s%c%s", folder->fl_filename, MAIL_DIR_SEPARATOR, ent->d_name);
 
       if (stat(filename, &buf) == -1)
 	continue;
 
       if (S_ISREG(buf.st_mode)) {
 	index = strtoul(ent->d_name, NULL, 10);
 	if (index != 0) {
 	  struct mailmh_msg_info * msg_info;
 	  unsigned int array_index;
           chashdatum key;
           chashdatum data;
 
 	  msg_info = mailmh_msg_info_new(index, buf.st_size, buf.st_mtime);
 	  if (msg_info == NULL) {
 	    res = MAILMH_ERROR_MEMORY;
 	    goto closedir;
 	  }
 	  
 	  r = carray_add(folder->fl_msgs_tab, msg_info, &array_index);
 	  if (r < 0) {
 	    mailmh_msg_info_free(msg_info);
 	    res = MAILMH_ERROR_MEMORY;
 	    goto closedir;
 	  }
 	  msg_info->msg_array_index = array_index;
 
 	  if (index > max_index)
 	    max_index = index;
 
 #if 0
 	  r = cinthash_add(folder->fl_msgs_hash, msg_info->msg_index, msg_info);
 #endif
           key.data = &msg_info->msg_index;
           key.len = sizeof(msg_info->msg_index);
           data.data = msg_info;
           data.len = 0;
           
           r = chash_set(folder->fl_msgs_hash, &key, &data, NULL);
 	  if (r < 0) {
 	    carray_delete_fast(folder->fl_msgs_tab, msg_info->msg_array_index);
 	    mailmh_msg_info_free(msg_info);
 	    res = MAILMH_ERROR_MEMORY;
 	    goto closedir;
 	  }
+                    //LR memory leak? added next line
+                    //mailmh_msg_info_free(msg_info);
+                    //it seems so that it should be freed later,
+                    // but it is not in every case
+                    //PENDING fixme in ompi somewhere
 	}
       }
       else if (S_ISDIR(buf.st_mode)) {
 	struct mailmh_folder * subfolder;
 	unsigned int array_index;
 	chashdatum key;
 	chashdatum data;
 
 	if (ent->d_name[0] == '.') {
 	  if (ent->d_name[1] == 0)
 	    continue;
 	  if ((ent->d_name[1] == '.') && (ent->d_name[2] == 0))
 	    continue;
 	}
 
 	key.data = ent->d_name;
 	key.len = strlen(ent->d_name);
 	r = chash_get(folder->fl_subfolders_hash, &key, &data);
 	if (r < 0) {
 	  subfolder = mailmh_folder_new(folder, ent->d_name);
 	  if (subfolder == NULL) {
 	    res = MAILMH_ERROR_MEMORY;
 	    goto closedir;
 	  }
 	  
 	  r = carray_add(folder->fl_subfolders_tab, subfolder, &array_index);
 	  if (r < 0) {
 	    mailmh_folder_free(subfolder);
 	    res = MAILMH_ERROR_MEMORY;
 	    goto closedir;
 	  }
 	  subfolder->fl_array_index = array_index;
 	  
 	  key.data = subfolder->fl_filename;
 	  key.len = strlen(subfolder->fl_filename);
 	  data.data = subfolder;
 	  data.len = 0;
 	  r = chash_set(folder->fl_subfolders_hash, &key, &data, NULL);
 	  if (r < 0) {
 	    carray_delete_fast(folder->fl_subfolders_tab, subfolder->fl_array_index);
 	    mailmh_folder_free(subfolder);
 	    res = MAILMH_ERROR_MEMORY;
 	    goto closedir;
 	  }
 	}
       }
     }
   }