gimmick (sound,pics) and hopefully dual sleeve handling right, thanks to Bruno David Rodrigues <bruno.rodrigues@litux.org>

4 files changed, 41 insertions, 49 deletions

diff --git a/core/applets/cardmon/cardmon.cpp b/core/applets/cardmon/cardmon.cpp
index 0addb89..0bd1ed3 100644
--- a/core/applets/cardmon/cardmon.cpp
+++ b/core/applets/cardmon/cardmon.cpp
@@ -35,2 +35,3 @@
 #include <fcntl.h>
+#include <qsound.h>
 
@@ -101,3 +102,3 @@ void CardMonitor::mousePressEvent( QMouseEvent * ) {
     if ( cardInPcmcia0 ) {
-        menu->insertItem( QIconSet ( Resource::loadPixmap ( getIconName(cardInPcmcia0Type) )), 
+        menu->insertItem( QIconSet ( Resource::loadPixmap ( "cardmon/" + cardInPcmcia0Type )), 
 		tr("Eject card 0: %1").arg(cardInPcmcia0Name), 1 );
@@ -106,3 +107,3 @@ void CardMonitor::mousePressEvent( QMouseEvent * ) {
     if ( cardInPcmcia1 ) {
-        menu->insertItem( QIconSet ( Resource::loadPixmap ( getIconName(cardInPcmcia1Type) )), 
+        menu->insertItem( QIconSet ( Resource::loadPixmap ( "cardmon/" + cardInPcmcia1Type )), 
 		tr("Eject card 1: %1").arg(cardInPcmcia1Name), 2 );
@@ -211,2 +212,20 @@ bool CardMonitor::getStatusPcmcia( int showPopUp ) {
 	f.close();
+	if( !showPopUp && (cardWas0 != cardInPcmcia0 || cardWas1 != cardInPcmcia1)) {
+	    QString text = "";
+	    QString what = "";
+	    if(cardWas0 != cardInPcmcia0) {
+		if(cardInPcmcia0) { text += tr("New card: "); what="on";}
+		else { text += tr("Ejected: "); what="off";}
+		text += cardInPcmcia0Name;
+		popUp( text, "cardmon/" + cardInPcmcia0Type );
+	    }
+	    if(cardWas1 != cardInPcmcia1) {
+		if(cardInPcmcia1) { text += tr("New card: "); what="on";}
+		else { text += tr("Ejected: "); what="off";}
+		text += cardInPcmcia1Name;
+		popUp( text, "cardmon/" + cardInPcmcia1Type );
+	    }
+	    QSound::play(Resource::findSound("cardmon/card" + what));
+	}
+
     } else {
@@ -216,24 +235,5 @@ bool CardMonitor::getStatusPcmcia( int showPopUp ) {
         cardInPcmcia1 = FALSE;
-	return FALSE;
-
     }
 
-    if( !showPopUp && (cardWas0 != cardInPcmcia0 || cardWas1 != cardInPcmcia1)) {
-	QString text = "";
-	if(cardWas0 != cardInPcmcia0) {
-	    if(cardInPcmcia0) { text += tr("New card: "); }
-	    else { text += tr("Ejected: "); }
-	    text += cardInPcmcia0Name;
-	    popUp( text, getIconName( cardInPcmcia0Type ) );
-	}
-	if(cardWas1 != cardInPcmcia1) {
-	    if(cardInPcmcia1) { text += tr("New card: "); }
-	    else { text += tr("Ejected: "); }
-	    text += cardInPcmcia1Name;
-	    popUp( text, getIconName( cardInPcmcia1Type ) );
-	}
-    }
-
-
-    return ((cardWas0 == cardInPcmcia0 || cardWas1 == cardInPcmcia1) ? FALSE : TRUE);
+    return ((cardWas0 == cardInPcmcia0 && cardWas1 == cardInPcmcia1) ? FALSE : TRUE);
 }
@@ -283,11 +283 @@ void CardMonitor::paintEvent( QPaintEvent * ) {
 }
-
-QString CardMonitor::getIconName( QString type ) {
-    if( type != "network" && 
-	type != "ide" ) {
-	type="cardmon";
-    }
-    return "cardmon/"+type;
-}
-	
-
diff --git a/core/applets/cardmon/cardmon.h b/core/applets/cardmon/cardmon.h
index 3dcf235..9651783 100644
--- a/core/applets/cardmon/cardmon.h
+++ b/core/applets/cardmon/cardmon.h
@@ -54,4 +54,3 @@ private:
     void popUp(QString message, QString icon="");
-    QString getIconName(QString type);
-};
+ };
 
diff --git a/core/applets/cardmon/cardmon.pro b/core/applets/cardmon/cardmon.pro
index e79e91a..3bddd22 100644
--- a/core/applets/cardmon/cardmon.pro
+++ b/core/applets/cardmon/cardmon.pro
@@ -11,15 +11,18 @@ VERSION		= 1.0.0
 
-TRANSLATIONS = ../../i18n/de/libcardmonapplet.ts
-TRANSLATIONS += ../../i18n/es/libcardmonapplet.ts
-TRANSLATIONS += ../../i18n/pt/libcardmonapplet.ts
-TRANSLATIONS += ../../i18n/pt_BR/libcardmonapplet.ts
-TRANSLATIONS   += ../../i18n/en/libcardmonapplet.ts
-TRANSLATIONS   += ../../i18n/hu/libcardmonapplet.ts
-TRANSLATIONS   += ../../i18n/sl/libcardmonapplet.ts
-TRANSLATIONS   += ../../i18n/pl/libcardmonapplet.ts
-TRANSLATIONS   += ../../i18n/ja/libcardmonapplet.ts
-TRANSLATIONS   += ../../i18n/fr/libcardmonapplet.ts
-TRANSLATIONS   += ../../i18n/ko/libcardmonapplet.ts
-TRANSLATIONS   += ../../i18n/no/libcardmonapplet.ts
-TRANSLATIONS   += ../../i18n/zh_CN/libcardmonapplet.ts
-TRANSLATIONS   += ../../i18n/zh_TW/libcardmonapplet.ts
+
+
+TRANSLATIONS = ../../../i18n/de/libcardmonapplet.ts
+TRANSLATIONS += ../../../i18n/en/libcardmonapplet.ts
+TRANSLATIONS += ../../../i18n/es/libcardmonapplet.ts
+TRANSLATIONS += ../../../i18n/fr/libcardmonapplet.ts
+TRANSLATIONS += ../../../i18n/hu/libcardmonapplet.ts
+TRANSLATIONS += ../../../i18n/ja/libcardmonapplet.ts
+TRANSLATIONS += ../../../i18n/ko/libcardmonapplet.ts
+TRANSLATIONS += ../../../i18n/no/libcardmonapplet.ts
+TRANSLATIONS += ../../../i18n/pl/libcardmonapplet.ts
+TRANSLATIONS += ../../../i18n/pt/libcardmonapplet.ts
+TRANSLATIONS += ../../../i18n/pt_BR/libcardmonapplet.ts
+TRANSLATIONS += ../../../i18n/sl/libcardmonapplet.ts
+TRANSLATIONS += ../../../i18n/zh_CN/libcardmonapplet.ts
+TRANSLATIONS += ../../../i18n/zh_TW/libcardmonapplet.ts
+
diff --git a/core/applets/cardmon/opie-cardmon.control b/core/applets/cardmon/opie-cardmon.control
index bcd0326..6382fdb 100644
--- a/core/applets/cardmon/opie-cardmon.control
+++ b/core/applets/cardmon/opie-cardmon.control
@@ -1,2 +1,2 @@
-Files: plugins/applets/libcardmonapplet.so* pics/cardmon/*.png
+Files: plugins/applets/libcardmonapplet.so* pics/cardmon/*.png sound/cardmon/*.wav
 Priority: optional