summaryrefslogtreecommitdiff
authordrw <drw>2004-12-21 00:05:06 (UTC)
committer drw <drw>2004-12-21 00:05:06 (UTC)
commit8c316a01b28879b9f4fc6df736773245c8358ffc (patch) (side-by-side diff)
tree3cfd20bfac60255a9ebe1460baeabe68427c8ac6
parentfaf7441b78dfc293f1dea1edebc202244fc3a1cf (diff)
downloadopie-8c316a01b28879b9f4fc6df736773245c8358ffc.zip
opie-8c316a01b28879b9f4fc6df736773245c8358ffc.tar.gz
opie-8c316a01b28879b9f4fc6df736773245c8358ffc.tar.bz2
Some cleaner string handling
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--core/applets/batteryapplet/batterystatus.cpp55
1 files changed, 36 insertions, 19 deletions
diff --git a/core/applets/batteryapplet/batterystatus.cpp b/core/applets/batteryapplet/batterystatus.cpp
index addb517..7f8de2c 100644
--- a/core/applets/batteryapplet/batterystatus.cpp
+++ b/core/applets/batteryapplet/batterystatus.cpp
@@ -101,3 +101,4 @@ bool BatteryStatus::getProcApmStatusIpaq() {
- jackStatus == (" ( " + jackStatus + " )");
+ jackStatus.prepend( " ( " );
+ jackStatus.append( " )" );
return true;
@@ -141,20 +142,21 @@ QString BatteryStatus::statusText() const {
} else if ( ps->batteryPercentAccurate() ) {
- text.sprintf( tr("Remaining Power") + ": %i%%", percent );
+ text = tr( "Remaining Power: %1%" ).arg( percent );
+ //text.sprintf( tr("Remaining Power") + ": %i%%", percent );
} else {
- text = tr("Battery status: ");
+ text = tr( "Battery status: " );
switch ( ps->batteryStatus() ) {
case PowerStatus::High:
- text += tr("Good");
+ text.append( tr( "Good" ) );
break;
case PowerStatus::Low:
- text += tr("Low");
+ text.append( tr( "Low" ) );
break;
case PowerStatus::VeryLow:
- text += tr("Very Low");
+ text.append( tr( "Very Low" ) );
break;
case PowerStatus::Critical:
- text += tr("Critical");
+ text.append( tr( "Critical" ) );
break;
default: // NotPresent, etc.
- text += tr("Unknown");
+ text.append( tr( "Unknown" ) );
}
@@ -163,11 +165,24 @@ QString BatteryStatus::statusText() const {
if ( ps->acStatus() == PowerStatus::Backup )
- text += "\n" + tr("On backup power");
+ {
+ text.append( '\n' );
+ text.append( tr( "On backup power" ) );
+ }
else if ( ps->acStatus() == PowerStatus::Online )
- text += "\n" + tr("Power on-line");
+ {
+ text.append( '\n' );
+ text.append( tr( "Power on-line" ) );
+ }
else if ( ps->acStatus() == PowerStatus::Offline )
- text += "\n" + tr("External power disconnected");
+ {
+ text.append( '\n' );
+ text.append( tr( "External power disconnected" ) );
+ }
- if ( ps->batteryTimeRemaining() >= 0 ) {
- text += "\n" + QString().sprintf( tr("Remaining Time") + ": %im %02is",
- ps->batteryTimeRemaining() / 60, ps->batteryTimeRemaining() % 60 );
+ if ( ps->batteryTimeRemaining() >= 0 )
+ {
+ text.append( '\n' );
+ text.append( tr("Remaining Time: %1m %2s" ).arg( ps->batteryTimeRemaining() / 60 )
+ .arg( ps->batteryTimeRemaining() % 60, 2 ) );
+/* text += "\n" + QString().sprintf( tr("Remaining Time") + ": %im %02is",
+ ps->batteryTimeRemaining() / 60, ps->batteryTimeRemaining() % 60 );*/
}
@@ -177,5 +192,7 @@ QString BatteryStatus::statusText() const {
QString BatteryStatus::statusTextIpaq() const {
- QString text;
- text += tr("Remaining Power: ") + perc2 + " " + jackStatus;
- text += "\n" + tr("Remaining Time: ") + sec2;
+ QString text = tr( "Remaing Power: %1 %2\nRemaining Time: %3" ).arg( perc2 )
+ .arg( jackStatus )
+ .arg( sec2 );
+/* QString text = tr("Remaining Power: ") + perc2 + " " + jackStatus;
+ text += "\n" + tr("Remaining Time: ") + sec2;*/
return text;
@@ -222,3 +239,3 @@ void BatteryStatus::paintEvent( QPaintEvent * ev ) {
- p.drawText( 15, 30, tr ("Ipaq ") + ipaqChem );
+ p.drawText( 15, 30, tr("Ipaq %1").arg( ipaqChem ) );
@@ -229,3 +246,3 @@ void BatteryStatus::paintEvent( QPaintEvent * ev ) {
p.drawText( 10, 150, text );
- jacketMsg = tr("Jacket ") + jackChem;
+ jacketMsg = tr("Jacket ").arg( jackChem );
} else {