summaryrefslogtreecommitdiff
authorzecke <zecke>2002-11-15 10:53:42 (UTC)
committer zecke <zecke>2002-11-15 10:53:42 (UTC)
commitdc68676392f6ac7cced3a9b004fe72a8b408812f (patch) (side-by-side diff)
treed74a42aef53b57edb9d452806b34695c591f8252
parent5fac1f8271dc037d8d3a3a765bccc44c4734e544 (diff)
downloadopie-dc68676392f6ac7cced3a9b004fe72a8b408812f.zip
opie-dc68676392f6ac7cced3a9b004fe72a8b408812f.tar.gz
opie-dc68676392f6ac7cced3a9b004fe72a8b408812f.tar.bz2
API REVIEW added
Simon if you read that feel free to do an API REVIEW on libopie but leave out OFileSelector for now... Stefan: added an explanation for you
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--libopie/pim/ocontact.h26
-rw-r--r--libopie2/opiepim/ocontact.h26
2 files changed, 52 insertions, 0 deletions
diff --git a/libopie/pim/ocontact.h b/libopie/pim/ocontact.h
index 81ac1c1..9643e8b 100644
--- a/libopie/pim/ocontact.h
+++ b/libopie/pim/ocontact.h
@@ -37,2 +37,11 @@ QPC_TEMPLATEEXTERN template class QPC_EXPORT QMap<int, QString>;
class ContactPrivate; // Wozu ist das gut und wo ist das decrariert ? (se)
+ /* Stefan das ist eine forward declaration
+ * dann machst du in der private section
+ * ContactPrivate *d;
+ *
+ * und wenn du bei Opie1.1 was hinzufuegen moechtest
+ * packst du es in ContactPrivate damit Opie
+ * binaer kompatibel bleibt
+ * -zecke
+ */
class QPC_EXPORT OContact : public OPimRecord
@@ -45,2 +54,3 @@ public:
+ /* VCARD stuff should vanish! -zecke */
static void writeVCard( const QString &filename, const QValueList<OContact> &contacts);
@@ -51,2 +61,7 @@ public:
+ /*
+ * do we need to inline them
+ * if yes do we need to inline them this way?
+ * -zecke
+ */
void setTitle( const QString &v ) { replace( Qtopia::Title, v ); }
@@ -129,2 +144,7 @@ public:
// home
+ /*
+ * OPimAddress address(enum Location)const;
+ * would be some how nicer...
+ * -zecke
+ */
QString homeStreet() const { return find( Qtopia::HomeStreet ); }
@@ -198,2 +218,3 @@ public:
// journaling...
+ /* do we still need them? Stefan your backend takes care of these -zecke */
void saveJournal( journal_action action, const QString &key = QString::null );
@@ -201,2 +222,3 @@ public:
+ /* we shouldn't inline this one -zecke */
void setUid( int i )
@@ -217,2 +239,6 @@ public:
private:
+ /* I do not like friends ;)
+ * besides that I think we do not need them
+ * anymore -zecke
+ */
friend class AbEditor;
diff --git a/libopie2/opiepim/ocontact.h b/libopie2/opiepim/ocontact.h
index 81ac1c1..9643e8b 100644
--- a/libopie2/opiepim/ocontact.h
+++ b/libopie2/opiepim/ocontact.h
@@ -37,2 +37,11 @@ QPC_TEMPLATEEXTERN template class QPC_EXPORT QMap<int, QString>;
class ContactPrivate; // Wozu ist das gut und wo ist das decrariert ? (se)
+ /* Stefan das ist eine forward declaration
+ * dann machst du in der private section
+ * ContactPrivate *d;
+ *
+ * und wenn du bei Opie1.1 was hinzufuegen moechtest
+ * packst du es in ContactPrivate damit Opie
+ * binaer kompatibel bleibt
+ * -zecke
+ */
class QPC_EXPORT OContact : public OPimRecord
@@ -45,2 +54,3 @@ public:
+ /* VCARD stuff should vanish! -zecke */
static void writeVCard( const QString &filename, const QValueList<OContact> &contacts);
@@ -51,2 +61,7 @@ public:
+ /*
+ * do we need to inline them
+ * if yes do we need to inline them this way?
+ * -zecke
+ */
void setTitle( const QString &v ) { replace( Qtopia::Title, v ); }
@@ -129,2 +144,7 @@ public:
// home
+ /*
+ * OPimAddress address(enum Location)const;
+ * would be some how nicer...
+ * -zecke
+ */
QString homeStreet() const { return find( Qtopia::HomeStreet ); }
@@ -198,2 +218,3 @@ public:
// journaling...
+ /* do we still need them? Stefan your backend takes care of these -zecke */
void saveJournal( journal_action action, const QString &key = QString::null );
@@ -201,2 +222,3 @@ public:
+ /* we shouldn't inline this one -zecke */
void setUid( int i )
@@ -217,2 +239,6 @@ public:
private:
+ /* I do not like friends ;)
+ * besides that I think we do not need them
+ * anymore -zecke
+ */
friend class AbEditor;