Use OTabWidget & OColorButtons in config dialog for consistency w/other apps (reduces executable size by ~4k as well).

6 files changed, 47 insertions, 99 deletions

diff --git a/noncore/net/opieirc/ircmisc.cpp b/noncore/net/opieirc/ircmisc.cpp
index f94cf1b..a15a790 100644
--- a/noncore/net/opieirc/ircmisc.cpp
+++ b/noncore/net/opieirc/ircmisc.cpp
@@ -1,2 +1 @@
-#include <opie/colordialog.h>
 #include <qlayout.h>
@@ -5,30 +4,2 @@
 
-IRCColorLabel::IRCColorLabel(QColor color, QWidget *parent, const char *name, WFlags f) : QLabel(parent, name, f) {
-    m_color = color;
-    setAlignment(AlignVCenter | AlignCenter);
-    setFrameStyle(QFrame::StyledPanel);
-    setFrameShadow(QFrame::Sunken);
-    setBackgroundColor(m_color);
-}
-
-void IRCColorLabel::mousePressEvent(QMouseEvent *) {
-    m_color = OColorDialog::getColor(m_color);
-    setBackgroundColor(m_color);
-}
-
-QColor IRCColorLabel::color() {
-    return m_color;
-}
-
-IRCFramedColorLabel::IRCFramedColorLabel(QColor color, QWidget *parent, const char *name, WFlags f) : QWidget(parent, name, f) {
-    QVBoxLayout *layout = new QVBoxLayout(this, 10, 0);
-    m_label = new IRCColorLabel(color, this);
-    layout->addWidget(m_label);
-}
-
-QColor IRCFramedColorLabel::color() {
-    return m_label->color();
-}
-
-
 IRCTabBar::IRCTabBar(QWidget *parent, const char *name) : QTabBar(parent, name) {
diff --git a/noncore/net/opieirc/ircmisc.h b/noncore/net/opieirc/ircmisc.h
index 6a8db50..b4a5b06 100644
--- a/noncore/net/opieirc/ircmisc.h
+++ b/noncore/net/opieirc/ircmisc.h
@@ -30,23 +30,2 @@
 
-/* IRCFramedColorLabel is used to display a color */
-
-class IRCColorLabel : public QLabel {
-    Q_OBJECT
-public:
-    IRCColorLabel(QColor color, QWidget *parent = 0, const char *name = 0, WFlags f = 0);
-    QColor color();
-    void mousePressEvent(QMouseEvent *event); 
-protected:
-    QColor m_color;
-};
-
-class IRCFramedColorLabel : public QWidget {
-    Q_OBJECT
-public:
-    IRCFramedColorLabel(QColor color, QWidget *parent = 0, const char *name = 0, WFlags f = 0); 
-    QColor color();
-protected:
-    IRCColorLabel *m_label;
-};
-
 /* Custom colored QTabWidget */
diff --git a/noncore/net/opieirc/ircsettings.cpp b/noncore/net/opieirc/ircsettings.cpp
index 78eaed3..b110a5b 100644
--- a/noncore/net/opieirc/ircsettings.cpp
+++ b/noncore/net/opieirc/ircsettings.cpp
@@ -1 +1,3 @@
+#include <opie/ocolorbutton.h>
+#include <opie/otabwidget.h>
 #include <qlayout.h>
@@ -13,10 +15,10 @@ IRCSettings::IRCSettings(QWidget* parent, const char* name, bool modal, WFlags)
     QHBoxLayout *l = new QHBoxLayout(this, 2, 2);
-    QTabWidget *tw = new QTabWidget(this);
+    OTabWidget *tw = new OTabWidget(this);
     l->addWidget(tw);
     /* General Configuration */
-    QWidget *widget = new QWidget(tw);
-    QGridLayout *layout = new QGridLayout(widget, 1, 2, 5, 0);
-    QLabel *label = new QLabel(tr("Lines displayed :"), widget);
+    QWidget *genwidget = new QWidget(tw);
+    QGridLayout *layout = new QGridLayout(genwidget, 1, 2, 5, 0);
+    QLabel *label = new QLabel(tr("Lines displayed :"), genwidget);
     layout->addWidget(label, 0, 0);
-    m_lines = new QLineEdit(m_config->readEntry("Lines", "100"), widget);
+    m_lines = new QLineEdit(m_config->readEntry("Lines", "100"), genwidget);
     QWhatsThis::add(m_lines, tr("Amount of lines to be displayed in chats before old lines get deleted - this is necessary to restrain memory consumption. Set to 0 if you don't need this"));
@@ -27,8 +29,9 @@ IRCSettings::IRCSettings(QWidget* parent, const char* name, bool modal, WFlags)
     layout->addWidget(m_lines, 0, 1);
-    tw->addTab(widget, tr("General"));
+    tw->addTab(genwidget, "opieirc/settings", tr("General"));
 
     /* Color configuration */
-    QScrollView *view = new QScrollView(tw);
+    QScrollView *view = new QScrollView(this);
     view->setResizePolicy(QScrollView::AutoOneFit);
-    widget = new QWidget(view->viewport());
+    view->setFrameStyle( QFrame::NoFrame );
+    QWidget *widget = new QWidget(view->viewport());
     view->addChild(widget);
@@ -37,3 +40,3 @@ IRCSettings::IRCSettings(QWidget* parent, const char* name, bool modal, WFlags)
     layout->addWidget(label, 0, 0);
-    m_background = new IRCFramedColorLabel(QColor(m_config->readEntry("BackgroundColor", "#FFFFFF")), widget);
+    m_background = new OColorButton(widget, m_config->readEntry("BackgroundColor", "#FFFFFF"));
     QWhatsThis::add(m_background, tr("Background color to be used in chats"));
@@ -42,3 +45,3 @@ IRCSettings::IRCSettings(QWidget* parent, const char* name, bool modal, WFlags)
     layout->addWidget(label, 1, 0);
-    m_text = new IRCFramedColorLabel(m_config->readEntry("TextColor", "#000000"), widget);
+    m_text = new OColorButton(widget, m_config->readEntry("TextColor", "#000000"));
     QWhatsThis::add(m_text, tr("Text color to be used in chats"));
@@ -47,3 +50,3 @@ IRCSettings::IRCSettings(QWidget* parent, const char* name, bool modal, WFlags)
     layout->addWidget(label, 2, 0);
-    m_error = new IRCFramedColorLabel(m_config->readEntry("ErrorColor", "#FF0000"), widget);
+    m_error = new OColorButton(widget, m_config->readEntry("ErrorColor", "#FF0000"));
     QWhatsThis::add(m_error, tr("Text color to be used to display errors"));
@@ -52,3 +55,3 @@ IRCSettings::IRCSettings(QWidget* parent, const char* name, bool modal, WFlags)
     layout->addWidget(label, 3, 0);
-    m_self = new IRCFramedColorLabel(m_config->readEntry("SelfColor", "#CC0000"), widget);
+    m_self = new OColorButton(widget, m_config->readEntry("SelfColor", "#CC0000"));
     QWhatsThis::add(m_self, tr("Text color to be used to identify text written by yourself"));
@@ -57,3 +60,3 @@ IRCSettings::IRCSettings(QWidget* parent, const char* name, bool modal, WFlags)
     layout->addWidget(label, 4, 0);
-    m_other = new IRCFramedColorLabel(m_config->readEntry("OtherColor", "#0000BB"), widget);
+    m_other = new OColorButton(widget, m_config->readEntry("OtherColor", "#0000BB"));
     QWhatsThis::add(m_other, tr("Text color to be used to identify text written by others"));
@@ -62,3 +65,3 @@ IRCSettings::IRCSettings(QWidget* parent, const char* name, bool modal, WFlags)
     layout->addWidget(label, 5, 0);
-    m_server = new IRCFramedColorLabel(m_config->readEntry("ServerColor", "#0000FF"), widget);
+    m_server = new OColorButton(widget, m_config->readEntry("ServerColor", "#0000FF"));
     QWhatsThis::add(m_server, tr("Text color to be used to identify text written by the server"));
@@ -67,6 +70,7 @@ IRCSettings::IRCSettings(QWidget* parent, const char* name, bool modal, WFlags)
     layout->addWidget(label, 6, 0);
-    m_notification = new IRCFramedColorLabel(m_config->readEntry("NotificationColor", "#AAE300"), widget);
+    m_notification = new OColorButton(widget, m_config->readEntry("NotificationColor", "#AAE300"));
     QWhatsThis::add(m_notification, tr("Text color to be used to display notifications"));
     layout->addWidget(m_notification, 6, 1);
-    tw->addTab(view, tr("Colors"));
+    tw->addTab(view, "opieirc/colors", tr("Colors"));
+    tw->setCurrentTab( genwidget );
     showMaximized();
@@ -74,25 +78,18 @@ IRCSettings::IRCSettings(QWidget* parent, const char* name, bool modal, WFlags)
 
-QString IRCSettings::getColorString(QWidget *widget) {
-    QColor color = ((IRCFramedColorLabel *)widget)->color();
-    QString temp;
-    temp.sprintf("#%02x%02x%02x", color.red(), color.green(), color.blue());
-    return temp;
-}
-
 void IRCSettings::accept() {
-    IRCTab::m_backgroundColor = getColorString(m_background);
-    IRCTab::m_textColor = getColorString(m_text);
-    IRCTab::m_errorColor = getColorString(m_error);
-    IRCTab::m_selfColor = getColorString(m_self);
-    IRCTab::m_otherColor = getColorString(m_other);
-    IRCTab::m_serverColor = getColorString(m_server);
-    IRCTab::m_notificationColor = getColorString(m_notification);
+    IRCTab::m_backgroundColor = m_background->color().name();
+    IRCTab::m_textColor = m_text->color().name();
+    IRCTab::m_errorColor = m_error->color().name();
+    IRCTab::m_selfColor = m_self->color().name();
+    IRCTab::m_otherColor = m_other->color().name();
+    IRCTab::m_serverColor = m_server->color().name();
+    IRCTab::m_notificationColor = m_notification->color().name();
     IRCTab::m_maxLines = m_lines->text().toInt();
-    m_config->writeEntry("BackgroundColor", getColorString(m_background));
-    m_config->writeEntry("TextColor", getColorString(m_text));
-    m_config->writeEntry("ErrorColor", getColorString(m_error));
-    m_config->writeEntry("SelfColor", getColorString(m_self));
-    m_config->writeEntry("OtherColor", getColorString(m_other));
-    m_config->writeEntry("ServerColor", getColorString(m_server));
-    m_config->writeEntry("NotificationColor", getColorString(m_notification));
+    m_config->writeEntry("BackgroundColor", IRCTab::m_backgroundColor);
+    m_config->writeEntry("TextColor", IRCTab::m_textColor);
+    m_config->writeEntry("ErrorColor", IRCTab::m_errorColor);
+    m_config->writeEntry("SelfColor", IRCTab::m_selfColor);
+    m_config->writeEntry("OtherColor", IRCTab::m_otherColor);
+    m_config->writeEntry("ServerColor", IRCTab::m_serverColor);
+    m_config->writeEntry("NotificationColor", IRCTab::m_notificationColor);
     m_config->writeEntry("Lines", m_lines->text());
diff --git a/noncore/net/opieirc/ircsettings.h b/noncore/net/opieirc/ircsettings.h
index 190abaf..cb8d896 100644
--- a/noncore/net/opieirc/ircsettings.h
+++ b/noncore/net/opieirc/ircsettings.h
@@ -27,2 +27,4 @@
 
+class OColorButton;
+
 class IRCSettings : public QDialog {
@@ -31,3 +33,2 @@ public:
     IRCSettings(QWidget* parent = 0, const char* name = 0, bool modal = FALSE, WFlags f = 0);
-    QString getColorString(QWidget *widget);
     ~IRCSettings();
@@ -36,11 +37,11 @@ protected slots:
 protected:
-    Config    *m_config;
-    QWidget   *m_background;
-    QWidget   *m_text;
-    QWidget   *m_error;
-    QWidget   *m_self;
-    QWidget   *m_server;
-    QWidget   *m_other;
-    QWidget   *m_notification;
-    QLineEdit *m_lines;
+    Config       *m_config;
+    OColorButton *m_background;
+    OColorButton *m_text;
+    OColorButton *m_error;
+    OColorButton *m_self;
+    OColorButton *m_server;
+    OColorButton *m_other;
+    OColorButton *m_notification;
+    QLineEdit    *m_lines;
 };
diff --git a/noncore/net/opieirc/mainwindow.cpp b/noncore/net/opieirc/mainwindow.cpp
index 7928310..c0e2ff1 100644
--- a/noncore/net/opieirc/mainwindow.cpp
+++ b/noncore/net/opieirc/mainwindow.cpp
@@ -25,3 +25,3 @@ MainWindow::MainWindow(QWidget *parent, const char *name, WFlags) : QMainWindow(
     a->addTo(irc);
-    a = new QAction(tr("Settings"), Resource::loadPixmap("SettingsIcon"), QString::null, 0, this, 0);
+    a = new QAction(tr("Settings"), Resource::loadPixmap("opieirc/settings"), QString::null, 0, this, 0);
     a->setWhatsThis(tr("Configure OpieIRC's behavior and appearance"));
diff --git a/noncore/net/opieirc/opie-irc.control b/noncore/net/opieirc/opie-irc.control
index 0bcdecd..b0cdfde 100644
--- a/noncore/net/opieirc/opie-irc.control
+++ b/noncore/net/opieirc/opie-irc.control
@@ -6,3 +6,3 @@ Architecture: arm
 Version: $QPE_VERSION-$SUB_VERSION
-Depends: opie-base ($QPE_VERSION)
+Depends: opie-base ($QPE_VERSION), libopie ($QPE_VERSION)
 Description: The Opie IRC client lets you chat on your favorite IRC server using your handheld computer