Each file in this commit exhibits a problem where a variable is made in

some way but never used. This is a tricky problem with Qt since almost all
UI forms are made but not used (like QLabel). But I am pretty confident that
these changes are correct and do not have any aspect of a change to the UI.

In most cases, there are just variables that are made and then copied over
(like in iteration over lists or assignment of pointers based on
conditionals).

4 files changed, 7 insertions, 14 deletions

diff --git a/libqtaux/qsplitter.cpp b/libqtaux/qsplitter.cpp
index 39321f8..959d5e1 100644
--- a/libqtaux/qsplitter.cpp
+++ b/libqtaux/qsplitter.cpp
@@ -718,25 +718,25 @@ void QSplitter::recalc( bool update )
     int maxt = QWIDGETSIZE_MAX;
     int mint = fi;
     int n = data->list.count();
     bool first = TRUE;
     /*
       The splitter before a hidden widget is always hidden.
       The splitter before the first visible widget is hidden.
       The splitter before any other visible widget is visible.
     */
     for ( int i = 0; i< n; i++ ) {
 	QSplitterLayoutStruct *s = data->list.at(i);
 	if ( !s->isSplitter ) {
-	    QSplitterLayoutStruct *p = (i > 0) ? p = data->list.at( i-1 ) : 0;
+	    QSplitterLayoutStruct *p = (i > 0) ? data->list.at( i-1 ) : 0;
 	    if ( p && p->isSplitter )
 		if ( first || s->wid->isHidden() )
 		    p->wid->hide(); //may trigger new recalc
 		else
 		    p->wid->show(); //may trigger new recalc
 	    if ( !s->wid->isHidden() )
 		first = FALSE;
 	}
     }
 
     bool empty=TRUE;
     for ( int j = 0; j< n; j++ ) {
diff --git a/noncore/apps/tinykate/libkate/document/katesyntaxdocument.cpp b/noncore/apps/tinykate/libkate/document/katesyntaxdocument.cpp
index 9fa4452..d8f5aa7 100644
--- a/noncore/apps/tinykate/libkate/document/katesyntaxdocument.cpp
+++ b/noncore/apps/tinykate/libkate/document/katesyntaxdocument.cpp
@@ -48,27 +48,25 @@ void SyntaxDocument::setIdentifier(const QString& identifier)
 }
 
 SyntaxDocument::~SyntaxDocument()
 {
 }
 
 void SyntaxDocument::setupModeList(bool force)
 {
 
   if (myModeList.count() > 0) return;
 
   KateConfig *config=KGlobal::config();
-  KStandardDirs *dirs = KGlobal::dirs();
 
-//  QStringList list=dirs->findAllResources("data","kate/syntax/*.xml",false,true);
   QString path=QPEApplication::qpeDir() +"share/tinykate/syntax/";
 
   QDir dir(path);
   QStringList list=dir.entryList("*.xml");
 
   for ( QStringList::Iterator it = list.begin(); it != list.end(); ++it )
   {
     QString Group="Highlighting_Cache"+path+*it;
     if ((config->hasGroup(Group)) && (!force))
     {
       config->setGroup(Group);
       syntaxModeListItem *mli=new syntaxModeListItem;
diff --git a/noncore/apps/tinykate/mainwindow/tinykate.cpp b/noncore/apps/tinykate/mainwindow/tinykate.cpp
index e87464e..e920d5b 100644
--- a/noncore/apps/tinykate/mainwindow/tinykate.cpp
+++ b/noncore/apps/tinykate/mainwindow/tinykate.cpp
@@ -194,48 +194,47 @@ void TinyKate::slotOpen( )
 {
     QString filename = OFileDialog::getOpenFileName( OFileSelector::EXTENDED_ALL,
                        QString::null);
     if (!filename.isEmpty())
     {
         open(filename);
     }
 }
 
 void TinyKate::open(const QString & filename)
 {
     KateDocument *kd= new KateDocument(false, false, this,0,this);
-    KTextEditor::View *kv;
     QString realFileName;
     //check if filename is a .desktop file
     if ( filename.find( ".desktop", 0, true ) != -1 ) {
         switch ( QMessageBox::warning( this, tr( "TinyKATE" ),
                                        tr("TinyKATE has detected<BR>you selected a <B>.desktop</B> file.<BR>Open <B>.desktop</B> file or <B>linked</B> file?" ),
                                        tr(".desktop File"),
                                        tr("Linked Document"), 0, 1, 1 ) )
         {
         case 0: //desktop
             realFileName = filename;
             break;
         case 1: //linked
             DocLnk docLnk( filename );
             realFileName = docLnk.file();
             break;
         };
     } else {
 	    realFileName = filename;
     }
 
     QFileInfo fileInfo( realFileName );
     QString filenamed = fileInfo.fileName();
-    tabwidget->addTab(kv=kd->createView(tabwidget,"bLAH"),"tinykate/tinykate", filenamed );
+    tabwidget->addTab(kd->createView(tabwidget,"Unnamed kateview"),"tinykate/tinykate", filenamed );
     odebug << realFileName << oendl;
 
     kd->setDocName( filenamed);
     kd->open( realFileName );
     viewCount++;
 }
 
 void TinyKate::setDocument(const QString& fileref)
 {
     open( fileref );
 }
 
@@ -269,29 +268,28 @@ void TinyKate::slotCurrentChanged( QWidget * view)
     connect(editReplace,SIGNAL(activated()),currentView,SLOT(replace()));
     connect(editGotoLine,SIGNAL(activated()),currentView,SLOT(gotoLine()));
     connect(viewIncFontSizes,SIGNAL(activated()), currentView,SLOT(slotIncFontSizes()));
     connect(viewDecFontSizes,SIGNAL(activated()), currentView,SLOT(slotDecFontSizes()));
     connect(hlmenu,SIGNAL(activated(int)), currentView,SLOT(setHl(int)));
     connect(utilSettings,SIGNAL(activated()), currentView,SLOT(configDialog()));
 
 }
 
 void TinyKate::slotNew( )
 {
     KateDocument *kd= new KateDocument(false, false, this,0,this);
-    KTextEditor::View *kv;
     
     kd->setDocName(tr("Unnamed %1").arg(nextUnnamed++));
     kd->setNewDoc(true);
-    tabwidget->addTab(kv=kd->createView(tabwidget,"BLAH"),
+    tabwidget->addTab(kd->createView(tabwidget,"Unnamed"),
                       "tinykate/tinykate",
                       kd->docName());
     viewCount++;
 }
 
 bool TinyKate::checkSave() {
     if (currentView==0) return true;
 
     KateView *kv = (KateView*) currentView;
     if(kv->isModified()) {
         KateDocument *kd = (KateDocument*) kv->document();
         switch( QMessageBox::information( 0, (tr("TinyKATE")),
diff --git a/noncore/graphics/opie-eye/impl/dcim/dcim_lister.cpp b/noncore/graphics/opie-eye/impl/dcim/dcim_lister.cpp
index 147eb9c..d4f9943 100644
--- a/noncore/graphics/opie-eye/impl/dcim/dcim_lister.cpp
+++ b/noncore/graphics/opie-eye/impl/dcim/dcim_lister.cpp
@@ -109,32 +109,29 @@ QString DCIM_DirLister::dirUp( const QString& p )const {
     m_path = str;
     return str;
 }
 
 
 QStringList DCIM_DirLister::findCameras()const {
     QStringList lst;
     StorageInfo inf;
 
     m_map.clear();
 
     const QList<FileSystem> &list = inf.fileSystems();
-    QListIterator<FileSystem> it( list );
 
-
-    FileSystem *sys;
-    for ( sys = it.current(); (sys=it.current())!=0  ; ++it )
-        if ( QFileInfo( sys->path() + "/dcim/" ).exists() ) {
-            lst << sys->name();
-            m_map.insert( sys->name(), sys->path() );
+    for ( QListIterator<FileSystem> it( list ); it.current()!=0  ; ++it )
+        if ( QFileInfo( it.current()->path() + "/dcim/" ).exists() ) {
+            lst << it.current()->name();
+            m_map.insert( it.current()->name(), it.current()->path() );
         }
 
     if ( lst.isEmpty() ) {
         m_mode = ListingUnknown;
         lst << QObject::tr("Error no Camera Dir found");
     }else
         m_mode = ListingStart;
 
     return lst;
 }
 
 QStringList DCIM_DirLister::findAlbums()const {