use safer method to set file perms after copy

1 files changed, 2 insertions, 2 deletions

diff --git a/noncore/apps/advancedfm/advancedfmMenu.cpp b/noncore/apps/advancedfm/advancedfmMenu.cpp
index d34f330..4628170 100644
--- a/noncore/apps/advancedfm/advancedfmMenu.cpp
+++ b/noncore/apps/advancedfm/advancedfmMenu.cpp
@@ -436,258 +436,258 @@ void AdvancedFm::move() {
   QStringList curFileList = getPath();
   if( curFileList.count() > 0) {
       QString curFile, destFile, item;
 
       QDir *thisDir = CurrentDir();
       QDir *thatDir = OtherDir();
       for ( QStringList::Iterator it = curFileList.begin(); it != curFileList.end(); ++it ) {
           item=(*it);
           QString destFile =  thatDir->canonicalPath();
 
           if(destFile.right(1).find("/",0,TRUE) == -1)
             destFile+="/";
           destFile += item;
 //          odebug << "Destination file is "+destFile << oendl; 
 
           curFile = thisDir->canonicalPath();
           if(curFile.right(1).find("/",0,TRUE) == -1)
                             curFile +="/";
           curFile+= item;
 //          odebug << "CurrentFile file is " + curFile << oendl; 
 
           if(QFileInfo(curFile).isDir()) {
                             moveDirectory( curFile, destFile );
                             rePopulate();
                             return;
           }
 
                     QFile f( curFile);
           if( f.exists()) {
                             if( !copyFile(  curFile, destFile) )  {
                                     QMessageBox::message(tr("Note"),tr("Could not move\n")+curFile);
                                     return;
               } else
                                     QFile::remove(curFile);
           }
             }
 
   }
             rePopulate();
             setOtherTabCurrent();
 }
 
 bool AdvancedFm::moveDirectory( const QString & src, const QString & dest ) {
         int err = 0;
         if( copyDirectory( src, dest ) ) {      QString cmd = "rm -rf " + src;
         err = system((const char*)cmd);
         } else
                 err = -1;
 
         if(err!=0) {
                 QMessageBox::message(tr("Note"),tr("Could not move\n") + src);
                 return false;
         }
         return true;
 }
 
 bool AdvancedFm::copyDirectory( const QString & src, const QString & dest ) {
 
         QString    cmd = "/bin/cp -fpR " + src + " " + dest;
     owarn << cmd << oendl; 
         int    err = system( (const char *) cmd );
         if ( err != 0 ) {
                 QMessageBox::message("AdvancedFm",
                                                          tr( "Could not copy \n%1 \nto \n%2").arg( src ).arg( dest ) );
                 return false;
         }
 
         return true;
 }
 
 
 bool AdvancedFm::copyFile( const QString & src, const QString & dest ) {
 
 
         if(QFileInfo(src).isDir()) {
                 if( copyDirectory( src, dest )) {
                         setOtherTabCurrent();
                         populateView();
                         return true;
                 }
                 else
                         return false;
         }
 
 
         bool success = true;
         struct stat status;
         QFile srcFile(src);
         QFile destFile(dest);
         int err=0;
         int read_fd=0;
    int write_fd=0;
    struct stat stat_buf;
    off_t offset = 0;
       if(!srcFile.open( IO_ReadOnly|IO_Raw)) {
 //         owarn << "open failed" << oendl; 
          return success = false;
    }
    read_fd = srcFile.handle();
    if(read_fd != -1) {
       fstat (read_fd, &stat_buf);
       if( !destFile.open( IO_WriteOnly|IO_Raw ) ) {
 //       owarn << "destfile open failed" << oendl; 
        return success = false;
       }
       write_fd = destFile.handle();
       if(write_fd != -1) {
          err = sendfile(write_fd, read_fd, &offset, stat_buf.st_size);
            if( err == -1) {
               QString msg;
               switch(err) {
               case EBADF : msg = "The input file was not opened for reading or the output file was not opened for writing. ";
               case EINVAL: msg = "Descriptor is not valid or locked. ";
               case ENOMEM: msg = "Insufficient memory to read from in_fd.";
               case EIO: msg = "Unspecified error while reading from in_fd.";
               };
               success = false;
 //              owarn << msg << oendl; 
          }
       } else {
          success = false;
       }
    } else {
       success = false;
    }
    srcFile.close();
    destFile.close();
     // Set file permissions
-  if( stat( (const char *) src, &status ) == 0 )  {
-      chmod( (const char *) dest, status.st_mode );
+  if( stat( QFile::encodeName(src), &status ) == 0 )  {
+      chmod( QFile::encodeName(dest), status.st_mode );
     }
 
   return success;
 }
 
 void AdvancedFm::runCommand() {
    if( !CurrentView()->currentItem()) return;
    QDir *thisDir = CurrentDir();
 
    QString curFile;
    curFile = thisDir->canonicalPath() +"/"+ CurrentView()->currentItem()->text(0);
 
    InputDialog *fileDlg;
    fileDlg = new InputDialog(this,tr("Run Command"),TRUE, 0);
    fileDlg->setInputText(curFile);
    fileDlg->exec();
    //QString command;
 
    if( fileDlg->result() == 1 ) {
 //      odebug << fileDlg->LineEdit1->text() << oendl; 
       QStringList command;
 
       command << "/bin/sh";
       command << "-c";
       command <<  fileDlg->LineEdit1->text();
       Output *outDlg;
       outDlg = new Output( command, this, tr("AdvancedFm Output"), true);
       QPEApplication::execDialog( outDlg );
       qApp->processEvents();
 
    }
 }
 
 void AdvancedFm::runCommandStd() {
    if( !CurrentView()->currentItem()) return;
    QString curFile;
    QDir *thisDir = CurrentDir();
    QListView *thisView = CurrentView();
    if( thisView->currentItem())
       curFile = thisDir->canonicalPath() +"/"+  thisView->currentItem()->text(0);
 
    InputDialog *fileDlg;
    fileDlg = new InputDialog(this,tr("Run Command"),TRUE, 0);
    fileDlg->setInputText(curFile);
    fileDlg->exec();
 
    if( fileDlg->result() == 1 ) {
       qApp->processEvents();
       startProcess( (const QString)fileDlg->LineEdit1->text().latin1());
    }
 }
 
 void AdvancedFm::fileStatus() {
    if( !CurrentView()->currentItem()) return;
    QString curFile;
    curFile = CurrentView()->currentItem()->text(0);
 
    QStringList command;
    command << "/bin/sh";
    command << "-c";
    command << "stat -l "+ curFile;
 
    Output *outDlg;
    outDlg = new Output( command, this, tr("AdvancedFm Output"), true);
    QPEApplication::execDialog( outDlg );
    qApp->processEvents();
 }
 
 
 void AdvancedFm::mkDir() {
     makeDir();
 }
 
 void AdvancedFm::rn() {
   renameIt();
 }
 
 void AdvancedFm::del() {
     doDelete();
 }
 
 void AdvancedFm::mkSym() {
   QString cmd;
   QStringList curFileList = getPath();
   if( curFileList.count() > 0) {
       QDir *thisDir = CurrentDir();
       QDir * thatDir = OtherDir();
 
       for ( QStringList::Iterator it = curFileList.begin(); it != curFileList.end(); ++it ) {
 
           QString destName = thatDir->canonicalPath()+"/"+(*it);
           if(destName.right(1) == "/") {
               destName = destName.left( destName.length() -1);
             }
 
           QString curFile =  thisDir->canonicalPath()+"/"+(*it);
 
           if( curFile.right(1) == "/") {
               curFile = curFile.left( curFile.length() -1);
             }
 
           cmd = "ln -s "+curFile+" "+destName;
 //          odebug << cmd << oendl; 
           startProcess( (const QString)cmd );
         }
             rePopulate();
             setOtherTabCurrent();
     }
 }
 
 void AdvancedFm::doBeam() {
    Ir ir;
    if(!ir.supported())  {
    } else {
       QStringList curFileList = getPath();
       if( curFileList.count() > 0)  {
          for ( QStringList::Iterator it = curFileList.begin(); it != curFileList.end(); ++it ) {
             QString curFile = (*it);
             QString curFilePath =  CurrentDir()->canonicalPath()+"/"+curFile;
             if( curFilePath.right(1) == "/") {
                curFilePath = curFilePath.left( curFilePath.length() -1);
             }
             Ir *file = new Ir(this, "IR");
             connect(file, SIGNAL(done(Ir*)), this, SLOT( fileBeamFinished(Ir*)));
             file->send( curFilePath, curFile );
          }
       }
    }