-FlowControl and LineTermination are saved and activated by numerical

 value now. This makes it work across different translations
-Switch code to use new PPPData::enter() and PPPData::flowcontrol()

6 files changed, 45 insertions, 44 deletions

diff --git a/noncore/settings/networksettings/ppp/connect.cpp b/noncore/settings/networksettings/ppp/connect.cpp
index 128877a..8981e01 100644
--- a/noncore/settings/networksettings/ppp/connect.cpp
+++ b/noncore/settings/networksettings/ppp/connect.cpp
@@ -1090,258 +1090,258 @@ void ConnectWidget::pppdDied()
 
 void ConnectWidget::if_waiting_slot() {
   messg->setText(QObject::tr("Logging on to network..."));
 
 //   if(!stats->ifIsUp()) {
 
 //     if(_ifaceppp->data()->pppdError() != 0) {
 //       // we are here if pppd died immediately after starting it.
 //       pppdDied();
 //       // error message handled in main.cpp: sigPPPDDied()
 //       return;
 //     }
 
 //     if_timer->start(100, TRUE); // single shot
 //     return;
 //   }
 
   // O.K the ppp interface is up and running
   // give it a few time to come up completly (0.2 seconds)
   if_timeout_timer->stop();
   if_timer->stop();
   usleep(200000);
 
   if(_ifaceppp->data()->autoDNS())
     addpeerdns( _ifaceppp );
 
   // Close the debugging window. If we are connected, we
   // are not really interested in debug output
   emit closeDebugWindow();
 //  p_kppp->statdlg->take_stats(); // start taking ppp statistics
   auto_hostname(_ifaceppp);
 
   if(!_ifaceppp->data()->command_on_connect().isEmpty()) {
     messg->setText(QObject::tr("Running startup command..."));
 
     // make sure that we don't get any async errors
     qApp->flushX();
     execute_command(_ifaceppp->data()->command_on_connect());
     messg->setText(QObject::tr("Done"));
   }
 
   // remove the authentication file
   _ifaceppp->modem()->removeSecret(AUTH_PAP);
   _ifaceppp->modem()->removeSecret(AUTH_CHAP);
 
   emit debugMessage(QObject::tr("Done"));
   set_con_speed_string();
 
 //  p_kppp->con_win->setConnectionSpeed(p_kppp->con_speed);
 //  this->hide();
 //  messg->setText("");
 
   _ifaceppp->setStatus( true );
 
   m_refreshTimer = new QTimer( this );
   connect( m_refreshTimer, SIGNAL( timeout() ), this, SLOT( refresh() ) );
   m_refreshTimer->start( 3000 );
   //_ifaceppp->refresh();
   //  emit _ifaceppp->updateInterface(_ifaceppp);
 
   // prepare the con_win so as to have the right size for
   // accounting / non-accounting mode
 //   if(p_kppp->acct != 0)
 //     p_kppp->con_win->accounting(p_kppp->acct->running());
 //   else
 //     p_kppp->con_win->accounting(false);
 
 //   if (_ifaceppp->data()->get_dock_into_panel()) {
 // //    DockWidget::dock_widget->show();
 // //    DockWidget::dock_widget->take_stats();
 // //    this->hide();
 //   }
 //   else {
 // //    p_kppp->con_win->show();
 
 //     if(_ifaceppp->data()->get_iconify_on_connect()) {
 //         //    p_kppp->con_win->showMinimized();
 //     }
 //  }
 
   _ifaceppp->modem()->closetty();
 }
 
 void ConnectWidget::refresh()  {
     _ifaceppp->refresh();
     if ( _ifaceppp->getStatus() )  {
         messg->setText(QObject::tr("Online"));
     } else {
         messg->setText(QObject::tr("Offline"));
     }
 }
 
 
 bool ConnectWidget::execppp() {
   QString command;
 
   command = "pppd";
 
   // as of version 2.3.6 pppd falls back to the real user rights when
   // opening a device given in a command line. To avoid permission conflicts
   // we'll simply leave this argument away. pppd will then use the default tty
   // which is the serial port we connected stdin/stdout to in opener.cpp.
   //  command += " ";
   //  command += _ifaceppp->data()->modemDevice();
 
   command += " " + _ifaceppp->data()->speed();
 
   command += " -detach";
 
   if(_ifaceppp->data()->ipaddr() != "0.0.0.0" ||
      _ifaceppp->data()->gateway() != "0.0.0.0") {
     if(_ifaceppp->data()->ipaddr() != "0.0.0.0") {
       command += " ";
       command += _ifaceppp->data()->ipaddr();
       command +=  ":";
     }
     else {
       command += " ";
       command += ":";
     }
 
     if(_ifaceppp->data()->gateway() != "0.0.0.0")
       command += _ifaceppp->data()->gateway();
   }
 
   if(_ifaceppp->data()->subnetmask() != "0.0.0.0")
     command += " netmask " + _ifaceppp->data()->subnetmask();
 
-  if(_ifaceppp->data()->flowcontrol() != "None") {
-    if(_ifaceppp->data()->flowcontrol() == "CRTSCTS")
+  if(_ifaceppp->data()->flowcontrol() != PPPData::FlowNone) {
+      if(_ifaceppp->data()->flowcontrol() == PPPData::FlowHardware)
       command += " crtscts";
     else
       command += " xonxoff";
   }
 
   if(_ifaceppp->data()->defaultroute())
     command += " defaultroute";
 
   if(_ifaceppp->data()->autoDNS())
     command += " usepeerdns";
 
 
   // PAP settings
   if(_ifaceppp->data()->authMethod() == AUTH_PAP) {
     command += " -chap user ";
     command = command + _ifaceppp->data()->storedUsername();
   }
 
   // CHAP settings
   if(_ifaceppp->data()->authMethod() == AUTH_CHAP) {
     command += " -pap user ";
     command = command  + _ifaceppp->data()->storedUsername();
   }
 
   // PAP/CHAP settings
   if(_ifaceppp->data()->authMethod() == AUTH_PAPCHAP) {
       QString tmpName = _ifaceppp->data()->storedUsername();
       if ( !tmpName.isEmpty() )  {
           command += " user ";
           command = command + tmpName;
       }
   }
 
   // check for debug
   if(_ifaceppp->data()->getPPPDebug())
     command += " debug";
 
   QStringList &arglist = _ifaceppp->data()->pppdArgument();
   for ( QStringList::Iterator it = arglist.begin();
         it != arglist.end();
         ++it )
   {
     command += " " + *it;
   }
 
   command += " call opie-kppp logfd 11";
 
   if (command.length() > MAX_CMDLEN) {
       QMessageBox::critical(this, "error", QObject::tr(
                               "pppd command + command-line arguments exceed "
                               "2024 characters in length."
                               ));
 
     return false; // nonsensically long command which would bust my buffer buf.
   }
 
   owarn << "Command IS: " << command.latin1() << "" << oendl;
 
   qApp->flushX();
 
   return _ifaceppp->modem()->execPPPDaemon(command);
 }
 
 
 void ConnectWidget::closeEvent( QCloseEvent *e ) {
   e->ignore();
   emit cancelbutton();
 }
 
 
 void ConnectWidget::setMsg(const QString &msg) {
   messg->setText(msg);
 }
 
 void ConnectWidget::writeline(const QString &s) {
   _ifaceppp->modem()->writeLine(s.local8Bit());
 }
 
 // Set the hostname and domain from DNS Server
 void auto_hostname(InterfacePPP *_ifaceppp) {
   struct in_addr local_ip;
   struct hostent *hostname_entry;
   QString new_hostname;
   int    dot;
   char   tmp_str[100]; // buffer overflow safe
 
   gethostname(tmp_str, sizeof(tmp_str));
   tmp_str[sizeof(tmp_str)-1]=0; // panic
   old_hostname=tmp_str; // copy to QString
 
   // if (!p_kppp->stats->local_ip_address.isEmpty() && _ifaceppp->data()->autoname()) {
   if ( _ifaceppp->data()->autoname()) {
 //    local_ip.s_addr=inet_addr(p_kppp->stats->local_ip_address.ascii());
     hostname_entry=gethostbyaddr((const char *)&local_ip,sizeof(in_addr),AF_INET);
 
     if (hostname_entry != 0L) {
       new_hostname=hostname_entry->h_name;
       dot=new_hostname.find('.');
       new_hostname=new_hostname.remove(dot,new_hostname.length()-dot);
       _ifaceppp->modem()->setHostname(new_hostname);
       modified_hostname = TRUE;
 
       new_hostname=hostname_entry->h_name;
       new_hostname.remove(0,dot+1);
 
       add_domain(new_hostname, _ifaceppp);
     }
   }
 
 }
 
 // Replace the DNS domain entry in the /etc/resolv.conf file and
 // disable the nameserver entries if option is enabled
 void add_domain(const QString &domain, InterfacePPP *_ifaceppp) {
 
   int fd;
   char c;
   QString resolv[MAX_RESOLVCONF_LINES];
 
   if (domain.isEmpty())
     return;
 
   if((fd = _ifaceppp->modem()->openResolv(O_RDONLY)) >= 0) {
 
     int i=0;
     while((read(fd, &c, 1) == 1) && (i < MAX_RESOLVCONF_LINES)) {
       if(c == '\n') {
         i++;
diff --git a/noncore/settings/networksettings/ppp/general.cpp b/noncore/settings/networksettings/ppp/general.cpp
index 5e2a04f..9457173 100644
--- a/noncore/settings/networksettings/ppp/general.cpp
+++ b/noncore/settings/networksettings/ppp/general.cpp
@@ -67,433 +67,419 @@ ModemWidget::ModemWidget( PPPData *pd, QWidget *parent, const char *name )
     modemname->setText( _pppdata->devname() );
     label1->setBuddy(modemname);
     tl->addWidget(modemname, 0, 1);
 
     label1 = new QLabel(tr("Modem de&vice:"), this);
     tl->addWidget(label1, 1, 0);
 
     modemdevice = new QComboBox(false, this);
     modemdevice->setEditable( true );
     modemdevice->setDuplicatesEnabled ( false );
     modemdevice->setInsertionPolicy( QComboBox::AtTop );
     label1->setBuddy(modemdevice);
 
     Config cfg("NetworkSetupPPP");
     cfg.setGroup("Devices_General");
     QStringList devs = cfg.readListEntry("devices",',');
     if (devs.isEmpty()) devs << "/dev/modem" << "/dev/ircomm0" << "/dev/ttyS0";
     modemdevice->insertStringList( devs );
     tl->addWidget(modemdevice, 1, 1);
 
     //   connect(modemdevice, SIGNAL(activated(int)),
             //   SLOT(setmodemdc(int)));
     //   connect(modemdevice, SIGNAL(textChanged(const QString&) ),
     //           SLOT( setmodemdc(const QString&) ) );
 
     QString tmp = tr("This specifies the serial port your modem is attached \n"
                      "to. On Linux/x86, typically this is either /dev/ttyS0 \n"
                      "(COM1 under DOS) or /dev/ttyS1 (COM2 under DOS).\n"
                      "\n"
                      "If you have an internal ISDN card with AT command\n"
                      "emulation (most cards under Linux support this), you\n"
                      "should select one of the /dev/ttyIx devices.");
 
     QWhatsThis::add(label1,tmp);
     QWhatsThis::add(modemdevice,tmp);
 
 
     label1 = new QLabel(tr("&Flow control:"), this);
     tl->addWidget(label1, 2, 0);
 
     flowcontrol = new QComboBox(false, this);
     label1->setBuddy(flowcontrol);
     flowcontrol->insertItem(tr("Hardware [CRTSCTS]"));
     flowcontrol->insertItem(tr("Software [XON/XOFF]"));
     flowcontrol->insertItem(tr("None"));
     tl->addWidget(flowcontrol, 2, 1);
     //   connect(flowcontrol, SIGNAL(activated(int)),
             //   SLOT(setflowcontrol(int)));
 
     tmp = tr("<p>Specifies how the serial port and modem\n"
              "communicate. You should not change this unless\n"
              "you know what you are doing.\n"
              "\n"
              "<b>Default</b>: CRTSCTS");
 
     QWhatsThis::add(label1,tmp);
     QWhatsThis::add(flowcontrol,tmp);
 
     QLabel *labelenter = new QLabel(tr("&Line termination:"), this);
     tl->addWidget(labelenter, 3, 0);
 
     enter = new QComboBox(false, this);
     labelenter->setBuddy(enter);
     enter->insertItem("CR");
     enter->insertItem("LF");
     enter->insertItem("CR/LF");
     tl->addWidget(enter, 3, 1);
     //  connect(enter, SIGNAL(activated(int)), SLOT(setenter(int)));
     tmp = tr("<p>Specifies how AT commands are sent to your\n"
              "modem. Most modems will work fine with the\n"
              "default <i>CR/LF</i>. If your modem does not react\n"
              "to the init string, you should try different\n"
              "settings here\n"
              "\n"
              "<b>Default</b>: CR/LF");
 
     QWhatsThis::add(labelenter,tmp);
     QWhatsThis::add(enter, tmp);
 
     QLabel *baud_label = new QLabel(tr("Co&nnection speed:"), this);
     tl->addWidget(baud_label, 4, 0);
     baud_c = new QComboBox(this);
     baud_label->setBuddy(baud_c);
 
     static const char *baudrates[] =
         {
 
 #ifdef B460800
             "460800",
 #endif
 
 #ifdef B230400
             "230400",
 #endif
 
 #ifdef B115200
             "115200",
 #endif
 
 #ifdef B57600
             "57600",
 #endif
 
             "38400",
             "19200",
             "9600",
             "2400",
             0
         };
 
     for(k = 0; baudrates[k]; k++)
         baud_c->insertItem(baudrates[k]);
 
     baud_c->setCurrentItem(3);
     //   connect(baud_c, SIGNAL(activated(int)),
             //   this, SLOT(speed_selection(int)));
     tl->addWidget(baud_c, 4, 1);
 
     tmp = tr("Specifies the speed your modem and the serial\n"
              "port talk to each other. You should begin with\n"
              "the default of 38400 bits/sec. If everything\n"
              "works you can try to increase this value, but to\n"
              "no more than 115200 bits/sec (unless you know\n"
              "that your serial port supports higher speeds).");
 
     QWhatsThis::add(baud_label,tmp);
     QWhatsThis::add(baud_c,tmp);
 
-    for(int i=0; i <= enter->count()-1; i++)
-    {
-        if(_pppdata->enter() == enter->text(i))
-            enter->setCurrentItem(i);
-    }
-
     tl->addRowSpacing(5, 10);
 
     //Modem Lock File
     modemlockfile = new QCheckBox(tr("&Use lock file"), this);
-
     modemlockfile->setChecked(_pppdata->modemLockFile());
     //   connect(modemlockfile, SIGNAL(toggled(bool)),
     //           SLOT(modemlockfilechanged(bool)));
     tl->addMultiCellWidget(modemlockfile, 6, 6, 0, 1);
     //  l12->addStretch(1);
     QWhatsThis::add(modemlockfile,
                         tr("<p>To prevent other programs from accessing the\n"
                            "modem while a connection is established, a\n"
                            "file can be created to indicate that the modem\n"
                            "is in use. On Linux an example file would be\n"
                            "<tt>/var/lock/LCK..ttyS1</tt>\n"
                            "Here you can select whether this locking will\n"
                            "be done.\n"
                            "\n"
                            "<b>Default</b>: On"));
 
     // Modem Timeout Line Edit Box
     QHBoxLayout *timeoutLayout = new QHBoxLayout( this );
     QLabel *timeoutlabel = new QLabel( tr("Modem timeout:") ,this, "timeout" );
     modemtimeout = new QSpinBox( 1, 120, 1, this, "modemTimeout" );
     //   modemtimeout = new KIntNumInput(_pppdata->modemTimeout(), this);
     //   modemtimeout->setLabel(tr("Modem &timeout:"));
     //  modemtimeout->setRange(1, 120, 1);
     modemtimeout->setSuffix(tr(" sec"));
     modemtimeout->setValue( _pppdata->modemTimeout() );
     //   connect(modemtimeout, SIGNAL(valueChanged(int)),
             //   SLOT(modemtimeoutchanged(int)));
     timeoutLayout->addWidget(timeoutlabel);
     timeoutLayout->addWidget(modemtimeout);
     tl->addMultiCellLayout(timeoutLayout, 7, 7, 0, 1);
 
     QWhatsThis::add(modemtimeout,
                         tr("This specifies how long <i>kppp</i> waits for a\n"
                            "<i>CONNECT</i> response from your modem. The\n"
                            "recommended value is 30 seconds."));
 
     //set stuff from gpppdata
-    for(int i=0; i <= enter->count()-1; i++)
-    {
-        if(_pppdata->enter() == enter->text(i))
-            enter->setCurrentItem(i);
-    }
+    enter->setCurrentItem( static_cast<int>(_pppdata->enter()) );
+    flowcontrol->setCurrentItem( static_cast<int>( _pppdata->flowcontrol() ) );
 
     for(int i=0; i <= modemdevice->count()-1; i++)
     {
         if(_pppdata->modemDevice() == modemdevice->text(i))
             modemdevice->setCurrentItem(i);
     }
 
-    for(int i=0; i <= flowcontrol->count()-1; i++)
-    {
-        if(_pppdata->flowcontrol() == flowcontrol->text(i))
-            flowcontrol->setCurrentItem(i);
-    }
-
     //set the modem speed
     for(int i=0; i < baud_c->count(); i++)
         if(baud_c->text(i) == _pppdata->speed())
             baud_c->setCurrentItem(i);
 
     tl->setRowStretch(1, 1);
 }
 
 ModemWidget::~ModemWidget()
 {
     QStringList devs;
 
     for (int i=0;i<modemdevice->count();i++)
     {
         QString s = modemdevice->text(i);
         s.simplifyWhiteSpace();
         if (! s.isEmpty() ) devs << s;
     }
 
 
     QString edited = modemdevice->currentText();
     if ( !( edited ).isEmpty() )
     {
         edited.simplifyWhiteSpace();
         if ( devs.contains( edited ) == 0 )
         {
             devs << edited;
         }
     }
 
 
     Config cfg("NetworkSetupPPP");
     cfg.setGroup("Devices_General");
     cfg.writeEntry("devices",devs,',');
 
 }
 
 // void ModemWidget::speed_selection(int) {
 //   _pppdata->setSpeed(baud_c->text(baud_c->currentItem()));
 // }
 
 
 // void ModemWidget::setenter(int ) {
 //   _pppdata->setEnter(enter->text(enter->currentItem()));
 // }
 
 
 // void ModemWidget::setmodemdc(int i) {
 //   _pppdata->setModemDevice(modemdevice->text(i));
 // }
 
 // void ModemWidget::setmodemdc( const QString &string )  {
 //     _pppdata->setModemDevice( string );
 // }
 
 // void ModemWidget::setflowcontrol(int i) {
 //   _pppdata->setFlowcontrol(flowcontrol->text(i));
 // }
 
 
 // void ModemWidget::modemlockfilechanged(bool set) {
 //   _pppdata->setModemLockFile(set);
 // }
 
 
 // void ModemWidget::modemtimeoutchanged(int n) {
 //   _pppdata->setModemTimeout(n);
 // }
 
 
 
 bool ModemWidget::save()
 {
     //first check to make sure that the device name is unique!
     if(modemname->text().isEmpty() ||
             !_pppdata->isUniqueDevname(modemname->text()))
         return false;
 
     _pppdata->setDevname( modemname->text() );
     _pppdata->setModemDevice( modemdevice->currentText() );
-    _pppdata->setFlowcontrol(flowcontrol->currentText());
-    _pppdata->setFlowcontrol(flowcontrol->currentText());
+    _pppdata->setFlowcontrol(static_cast<PPPData::FlowControl>(flowcontrol->currentItem()));
+    _pppdata->setEnter( static_cast<PPPData::LineTermination>(enter->currentItem()));
     _pppdata->setSpeed(baud_c->currentText());
     _pppdata->setModemLockFile( modemlockfile->isChecked());
     _pppdata->setModemTimeout( modemtimeout->value() );
     return true;
 
 }
 
 void ModemWidget::slotBeforeModemQuery()
 {
     m_oldModemDev     = _pppdata->modemDevice();
-    m_oldFlowControl  = _pppdata->flowcontrol();
+    m_oldFlowControl  = static_cast<int>( _pppdata->flowcontrol() );
     m_oldSpeed        = _pppdata->speed();
     m_oldModemLock    = _pppdata->modemLockFile();
     m_oldModemTimeout = _pppdata->modemTimeout();
+    m_oldLineEnd      = static_cast<int>( _pppdata->enter() );
 
 
     _pppdata->setModemDevice( modemdevice->currentText() );
-    _pppdata->setFlowcontrol(flowcontrol->currentText());
-    _pppdata->setFlowcontrol(flowcontrol->currentText());
+    _pppdata->setFlowcontrol(static_cast<PPPData::FlowControl>(flowcontrol->currentItem()));
+    _pppdata->setEnter(static_cast<PPPData::LineTermination>(enter->currentItem()));
     _pppdata->setSpeed(baud_c->currentText());
     _pppdata->setModemLockFile( modemlockfile->isChecked());
     _pppdata->setModemTimeout( modemtimeout->value() );
 }
 
 
 void ModemWidget::slotAfterModemQuery()
 {
     _pppdata->setModemDevice( m_oldModemDev );
-    _pppdata->setFlowcontrol( m_oldFlowControl );
+    _pppdata->setFlowcontrol( static_cast<PPPData::FlowControl>(m_oldFlowControl) );
+    _pppdata->setEnter( static_cast<PPPData::LineTermination>(m_oldLineEnd) );
     _pppdata->setSpeed( m_oldSpeed );
     _pppdata->setModemLockFile( m_oldModemLock );
     _pppdata->setModemTimeout( m_oldModemTimeout );
 }
 
 
 ModemWidget2::ModemWidget2( PPPData *pd, InterfacePPP *ip, QWidget *parent,
                             const char *name)
         : QWidget(parent, name), _pppdata(pd), _ifaceppp(ip)
 {
     QVBoxLayout *l1 = new QVBoxLayout(this, 0 );//, KDialog::spacingHint());
 
 
     waitfordt = new QCheckBox(tr("&Wait for dial tone before dialing"), this);
     waitfordt->setChecked(_pppdata->waitForDialTone());
     //  connect(waitfordt, SIGNAL(toggled(bool)), SLOT(waitfordtchanged(bool)));
     l1->addWidget(waitfordt);
     QWhatsThis::add(waitfordt,
                         tr("<p>Normally the modem waits for a dial tone\n"
                            "from your phone line, indicating that it can\n"
                            "start to dial a number. If your modem does not\n"
                            "recognize this sound, or your local phone system\n"
                            "does not emit such a tone, uncheck this option\n"
                            "\n"
                            "<b>Default:</b>: On"));
 
     QHBoxLayout *waitLayout = new QHBoxLayout( this );
     QLabel *waitLabel = new QLabel( tr("Busy wait:"), this, "busyWait" );
     busywait = new QSpinBox( 0, 300, 5, this, "busyWait" );
     //   busywait = new KIntNumInput(_pppdata->busyWait(), this);
     //   busywait->setLabel(tr("B&usy wait:"));
     //   busywait->setRange(0, 300, 5, true);
     busywait->setSuffix(tr(" sec"));
     //  connect(busywait, SIGNAL(valueChanged(int)), SLOT(busywaitchanged(int)));
     waitLayout->addWidget(waitLabel);
     waitLayout->addWidget(busywait);
     l1->addLayout( waitLayout );
 
     QWhatsThis::add(busywait,
                         tr("Specifies the number of seconds to wait before\n"
                            "redial if all dialed numbers are busy. This is\n"
                            "necessary because some modems get stuck if the\n"
                            "same number is busy too often.\n"
                            "\n"
                            "The default is 0 seconds, you should not change\n"
                            "this unless you need to."));
 
     l1->addSpacing(10);
 
     QHBoxLayout *hbl = new QHBoxLayout;
     hbl->setSpacing(2);//KDialog::spacingHint());
 
     QLabel *volumeLabel = new QLabel(tr("Modem &volume:"), this);
     hbl->addWidget(volumeLabel);
     volume = new QSlider(0, 2, 1, _pppdata->volume(),
                          QSlider::Horizontal, this);
     volumeLabel->setBuddy(volume);
     volume->setTickmarks(QSlider::Below);
     hbl->addWidget(volume);
 
     l1->addLayout(hbl);
 
     //   connect(volume, SIGNAL(valueChanged(int)),
             //   this, SLOT(volumeChanged(int)));
     QString tmp = tr("Most modems have a speaker which makes\n"
                      "a lot of noise when dialing. Here you can\n"
                      "either turn this completely off or select a\n"
                      "lower volume.\n"
                      "\n"
                      "If this does not work for your modem,\n"
                      "you must modify the modem volume command.");
 
     QWhatsThis::add(volumeLabel,tmp);
     QWhatsThis::add(volume, tmp);
 
     l1->addSpacing(20);
 
 #if 0
     chkbox1 = new QCheckBox(tr("Modem asserts CD line"), this);
     chkbox1->setChecked(_pppdata->UseCDLine());
     connect(chkbox1,SIGNAL(toggled(bool)),
             this,SLOT(use_cdline_toggled(bool)));
     l12->addWidget(chkbox1);
     l12->addStretch(1);
     l1->addStretch(1);
     QWhatsThis::add(chkbox1,
                         tr("This controls how <i>kppp</i> detects that the modem\n"
                            "is not responding. Unless you are having\n"
                            "problems with this, do not modify this setting.\n"
                            "\n"
                            "<b>Default</b>: Off"));
 #endif
 
     modemcmds = new QPushButton(tr("Mod&em Commands..."), this);
     QWhatsThis::add(modemcmds,
                         tr("Allows you to change the AT command for\n"
                            "your modem."));
 
     modeminfo_button = new QPushButton(tr("&Query Modem..."), this);
     QWhatsThis::add(modeminfo_button,
                         tr("Most modems support the ATI command set to\n"
                            "find out vendor and revision of your modem.\n"
                            "\n"
                            "Press this button to query your modem for\n"
                            "this information. It can be useful to help\n"
                            "you setup the modem"));
 
     //   terminal_button = new QPushButton(tr("&Terminal..."), this);
     //   QWhatsThis::add(terminal_button,
             //            tr("Opens the built-in terminal program. You\n"
             //                 "can use this if you want to play around\n"
             //                 "with your modem's AT command set"));
 
     QHBoxLayout *hbox = new QHBoxLayout();
     l1->addLayout(hbox);
     hbox->addStretch(1);
     QVBoxLayout *vbox = new QVBoxLayout();
     hbox->addLayout(vbox);
 
     vbox->addWidget(modemcmds);
     vbox->addWidget(modeminfo_button);
     //  vbox->addWidget(terminal_button);
 
     hbox->addStretch(1);
     l1->addStretch(1);
 
     connect(modemcmds, SIGNAL(clicked()),
             SLOT(modemcmdsbutton()));
diff --git a/noncore/settings/networksettings/ppp/general.h b/noncore/settings/networksettings/ppp/general.h
index a4dece4..0bb3136 100644
--- a/noncore/settings/networksettings/ppp/general.h
+++ b/noncore/settings/networksettings/ppp/general.h
@@ -1,125 +1,125 @@
 /*
  *
  *            kPPP: A pppd front end for the KDE project
  *
  * $Id$
  *
  *            Copyright (C) 1997 Bernd Johannes Wuebben
  *                   wuebben@math.cornell.edu
  *
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public
  * License along with this program; if not, write to the Free
  * Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
 #ifndef _GENERAL_H_
 #define _GENERAL_H_
 
 #include <qwidget.h>
 
 class QSlider;
 class QSpinBox;
 class QCombobox;
 class QLabel;
 class QCheckBox;
 class QComboBox;
 class PPPData;
 class InterfacePPP;
 class QLineEdit;
 
 class ModemWidget : public QWidget {
   Q_OBJECT
 public:
   ModemWidget(PPPData*, QWidget *parent=0, const char *name=0 );
   ~ModemWidget();
 
   bool save();
 
 private slots:
     /*
      * temporarily commit configuration so queryModem
      * will use 'current' settings
      */
     void slotBeforeModemQuery();
     void slotAfterModemQuery();
 
 /* private slots: */
         /*   void setmodemdc(int); */
 /*   void  setmodemdc(const QString &); */
         /*   void setflowcontrol(int); */
         /*   void modemtimeoutchanged(int); */
         /*   void modemlockfilechanged(bool); */
         /*   void setenter(int); */
 /*   void  speed_selection(int); */
 
 private:
           QComboBox *enter;
         /*   QLabel *label1; */
         /*   QLabel *label2; */
         /*   QLabel *labeltmp; */
         /*   QLabel *labelenter; */
   QLineEdit     *modemname;
           QComboBox *modemdevice;
           QComboBox *flowcontrol;
 
   QComboBox *baud_c;
   QLabel *baud_label;
 
           QSpinBox *modemtimeout;
   QCheckBox     *modemlockfile;
   PPPData *_pppdata;
 
 private:
-    QString m_oldModemDev, m_oldFlowControl, m_oldSpeed;
+    QString m_oldModemDev, m_oldSpeed;
     bool m_oldModemLock;
-    int m_oldModemTimeout;
+    int m_oldModemTimeout, m_oldFlowControl, m_oldLineEnd;
 };
 
 
 class ModemWidget2 : public QWidget {
   Q_OBJECT
 public:
   ModemWidget2( PPPData*, InterfacePPP*, QWidget *parent=0, const char *name=0 );
   bool save();
 
 signals:
     void sig_beforeQueryModem();
     void sig_afterQueryModem();
 
 private slots:
 /*   void  waitfordtchanged(bool); */
         /*   void busywaitchanged(int); */
         //  void use_cdline_toggled(bool);
           void modemcmdsbutton();
           //  void terminal();
           void query_modem();
   //  void  volumeChanged(int);
 
 private:
           QLabel *labeltmp;
           QPushButton *modemcmds;
           QPushButton *modeminfo_button;
           //  QPushButton *terminal_button;
           //  QFrame *fline;
   QCheckBox     *waitfordt;
           QSpinBox *busywait;
           QCheckBox *chkbox1;
   QSlider       *volume;
   PPPData *_pppdata;
   InterfacePPP *_ifaceppp;
 };
 
 #endif
 
 
diff --git a/noncore/settings/networksettings/ppp/modem.cpp b/noncore/settings/networksettings/ppp/modem.cpp
index 79f015b..7b2e2a3 100644
--- a/noncore/settings/networksettings/ppp/modem.cpp
+++ b/noncore/settings/networksettings/ppp/modem.cpp
@@ -100,395 +100,399 @@ Modem::Modem( PPPData* pd )
     modemfd = -1;
     _pppdExitStatus = -1;
     pppdPid = -1;
     sn = m_modemDebug =  0L;
     data_mode = false;
     modem_is_locked = false;
     lockfile[0] = '\0';
     device = "/dev/modem";
 }
 
 
 Modem::~Modem()
 {
 }
 
 
 speed_t Modem::modemspeed() {
   // convert the string modem speed int the gpppdata object to a t_speed type
   // to set the modem.  The constants here should all be ifdef'd because
   // other systems may not have them
     int i = _pppdata->speed().toInt()/100;
 
   switch(i) {
   case 24:
     return B2400;
     break;
   case 96:
     return B9600;
     break;
   case 192:
     return B19200;
     break;
   case 384:
     return B38400;
     break;
 #ifdef B57600
   case 576:
     return B57600;
     break;
 #endif
 
 #ifdef B115200
   case 1152:
     return B115200;
     break;
 #endif
 
 #ifdef B230400
   case 2304:
     return B230400;
     break;
 #endif
 
 #ifdef B460800
   case 4608:
     return B460800;
     break;
 #endif
 
   default:
     return B38400;
     break;
   }
 }
 
 bool Modem::opentty() {
   //  int flags;
 
 //begin  if((modemfd = Requester::rq->openModem(gpppdata.modemDevice()))<0) {
     close(modemfd);
     device = _pppdata->modemDevice();
     if ((modemfd = open(device, O_RDWR|O_NDELAY|O_NOCTTY)) == -1) {
         odebug << "error opening modem device !" << oendl;
         errmsg = QObject::tr("Unable to open modem.");
         return false;
     }
 //bend  if((modemfd = Requester::rq->openModem(gpppdata.modemDevice()))<0) {
 //}
 
 #if 0
   if(_pppdata->UseCDLine()) {
     if(ioctl(modemfd, TIOCMGET, &flags) == -1) {
       errmsg = QObject::tr("Unable to detect state of CD line.");
       ::close(modemfd);
       modemfd = -1;
       return false;
     }
     if ((flags&TIOCM_CD) == 0) {
       errmsg = QObject::tr("The modem is not ready.");
       ::close(modemfd);
       modemfd = -1;
       return false;
     }
   }
 #endif
 
   tcdrain (modemfd);
   tcflush (modemfd, TCIOFLUSH);
 
   if(tcgetattr(modemfd, &tty) < 0){
     // this helps in some cases
     tcsendbreak(modemfd, 0);
     sleep(1);
     if(tcgetattr(modemfd, &tty) < 0){
       errmsg = QObject::tr("The modem is busy.");
       ::close(modemfd);
       modemfd = -1;
       return false;
     }
   }
 
   memset(&initial_tty,'\0',sizeof(initial_tty));
 
   initial_tty = tty;
 
   tty.c_cc[VMIN] = 0; // nonblocking
   tty.c_cc[VTIME] = 0;
   tty.c_oflag = 0;
   tty.c_lflag = 0;
 
   tty.c_cflag &= ~(CSIZE | CSTOPB | PARENB);
   tty.c_cflag |= CS8 | CREAD;
   tty.c_cflag |= CLOCAL;                   // ignore modem status lines
   tty.c_iflag = IGNBRK | IGNPAR /* | ISTRIP */ ;
   tty.c_lflag &= ~ICANON;                  // non-canonical mode
   tty.c_lflag &= ~(ECHO|ECHOE|ECHOK|ECHOKE);
 
 
-  if(_pppdata->flowcontrol() != "None") {
-      if(_pppdata->flowcontrol() == "CRTSCTS") {
+  if(_pppdata->flowcontrol() != PPPData::FlowNone) {
+      if(_pppdata->flowcontrol() == PPPData::FlowHardware) {
       tty.c_cflag |= CRTSCTS;
     }
     else {
       tty.c_iflag |= IXON | IXOFF;
       tty.c_cc[VSTOP]  = 0x13; /* DC3 = XOFF = ^S */
       tty.c_cc[VSTART] = 0x11; /* DC1 = XON  = ^Q */
     }
   }
   else {
     tty.c_cflag &= ~CRTSCTS;
     tty.c_iflag &= ~(IXON | IXOFF);
   }
 
   cfsetospeed(&tty, modemspeed());
   cfsetispeed(&tty, modemspeed());
 
   tcdrain(modemfd);
 
   if(tcsetattr(modemfd, TCSANOW, &tty) < 0){
     errmsg = QObject::tr("The modem is busy.");
     ::close(modemfd);
     modemfd=-1;
     return false;
   }
 
   errmsg = QObject::tr("Modem Ready.");
   return true;
 }
 
 
 bool Modem::closetty() {
   if(modemfd >=0 ) {
     stop();
     /* discard data not read or transmitted */
     tcflush(modemfd, TCIOFLUSH);
 
     if(tcsetattr(modemfd, TCSANOW, &initial_tty) < 0){
       errmsg = QObject::tr("Can't restore tty settings: tcsetattr()\n");
       ::close(modemfd);
       modemfd = -1;
       return false;
     }
     ::close(modemfd);
     modemfd = -1;
   }
 
   return true;
 }
 
 
 void Modem::readtty(int) {
   char buffer[200];
   unsigned char c;
   int len;
 
   // read data in chunks of up to 200 bytes
   if((len = ::read(modemfd, buffer, 200)) > 0) {
     // split buffer into single characters for further processing
     for(int i = 0; i < len; i++) {
       c = buffer[i] & 0x7F;
       emit charWaiting(c);
     }
   }
 }
 
 
 void Modem::notify(const QObject *receiver, const char *member) {
   connect(this, SIGNAL(charWaiting(unsigned char)), receiver, member);
   startNotifier();
 }
 
 
 void Modem::stop() {
   disconnect(SIGNAL(charWaiting(unsigned char)));
   stopNotifier();
 }
 
 
 void Modem::startNotifier() {
   if(modemfd >= 0) {
     if(sn == 0) {
       sn = new QSocketNotifier(modemfd, QSocketNotifier::Read, this);
       connect(sn, SIGNAL(activated(int)), SLOT(readtty(int)));
       odebug << "QSocketNotifier started!" << oendl;
     } else {
         odebug << "QSocketNotifier re-enabled!" << oendl;
         sn->setEnabled(true);
     }
   }
 }
 
 
 void Modem::stopNotifier() {
   if(sn != 0) {
     sn->setEnabled(false);
     disconnect(sn);
     delete sn;
     sn = 0;
     odebug << "QSocketNotifier stopped!" << oendl;
   }
 }
 
 
 void Modem::flush() {
   char c;
   while(read(modemfd, &c, 1) == 1);
 }
 
 
 bool Modem::writeChar(unsigned char c) {
   int s;
   do {
     s = write(modemfd, &c, 1);
     if (s < 0) {
       oerr << "write() in Modem::writeChar failed" << oendl;
       return false;
     }
   } while(s == 0);
 
   return true;
 }
 
 
 bool Modem::writeLine(const char *buf) {
   int len = strlen(buf);
   char *b = new char[len+2];
   memcpy(b, buf, len);
   // different modems seem to need different line terminations
-  QString term = _pppdata->enter();
-  if(term == "LF")
+  switch( _pppdata->enter() ) {
+  case PPPData::EndLF:
     b[len++]='\n';
-  else if(term == "CR")
+    break;
+  case PPPData::EndCR:
     b[len++]='\r';
-  else if(term == "CR/LF") {
+    break;
+  case PPPData::EndCRLF:
     b[len++]='\r';
     b[len++]='\n';
+    break;
   }
+
   int l = len;
   while(l) {
     int wr = write(modemfd, &b[len-l], l);
     if(wr < 0) {
       // TODO do something meaningful with the error code (or ignore it
       oerr << "write() in Modem::writeLine failed" << oendl;
       delete[] b;
       return false;
     }
     l -= wr;
   }
   delete[] b;
   return true;
 }
 
 
 bool Modem::hangup() {
   // this should really get the modem to hang up and go into command mode
   // If anyone sees a fault in the following please let me know, since
   // this is probably the most imporant snippet of code in the whole of
   // kppp. If people complain about kppp being stuck, this piece of code
   // is most likely the reason.
   struct termios temptty;
 
   if(modemfd >= 0) {
 
     // is this Escape & HangupStr stuff really necessary ? (Harri)
 
     if (data_mode) escape_to_command_mode();
 
     // Then hangup command
     writeLine(_pppdata->modemHangupStr().local8Bit());
 
     usleep(_pppdata->modemInitDelay() * 10000); // 0.01 - 3.0 sec
 
 #ifndef DEBUG_WO_DIALING
     if (sigsetjmp(jmp_buffer, 1) == 0) {
       // set alarm in case tcsendbreak() hangs
       signal(SIGALRM, alarm_handler);
       alarm(2);
 
       tcsendbreak(modemfd, 0);
 
       alarm(0);
       signal(SIGALRM, SIG_IGN);
     } else {
       // we reach this point if the alarm handler got called
       closetty();
       close(modemfd);
       modemfd = -1;
       errmsg = QObject::tr("The modem does not respond.");
       return false;
     }
 
 #ifndef __svr4__ // drops DTR but doesn't set it afterwards again. not good for init.
     tcgetattr(modemfd, &temptty);
     cfsetospeed(&temptty, B0);
     cfsetispeed(&temptty, B0);
     tcsetattr(modemfd, TCSAFLUSH, &temptty);
 #else
     int modemstat;
     ioctl(modemfd, TIOCMGET, &modemstat);
     modemstat &= ~TIOCM_DTR;
     ioctl(modemfd, TIOCMSET, &modemstat);
     ioctl(modemfd, TIOCMGET, &modemstat);
     modemstat |= TIOCM_DTR;
     ioctl(modemfd, TIOCMSET, &modemstat);
 #endif
 
     usleep(_pppdata->modemInitDelay() * 10000); // 0.01 - 3.0 secs
 
     cfsetospeed(&temptty, modemspeed());
     cfsetispeed(&temptty, modemspeed());
     tcsetattr(modemfd, TCSAFLUSH, &temptty);
 #endif
     return true;
   } else
     return false;
 }
 
 
 void Modem::escape_to_command_mode() {
   // Send Properly bracketed escape code to put the modem back into command state.
   // A modem will accept AT commands only when it is in command state.
   // When a modem sends the host the CONNECT string, that signals
   // that the modem is now in the connect state (no long accepts AT commands.)
   // Need to send properly timed escape sequence to put modem in command state.
   // Escape codes and guard times are controlled by S2 and S12 values.
   //
   tcflush(modemfd, TCIOFLUSH);
 
   // +3 because quiet time must be greater than guard time.
   usleep((_pppdata->modemEscapeGuardTime()+3)*20000);
   QCString tmp = _pppdata->modemEscapeStr().local8Bit();
   write(modemfd, tmp.data(), tmp.length());
   tcflush(modemfd, TCIOFLUSH);
   usleep((_pppdata->modemEscapeGuardTime()+3)*20000);
 
   data_mode = false;
 }
 
 
 const QString Modem::modemMessage() {
   return errmsg;
 }
 
 
 QString Modem::parseModemSpeed(const QString &s) {
   // this is a small (and bad) parser for modem speeds
   int rx = -1;
   int tx = -1;
   int i;
   QString result;
 
   odebug << "Modem reported result string: " << s.latin1() << "" << oendl;
 
   const int RXMAX = 7;
   const int TXMAX = 2;
   QRegExp rrx[RXMAX] = {
     QRegExp("[0-9]+[:/ ]RX", false),
     QRegExp("[0-9]+RX", false),
     QRegExp("[/: -][0-9]+[/: ]", false),
     QRegExp("[/: -][0-9]+$", false),
     QRegExp("CARRIER [^0-9]*[0-9]+", false),
     QRegExp("CONNECT [^0-9]*[0-9]+", false),
     QRegExp("[0-9]+") // panic mode
   };
 
diff --git a/noncore/settings/networksettings/ppp/pppdata.cpp b/noncore/settings/networksettings/ppp/pppdata.cpp
index eb03ef4..1491ea2 100644
--- a/noncore/settings/networksettings/ppp/pppdata.cpp
+++ b/noncore/settings/networksettings/ppp/pppdata.cpp
@@ -262,262 +262,262 @@ bool PPPData::get_show_clock_on_caption() {
 
 void PPPData::set_show_clock_on_caption(bool set) {
   writeConfig(GENERAL_GRP, SHOWCLOCK_KEY, (int) set);
 }
 
 
 bool PPPData::get_xserver_exit_disconnect() {
   return (bool) readNumConfig(GENERAL_GRP, DISCONNECT_KEY, true);
 }
 
 
 void PPPData::setPPPDebug(bool set) {
   writeConfig(GENERAL_GRP, PPP_DEBUG_OPTION, (int)set);
 }
 
 
 bool PPPData::getPPPDebug() {
   return (bool)readNumConfig(GENERAL_GRP, PPP_DEBUG_OPTION, false);
 }
 
 
 void PPPData::set_xserver_exit_disconnect(bool set) {
   writeConfig(GENERAL_GRP, DISCONNECT_KEY, (int) set);
 }
 
 
 bool PPPData::quit_on_disconnect() {
   return (bool) readNumConfig(GENERAL_GRP, QUITONDISCONNECT_KEY, false);
 }
 
 
 void PPPData::set_quit_on_disconnect(bool set) {
   writeConfig(GENERAL_GRP, QUITONDISCONNECT_KEY, (int) set);
 }
 
 
 bool PPPData::get_show_log_window() {
   return (bool) readNumConfig (GENERAL_GRP, SHOWLOGWIN_KEY, false);
 }
 
 
 void PPPData::set_show_log_window(bool set) {
   writeConfig(GENERAL_GRP, SHOWLOGWIN_KEY, (int) set);
 }
 
 
 bool PPPData::automatic_redial() {
   return (bool) readNumConfig(GENERAL_GRP, AUTOREDIAL_KEY, FALSE);
 }
 
 
 void PPPData::set_automatic_redial(bool set) {
   writeConfig(GENERAL_GRP, AUTOREDIAL_KEY, (int) set);
 }
 
 
 // bool PPPData::get_iconify_on_connect() {
 //   return (bool) readNumConfig(GENERAL_GRP, ICONIFY_ON_CONNECT_KEY, TRUE);
 // }
 
 
 // void PPPData::set_iconify_on_connect(bool set) {
 //   writeConfig(GENERAL_GRP, ICONIFY_ON_CONNECT_KEY, (int) set);
 // }
 
 
 // bool PPPData::get_dock_into_panel() {
 //   return (bool) readNumConfig(GENERAL_GRP, DOCKING_KEY, false);
 // }
 
 
 // void PPPData::set_dock_into_panel(bool set) {
 //   writeConfig(GENERAL_GRP, DOCKING_KEY, (int) set);
 // }
 
 
 QString PPPData::pppdVersion() {
   return QString("%1.%2.%3").arg(pppdVer).arg(pppdMod).arg(pppdPatch);
 }
 
 bool PPPData::pppdVersionMin(int ver, int mod, int patch) {
   // check if pppd version fulfills minimum requirement
   return (pppdVer > ver
           || (pppdVer == ver && pppdMod > mod)
           || (pppdVer == ver && pppdMod == mod && pppdPatch >= patch));
 }
 
 int PPPData::pppdTimeout() {
   return readNumConfig(GENERAL_GRP, PPPDTIMEOUT_KEY, PPPD_TIMEOUT);
 }
 
 
 void PPPData::setpppdTimeout(int n) {
   writeConfig(GENERAL_GRP, PPPDTIMEOUT_KEY, n);
 }
 
 
 const QString PPPData::modemDevice() {
   return readConfig (modemGroup(), MODEMDEV_KEY, "/dev/modem" );
 }
 
 
 // const QString PPPData::modemName()
 // {
 //     return readConfig(modemGroup(), MODEMNAME_KEY);
 // }
 
 // bool PPPData::setModemName(const QString &n) {
 //     odebug << "Setting modem name to >" << n.latin1() << "<" << oendl; 
 //     _modemName = n;
 //     writeConfig(cgroup, MODEMNAME_KEY, n);
 //     return true; //FIXME
 // }
 
 // bool PPPData::changeModemName(const QString &n) {
 //     odebug << "Setting modem name to >" << n.latin1() << "<" << oendl; 
 //     _modemName = n;
 //     writeConfig(modemGroup(), MODEMNAME_KEY, n);
 //     return true; //FIXME
 // }
 
 bool PPPData::setModemDevice(const QString &n) {
     odebug << "Setting modem dev to >" << n.latin1() << "<" << oendl; 
     writeConfig(modemGroup(), MODEMDEV_KEY, n);
     return true; //FIXME
 }
 
 
-const QString PPPData::flowcontrol() {
-  return readConfig(modemGroup(), FLOWCONTROL_KEY, "CRTSCTS");
+enum PPPData::FlowControl PPPData::flowcontrol() {
+  return static_cast<FlowControl>(readNumConfig(modemGroup(), FLOWCONTROL_KEY, FlowHardware));
 }
 
 
-void PPPData::setFlowcontrol(const QString &n) {
+void PPPData::setFlowcontrol(enum FlowControl n) {
   writeConfig(modemGroup(), FLOWCONTROL_KEY, n);
 }
 
 
 const QString PPPData::speed() {
   QString s = readConfig(modemGroup(), SPEED_KEY, "57600");
   // undo the damage of a bug in former versions. It left an empty Speed=
   // entry in kppprc. kppp did set the serial port to 57600 as default but
   // pppd wouldn't receive the speed via the command line.
   if(s.toUInt() == 0)
     s = "57600";
   return s;
 }
 
 
 void PPPData::setSpeed(const QString &n) {
   writeConfig(modemGroup(), SPEED_KEY, n);
 }
 
 
 #if 0
 void PPPData::setUseCDLine(const int n) {
   writeConfig(modemGroup(),USECDLINE_KEY,n);
 }
 
 
 int PPPData::UseCDLine() {
   return  readNumConfig(modemGroup(),USECDLINE_KEY,0);
 }
 #endif
 
 const QString  PPPData::modemEscapeStr() {
   return readConfig(modemGroup(),ESCAPESTR_KEY,"+++");
 }
 
 
 void PPPData::setModemEscapeStr(const QString &n) {
   writeConfig(modemGroup(),ESCAPESTR_KEY,n);
 }
 
 
 const QString  PPPData::modemEscapeResp() {
   return readConfig(modemGroup(),ESCAPERESP_KEY,"OK");
 }
 
 
 void PPPData::setModemEscapeResp(const QString &n) {
   writeConfig(modemGroup(),ESCAPERESP_KEY,n);
 }
 
 
 int  PPPData::modemEscapeGuardTime() {
   return readNumConfig(modemGroup(),ESCAPEGUARDTIME_KEY,50);
 }
 
 
 void PPPData::setModemEscapeGuardTime(int n) {
   writeConfig(modemGroup(),ESCAPEGUARDTIME_KEY,n);
 }
 
 
 bool PPPData::modemLockFile() {
   return readNumConfig(modemGroup(), LOCKFILE_KEY, 1);
 }
 
 
 void PPPData::setModemLockFile(bool set) {
   writeConfig(modemGroup(), LOCKFILE_KEY, set);
 }
 
 
 int PPPData::modemTimeout() {
   return readNumConfig(modemGroup(), TIMEOUT_KEY, MODEM_TIMEOUT);
 }
 
 
 void PPPData::setModemTimeout(int n) {
   writeConfig(modemGroup(), TIMEOUT_KEY, n);
 }
 
 
 int PPPData::modemToneDuration() {
   return readNumConfig(modemGroup(), TONEDURATION_KEY,MODEM_TONEDURATION);
 }
 
 
 void PPPData::setModemToneDuration(int n) {
   writeConfig(modemGroup(), TONEDURATION_KEY, n);
 }
 
 
 int PPPData::busyWait() {
   return readNumConfig(modemGroup(), BUSYWAIT_KEY, BUSY_WAIT);
 }
 
 
 void PPPData::setbusyWait(int n) {
   writeConfig(modemGroup(), BUSYWAIT_KEY, n);
 }
 
 
 //
 //Advanced "Modem" dialog
 //
 // defaults: InitString=ATZ, InitString1="" etc.
 const QString PPPData::modemInitStr(int i) {
   assert(i >= 0 && i < NumInitStrings);
   if(i == 0)
     return readConfig(modemGroup(), INITSTR_KEY, "ATZ");
   else
     return readConfig(modemGroup(), INITSTR_KEY + QString::number(i), "");
 }
 
 
 void PPPData::setModemInitStr(int i, const QString &n) {
   assert(i >= 0 && i < NumInitStrings);
   QString k = INITSTR_KEY + (i > 0 ? QString::number(i) : QString(""));
   writeConfig(modemGroup(), k, n);
 }
 
 
 const QString PPPData::modemInitResp() {
   return readConfig(modemGroup(), INITRESP_KEY, "OK");
 }
 
 
 void PPPData::setModemInitResp(const QString &n) {
   writeConfig(modemGroup(), INITRESP_KEY, n);
@@ -595,262 +595,262 @@ const QString PPPData::modemNoDialtoneResp() {
   return readConfig(modemGroup(), NODIALTONERESP_KEY, "NO DIALTONE");
 }
 
 
 void PPPData::setModemNoDialtoneResp(const QString &n) {
   writeConfig(modemGroup(), NODIALTONERESP_KEY, n);
 }
 
 
 const QString PPPData::modemHangupStr() {
   return readConfig(modemGroup(), HANGUPSTR_KEY, "+++ATH");
 }
 
 void PPPData::setModemHangupStr(const QString &n) {
   writeConfig(modemGroup(), HANGUPSTR_KEY, n);
 }
 
 
 const QString PPPData::modemHangupResp() {
   return readConfig(modemGroup(), HANGUPRESP_KEY, "OK");
 }
 
 void PPPData::setModemHangupResp(const QString &n) {
   writeConfig(modemGroup(), HANGUPRESP_KEY, n);
 }
 
 
 const QString PPPData::modemAnswerStr() {
   return readConfig(modemGroup(), ANSWERSTR_KEY, "ATA");
 }
 
 
 QString PPPData::volumeOff() {
   return readConfig(modemGroup(), VOLUME_OFF, "M0L0");
 }
 
 
 void PPPData::setVolumeOff(const QString &s) {
   writeConfig(modemGroup(), VOLUME_OFF, s);
 }
 
 
 QString PPPData::volumeMedium() {
  return readConfig(modemGroup(), VOLUME_MEDIUM, "M1L1");
 }
 
 
 void PPPData::setVolumeMedium(const QString &s) {
   writeConfig(modemGroup(), VOLUME_MEDIUM, s);
 }
 
 
 QString PPPData::volumeHigh() {
   QString tmp = readConfig(modemGroup(), VOLUME_HIGH, "M1L3");
   if(tmp == "M1L4")
     tmp = "M1L3";
   return tmp;
 }
 
 
 void PPPData::setVolumeHigh(const QString &s) {
  writeConfig(modemGroup(), VOLUME_HIGH, s);
 }
 
 
 QString PPPData::volumeInitString() {
   QString s;
 
   switch(volume()) {
   case 0:
     s = volumeOff();
     break;
   case 1:
     s = volumeMedium();
     break;
   case 2:
     s = volumeHigh();
     break;
   default:
     s = volumeMedium();
   }
 
   return s;
 }
 
 
 int PPPData::volume() {
   return readNumConfig(modemGroup(), VOLUME_KEY, 1);
 }
 
 
 void PPPData::setVolume(int i) {
   writeConfig(modemGroup(), VOLUME_KEY, i);
 }
 
 int PPPData::waitForDialTone() {
   return readNumConfig(modemGroup(), DIALTONEWAIT_KEY, 1);
 }
 
 void PPPData::setWaitForDialTone(int i) {
   writeConfig(modemGroup(), DIALTONEWAIT_KEY, i);
 }
 
 void PPPData::setModemAnswerStr(const QString &n) {
   writeConfig(modemGroup(), ANSWERSTR_KEY, n);
 }
 
 
 const QString PPPData::modemRingResp() {
   return readConfig(modemGroup(), RINGRESP_KEY, "RING");
 }
 
 
 void PPPData::setModemRingResp(const QString &n) {
   writeConfig(modemGroup(), RINGRESP_KEY, n);
 }
 
 
 const QString PPPData::modemAnswerResp() {
   return readConfig(modemGroup(), ANSWERRESP_KEY, "CONNECT");
 }
 
 
 void PPPData::setModemAnswerResp(const QString &n) {
   writeConfig(modemGroup(), ANSWERRESP_KEY, n);
 }
 
 
-const QString PPPData::enter() {
-  return readConfig(modemGroup(), ENTER_KEY, "CR");
+enum PPPData::LineTermination PPPData::enter(){
+    return static_cast<PPPData::LineTermination>(readNumConfig(modemGroup(), ENTER_KEY, EndCR));
 }
 
 
-void PPPData::setEnter(const QString &n) {
+void PPPData::setEnter(enum PPPData::LineTermination n) {
   writeConfig(modemGroup(), ENTER_KEY, n);
 }
 
 
 //
 // functions to set/return account information
 //
 
 //returns number of accounts
 int PPPData::count() const {
   return highcount + 1;
 }
 
 
 bool PPPData::setAccount(const QString &aname) {
     odebug << "setting account to >" << aname.latin1() << "<" << oendl; 
     for ( QStringList::Iterator it = accountList.begin(); it != accountList.end(); ++it ) {
         cgroup = *it;
         odebug << "PPPData::setAccount " << cgroup.latin1() << "" << oendl; 
         odebug << "iterator " << (*it).latin1() << "" << oendl; 
         if(accname() == aname) {
             odebug << "SUCCESS" << oendl; 
             return true;
         }
 
     }
     odebug << "FAILURE" << oendl; 
     return false;
 }
 
 /*
 bool PPPData::setAccountbyIndex(int i) {
   if(i >= 0 && i <= highcount) {
     QString tmp;
     tmp.sprintf("%s%i", ACCOUNT_GRP, i);
     if (_deleted.find(tmp)!=_deleted.end()) return false;
     caccount = i;
     cgroup = tmp;
     return true;
   }
   return false;
 }
 */
 
 bool PPPData::isUniqueAccname(const QString &n) {
   QString save_cgroup = cgroup;
   for ( QStringList::Iterator it = accountList.begin(); it != accountList.end(); ++it ) {
       cgroup = *it;
       odebug << "PPPData::setAccount " << cgroup.latin1() << "" << oendl; 
       odebug << "" << (*it).latin1() << " \n" << oendl; 
       if(accname() == n && cgroup != save_cgroup) {
           cgroup = save_cgroup;
           odebug << "SUCCESS" << oendl; 
           return false;
       }
 
   }
   cgroup = save_cgroup;
   return true;
 }
 
 
 bool PPPData::isUniqueDevname(const QString &n) {
     QString save_mName = _modemName;
     odebug << "PPPData::isUniqueDevname checking if " << n.latin1() << " is unique" << oendl; 
     for ( QStringList::Iterator it = deviceList.begin(); it != deviceList.end(); ++it ) {
         _modemName = *it;
         odebug << "PPPData::isUniqueDevname " << n.latin1() << " == " << devname().latin1() << "" << oendl; 
         if(devname() == n && _modemName != save_mName) {
             _modemName = save_mName;
             odebug << "NOT UNIQUE" << oendl; 
             return false;
         }
 
     }
     _modemName = save_mName;
     return true;
 }
 
 
 bool PPPData::deleteAccount() {
     // FIXME: check if this account exists in a config...
     Config cfg = PPPData::config();
     cfg.setGroup(cgroup);
     cfg.clearGroup();
     accountList.remove(cgroup);
 
     QString key;
     QStringList keys;
     for( QMap<QString,QString>::Iterator it = stringEntries.begin();
          it != stringEntries.end(); ++it ){
         QString val = it.data();
         key = it.key();
         keys = QStringList::split( "SEPARATOR", key );
         if(keys[0]==cgroup){
             stringEntries.remove( it );
             odebug << "deleting >" << keys[0].latin1() << "< key >" << keys[1].latin1() << "< value >" << val.latin1() << "<" << oendl; 
         }
     }
     for( QMap<QString,int>::Iterator it = intEntries.begin();
          it != intEntries.end(); ++it ){
         int val = it.data();
         key = it.key();
         keys = QStringList::split( "SEPARATOR", key );
         if(keys[0]==cgroup){
             intEntries.remove( it );
             odebug << "deleting >" << keys[0].latin1() << "< key >" << keys[1].latin1() << "< value >" << val << "<" << oendl; 
         }
     }
     for( QMap<QString,QStringList>::Iterator it = listEntries.begin();
          it != listEntries.end(); ++it ){
         QStringList val = it.data();
         key = it.key();
         if(keys[0]==cgroup){
             listEntries.remove( it );
             sepEntries.remove( key );
             odebug << "deleting >" << keys[0].latin1() << "< key >" << keys[1].latin1() << "< value >" << val.join("").latin1() << "<" << oendl; 
         }
     }
 
     return true;
 }
 
 
 bool PPPData::deleteAccount(const QString &aname) {
   if(!setAccount(aname))
     return false;
 
diff --git a/noncore/settings/networksettings/ppp/pppdata.h b/noncore/settings/networksettings/ppp/pppdata.h
index d1cbeb5..d731b62 100644
--- a/noncore/settings/networksettings/ppp/pppdata.h
+++ b/noncore/settings/networksettings/ppp/pppdata.h
@@ -40,346 +40,357 @@
 
 class Config;
 
 // string lengths
 
 #define PATH_SIZE 120
 #define MODEMSTR_SIZE 80
 #define ACCNAME_SIZE 50
 #define PHONENUMBER_SIZE 60
 #define COMMAND_SIZE 255
 #define IPADDR_SIZE 15
 #define DOMAIN_SIZE 50
 #define TIMEOUT_SIZE 60
 
 //
 // keys for config file
 //
 
 // groups
 #define GENERAL_GRP        "PPP_General"
 #define MODEM_GRP          "PPP_Modem"
 #define ACCOUNT_GRP        "PPP_Account"
 #define ACCLIST_GRP        "PPP_Accounts_List"
 //#define GRAPH_GRP          "Graph"
 //#define WINPOS_GRP         "WindowPosition"
 
 // general
 #define ACCOUNT_LIST       "AccountList"
 #define DEVICE_LIST        "DeviceList"
 #define DEFAULTACCOUNT_KEY "DefaultAccount"
 #define PPPDVERSION_KEY    "pppdVersion"
 #define PPPDTIMEOUT_KEY    "pppdTimeout"
 #define SHOWCLOCK_KEY      "ShowClock"
 #define SHOWLOGWIN_KEY     "ShowLogWindow"
 #define AUTOREDIAL_KEY     "AutomaticRedial"
 #define DISCONNECT_KEY     "DisconnectOnXServerExit"
 #define QUITONDISCONNECT_KEY "QuitOnDisconnect"
 #define NUMACCOUNTS_KEY    "HighcountAccounts"
 #define NUMDEVICES_KEY    "HighcountDevices"
         #define ID_KEY     "ID"
 
 // modem
 #define MODEMNAME_KEY      "Modem_Name"
 #define MODEMDEV_KEY       "Device"
 #define LOCKFILE_KEY       "UseLockFile"
 #define FLOWCONTROL_KEY    "FlowControl"
 #define SPEED_KEY          "Speed"
 #define TIMEOUT_KEY        "Timeout"
 #define TONEDURATION_KEY   "ToneDuration"
 #define BUSYWAIT_KEY       "BusyWait"
 #define INITSTR_KEY        "InitString"
 #define INITRESP_KEY       "InitResponse"
 #define PREINITDELAY_KEY   "PreInitDelay"
 #define INITDELAY_KEY      "InitDelay"
 #define NODTDETECT_KEY     "NoDialToneDetection"
 #define DIALTONEWAIT_KEY   "WaitForDialTone"
 #define DIALSTR_KEY        "DialString"
 #define CONNECTRESP_KEY    "ConnectResponse"
 #define BUSYRESP_KEY       "BusyResponse"
 #define NOCARRIERRESP_KEY  "NoCarrierResponse"
 #define NODIALTONERESP_KEY "NoDialToneResp"
 #define HANGUPSTR_KEY      "HangupString"
 #define HANGUPRESP_KEY     "HangUpResponse"
 #define ANSWERSTR_KEY      "AnswerString"
 #define RINGRESP_KEY       "RingResponse"
 #define ANSWERRESP_KEY     "AnswerResponse"
 #define ENTER_KEY          "Enter"
 #define ESCAPESTR_KEY      "EscapeString"
 #define ESCAPERESP_KEY     "EscapeResponse"
 #define ESCAPEGUARDTIME_KEY "EscapeGuardTime"
 #define USECDLINE_KEY      "UseCDLine"
 #define VOLUME_HIGH        "VolumeHigh"
 #define VOLUME_MEDIUM      "VolumeMedium"
 #define VOLUME_OFF         "VolumeOff"
 #define VOLUME_KEY         "Volume"
 
 // account
 #define NAME_KEY           "Name"
 #define PHONENUMBER_KEY    "Phonenumber"
 #define DIAL_PREFIX_KEY    "DialPrefix"
 #define AUTH_KEY           "Authentication"
 #define STORED_PASSWORD_KEY "Password"
 #define STORED_USERNAME_KEY "Username"
 #define STORE_PASSWORD_KEY "StorePassword"
 #define BEFORE_CONNECT_KEY  "BeforeConnect"
 #define COMMAND_KEY        "Command"
 #define DISCONNECT_COMMAND_KEY "DisconnectCommand"
 #define BEFORE_DISCONNECT_KEY  "BeforeDisconnect"
 #define IPADDR_KEY         "IPAddr"
 #define SUBNETMASK_KEY     "SubnetMask"
 #define ACCTENABLED_KEY    "AccountingEnabled"
 #define VOLACCTENABLED_KEY "VolumeAccountingEnabled"
 #define ACCTFILE_KEY       "AccountingFile"
 #define AUTONAME_KEY       "AutoName"
 #define GATEWAY_KEY        "Gateway"
 #define DEFAULTROUTE_KEY   "DefaultRoute"
 #define DOMAIN_KEY         "Domain"
 #define DNS_KEY            "DNS"
 #define AUTODNS_KEY        "AutoDNS"
 #define EXDNSDISABLED_KEY  "ExDNSDisabled"
 #define SCRIPTCOM_KEY      "ScriptCommands"
 #define SCRIPTARG_KEY      "ScriptArguments"
 #define PPPDARG_KEY        "pppdArguments"
 #define PPP_DEBUG_OPTION   "PPPDebug"
 #define ICONIFY_ON_CONNECT_KEY "iconifyOnConnect"
 #define DOCKING_KEY        "DockIntoPanel"
 #define TOTALCOSTS_KEY     "TotalCosts"
 #define TOTALBYTES_KEY     "TotalBytes"
 
 // pppd errors
 #define E_IF_TIMEOUT       1
 #define E_PPPD_DIED        2
 
 // account list
 #define ACCOUNTS_COUNT     "Accounts_Count"
 #define ACOUNTS_DEV        "Accounts_Modem"
 #define ACOUNTS_ACC        "Accounts_Account"
 
 #define DEVICESNAMES_LIST  "DevicesNames_List"
 #define DEVICES_LIST       "Devices_List"
 #define DEVICES_LIST_SEP   ','
 
 class PPPData {
 public:
     PPPData();
     ~PPPData() {};
 
     enum { NumInitStrings = 2 };
+    enum LineTermination {
+        EndCR,
+        EndLF,
+        EndCRLF
+    };
+
+    enum FlowControl {
+        FlowHardware,
+        FlowSoftware,
+        FlowNone
+    };
 
     // general functions
     void save();
     void cancel();
 
     QStringList getAccountList();
 
     static QMap<QString,QString> getConfiguredInterfaces();
     static void setConfiguredInterfaces( QMap<QString,QString> );
 
     // function to read/write date to configuration file
     static Config config();
     QString readConfig(const QString &, const QString &, const QString &);
     int readNumConfig(const QString &, const QString &, int);
     bool readListConfig(const QString &, const QString &,
                       QStringList &, char sep = ',');
     void writeConfig(const QString &, const QString &, const QString &);
     void writeConfig(const QString &, const QString &, int);
     void writeListConfig(const QString &, const QString &,
                        QStringList &, char sep = ',');
 
     // return the current account group
     QString currentGroup() { return cgroup; }
     QString modemGroup();
 
   // functions to set/get general kppp info
   QString password();
   void setPassword(const QString &);
 
 //  int currentAccountID() { return caccount; };
   const QString defaultAccount();
   void setDefaultAccount(const QString &);
 
   void set_xserver_exit_disconnect(bool set);
   bool get_xserver_exit_disconnect();
 
   void setPPPDebug(bool set);
   bool getPPPDebug();
 
   void set_quit_on_disconnect(bool);
   bool quit_on_disconnect();
 
   void set_show_clock_on_caption(bool set);
   bool get_show_clock_on_caption();
 
   void set_show_log_window(bool set);
   bool get_show_log_window();
 
   void set_automatic_redial(bool set);
   bool automatic_redial();
 
 //   void set_iconify_on_connect(bool set);
 //   bool get_iconify_on_connect();
 
 //   void set_dock_into_panel(bool set);
 //   bool get_dock_into_panel();
 
-  const QString enter();
-  void setEnter(const QString &);
+  enum LineTermination enter();
+  void setEnter(enum LineTermination);
 
   QString pppdVersion();
   bool pppdVersionMin(int ver, int mod, int patch);
 
   int pppdTimeout();
   void setpppdTimeout(int);
 
   int busyWait();
   void setbusyWait(int);
 
   bool modemLockFile();
   void setModemLockFile(bool set);
 
   int modemEscapeGuardTime();
   void setModemEscapeGuardTime(int i);
 
   void setModemEscapeStr(const QString &);
   const QString modemEscapeStr();
 
   void setModemEscapeResp(const QString &);
   const QString modemEscapeResp();
 
 //  const QString modemName();
 //  bool setModemName(const QString &);
 //  bool changeModemName(const QString &);
 
    const QString modemDevice();
    bool setModemDevice(const QString &);
 
-  const QString flowcontrol();
-  void setFlowcontrol(const QString &);
+  enum FlowControl flowcontrol();
+  void setFlowcontrol(enum FlowControl);
 
   int modemTimeout();
   void setModemTimeout(int);
 
   int modemToneDuration();
   void setModemToneDuration(int);
 
   QString volumeInitString();
   int volume();
   void setVolume(int);
 
   int waitForDialTone();
   void setWaitForDialTone(int i);
 
   // modem command strings/responses
   const QString modemInitStr(int i);
   void setModemInitStr(int i, const QString &);
 
   const QString modemInitResp();
   void setModemInitResp(const QString &);
 
   int modemPreInitDelay();
   void setModemPreInitDelay(int);
 
   int modemInitDelay();
   void setModemInitDelay(int);
 
   QString modemNoDialToneDetectionStr();
   void setModemNoDialToneDetectionStr(const QString &);
 
   const QString modemDialStr();
   void setModemDialStr(const QString &);
 
   const QString modemConnectResp();
   void setModemConnectResp(const QString &);
 
   const QString modemBusyResp();
   void setModemBusyResp(const QString &);
 
   const QString modemNoCarrierResp();
   void setModemNoCarrierResp(const QString &);
 
   const QString modemNoDialtoneResp();
   void setModemNoDialtoneResp(const QString &);
 
   const QString modemHangupStr();
   void setModemHangupStr(const QString &);
 
   const QString modemHangupResp();
   void setModemHangupResp(const QString &);
 
   const QString modemAnswerStr();
   void setModemAnswerStr(const QString &);
 
   const QString modemRingResp();
   void setModemRingResp(const QString &);
 
   const QString modemAnswerResp();
   void setModemAnswerResp(const QString &);
 
   QString volumeOff();
   void setVolumeOff(const QString &);
 
   QString volumeMedium();
   void setVolumeMedium(const QString &);
 
   QString volumeHigh();
   void setVolumeHigh(const QString &);
 
   // functions to set/get account information
   int count() const;
   bool setAccount(const QString &);
 //  bool setAccountbyIndex(int);
 
   bool isUniqueAccname(const QString &);
   bool isUniqueDevname(const QString &);
 
   bool deleteAccount();
   bool deleteAccount(const QString &);
   int newaccount();
   int copyaccount(const QString&);
 
   const QString accname();
   void setAccname(const QString &);
 
   QStringList &phonenumbers();
   const QString phonenumber();
   void setPhonenumber(const QString &);
 
   const QString dialPrefix();
   void setDialPrefix(const QString &);
 
   int authMethod();
   void setAuthMethod(int);
 
   const QString storedUsername();
   void setStoredUsername(const QString &);
 
   const QString storedPassword();
   void setStoredPassword(const QString &);
 
   bool storePassword();
   void setStorePassword(bool);
 
   const QString speed();
   void setSpeed(const QString &);
 
   const QString command_before_connect();
   void setCommand_before_connect(const QString &);
 
   const QString command_on_connect();
   void setCommand_on_connect(const QString &);
 
   const QString command_on_disconnect();
   void setCommand_on_disconnect(const QString &);
 
   const QString command_before_disconnect();
   void setCommand_before_disconnect(const QString &);
 
   const QString ipaddr();
   void setIpaddr(const QString &);
 
   const QString subnetmask();
   void setSubnetmask(const QString &);
 
   bool AcctEnabled();
   void setAcctEnabled(bool set);